René's URL Explorer Experiment


Title: GH-111848: Set the IP when de-optimizing by markshannon · Pull Request #112065 · python/cpython · GitHub

Open Graph Title: GH-111848: Set the IP when de-optimizing by markshannon · Pull Request #112065 · python/cpython

X Title: GH-111848: Set the IP when de-optimizing by markshannon · Pull Request #112065 · python/cpython

Description: 2% faster for tier 2 Vs tier 1, now 5% slower. Main is 7% slower Issue: Unify branches and deopts in the tier 2 IR. #111848

Open Graph Description: 2% faster for tier 2 Vs tier 1, now 5% slower. Main is 7% slower Issue: Unify branches and deopts in the tier 2 IR. #111848

X Description: 2% faster for tier 2 Vs tier 1, now 5% slower. Main is 7% slower Issue: Unify branches and deopts in the tier 2 IR. #111848

Opengraph URL: https://github.com/python/cpython/pull/112065

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1bc369e6-c2e4-6366-f3f6-a438309789df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA620:37CCD2:298E48D:36EFAA4:696B2E48
html-safe-nonce4b80af7e7b07433820539ca4e1bea8c47306687678a9d39dfe625a8e575e6d05
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjIwOjM3Q0NEMjoyOThFNDhEOjM2RUZBQTQ6Njk2QjJFNDgiLCJ2aXNpdG9yX2lkIjoiNTA2MDc5NTMyMjgxNjIxMjU1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac56fef192646f7c6a207dfac0b127ea9ce333c56a26d70ee731471efa96f89c07
hovercard-subject-tagpull_request:1601147833
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/112065/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b30fb588b508f061db86b50a1ac61adea88e004439ae99e87101f4c4d8542f87/python/cpython/pull/112065
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b30fb588b508f061db86b50a1ac61adea88e004439ae99e87101f4c4d8542f87/python/cpython/pull/112065
og:image:alt2% faster for tier 2 Vs tier 1, now 5% slower. Main is 7% slower Issue: Unify branches and deopts in the tier 2 IR. #111848
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemarkshannon
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/112065#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112065
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112065
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/112065
Reloadhttps://github.com/python/cpython/pull/112065
Reloadhttps://github.com/python/cpython/pull/112065
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/112065
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/112065
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/112065#issue-comment-box
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
faster-cpython:deopts-with-iphttps://github.com/faster-cpython/cpython/tree/deopts-with-ip
GH-111848: Set the IP when de-optimizing https://github.com/python/cpython/pull/112065#top
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
faster-cpython:deopts-with-iphttps://github.com/faster-cpython/cpython/tree/deopts-with-ip
Conversation 6 https://github.com/python/cpython/pull/112065
Commits 14 https://github.com/python/cpython/pull/112065/commits
Checks 0 https://github.com/python/cpython/pull/112065/checks
Files changed https://github.com/python/cpython/pull/112065/files
Please reload this pagehttps://github.com/python/cpython/pull/112065
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Nov 14, 2023https://github.com/python/cpython/pull/112065#issue-1993213816
Please reload this pagehttps://github.com/python/cpython/pull/112065
2% faster for tier 2https://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20231112-3.13.0a1%2B-4d1e295-PYTHON_UOPS
7% slowerhttps://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20231114-3.13.0a1%2B-a519b87-PYTHON_UOPS
Unify branches and deopts in the tier 2 IR. #111848https://github.com/python/cpython/issues/111848
Please reload this pagehttps://github.com/python/cpython/pull/112065
markshannonhttps://github.com/markshannon
November 5, 2023 10:18https://github.com/python/cpython/pull/112065#commits-pushed-317db3a
https://github.com/markshannon
Replace jumps with deopts in tier 2https://github.com/python/cpython/pull/112065/commits/317db3a6760c785d931174e81dfe0179f5b4d9c1
317db3ahttps://github.com/python/cpython/pull/112065/commits/317db3a6760c785d931174e81dfe0179f5b4d9c1
https://github.com/markshannon
Fewer special cases of uop nameshttps://github.com/python/cpython/pull/112065/commits/2db61ccc925c329710cef63cdd09197482fee210
2db61cchttps://github.com/python/cpython/pull/112065/commits/2db61ccc925c329710cef63cdd09197482fee210
https://github.com/markshannon
Fix refleakhttps://github.com/python/cpython/pull/112065/commits/f36132831dc1d8696436ce107d6003c6514cd17d
f361328https://github.com/python/cpython/pull/112065/commits/f36132831dc1d8696436ce107d6003c6514cd17d
https://github.com/markshannon
Merge branch 'main' into jumps-to-deoptshttps://github.com/python/cpython/pull/112065/commits/2de345197e62b29b71c19644d0ec1c48cfe3b667
2de3451https://github.com/python/cpython/pull/112065/commits/2de345197e62b29b71c19644d0ec1c48cfe3b667
https://github.com/markshannon
Update testhttps://github.com/python/cpython/pull/112065/commits/69cee8daae30c8363bee399641fc61130e3eab35
69cee8dhttps://github.com/python/cpython/pull/112065/commits/69cee8daae30c8363bee399641fc61130e3eab35
https://github.com/markshannon
Add target field to uop IRhttps://github.com/python/cpython/pull/112065/commits/bb9a1a2e4d7b60e601525d7ed05dede441c10fa3
bb9a1a2https://github.com/python/cpython/pull/112065/commits/bb9a1a2e4d7b60e601525d7ed05dede441c10fa3
https://github.com/markshannon
Remove redundant SET_IP and _CHECK_VALIDITY micro-opshttps://github.com/python/cpython/pull/112065/commits/9cda14b21cf1af77ab3a91d2c27c1b8c09d6fb25
9cda14bhttps://github.com/python/cpython/pull/112065/commits/9cda14b21cf1af77ab3a91d2c27c1b8c09d6fb25
https://github.com/markshannon
Extend whitelist of non-escaping API functions.https://github.com/python/cpython/pull/112065/commits/6c61feb0f530e20120beac0fb8ea03cc9bfc552b
6c61febhttps://github.com/python/cpython/pull/112065/commits/6c61feb0f530e20120beac0fb8ea03cc9bfc552b
https://github.com/markshannon
Add more functions to whitelisthttps://github.com/python/cpython/pull/112065/commits/0a093fdec35ae41eb8a3e77d4100a3f905164f88
0a093fdhttps://github.com/python/cpython/pull/112065/commits/0a093fdec35ae41eb8a3e77d4100a3f905164f88
https://github.com/markshannon
Merge branch 'main' into deopts-with-iphttps://github.com/python/cpython/pull/112065/commits/18a6511f49fa70f230081e9e36a9655dbaa3037f
18a6511https://github.com/python/cpython/pull/112065/commits/18a6511f49fa70f230081e9e36a9655dbaa3037f
https://github.com/markshannon
Tidy uphttps://github.com/python/cpython/pull/112065/commits/222ee176012bd2a58d3c035f804b286c7aa86232
222ee17https://github.com/python/cpython/pull/112065/commits/222ee176012bd2a58d3c035f804b286c7aa86232
https://github.com/markshannon
Add another non-escaping functionhttps://github.com/python/cpython/pull/112065/commits/4d1e2950cf5724f97389f2d0920e8152255a45c6
4d1e295https://github.com/python/cpython/pull/112065/commits/4d1e2950cf5724f97389f2d0920e8152255a45c6
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Nov 15, 2023https://github.com/python/cpython/pull/112065#event-10965072383
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 15, 2023 https://github.com/python/cpython/pull/112065#ref-issue-1983410219
Unify branches and deopts in the tier 2 IR. #111848 https://github.com/python/cpython/issues/111848
https://github.com/markshannon
markshannonhttps://github.com/markshannon
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Nov 15, 2023https://github.com/python/cpython/pull/112065#event-10965074663
https://github.com/markshannon
Fix type annotationhttps://github.com/python/cpython/pull/112065/commits/b5737c805b8d2569403179799458c1d5947ce158
b5737c8https://github.com/python/cpython/pull/112065/commits/b5737c805b8d2569403179799458c1d5947ce158
https://github.com/markshannon
markshannonhttps://github.com/markshannon
force-pushedhttps://github.com/python/cpython/compare/407998575692f278aaff820e8ea1dcca0e4507f4..b5737c805b8d2569403179799458c1d5947ce158
4079985https://github.com/python/cpython/commit/407998575692f278aaff820e8ea1dcca0e4507f4
b5737c8https://github.com/python/cpython/commit/b5737c805b8d2569403179799458c1d5947ce158
Compare https://github.com/python/cpython/compare/407998575692f278aaff820e8ea1dcca0e4507f4..b5737c805b8d2569403179799458c1d5947ce158
November 15, 2023 09:44https://github.com/python/cpython/pull/112065#event-10965179625
https://github.com/markshannon
markshannonhttps://github.com/markshannon
November 15, 2023 12:13https://github.com/python/cpython/pull/112065#event-10966669200
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 15, 2023https://github.com/python/cpython/pull/112065#event-10966669717
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Nov 15, 2023 https://github.com/python/cpython/pull/112065#pullrequestreview-1731943283
View reviewed changes https://github.com/python/cpython/pull/112065/files/b5737c805b8d2569403179799458c1d5947ce158
Python/optimizer_analysis.chttps://github.com/python/cpython/pull/112065/files/b5737c805b8d2569403179799458c1d5947ce158#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
Please reload this pagehttps://github.com/python/cpython/pull/112065
Python/optimizer.chttps://github.com/python/cpython/pull/112065/files/b5737c805b8d2569403179799458c1d5947ce158#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
Please reload this pagehttps://github.com/python/cpython/pull/112065
Python/ceval.chttps://github.com/python/cpython/pull/112065/files/b5737c805b8d2569403179799458c1d5947ce158#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
Please reload this pagehttps://github.com/python/cpython/pull/112065
https://github.com/markshannon
Address review commentshttps://github.com/python/cpython/pull/112065/commits/8e2f0f64f20409c1957bf9c99547d01b3168982f
8e2f0f6https://github.com/python/cpython/pull/112065/commits/8e2f0f64f20409c1957bf9c99547d01b3168982f
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Nov 15, 2023 https://github.com/python/cpython/pull/112065#pullrequestreview-1732200893
View reviewed changes https://github.com/python/cpython/pull/112065/files/8e2f0f64f20409c1957bf9c99547d01b3168982f
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 15, 2023https://github.com/python/cpython/pull/112065#event-10968349409
https://github.com/markshannon
markshannonhttps://github.com/markshannon
4bbb367https://github.com/python/cpython/commit/4bbb367ba65e1df7307f7c6a33afd3c369592188
Nov 15, 2023https://github.com/python/cpython/pull/112065#event-10969129475
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 15, 2023https://github.com/python/cpython/pull/112065#event-10969130137
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Nov 15, 2023 https://github.com/python/cpython/pull/112065#pullrequestreview-1733050197
View reviewed changes https://github.com/python/cpython/pull/112065/files/8e2f0f64f20409c1957bf9c99547d01b3168982f
Python/optimizer.chttps://github.com/python/cpython/pull/112065/files/8e2f0f64f20409c1957bf9c99547d01b3168982f#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
gvanrossumhttps://github.com/gvanrossum
Nov 15, 2023https://github.com/python/cpython/pull/112065#discussion_r1394848606
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/112065
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Nov 16, 2023 https://github.com/python/cpython/pull/112065#ref-pullrequest-1995767100
gh-106529: Make FOR_ITER a viable uop #112134 https://github.com/python/cpython/pull/112134
aiskhttps://github.com/aisk
Feb 11, 2024 https://github.com/python/cpython/pull/112065#ref-commit-44f3d21
https://github.com/markshannon
https://github.com/aisk
pythonGH-111848https://github.com/python/cpython/issues/111848
: Set the IP when de-optimizing (https://github.com/aisk/cpython/commit/44f3d213bcf3f898479289064f7d4c32c6cb5c6e
pythonGH-112065https://github.com/python/cpython/pull/112065
)https://github.com/aisk/cpython/commit/44f3d213bcf3f898479289064f7d4c32c6cb5c6e
44f3d21https://github.com/aisk/cpython/commit/44f3d213bcf3f898479289064f7d4c32c6cb5c6e
https://github.com/markshannon
markshannonhttps://github.com/markshannon
August 6, 2024 10:18https://github.com/python/cpython/pull/112065#event-13776329647
Glyphackhttps://github.com/Glyphack
Sep 2, 2024 https://github.com/python/cpython/pull/112065#ref-commit-02026ac
https://github.com/markshannon
https://github.com/Glyphack
pythonGH-111848https://github.com/python/cpython/issues/111848
: Set the IP when de-optimizing (https://github.com/Glyphack/cpython/commit/02026ac1588a440b4538a27b16a779e34b6c9444
pythonGH-112065https://github.com/python/cpython/pull/112065
)https://github.com/Glyphack/cpython/commit/02026ac1588a440b4538a27b16a779e34b6c9444
02026achttps://github.com/Glyphack/cpython/commit/02026ac1588a440b4538a27b16a779e34b6c9444
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F112065
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/cpython/pull/112065/files/8e2f0f64f20409c1957bf9c99547d01b3168982f
https://github.com/iritkatriel
iritkatriel https://github.com/iritkatriel
https://github.com/python/cpython/pull/112065/files/8e2f0f64f20409c1957bf9c99547d01b3168982f
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/112065
https://github.com/markshannon
https://github.com/iritkatriel
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.