René's URL Explorer Experiment


Title: GH-111693: Propagate correct asyncio.CancelledError instance out of asyncio.Condition.wait() by kristjanvalur · Pull Request #111694 · python/cpython · GitHub

Open Graph Title: GH-111693: Propagate correct asyncio.CancelledError instance out of asyncio.Condition.wait() by kristjanvalur · Pull Request #111694 · python/cpython

X Title: GH-111693: Propagate correct asyncio.CancelledError instance out of asyncio.Condition.wait() by kristjanvalur · Pull Request #111694 · python/cpython

Description: This PR addresses #111693 and adds unit tests for them. Piggybacked on it are minor simplifying changes to asyncio.Lock.acquire() and asyncio.Semaphore.acquire(), as well as removal of dead code: code is documented the exception handling code is made non-specific to asyncio.CancelledError. dead code is removed from asyncio.Future. Issue: gh-111693

Open Graph Description: This PR addresses #111693 and adds unit tests for them. Piggybacked on it are minor simplifying changes to asyncio.Lock.acquire() and asyncio.Semaphore.acquire(), as well as removal of dead code: ...

X Description: This PR addresses #111693 and adds unit tests for them. Piggybacked on it are minor simplifying changes to asyncio.Lock.acquire() and asyncio.Semaphore.acquire(), as well as removal of dead code: ...

Opengraph URL: https://github.com/python/cpython/pull/111694

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4bed5df0-c9e7-2d44-3d73-e8e8b2a30da9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA242:1ABD8E:5236E31:6D2F237:6A5DB7E0
html-safe-nonce5a58eda8e5d20e0a4e2b7fab3271d4f93f5fff3529586b45d711d53fd1c0d3de
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjQyOjFBQkQ4RTo1MjM2RTMxOjZEMkYyMzc6NkE1REI3RTAiLCJ2aXNpdG9yX2lkIjoiNTk3MjA2MDE0MDM0MjE5NjE5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac79e1e80a58ba348605fdb55627971a8a700914075306561aa568df799d9bf9d6
hovercard-subject-tagpull_request:1586136220
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/111694/files
twitter:imagehttps://avatars.githubusercontent.com/u/6009543?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6009543?s=400&v=4
og:image:altThis PR addresses #111693 and adds unit tests for them. Piggybacked on it are minor simplifying changes to asyncio.Lock.acquire() and asyncio.Semaphore.acquire(), as well as removal of dead code: ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/111694/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111694%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111694%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/111694/files
Reloadhttps://github.com/python/cpython/pull/111694/files
Reloadhttps://github.com/python/cpython/pull/111694/files
Please reload this pagehttps://github.com/python/cpython/pull/111694/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/111694/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
kristjanvalur:kristjan/CancelledErrorhttps://github.com/kristjanvalur/stackless/tree/kristjan/CancelledError
Conversation 52 https://github.com/python/cpython/pull/111694
Commits 14 https://github.com/python/cpython/pull/111694/commits
Checks 0 https://github.com/python/cpython/pull/111694/checks
Files changed https://github.com/python/cpython/pull/111694/files
Please reload this pagehttps://github.com/python/cpython/pull/111694/files
GH-111693: Propagate correct asyncio.CancelledError instance out of asyncio.Condition.wait() https://github.com/python/cpython/pull/111694/files#top
Show all changes 14 commits https://github.com/python/cpython/pull/111694/files
c3aff47 Add test and fix case where original CancelledError was not re-raised. kristjanvalur Nov 3, 2023 https://github.com/python/cpython/pull/111694/commits/c3aff478c7a58e3d09e3bd18ff0a897e06bff293
111e74a Simplify Lock/Semaphore error handling, also deal with any error. kristjanvalur Nov 3, 2023 https://github.com/python/cpython/pull/111694/commits/111e74a2d39d1190fb7e510f491a1789a8c56a86
6d41771 Remove vestigial code from Future kristjanvalur Nov 4, 2023 https://github.com/python/cpython/pull/111694/commits/6d41771c13f333fb5b6db7af2be804f63b2fe025
4e16fa7 fix whitespace kristjanvalur Nov 4, 2023 https://github.com/python/cpython/pull/111694/commits/4e16fa765bbd5b22ba3e52256667eded7574fc1e
ad56f29 Apply suggestions from code review kristjanvalur Nov 20, 2023 https://github.com/python/cpython/pull/111694/commits/ad56f29676473c7ef0c4f6ba56260600ac6a6e46
30e0ec4 Restructure try/except, and improve comments kristjanvalur Nov 21, 2023 https://github.com/python/cpython/pull/111694/commits/30e0ec45af0c4bf045bf4320dd0af7c47465b278
6d59820 Merge remote-tracking branch 'kristjan/kristjan/CancelledError' into … kristjanvalur Nov 21, 2023 https://github.com/python/cpython/pull/111694/commits/6d5982097a46a6e1206ce04050b2b01650bef745
c060f40 Apply suggestions from code review kristjanvalur Nov 21, 2023 https://github.com/python/cpython/pull/111694/commits/c060f40a7e0b89cd530445ea023f5ae1caceb0ec
62bd6cd Suggestsions from code review. kristjanvalur Nov 26, 2023 https://github.com/python/cpython/pull/111694/commits/62bd6cdc420f536798741296c7be057ce2e72f09
01046c5 comment and add tests for waking up multiple FIFO tasks in the Semaphore kristjanvalur Nov 26, 2023 https://github.com/python/cpython/pull/111694/commits/01046c59f21f717a249481420c7a937e6a271016
8802dfa Fix comment typo gvanrossum Dec 30, 2023 https://github.com/python/cpython/pull/111694/commits/8802dfa7ad2cb085ba6168df9720d758dbf0cf9c
f7c103c 📜🤖 Added by blurb_it. blurb-it[bot] Jan 7, 2024 https://github.com/python/cpython/pull/111694/commits/f7c103cd0b88733eaf351877034bed3e4d92a0b6
1572b2b Format, capitalize, punctuate comments. kristjanvalur Jan 7, 2024 https://github.com/python/cpython/pull/111694/commits/1572b2b4469c76598e81fc9691e59a4eb2e210e4
dce420e Merge branch 'main' into kristjan/CancelledError kristjanvalur Jan 7, 2024 https://github.com/python/cpython/pull/111694/commits/dce420e0ece13495c0c8c9fa3f3050c2b52902b5
Clear filters https://github.com/python/cpython/pull/111694/files
Please reload this pagehttps://github.com/python/cpython/pull/111694/files
Please reload this pagehttps://github.com/python/cpython/pull/111694/files
futures.py https://github.com/python/cpython/pull/111694/files#diff-1450afcb4b859bcfe9f8f7b73ca91c40ff470cbae484d81c5315b97c86b25653
locks.py https://github.com/python/cpython/pull/111694/files#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
test_locks.py https://github.com/python/cpython/pull/111694/files#diff-49a2abccf92f646db3568727885f472bd096941b187c3580d56d96484fc74193
2024-01-07-13-36-03.gh-issue-111693.xN2LuL.rst https://github.com/python/cpython/pull/111694/files#diff-eb714f0aea730e0b0df6ae98b3ed8c167b0c1c017438152b372da63bf29a5887
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L379
Lib/asyncio/futures.pyhttps://github.com/python/cpython/pull/111694/files#diff-1450afcb4b859bcfe9f8f7b73ca91c40ff470cbae484d81c5315b97c86b25653
View file https://github.com/kristjanvalur/stackless/blob/dce420e0ece13495c0c8c9fa3f3050c2b52902b5/Lib/asyncio/futures.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/111694/{{ revealButtonHref }}
https://github.com/python/cpython/pull/111694/files#diff-1450afcb4b859bcfe9f8f7b73ca91c40ff470cbae484d81c5315b97c86b25653
Please reload this pagehttps://github.com/python/cpython/pull/111694/files
https://github.com/python/cpython/pull/111694/files#diff-1450afcb4b859bcfe9f8f7b73ca91c40ff470cbae484d81c5315b97c86b25653
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L379
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
View file https://github.com/kristjanvalur/stackless/blob/dce420e0ece13495c0c8c9fa3f3050c2b52902b5/Lib/asyncio/locks.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/111694/{{ revealButtonHref }}
https://github.com/python/cpython/pull/111694/files#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
https://github.com/python/cpython/pull/111694/files#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
Please reload this pagehttps://github.com/python/cpython/pull/111694/files
https://github.com/python/cpython/pull/111694/files#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
https://github.com/python/cpython/pull/111694/files#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
https://github.com/python/cpython/pull/111694/files#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
Please reload this pagehttps://github.com/python/cpython/pull/111694/files
https://github.com/python/cpython/pull/111694/files#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
https://github.com/python/cpython/pull/111694/files#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
https://github.com/python/cpython/pull/111694/files#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
https://github.com/python/cpython/pull/111694/files#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
Please reload this pagehttps://github.com/python/cpython/pull/111694/files
https://github.com/python/cpython/pull/111694/files#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
https://github.com/python/cpython/pull/111694/files#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L380
Lib/test/test_asyncio/test_locks.pyhttps://github.com/python/cpython/pull/111694/files#diff-49a2abccf92f646db3568727885f472bd096941b187c3580d56d96484fc74193
View file https://github.com/kristjanvalur/stackless/blob/dce420e0ece13495c0c8c9fa3f3050c2b52902b5/Lib/test/test_asyncio/test_locks.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/111694/{{ revealButtonHref }}
https://github.com/python/cpython/pull/111694/files#diff-49a2abccf92f646db3568727885f472bd096941b187c3580d56d96484fc74193
https://github.com/python/cpython/pull/111694/files#diff-49a2abccf92f646db3568727885f472bd096941b187c3580d56d96484fc74193
https://github.com/python/cpython/pull/111694/files#diff-49a2abccf92f646db3568727885f472bd096941b187c3580d56d96484fc74193
https://github.com/python/cpython/pull/111694/files#diff-49a2abccf92f646db3568727885f472bd096941b187c3580d56d96484fc74193
Misc/NEWS.d/next/Library/2024-01-07-13-36-03.gh-issue-111693.xN2LuL.rsthttps://github.com/python/cpython/pull/111694/files#diff-eb714f0aea730e0b0df6ae98b3ed8c167b0c1c017438152b372da63bf29a5887
View file https://github.com/kristjanvalur/stackless/blob/dce420e0ece13495c0c8c9fa3f3050c2b52902b5/Misc/NEWS.d/next/Library/2024-01-07-13-36-03.gh-issue-111693.xN2LuL.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/111694/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.