René's URL Explorer Experiment


Title: GH-111693: Propagate correct asyncio.CancelledError instance out of asyncio.Condition.wait() by kristjanvalur · Pull Request #111694 · python/cpython · GitHub

Open Graph Title: GH-111693: Propagate correct asyncio.CancelledError instance out of asyncio.Condition.wait() by kristjanvalur · Pull Request #111694 · python/cpython

X Title: GH-111693: Propagate correct asyncio.CancelledError instance out of asyncio.Condition.wait() by kristjanvalur · Pull Request #111694 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This PR addresses #111693 and adds unit tests for them. Piggybacked on it are minor simplifying changes to asyncio.Lock.acquire() and asyncio.Semaphore.acquire(), as well as removal of dead code: ...

X Description: This PR addresses #111693 and adds unit tests for them. Piggybacked on it are minor simplifying changes to asyncio.Lock.acquire() and asyncio.Semaphore.acquire(), as well as removal of dead code: ...

Opengraph URL: https://github.com/python/cpython/pull/111694

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:da5e7744-3bbe-792c-058e-c5427fe067fd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD720:3C3DDE:1C71A3C:2596F55:6A5C938B
html-safe-nonce84692ca4ae6cd6f3dc17f4e40360f536f4005a2d742571b2254f12de9627dac3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzIwOjNDM0RERToxQzcxQTNDOjI1OTZGNTU6NkE1QzkzOEIiLCJ2aXNpdG9yX2lkIjoiODgxODMzOTc0MzQwNDk1NDUwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0e49cbaa96264385ac3e77958a92c053b2d433e8ff67d027b8151036b969d7ec
hovercard-subject-tagpull_request:1586136220
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/111694/commits
twitter:imagehttps://opengraph.githubassets.com/19760e156442cb2e9ff25d126316de59f2b4f315f714dd69c26a1e219b91a253/python/cpython/pull/111694
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/19760e156442cb2e9ff25d126316de59f2b4f315f714dd69c26a1e219b91a253/python/cpython/pull/111694
og:image:altThis PR addresses #111693 and adds unit tests for them. Piggybacked on it are minor simplifying changes to asyncio.Lock.acquire() and asyncio.Semaphore.acquire(), as well as removal of dead code: ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekristjanvalur
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/111694/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111694%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111694%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/111694/commits
Reloadhttps://github.com/python/cpython/pull/111694/commits
Reloadhttps://github.com/python/cpython/pull/111694/commits
Please reload this pagehttps://github.com/python/cpython/pull/111694/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/111694/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
kristjanvalur:kristjan/CancelledErrorhttps://github.com/kristjanvalur/stackless/tree/kristjan/CancelledError
Conversationhttps://github.com/python/cpython/pull/111694
Commits14 (14)https://github.com/python/cpython/pull/111694/commits
Checkshttps://github.com/python/cpython/pull/111694/checks
Files changedhttps://github.com/python/cpython/pull/111694/files
GH-111693: Propagate correct asyncio.CancelledError instance out of asyncio.Condition.wait()https://github.com/python/cpython/pull/111694/commits#top
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
kristjanvalur:kristjan/CancelledErrorhttps://github.com/kristjanvalur/stackless/tree/kristjan/CancelledError
Add test and fix case where original CancelledError was not re-raised.https://github.com/python/cpython/pull/111694/commits/c3aff478c7a58e3d09e3bd18ff0a897e06bff293
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/python/cpython/commits?author=kristjanvalur
c3aff47https://github.com/python/cpython/pull/111694/commits/c3aff478c7a58e3d09e3bd18ff0a897e06bff293
https://github.com/python/cpython/tree/c3aff478c7a58e3d09e3bd18ff0a897e06bff293
Simplify Lock/Semaphore error handling, also deal with any error.https://github.com/python/cpython/pull/111694/commits/111e74a2d39d1190fb7e510f491a1789a8c56a86
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/python/cpython/commits?author=kristjanvalur
111e74ahttps://github.com/python/cpython/pull/111694/commits/111e74a2d39d1190fb7e510f491a1789a8c56a86
https://github.com/python/cpython/tree/111e74a2d39d1190fb7e510f491a1789a8c56a86
Remove vestigial code from Futurehttps://github.com/python/cpython/pull/111694/commits/6d41771c13f333fb5b6db7af2be804f63b2fe025
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/python/cpython/commits?author=kristjanvalur
6d41771https://github.com/python/cpython/pull/111694/commits/6d41771c13f333fb5b6db7af2be804f63b2fe025
https://github.com/python/cpython/tree/6d41771c13f333fb5b6db7af2be804f63b2fe025
fix whitespacehttps://github.com/python/cpython/pull/111694/commits/4e16fa765bbd5b22ba3e52256667eded7574fc1e
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/python/cpython/commits?author=kristjanvalur
4e16fa7https://github.com/python/cpython/pull/111694/commits/4e16fa765bbd5b22ba3e52256667eded7574fc1e
https://github.com/python/cpython/tree/4e16fa765bbd5b22ba3e52256667eded7574fc1e
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/111694/commits/ad56f29676473c7ef0c4f6ba56260600ac6a6e46
kristjanvalurhttps://github.com/python/cpython/commits?author=kristjanvalur
gvanrossumhttps://github.com/python/cpython/commits?author=gvanrossum
ad56f29https://github.com/python/cpython/pull/111694/commits/ad56f29676473c7ef0c4f6ba56260600ac6a6e46
https://github.com/python/cpython/tree/ad56f29676473c7ef0c4f6ba56260600ac6a6e46
Restructure try/except, and improve commentshttps://github.com/python/cpython/pull/111694/commits/30e0ec45af0c4bf045bf4320dd0af7c47465b278
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/python/cpython/commits?author=kristjanvalur
30e0ec4https://github.com/python/cpython/pull/111694/commits/30e0ec45af0c4bf045bf4320dd0af7c47465b278
https://github.com/python/cpython/tree/30e0ec45af0c4bf045bf4320dd0af7c47465b278
Merge remote-tracking branch 'kristjan/kristjan/CancelledError' into kristjan/CancelledErrorhttps://github.com/python/cpython/pull/111694/commits/6d5982097a46a6e1206ce04050b2b01650bef745
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/python/cpython/commits?author=kristjanvalur
6d59820https://github.com/python/cpython/pull/111694/commits/6d5982097a46a6e1206ce04050b2b01650bef745
https://github.com/python/cpython/tree/6d5982097a46a6e1206ce04050b2b01650bef745
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/111694/commits/c060f40a7e0b89cd530445ea023f5ae1caceb0ec
kristjanvalurhttps://github.com/python/cpython/commits?author=kristjanvalur
gvanrossumhttps://github.com/python/cpython/commits?author=gvanrossum
c060f40https://github.com/python/cpython/pull/111694/commits/c060f40a7e0b89cd530445ea023f5ae1caceb0ec
https://github.com/python/cpython/tree/c060f40a7e0b89cd530445ea023f5ae1caceb0ec
Suggestsions from code review.https://github.com/python/cpython/pull/111694/commits/62bd6cdc420f536798741296c7be057ce2e72f09
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/python/cpython/commits?author=kristjanvalur
62bd6cdhttps://github.com/python/cpython/pull/111694/commits/62bd6cdc420f536798741296c7be057ce2e72f09
https://github.com/python/cpython/tree/62bd6cdc420f536798741296c7be057ce2e72f09
comment and add tests for waking up multiple FIFO tasks in the Semaphorehttps://github.com/python/cpython/pull/111694/commits/01046c59f21f717a249481420c7a937e6a271016
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/python/cpython/commits?author=kristjanvalur
01046c5https://github.com/python/cpython/pull/111694/commits/01046c59f21f717a249481420c7a937e6a271016
https://github.com/python/cpython/tree/01046c59f21f717a249481420c7a937e6a271016
Fix comment typohttps://github.com/python/cpython/pull/111694/commits/8802dfa7ad2cb085ba6168df9720d758dbf0cf9c
https://github.com/gvanrossum
gvanrossumhttps://github.com/python/cpython/commits?author=gvanrossum
8802dfahttps://github.com/python/cpython/pull/111694/commits/8802dfa7ad2cb085ba6168df9720d758dbf0cf9c
https://github.com/python/cpython/tree/8802dfa7ad2cb085ba6168df9720d758dbf0cf9c
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/111694/commits/f7c103cd0b88733eaf351877034bed3e4d92a0b6
https://github.com/apps/blurb-it
blurb-it[bot]https://github.com/python/cpython/commits?author=blurb-it%5Bbot%5D
f7c103chttps://github.com/python/cpython/pull/111694/commits/f7c103cd0b88733eaf351877034bed3e4d92a0b6
https://github.com/python/cpython/tree/f7c103cd0b88733eaf351877034bed3e4d92a0b6
Format, capitalize, punctuate comments.https://github.com/python/cpython/pull/111694/commits/1572b2b4469c76598e81fc9691e59a4eb2e210e4
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/python/cpython/commits?author=kristjanvalur
1572b2bhttps://github.com/python/cpython/pull/111694/commits/1572b2b4469c76598e81fc9691e59a4eb2e210e4
https://github.com/python/cpython/tree/1572b2b4469c76598e81fc9691e59a4eb2e210e4
Merge branch 'main' into kristjan/CancelledErrorhttps://github.com/python/cpython/pull/111694/commits/dce420e0ece13495c0c8c9fa3f3050c2b52902b5
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/python/cpython/commits?author=kristjanvalur
dce420ehttps://github.com/python/cpython/pull/111694/commits/dce420e0ece13495c0c8c9fa3f3050c2b52902b5
https://github.com/python/cpython/tree/dce420e0ece13495c0c8c9fa3f3050c2b52902b5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.