René's URL Explorer Experiment


Title: GH-111693: Propagate correct asyncio.CancelledError instance out of asyncio.Condition.wait() by kristjanvalur · Pull Request #111694 · python/cpython · GitHub

Open Graph Title: GH-111693: Propagate correct asyncio.CancelledError instance out of asyncio.Condition.wait() by kristjanvalur · Pull Request #111694 · python/cpython

X Title: GH-111693: Propagate correct asyncio.CancelledError instance out of asyncio.Condition.wait() by kristjanvalur · Pull Request #111694 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This PR addresses #111693 and adds unit tests for them. Piggybacked on it are minor simplifying changes to asyncio.Lock.acquire() and asyncio.Semaphore.acquire(), as well as removal of dead code: ...

X Description: This PR addresses #111693 and adds unit tests for them. Piggybacked on it are minor simplifying changes to asyncio.Lock.acquire() and asyncio.Semaphore.acquire(), as well as removal of dead code: ...

Opengraph URL: https://github.com/python/cpython/pull/111694

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:217eb5a8-dcf4-e1e5-86a0-18360ea3524f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7FC:1D4E56:C01C40:FDC9AD:6A5C2F60
html-safe-nonce23cb8b7cd62182f72339d26641370344c984737f4e517802f759bb4e31afb48f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0ZDOjFENEU1NjpDMDFDNDA6RkRDOUFEOjZBNUMyRjYwIiwidmlzaXRvcl9pZCI6IjQ0MDMxNTQ0MjcyOTkyNDU5MjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaced74a5fed4267759429812e0f976f1cce23d95011dcf755fea6c67605d81f637
hovercard-subject-tagpull_request:1586136220
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/111694/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/19760e156442cb2e9ff25d126316de59f2b4f315f714dd69c26a1e219b91a253/python/cpython/pull/111694
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/19760e156442cb2e9ff25d126316de59f2b4f315f714dd69c26a1e219b91a253/python/cpython/pull/111694
og:image:altThis PR addresses #111693 and adds unit tests for them. Piggybacked on it are minor simplifying changes to asyncio.Lock.acquire() and asyncio.Semaphore.acquire(), as well as removal of dead code: ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekristjanvalur
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/111694#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111694
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111694
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/111694
Reloadhttps://github.com/python/cpython/pull/111694
Reloadhttps://github.com/python/cpython/pull/111694
Please reload this pagehttps://github.com/python/cpython/pull/111694
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/111694
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
kristjanvalur:kristjan/CancelledErrorhttps://github.com/kristjanvalur/stackless/tree/kristjan/CancelledError
Conversationhttps://github.com/python/cpython/pull/111694
Commits14 (14)https://github.com/python/cpython/pull/111694/commits
Checkshttps://github.com/python/cpython/pull/111694/checks
Files changedhttps://github.com/python/cpython/pull/111694/files
GH-111693: Propagate correct asyncio.CancelledError instance out of asyncio.Condition.wait()https://github.com/python/cpython/pull/111694#top
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
kristjanvalur:kristjan/CancelledErrorhttps://github.com/kristjanvalur/stackless/tree/kristjan/CancelledError
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/kristjanvalur
Nov 3, 2023https://github.com/python/cpython/pull/111694#issue-1976266956
Please reload this pagehttps://github.com/python/cpython/pull/111694
#111693https://github.com/python/cpython/issues/111693
asyncio.Condition.wait() sometimes propagates incorrect asyncio.CancelledError #111693https://github.com/python/cpython/issues/111693
Please reload this pagehttps://github.com/python/cpython/pull/111694
kristjanvalurhttps://github.com/kristjanvalur
November 3, 2023 13:51https://github.com/python/cpython/pull/111694#commits-pushed-c3aff47
https://github.com/kristjanvalur
Add test and fix case where original CancelledError was not re-raised.https://github.com/python/cpython/pull/111694/commits/c3aff478c7a58e3d09e3bd18ff0a897e06bff293
c3aff47https://github.com/python/cpython/pull/111694/commits/c3aff478c7a58e3d09e3bd18ff0a897e06bff293
https://github.com/kristjanvalur
Simplify Lock/Semaphore error handling, also deal with any error.https://github.com/python/cpython/pull/111694/commits/111e74a2d39d1190fb7e510f491a1789a8c56a86
111e74ahttps://github.com/python/cpython/pull/111694/commits/111e74a2d39d1190fb7e510f491a1789a8c56a86
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/kristjanvalur
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
gvanrossumhttps://github.com/gvanrossum
kumaraditya303https://github.com/kumaraditya303
willingchttps://github.com/willingc
code ownershttps://github.com/python/cpython/blob/9f33ede12710c454643c394421f52d209247272c/.github/CODEOWNERS#L18
November 3, 2023 13:59https://github.com/python/cpython/pull/111694#event-10856454878
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 3, 2023https://github.com/python/cpython/pull/111694#event-10856455603
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 3, 2023 https://github.com/python/cpython/pull/111694#ref-issue-1976262278
asyncio.Condition.wait() sometimes propagates incorrect asyncio.CancelledError #111693 https://github.com/python/cpython/issues/111693
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/kristjanvalur
Nov 3, 2023https://github.com/python/cpython/pull/111694#event-10856468066
kristjanvalurhttps://github.com/kristjanvalur
November 4, 2023 12:11https://github.com/python/cpython/pull/111694#commits-pushed-6d41771
https://github.com/kristjanvalur
Remove vestigial code from Futurehttps://github.com/python/cpython/pull/111694/commits/6d41771c13f333fb5b6db7af2be804f63b2fe025
6d41771https://github.com/python/cpython/pull/111694/commits/6d41771c13f333fb5b6db7af2be804f63b2fe025
https://github.com/kristjanvalur
fix whitespacehttps://github.com/python/cpython/pull/111694/commits/4e16fa765bbd5b22ba3e52256667eded7574fc1e
4e16fa7https://github.com/python/cpython/pull/111694/commits/4e16fa765bbd5b22ba3e52256667eded7574fc1e
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Nov 18, 2023 https://github.com/python/cpython/pull/111694#pullrequestreview-1738493708
View reviewed changes https://github.com/python/cpython/pull/111694/files/4e16fa765bbd5b22ba3e52256667eded7574fc1e
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/111694#pullrequestreview-1738493708
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
gh-112201https://github.com/python/cpython/pull/112201
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/futures.pyhttps://github.com/python/cpython/pull/111694/files/4e16fa765bbd5b22ba3e52256667eded7574fc1e#diff-1450afcb4b859bcfe9f8f7b73ca91c40ff470cbae484d81c5315b97c86b25653
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/4e16fa765bbd5b22ba3e52256667eded7574fc1e#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/4e16fa765bbd5b22ba3e52256667eded7574fc1e#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/4e16fa765bbd5b22ba3e52256667eded7574fc1e#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/4e16fa765bbd5b22ba3e52256667eded7574fc1e#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Nov 18, 2023 https://github.com/python/cpython/pull/111694#ref-pullrequest-1999166818
gh-112202: Ensure that condition.notify() succeeds even when racing with Task.cancel() #112201 https://github.com/python/cpython/pull/112201
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/kristjanvalur
Nov 20, 2023https://github.com/python/cpython/pull/111694#issuecomment-1819048677
gh-112201https://github.com/python/cpython/pull/112201
https://github.com/kristjanvalur/py-asynkithttps://github.com/kristjanvalur/py-asynkit
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/kristjanvalur
https://github.com/gvanrossum
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/111694/commits/ad56f29676473c7ef0c4f6ba56260600ac6a6e46
ad56f29https://github.com/python/cpython/pull/111694/commits/ad56f29676473c7ef0c4f6ba56260600ac6a6e46
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Nov 20, 2023https://github.com/python/cpython/pull/111694#issuecomment-1819873758
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Nov 20, 2023 https://github.com/python/cpython/pull/111694#pullrequestreview-1740805009
View reviewed changes https://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/111694#pullrequestreview-1740805009
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
gvanrossumhttps://github.com/gvanrossum
Nov 20, 2023https://github.com/python/cpython/pull/111694#discussion_r1399822421
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
kristjanvalurhttps://github.com/kristjanvalur
Nov 21, 2023https://github.com/python/cpython/pull/111694#discussion_r1400846830
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
gvanrossumhttps://github.com/gvanrossum
Nov 20, 2023https://github.com/python/cpython/pull/111694#discussion_r1399832646
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
kristjanvalurhttps://github.com/kristjanvalur
Nov 21, 2023https://github.com/python/cpython/pull/111694#discussion_r1400879082
Please reload this pagehttps://github.com/python/cpython/pull/111694
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
gvanrossumhttps://github.com/gvanrossum
Nov 20, 2023https://github.com/python/cpython/pull/111694#discussion_r1399839943
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
kristjanvalurhttps://github.com/kristjanvalur
Nov 21, 2023https://github.com/python/cpython/pull/111694#discussion_r1400851484
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
gvanrossumhttps://github.com/gvanrossum
Nov 22, 2023https://github.com/python/cpython/pull/111694#discussion_r1401393174
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
kristjanvalurhttps://github.com/kristjanvalur
Nov 23, 2023https://github.com/python/cpython/pull/111694#discussion_r1403604371
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
gvanrossumhttps://github.com/gvanrossum
Nov 20, 2023https://github.com/python/cpython/pull/111694#discussion_r1399852401
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
kristjanvalurhttps://github.com/kristjanvalur
Nov 21, 2023https://github.com/python/cpython/pull/111694#discussion_r1400807925
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
Please reload this pagehttps://github.com/python/cpython/pull/111694
kristjanvalurhttps://github.com/kristjanvalur
November 21, 2023 17:07https://github.com/python/cpython/pull/111694#commits-pushed-30e0ec4
https://github.com/kristjanvalur
Restructure try/except, and improve commentshttps://github.com/python/cpython/pull/111694/commits/30e0ec45af0c4bf045bf4320dd0af7c47465b278
30e0ec4https://github.com/python/cpython/pull/111694/commits/30e0ec45af0c4bf045bf4320dd0af7c47465b278
https://github.com/kristjanvalur
Merge remote-tracking branch 'kristjan/kristjan/CancelledError' into …https://github.com/python/cpython/pull/111694/commits/6d5982097a46a6e1206ce04050b2b01650bef745
6d59820https://github.com/python/cpython/pull/111694/commits/6d5982097a46a6e1206ce04050b2b01650bef745
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/kristjanvalur
Nov 21, 2023https://github.com/python/cpython/pull/111694#issuecomment-1821333810
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/kristjanvalur
https://github.com/gvanrossum
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/111694/commits/c060f40a7e0b89cd530445ea023f5ae1caceb0ec
c060f40https://github.com/python/cpython/pull/111694/commits/c060f40a7e0b89cd530445ea023f5ae1caceb0ec
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Nov 22, 2023 https://github.com/python/cpython/pull/111694#pullrequestreview-1743404173
View reviewed changes https://github.com/python/cpython/pull/111694/files/c060f40a7e0b89cd530445ea023f5ae1caceb0ec
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/111694#pullrequestreview-1743404173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
gvanrossumhttps://github.com/gvanrossum
Nov 22, 2023https://github.com/python/cpython/pull/111694#discussion_r1401393174
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46..c060f40a7e0b89cd530445ea023f5ae1caceb0ec#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
gvanrossumhttps://github.com/gvanrossum
Nov 22, 2023https://github.com/python/cpython/pull/111694#discussion_r1401397405
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46..c060f40a7e0b89cd530445ea023f5ae1caceb0ec#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
gvanrossumhttps://github.com/gvanrossum
Nov 22, 2023https://github.com/python/cpython/pull/111694#discussion_r1401433237
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
gvanrossumhttps://github.com/gvanrossum
Nov 22, 2023https://github.com/python/cpython/pull/111694#discussion_r1401451608
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
kristjanvalurhttps://github.com/kristjanvalur
Nov 23, 2023https://github.com/python/cpython/pull/111694#discussion_r1403599445
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Nov 22, 2023 https://github.com/python/cpython/pull/111694#pullrequestreview-1743478333
View reviewed changes https://github.com/python/cpython/pull/111694/files/c060f40a7e0b89cd530445ea023f5ae1caceb0ec
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/111694#pullrequestreview-1743478333
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/asyncio/locks.pyhttps://github.com/python/cpython/pull/111694/files/ad56f29676473c7ef0c4f6ba56260600ac6a6e46..c060f40a7e0b89cd530445ea023f5ae1caceb0ec#diff-0fee1befb15023abc0dad2623effa93a304946796929f6cb445d11a57821e737
gvanrossumhttps://github.com/gvanrossum
Nov 22, 2023https://github.com/python/cpython/pull/111694#discussion_r1401451608
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/test/test_asyncio/test_locks.pyhttps://github.com/python/cpython/pull/111694/files/c060f40a7e0b89cd530445ea023f5ae1caceb0ec#diff-49a2abccf92f646db3568727885f472bd096941b187c3580d56d96484fc74193
gvanrossumhttps://github.com/gvanrossum
Nov 22, 2023https://github.com/python/cpython/pull/111694#discussion_r1401453218
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Nov 22, 2023https://github.com/python/cpython/pull/111694#issuecomment-1822045907
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/kristjanvalur
Nov 23, 2023https://github.com/python/cpython/pull/111694#issuecomment-1824723548
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/kristjanvalur
Nov 26, 2023https://github.com/python/cpython/pull/111694#issuecomment-1826755314
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/kristjanvalur
Suggestsions from code review.https://github.com/python/cpython/pull/111694/commits/62bd6cdc420f536798741296c7be057ce2e72f09
62bd6cdhttps://github.com/python/cpython/pull/111694/commits/62bd6cdc420f536798741296c7be057ce2e72f09
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/kristjanvalur
Nov 26, 2023https://github.com/python/cpython/pull/111694#issuecomment-1826761360
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/kristjanvalur
comment and add tests for waking up multiple FIFO tasks in the Semaphorehttps://github.com/python/cpython/pull/111694/commits/01046c59f21f717a249481420c7a937e6a271016
01046c5https://github.com/python/cpython/pull/111694/commits/01046c59f21f717a249481420c7a937e6a271016
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/kristjanvalur
Nov 26, 2023https://github.com/python/cpython/pull/111694#issuecomment-1826778534
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Dec 30, 2023 https://github.com/python/cpython/pull/111694#pullrequestreview-1799271364
View reviewed changes https://github.com/python/cpython/pull/111694/files/01046c59f21f717a249481420c7a937e6a271016
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/111694#pullrequestreview-1799271364
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/test/test_asyncio/test_locks.pyhttps://github.com/python/cpython/pull/111694/files/62bd6cdc420f536798741296c7be057ce2e72f09..01046c59f21f717a249481420c7a937e6a271016#diff-49a2abccf92f646db3568727885f472bd096941b187c3580d56d96484fc74193
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 30, 2023https://github.com/python/cpython/pull/111694#event-11359248781
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Dec 30, 2023 https://github.com/python/cpython/pull/111694#pullrequestreview-1799272795
View reviewed changes https://github.com/python/cpython/pull/111694/files/01046c59f21f717a249481420c7a937e6a271016
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/111694#pullrequestreview-1799272795
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
Lib/test/test_asyncio/test_locks.pyhttps://github.com/python/cpython/pull/111694/files/62bd6cdc420f536798741296c7be057ce2e72f09..01046c59f21f717a249481420c7a937e6a271016#diff-49a2abccf92f646db3568727885f472bd096941b187c3580d56d96484fc74193
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/gvanrossum
Fix comment typohttps://github.com/python/cpython/pull/111694/commits/8802dfa7ad2cb085ba6168df9720d758dbf0cf9c
8802dfahttps://github.com/python/cpython/pull/111694/commits/8802dfa7ad2cb085ba6168df9720d758dbf0cf9c
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Dec 30, 2023https://github.com/python/cpython/pull/111694#issuecomment-1872432552
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/kristjanvalur
Jan 6, 2024https://github.com/python/cpython/pull/111694#issuecomment-1879719716
Please reload this pagehttps://github.com/python/cpython/pull/111694
blurb-ithttps://github.com/apps/blurb-it
January 7, 2024 13:36https://github.com/python/cpython/pull/111694#commits-pushed-f7c103c
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/111694/commits/f7c103cd0b88733eaf351877034bed3e4d92a0b6
f7c103chttps://github.com/python/cpython/pull/111694/commits/f7c103cd0b88733eaf351877034bed3e4d92a0b6
https://github.com/kristjanvalur
Format, capitalize, punctuate comments.https://github.com/python/cpython/pull/111694/commits/1572b2b4469c76598e81fc9691e59a4eb2e210e4
1572b2bhttps://github.com/python/cpython/pull/111694/commits/1572b2b4469c76598e81fc9691e59a4eb2e210e4
https://github.com/kristjanvalur
Merge branch 'main' into kristjan/CancelledErrorhttps://github.com/python/cpython/pull/111694/commits/dce420e0ece13495c0c8c9fa3f3050c2b52902b5
dce420ehttps://github.com/python/cpython/pull/111694/commits/dce420e0ece13495c0c8c9fa3f3050c2b52902b5
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/kristjanvalur
Jan 7, 2024https://github.com/python/cpython/pull/111694#issuecomment-1880063089
Please reload this pagehttps://github.com/python/cpython/pull/111694
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 8, 2024 https://github.com/python/cpython/pull/111694#pullrequestreview-1809921390
View reviewed changes https://github.com/python/cpython/pull/111694/files/dce420e0ece13495c0c8c9fa3f3050c2b52902b5
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/111694#pullrequestreview-1809921390
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
5216178https://github.com/python/cpython/commit/52161781a6134a4b846500ad68004fe9027a233c
Jan 8, 2024https://github.com/python/cpython/pull/111694#event-11421951189
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 8, 2024https://github.com/python/cpython/pull/111694#event-11421951593
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/kristjanvalur
Jan 9, 2024https://github.com/python/cpython/pull/111694#issuecomment-1882822714
Please reload this pagehttps://github.com/python/cpython/pull/111694
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/kristjanvalur
kristjanvalurhttps://github.com/kristjanvalur
January 9, 2024 10:40https://github.com/python/cpython/pull/111694#event-11428543248
kulikjakhttps://github.com/kulikjak
Jan 22, 2024 https://github.com/python/cpython/pull/111694#ref-commit-d743905
https://github.com/kristjanvalur
https://github.com/kulikjak
pythonGH-111693https://github.com/python/cpython/issues/111693
: Propagate correct asyncio.CancelledError instance ou…https://github.com/kulikjak/cpython/commit/d7439052fef8150637f1131893dec03839e6fd55
d743905https://github.com/kulikjak/cpython/commit/d7439052fef8150637f1131893dec03839e6fd55
python#111694https://github.com/python/cpython/pull/111694
aiskhttps://github.com/aisk
Feb 11, 2024 https://github.com/python/cpython/pull/111694#ref-commit-80d3991
https://github.com/kristjanvalur
https://github.com/aisk
pythonGH-111693https://github.com/python/cpython/issues/111693
: Propagate correct asyncio.CancelledError instance ou…https://github.com/aisk/cpython/commit/80d3991fa88c6618a42ba01de7de422aae04f097
80d3991https://github.com/aisk/cpython/commit/80d3991fa88c6618a42ba01de7de422aae04f097
python#111694https://github.com/python/cpython/pull/111694
Glyphackhttps://github.com/Glyphack
Sep 2, 2024 https://github.com/python/cpython/pull/111694#ref-commit-7610431
https://github.com/kristjanvalur
https://github.com/Glyphack
pythonGH-111693https://github.com/python/cpython/issues/111693
: Propagate correct asyncio.CancelledError instance ou…https://github.com/Glyphack/cpython/commit/76104314aa8a7d4b1ecf548eeefa74e6e3bf43fd
7610431https://github.com/Glyphack/cpython/commit/76104314aa8a7d4b1ecf548eeefa74e6e3bf43fd
python#111694https://github.com/python/cpython/pull/111694
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111694
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/cpython/pull/111694/files/dce420e0ece13495c0c8c9fa3f3050c2b52902b5
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/willingc
willingc https://github.com/willingc
Please reload this pagehttps://github.com/python/cpython/pull/111694
https://github.com/kristjanvalur
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.