René's URL Explorer Experiment


Title: GH-109369: Exit tier 2 if executor is invalid by markshannon · Pull Request #111657 · python/cpython · GitHub

Open Graph Title: GH-109369: Exit tier 2 if executor is invalid by markshannon · Pull Request #111657 · python/cpython

X Title: GH-109369: Exit tier 2 if executor is invalid by markshannon · Pull Request #111657 · python/cpython

Description: Fixes GH-109369. Adds a _CHECK_VALIDITY uop which is inserted after any escaping operations. Ensures that uop traces will be exited promptly if the code is instrumented.

Open Graph Description: Fixes GH-109369. Adds a _CHECK_VALIDITY uop which is inserted after any escaping operations. Ensures that uop traces will be exited promptly if the code is instrumented.

X Description: Fixes GH-109369. Adds a _CHECK_VALIDITY uop which is inserted after any escaping operations. Ensures that uop traces will be exited promptly if the code is instrumented.

Opengraph URL: https://github.com/python/cpython/pull/111657

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:eb62245d-138c-70a1-8448-742ece86db40
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCBB8:3C7D7F:B1083F:F3E172:696A8A29
html-safe-nonce263abbec9d5fe5e091232c7136e220d9546634a931cb2db9a54b73078e2461ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkI4OjNDN0Q3RjpCMTA4M0Y6RjNFMTcyOjY5NkE4QTI5IiwidmlzaXRvcl9pZCI6IjYyMDMzOTE4NzYzNjcyODg4NzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb2a9e8f2da8a7b08e62181fe7a2b3fcb5a6f400a970c8992170f03cd08e87970
hovercard-subject-tagpull_request:1584806805
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/111657/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1e1c5568197bd2e0e2f28bcfa475f8feed1fa49ccae7a79eac62c676de0f3946/python/cpython/pull/111657
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1e1c5568197bd2e0e2f28bcfa475f8feed1fa49ccae7a79eac62c676de0f3946/python/cpython/pull/111657
og:image:altFixes GH-109369. Adds a _CHECK_VALIDITY uop which is inserted after any escaping operations. Ensures that uop traces will be exited promptly if the code is instrumented.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemarkshannon
hostnamegithub.com
expected-hostnamegithub.com
Noned2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1dbca8981c5e3d6a69bce2f1d289e732b86241d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/111657#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111657
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111657
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/111657
Reloadhttps://github.com/python/cpython/pull/111657
Reloadhttps://github.com/python/cpython/pull/111657
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/111657
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/111657
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/111657#issue-comment-box
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
faster-cpython:exit-if-invalidhttps://github.com/faster-cpython/cpython/tree/exit-if-invalid
GH-109369: Exit tier 2 if executor is invalid https://github.com/python/cpython/pull/111657#top
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
faster-cpython:exit-if-invalidhttps://github.com/faster-cpython/cpython/tree/exit-if-invalid
Conversation 7 https://github.com/python/cpython/pull/111657
Commits 11 https://github.com/python/cpython/pull/111657/commits
Checks 0 https://github.com/python/cpython/pull/111657/checks
Files changed https://github.com/python/cpython/pull/111657/files
Please reload this pagehttps://github.com/python/cpython/pull/111657
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Nov 2, 2023https://github.com/python/cpython/pull/111657#issue-1974784601
Please reload this pagehttps://github.com/python/cpython/pull/111657
GH-109369https://github.com/python/cpython/issues/109369
Please reload this pagehttps://github.com/python/cpython/pull/111657
markshannonhttps://github.com/markshannon
November 1, 2023 16:44https://github.com/python/cpython/pull/111657#commits-pushed-8fb3c7d
https://github.com/markshannon
Exit uop trace if trace is invalidhttps://github.com/python/cpython/pull/111657/commits/8fb3c7d70f2e11e7fa6ae2194366c7c89ca23f26
8fb3c7dhttps://github.com/python/cpython/pull/111657/commits/8fb3c7d70f2e11e7fa6ae2194366c7c89ca23f26
https://github.com/markshannon
Merge branch 'main' into exit-if-invalidhttps://github.com/python/cpython/pull/111657/commits/62d5e68ba19261b421eb0dc6e7cd58619ea3cc09
62d5e68https://github.com/python/cpython/pull/111657/commits/62d5e68ba19261b421eb0dc6e7cd58619ea3cc09
https://github.com/markshannon
Remove debug codehttps://github.com/python/cpython/pull/111657/commits/3dc1695b5a5822c1754406aae48fce9a3e29ba18
3dc1695https://github.com/python/cpython/pull/111657/commits/3dc1695b5a5822c1754406aae48fce9a3e29ba18
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 2, 2023https://github.com/python/cpython/pull/111657#event-10847529104
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Nov 2, 2023 https://github.com/python/cpython/pull/111657#ref-issue-1894124587
Executors might ignore instrumentation. #109369 https://github.com/python/cpython/issues/109369
https://github.com/markshannon
markshannonhttps://github.com/markshannon
November 3, 2023 09:43https://github.com/python/cpython/pull/111657#event-10853526566
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 3, 2023https://github.com/python/cpython/pull/111657#event-10853526970
markshannonhttps://github.com/markshannon
November 3, 2023 19:33https://github.com/python/cpython/pull/111657#commits-pushed-285600c
https://github.com/markshannon
Merge branch 'main' into exit-if-invalidhttps://github.com/python/cpython/pull/111657/commits/285600c5e608fef4a9a9908bbfaa49324d530a1b
285600chttps://github.com/python/cpython/pull/111657/commits/285600c5e608fef4a9a9908bbfaa49324d530a1b
https://github.com/markshannon
Remove most surplus _CHECK_VALIDITY uopshttps://github.com/python/cpython/pull/111657/commits/16301273c82e432763f36b8ae2b1e4de1664a6c6
1630127https://github.com/python/cpython/pull/111657/commits/16301273c82e432763f36b8ae2b1e4de1664a6c6
https://github.com/markshannon
Add newshttps://github.com/python/cpython/pull/111657/commits/1a86439c18887b189c5ee4da91b50f6187a92d9f
1a86439https://github.com/python/cpython/pull/111657/commits/1a86439c18887b189c5ee4da91b50f6187a92d9f
https://github.com/markshannon
Merge branch 'main' into exit-if-invalidhttps://github.com/python/cpython/pull/111657/commits/cccba8cfea8115feb3544c12c26fb2904cd71400
cccba8chttps://github.com/python/cpython/pull/111657/commits/cccba8cfea8115feb3544c12c26fb2904cd71400
https://github.com/markshannon
Make sure IP is up to date when checing validity.https://github.com/python/cpython/pull/111657/commits/65b6e36a2cb210963552e5d45c8a7c7d12e3d3d0
65b6e36https://github.com/python/cpython/pull/111657/commits/65b6e36a2cb210963552e5d45c8a7c7d12e3d3d0
https://github.com/markshannon
Minor fixeshttps://github.com/python/cpython/pull/111657/commits/f04bf61add7de8fa547b8dc4beaa15ce43afb599
f04bf61https://github.com/python/cpython/pull/111657/commits/f04bf61add7de8fa547b8dc4beaa15ce43afb599
https://github.com/markshannon
markshannonhttps://github.com/markshannon
November 6, 2023 14:36https://github.com/python/cpython/pull/111657#event-10873990538
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 6, 2023https://github.com/python/cpython/pull/111657#event-10873992453
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Nov 8, 2023 https://github.com/python/cpython/pull/111657#pullrequestreview-1720182941
View reviewed changes https://github.com/python/cpython/pull/111657/files/f04bf61add7de8fa547b8dc4beaa15ce43afb599
Python/optimizer.chttps://github.com/python/cpython/pull/111657/files/f04bf61add7de8fa547b8dc4beaa15ce43afb599#diff-de09f74c4306be5ef0284d665091976873569094d645a35b48467ea2a11d67f7
Please reload this pagehttps://github.com/python/cpython/pull/111657
Tools/cases_generator/flags.pyhttps://github.com/python/cpython/pull/111657/files/f04bf61add7de8fa547b8dc4beaa15ce43afb599#diff-8f4a83e53e72a65969b138b0430e1d84024738f8eca7a763ac235fee4752d82a
Please reload this pagehttps://github.com/python/cpython/pull/111657
markshannonhttps://github.com/markshannon
November 8, 2023 12:28https://github.com/python/cpython/pull/111657#commits-pushed-d624231
https://github.com/markshannon
https://github.com/iritkatriel
Update Python/optimizer.chttps://github.com/python/cpython/pull/111657/commits/d6242312fc0762a877af0e51e191d8feb9c4ade9
d624231https://github.com/python/cpython/pull/111657/commits/d6242312fc0762a877af0e51e191d8feb9c4ade9
https://github.com/markshannon
Merge branch 'main' into exit-if-invalidhttps://github.com/python/cpython/pull/111657/commits/ce3670634b5ef0c666d5e4571f10153164d27021
ce36706https://github.com/python/cpython/pull/111657/commits/ce3670634b5ef0c666d5e4571f10153164d27021
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Nov 8, 2023 https://github.com/python/cpython/pull/111657#pullrequestreview-1720248331
View reviewed changes https://github.com/python/cpython/pull/111657/files/d6242312fc0762a877af0e51e191d8feb9c4ade9
Python/optimizer_analysis.chttps://github.com/python/cpython/pull/111657/files/d6242312fc0762a877af0e51e191d8feb9c4ade9#diff-eac5ab7e741b8b825a24d31a5bf844e86086431fb698cfcabe1277b68c375ca2
Please reload this pagehttps://github.com/python/cpython/pull/111657
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Nov 8, 2023 https://github.com/python/cpython/pull/111657#pullrequestreview-1720760693
View reviewed changes https://github.com/python/cpython/pull/111657/files/d6242312fc0762a877af0e51e191d8feb9c4ade9
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 8, 2023https://github.com/python/cpython/pull/111657#event-10903046241
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Nov 8, 2023https://github.com/python/cpython/pull/111657#issuecomment-1802513294
Please reload this pagehttps://github.com/python/cpython/pull/111657
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Nov 8, 2023https://github.com/python/cpython/pull/111657#issuecomment-1802514420
Please reload this pagehttps://github.com/python/cpython/pull/111657
Please reload this pagehttps://github.com/python/cpython/pull/111657
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Nov 8, 2023https://github.com/python/cpython/pull/111657#issuecomment-1802538130
Please reload this pagehttps://github.com/python/cpython/pull/111657
https://github.com/markshannon
markshannonhttps://github.com/markshannon
25c4956https://github.com/python/cpython/commit/25c49564880e6868e4c76602f9f1650f0bc71c75
Nov 9, 2023https://github.com/python/cpython/pull/111657#event-10911922477
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 9, 2023https://github.com/python/cpython/pull/111657#event-10911923042
aiskhttps://github.com/aisk
Feb 11, 2024 https://github.com/python/cpython/pull/111657#ref-commit-93cd550
https://github.com/markshannon
https://github.com/aisk
pythonGH-109369https://github.com/python/cpython/issues/109369
: Exit tier 2 if executor is invalid (https://github.com/aisk/cpython/commit/93cd550888d1fec04bf1e4c0a2e2992110c71d49
pythonGH-111657https://github.com/python/cpython/pull/111657
)https://github.com/aisk/cpython/commit/93cd550888d1fec04bf1e4c0a2e2992110c71d49
93cd550https://github.com/aisk/cpython/commit/93cd550888d1fec04bf1e4c0a2e2992110c71d49
https://github.com/markshannon
markshannonhttps://github.com/markshannon
August 6, 2024 10:18https://github.com/python/cpython/pull/111657#event-13776328955
Glyphackhttps://github.com/Glyphack
Sep 2, 2024 https://github.com/python/cpython/pull/111657#ref-commit-3772ae9
https://github.com/markshannon
https://github.com/Glyphack
pythonGH-109369https://github.com/python/cpython/issues/109369
: Exit tier 2 if executor is invalid (https://github.com/Glyphack/cpython/commit/3772ae957be8d72307f02068502b050f67574afc
pythonGH-111657https://github.com/python/cpython/pull/111657
)https://github.com/Glyphack/cpython/commit/3772ae957be8d72307f02068502b050f67574afc
3772ae9https://github.com/Glyphack/cpython/commit/3772ae957be8d72307f02068502b050f67574afc
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111657
https://github.com/iritkatriel
iritkatriel https://github.com/iritkatriel
https://github.com/python/cpython/pull/111657/files/d6242312fc0762a877af0e51e191d8feb9c4ade9
Executors might ignore instrumentation. https://github.com/python/cpython/issues/109369
Please reload this pagehttps://github.com/python/cpython/pull/111657
https://github.com/markshannon
https://github.com/brandtbucher
https://github.com/iritkatriel
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.