| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:826bfccf-3e33-b9e9-68b7-2127e94d7e6c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9B26:222345:8964E:B1930:696B2DEF |
| html-safe-nonce | 43a755b93e721fd22d4a60b5242ed8a1df40be39938dcc4c6ea58788f1c40452 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjI2OjIyMjM0NTo4OTY0RTpCMTkzMDo2OTZCMkRFRiIsInZpc2l0b3JfaWQiOiIxNjk5OTg3NDkzOTE1MTQzNjYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a5287130f0426ff582f51bb0ca92aa3a3d7ac59414eb32ec53eae9d0317ce01b |
| hovercard-subject-tag | pull_request:1577817188 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/111454/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c80510a0e36305929a6562940957cd671da2c070f3b3c36ccfe1623c4f4d4645/python/cpython/pull/111454 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c80510a0e36305929a6562940957cd671da2c070f3b3c36ccfe1623c4f4d4645/python/cpython/pull/111454 |
| og:image:alt | Remove unused code block in math.trunc() and builtin_round_impl as mentioned in #111417
Issue: Useless code block in math.trunc() ? #111417 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Jason-Y-Z |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/111454#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111454 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111454 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/111454 |
| Reload | https://github.com/python/cpython/pull/111454 |
| Reload | https://github.com/python/cpython/pull/111454 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/111454#issue-comment-box |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| python:main | https://github.com/python/cpython/tree/main |
| Jason-Y-Z:fix-issue-111417 | https://github.com/Jason-Y-Z/cpython/tree/fix-issue-111417 |
|
gh-111417: Remove unused code block in math.trunc() and builtin_round_impl
| https://github.com/python/cpython/pull/111454#top |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| python:main | https://github.com/python/cpython/tree/main |
| Jason-Y-Z:fix-issue-111417 | https://github.com/Jason-Y-Z/cpython/tree/fix-issue-111417 |
|
Conversation
9
| https://github.com/python/cpython/pull/111454 |
|
Commits
1
| https://github.com/python/cpython/pull/111454/commits |
|
Checks
0
| https://github.com/python/cpython/pull/111454/checks |
|
Files changed
| https://github.com/python/cpython/pull/111454/files |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/Jason-Y-Z |
| Jason-Y-Z | https://github.com/Jason-Y-Z |
| Oct 29, 2023 | https://github.com/python/cpython/pull/111454#issue-1966932691 |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
| #111417 | https://github.com/python/cpython/issues/111417 |
| Useless code block in math.trunc() ? #111417 | https://github.com/python/cpython/issues/111417 |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Oct 29, 2023
| https://github.com/python/cpython/pull/111454#ref-issue-1966356804 |
|
Useless code block in math.trunc() ?
#111417
| https://github.com/python/cpython/issues/111417 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Oct 29, 2023 | https://github.com/python/cpython/pull/111454#event-10799553204 |
| https://github.com/skirpichev |
| skirpichev | https://github.com/skirpichev |
| Oct 29, 2023 | https://github.com/python/cpython/pull/111454#issuecomment-1784084914 |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
| https://github.com/willingc |
| willingc | https://github.com/willingc |
|
Oct 29, 2023
| https://github.com/python/cpython/pull/111454#pullrequestreview-1703003033 |
|
View reviewed changes
| https://github.com/python/cpython/pull/111454/files |
| Misc/NEWS.d/next/Library/2023-10-29-11-51-04.gh-issue-111417.LkmWKc.rst | https://github.com/python/cpython/pull/111454/files#diff-0afae8699b8db749d229bbd86c7388be639417924a4ea536bdd6eebc08beda93 |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
| https://github.com/willingc |
| willingc | https://github.com/willingc |
|
Oct 29, 2023
| https://github.com/python/cpython/pull/111454#pullrequestreview-1703003131 |
|
View reviewed changes
| https://github.com/python/cpython/pull/111454/files |
| Modules/mathmodule.c | https://github.com/python/cpython/pull/111454/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7 |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
| https://github.com/Jason-Y-Z |
| Jason-Y-Z | https://github.com/Jason-Y-Z |
| Nov 7, 2023 | https://github.com/python/cpython/pull/111454#issuecomment-1798136637 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Dec 7, 2023
| https://github.com/python/cpython/pull/111454#pullrequestreview-1769770841 |
|
View reviewed changes
| https://github.com/python/cpython/pull/111454/files |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| https://github.com/python/cpython/pull/111454#pullrequestreview-1769770841 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
| Misc/NEWS.d/next/Library/2023-10-29-11-51-04.gh-issue-111417.LkmWKc.rst | https://github.com/python/cpython/pull/111454/files#diff-0afae8699b8db749d229bbd86c7388be639417924a4ea536bdd6eebc08beda93 |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Dec 7, 2023 | https://github.com/python/cpython/pull/111454#event-11180045170 |
|
| https://github.com/Jason-Y-Z |
| pythongh-111417 | https://github.com/python/cpython/issues/111417 |
| : Remove unused code block in math.trunc() and builtin… | https://github.com/python/cpython/pull/111454/commits/9716a15ca0b289ed80d6aacee8a194482c28fe20 |
| 9716a15 | https://github.com/python/cpython/pull/111454/commits/9716a15ca0b289ed80d6aacee8a194482c28fe20 |
| https://github.com/Jason-Y-Z |
| Jason-Y-Z | https://github.com/Jason-Y-Z |
| force-pushed | https://github.com/python/cpython/compare/3048741ca555263108827e9a8492710fb1b46413..9716a15ca0b289ed80d6aacee8a194482c28fe20 |
| 3048741 | https://github.com/python/cpython/commit/3048741ca555263108827e9a8492710fb1b46413 |
| 9716a15 | https://github.com/python/cpython/commit/9716a15ca0b289ed80d6aacee8a194482c28fe20 |
|
Compare
| https://github.com/python/cpython/compare/3048741ca555263108827e9a8492710fb1b46413..9716a15ca0b289ed80d6aacee8a194482c28fe20 |
| February 3, 2024 11:31 | https://github.com/python/cpython/pull/111454#event-11692433250 |
| https://github.com/Jason-Y-Z |
| Jason-Y-Z | https://github.com/Jason-Y-Z |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| code owner | https://github.com/python/cpython/blob/28bb2961ba2f650452c949fcfc75ccfe0b5517e9/.github/CODEOWNERS#L55 |
| February 3, 2024 11:31 | https://github.com/python/cpython/pull/111454#event-11692433253 |
| https://github.com/Jason-Y-Z |
| Jason-Y-Z | https://github.com/Jason-Y-Z |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| February 3, 2024 11:31 | https://github.com/python/cpython/pull/111454#event-11692434131 |
| https://github.com/Jason-Y-Z |
| Jason-Y-Z | https://github.com/Jason-Y-Z |
| Feb 3, 2024 | https://github.com/python/cpython/pull/111454#event-11692435107 |
| https://github.com/Jason-Y-Z |
| Jason-Y-Z | https://github.com/Jason-Y-Z |
| Feb 3, 2024 | https://github.com/python/cpython/pull/111454#issuecomment-1925291534 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Feb 3, 2024
| https://github.com/python/cpython/pull/111454#pullrequestreview-1861045397 |
|
View reviewed changes
| https://github.com/python/cpython/pull/111454/files/9716a15ca0b289ed80d6aacee8a194482c28fe20 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| https://github.com/python/cpython/pull/111454#pullrequestreview-1861045397 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Feb 3, 2024 | https://github.com/python/cpython/pull/111454#event-11692811623 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| efc4890 | https://github.com/python/cpython/commit/efc489021c2a5dba46979bd304563aee0c479a31 |
| Feb 3, 2024 | https://github.com/python/cpython/pull/111454#event-11692815474 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Feb 3, 2024 | https://github.com/python/cpython/pull/111454#event-11692815555 |
| https://github.com/Jason-Y-Z |
| Jason-Y-Z | https://github.com/Jason-Y-Z |
| February 3, 2024 19:40 | https://github.com/python/cpython/pull/111454#event-11693360048 |
| aisk | https://github.com/aisk |
|
Feb 11, 2024
| https://github.com/python/cpython/pull/111454#ref-commit-6ee8a57 |
|
| https://github.com/Jason-Y-Z |
|
| https://github.com/aisk |
| pythongh-111417 | https://github.com/python/cpython/issues/111417 |
| : Remove unused code block in math.trunc() and round() ( | https://github.com/aisk/cpython/commit/6ee8a57f02d5c1f34e84b52c70e06082b0eaeab0 |
| … | https://github.com/python/cpython/pull/111454 |
| 6ee8a57 | https://github.com/aisk/cpython/commit/6ee8a57f02d5c1f34e84b52c70e06082b0eaeab0 |
| …pythonGH-111454 | https://github.com/python/cpython/pull/111454 |
| fsc-eriker | https://github.com/fsc-eriker |
|
Feb 14, 2024
| https://github.com/python/cpython/pull/111454#ref-commit-8e8de6c |
|
| https://github.com/Jason-Y-Z |
|
| https://github.com/fsc-eriker |
| pythongh-111417 | https://github.com/python/cpython/issues/111417 |
| : Remove unused code block in math.trunc() and round() ( | https://github.com/fsc-eriker/cpython/commit/8e8de6ce52b01ed2ce51480c81d4245c8a74d325 |
| … | https://github.com/python/cpython/pull/111454 |
| 8e8de6c | https://github.com/fsc-eriker/cpython/commit/8e8de6ce52b01ed2ce51480c81d4245c8a74d325 |
| …pythonGH-111454 | https://github.com/python/cpython/pull/111454 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111454 |
|
| https://github.com/willingc |
|
willingc
| https://github.com/willingc |
|
| https://github.com/python/cpython/pull/111454/files/3048741ca555263108827e9a8492710fb1b46413 |
|
| https://github.com/serhiy-storchaka |
|
serhiy-storchaka
| https://github.com/serhiy-storchaka |
|
| https://github.com/python/cpython/pull/111454/files/9716a15ca0b289ed80d6aacee8a194482c28fe20 |
|
| https://github.com/ericsnowcurrently |
|
ericsnowcurrently
| https://github.com/ericsnowcurrently |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/111454 |
|
| https://github.com/Jason-Y-Z |
|
| https://github.com/skirpichev |
|
| https://github.com/willingc |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |