René's URL Explorer Experiment


Title: [3.12] gh-110205: Fix asyncio ThreadedChildWatcher._join_threads() (GH-110884) by miss-islington · Pull Request #111412 · python/cpython · GitHub

Open Graph Title: [3.12] gh-110205: Fix asyncio ThreadedChildWatcher._join_threads() (GH-110884) by miss-islington · Pull Request #111412 · python/cpython

X Title: [3.12] gh-110205: Fix asyncio ThreadedChildWatcher._join_threads() (GH-110884) by miss-islington · Pull Request #111412 · python/cpython

Description: ThreadedChildWatcher.close() is now officially a no-op; _join_threads() never did anything. Threads created by that class are now named asyncio-waitpid-NNN. test.test_asyncio.utils.TestCase.close_loop() now waits for the child watcher's threads, but not forever; if a thread hangs, it raises RuntimeError. (cherry picked from commit c3bb10c) Co-authored-by: Guido van Rossum guido@python.org Issue: gh-110205

Open Graph Description: ThreadedChildWatcher.close() is now officially a no-op; _join_threads() never did anything. Threads created by that class are now named asyncio-waitpid-NNN. test.test_asyncio.utils.TestCase.close_l...

X Description: ThreadedChildWatcher.close() is now officially a no-op; _join_threads() never did anything. Threads created by that class are now named asyncio-waitpid-NNN. test.test_asyncio.utils.TestCase.close_l...

Opengraph URL: https://github.com/python/cpython/pull/111412

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c35792fa-4a43-ac14-d93c-1cd615fe5bc8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC6F8:151FE8:8D687:10F7AF:6A50B59E
html-safe-nonce3046889ad5f2fd420602f85fba86fd349e1fbbeb21acb77f2472b96234b74a7a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkY4OjE1MUZFODo4RDY4NzoxMEY3QUY6NkE1MEI1OUUiLCJ2aXNpdG9yX2lkIjoiMzAwNjYzNjAyNzA2ODU5MzU2NiIsInJlZ2lvbl9lZGdlIjoid2VzdHVzMiIsInJlZ2lvbl9yZW5kZXIiOiJ3ZXN0dXMyIn0=
visitor-hmac714031c039742c21db2129340c8437f042769471d615c580328bbc42f13933d8
hovercard-subject-tagpull_request:1577277024
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/111412/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altThreadedChildWatcher.close() is now officially a no-op; _join_threads() never did anything. Threads created by that class are now named asyncio-waitpid-NNN. test.test_asyncio.utils.TestCase.close_l...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None63772747707af4093f0d5fc7aa1bb3bb55f412a9865207c4f421aa34c64cc404
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseded53fe94e3ff1bb4dbf8cc77e285396c92580fb
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/111412/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111412%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F111412%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/111412/files
Reloadhttps://github.com/python/cpython/pull/111412/files
Reloadhttps://github.com/python/cpython/pull/111412/files
Please reload this pagehttps://github.com/python/cpython/pull/111412/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/111412/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:3.12https://github.com/python/cpython/tree/3.12
miss-islington:backport-c3bb10c-3.12https://github.com/miss-islington/cpython/tree/backport-c3bb10c-3.12
Conversation 0 https://github.com/python/cpython/pull/111412
Commits 1 https://github.com/python/cpython/pull/111412/commits
Checks 0 https://github.com/python/cpython/pull/111412/checks
Files changed https://github.com/python/cpython/pull/111412/files
Please reload this pagehttps://github.com/python/cpython/pull/111412/files
[3.12] gh-110205: Fix asyncio ThreadedChildWatcher._join_threads() (GH-110884) https://github.com/python/cpython/pull/111412/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/111412/files
8d9326d gh-110205: Fix asyncio ThreadedChildWatcher._join_threads() (GH-110884) gvanrossum Oct 27, 2023 https://github.com/python/cpython/pull/111412/commits/8d9326d7ceeeccf753c04068df9c8ffa612ce9d9
Clear filters https://github.com/python/cpython/pull/111412/files
Please reload this pagehttps://github.com/python/cpython/pull/111412/files
Please reload this pagehttps://github.com/python/cpython/pull/111412/files
unix_events.py https://github.com/python/cpython/pull/111412/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4
utils.py https://github.com/python/cpython/pull/111412/files#diff-73a82d560b5e6a3b3abd58b460de2b09eaf53e3d1598a263a7b3a61d41068d34
https://github.com/python/cpython/blob/3.12/.github/CODEOWNERS#L18
Lib/asyncio/unix_events.pyhttps://github.com/python/cpython/pull/111412/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4
View file https://github.com/miss-islington/cpython/blob/8d9326d7ceeeccf753c04068df9c8ffa612ce9d9/Lib/asyncio/unix_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/111412/{{ revealButtonHref }}
https://github.com/python/cpython/pull/111412/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4
https://github.com/python/cpython/pull/111412/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4
https://github.com/python/cpython/pull/111412/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4
https://github.com/python/cpython/blob/3.12/.github/CODEOWNERS#L18
Lib/test/test_asyncio/utils.pyhttps://github.com/python/cpython/pull/111412/files#diff-73a82d560b5e6a3b3abd58b460de2b09eaf53e3d1598a263a7b3a61d41068d34
View file https://github.com/miss-islington/cpython/blob/8d9326d7ceeeccf753c04068df9c8ffa612ce9d9/Lib/test/test_asyncio/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/111412/{{ revealButtonHref }}
https://github.com/python/cpython/pull/111412/files#diff-73a82d560b5e6a3b3abd58b460de2b09eaf53e3d1598a263a7b3a61d41068d34
https://github.com/python/cpython/pull/111412/files#diff-73a82d560b5e6a3b3abd58b460de2b09eaf53e3d1598a263a7b3a61d41068d34
https://github.com/python/cpython/pull/111412/files#diff-73a82d560b5e6a3b3abd58b460de2b09eaf53e3d1598a263a7b3a61d41068d34
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.