René's URL Explorer Experiment


Title: Enable most pyflakes rules when running ruff on `Lib/test` in CI by AlexWaygood · Pull Request #110917 · python/cpython · GitHub

Open Graph Title: Enable most pyflakes rules when running ruff on `Lib/test` in CI by AlexWaygood · Pull Request #110917 · python/cpython

X Title: Enable most pyflakes rules when running ruff on `Lib/test` in CI by AlexWaygood · Pull Request #110917 · python/cpython

Description: Ruff's pyflakes rules generally have very few false-positive errors; I think we generally should aim to have as many enabled in CI as is practical. With the exception of a few rules that currently have many hits when enabled on our test suite, this PR enables the full suite of pyflakes rules when running ruff on Lib/test/.

Open Graph Description: Ruff's pyflakes rules generally have very few false-positive errors; I think we generally should aim to have as many enabled in CI as is practical. With the exception of a few rules that curren...

X Description: Ruff's pyflakes rules generally have very few false-positive errors; I think we generally should aim to have as many enabled in CI as is practical. With the exception of a few rules that cu...

Opengraph URL: https://github.com/python/cpython/pull/110917

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files/:range(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:819db75f-75a4-dd9e-6ed4-e0865965eab8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9474:A48B4:3F3A0AB:54EEFC3:69969BED
html-safe-noncef011ae1f38ad6b9cab276e58f4ee3a5bf3ef195bd2221ff71bca2ab5ad71764a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDc0OkE0OEI0OjNGM0EwQUI6NTRFRUZDMzo2OTk2OUJFRCIsInZpc2l0b3JfaWQiOiI2MTQ5Nzk2MTU2MzA0NDMyMTA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9f7dd76e21fe5ec087fbc01db65adaf82b6538501191aae38dde4ff777e01d2f
hovercard-subject-tagpull_request:1558314792
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681
twitter:imagehttps://avatars.githubusercontent.com/u/66076021?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/66076021?s=400&v=4
og:image:altRuff's pyflakes rules generally have very few false-positive errors; I think we generally should aim to have as many enabled in CI as is practical. With the exception of a few rules that curren...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5513290f8d09a9ed78de519ab8316ed23b2b0ddd5e91d2420df56691d00827e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release713df166b386c9c8deff3497f1bcf2b0591aa817
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F110917%2Ffiles%2F985595ce593961db016d0d459e19004c43011681
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F110917%2Ffiles%2F985595ce593961db016d0d459e19004c43011681
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681
Reloadhttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681
Reloadhttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:more-ruffhttps://github.com/AlexWaygood/cpython/tree/more-ruff
Conversation 2 https://github.com/python/cpython/pull/110917
Commits 2 https://github.com/python/cpython/pull/110917/commits
Checks 0 https://github.com/python/cpython/pull/110917/checks
Files changed https://github.com/python/cpython/pull/110917/files
Please reload this pagehttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681
Enable most pyflakes rules when running ruff on Lib/test in CI https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#top
Show all changes 2 commits https://github.com/python/cpython/pull/110917/files
985595c Enable most pyflakes rules when running ruff on `Lib/test` in CI AlexWaygood Oct 16, 2023 https://github.com/python/cpython/pull/110917/commits/985595ce593961db016d0d459e19004c43011681
7fdba02 Merge branch 'main' into more-ruff AlexWaygood Oct 16, 2023 https://github.com/python/cpython/pull/110917/commits/7fdba02e76f6a3274a7ce2857f670b072bff2b7e
Clear filters https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681
Please reload this pagehttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681
Please reload this pagehttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681
.ruff.toml https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-04b0f787c14f2fdcbc8e759fe78cf46b3e72cc9102d9e67684d15fa6c8673c5e
test_compile.py https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-c69ceae0611c40012b4691e3536bf17efacdb5b51b8e155eec9a939108e42e43
test_format.py https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-abdba5791a8f0143685a423eba82d53f951df55e45d87b5bea45a1e3acd43351
test_long.py https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-02037b51ab56d36386bd847e681b34c3d6603b5ec033cfea65fc92357697a478
test_peepholer.py https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-bcf92ed219340e9e0c52401909828c2e9a821541660073e24d64dd996beaf842
test_string.py https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-95bb50b3b847c725c7aa68ed49b82f17a9565d88254dc0afb6b1919ec8662d79
__init__.py https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-21be9e4809f5cd7dcd4665eb0054b4bf9d924c2c9ce0a010e85dba405e94d9e9
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L72
Lib/test/.ruff.tomlhttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-04b0f787c14f2fdcbc8e759fe78cf46b3e72cc9102d9e67684d15fa6c8673c5e
View file https://github.com/python/cpython/blob/985595ce593961db016d0d459e19004c43011681/Lib/test/.ruff.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/110917/files/{{ revealButtonHref }}
https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-04b0f787c14f2fdcbc8e759fe78cf46b3e72cc9102d9e67684d15fa6c8673c5e
Lib/test/test_compile.pyhttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-c69ceae0611c40012b4691e3536bf17efacdb5b51b8e155eec9a939108e42e43
View file https://github.com/python/cpython/blob/985595ce593961db016d0d459e19004c43011681/Lib/test/test_compile.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/110917/files/{{ revealButtonHref }}
https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-c69ceae0611c40012b4691e3536bf17efacdb5b51b8e155eec9a939108e42e43
https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-c69ceae0611c40012b4691e3536bf17efacdb5b51b8e155eec9a939108e42e43
Lib/test/test_format.pyhttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-abdba5791a8f0143685a423eba82d53f951df55e45d87b5bea45a1e3acd43351
View file https://github.com/python/cpython/blob/985595ce593961db016d0d459e19004c43011681/Lib/test/test_format.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/110917/files/{{ revealButtonHref }}
https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-abdba5791a8f0143685a423eba82d53f951df55e45d87b5bea45a1e3acd43351
https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-abdba5791a8f0143685a423eba82d53f951df55e45d87b5bea45a1e3acd43351
Lib/test/test_long.pyhttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-02037b51ab56d36386bd847e681b34c3d6603b5ec033cfea65fc92357697a478
View file https://github.com/python/cpython/blob/985595ce593961db016d0d459e19004c43011681/Lib/test/test_long.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/110917/files/{{ revealButtonHref }}
https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-02037b51ab56d36386bd847e681b34c3d6603b5ec033cfea65fc92357697a478
AlexWaygoodhttps://github.com/AlexWaygood
Oct 16, 2023https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#r1360462455
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
cpython/Lib/test/test_long.pyhttps://github.com/python/cpython/blob/162213f2db3835e1115178d38741544f4b4db416/Lib/test/test_long.py#L1421
162213fhttps://github.com/python/cpython/commit/162213f2db3835e1115178d38741544f4b4db416
cpython/Lib/test/test_long.pyhttps://github.com/python/cpython/blob/162213f2db3835e1115178d38741544f4b4db416/Lib/test/test_long.py#L1432
162213fhttps://github.com/python/cpython/commit/162213f2db3835e1115178d38741544f4b4db416
Please reload this pagehttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681
https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-02037b51ab56d36386bd847e681b34c3d6603b5ec033cfea65fc92357697a478
Lib/test/test_peepholer.pyhttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-bcf92ed219340e9e0c52401909828c2e9a821541660073e24d64dd996beaf842
View file https://github.com/python/cpython/blob/985595ce593961db016d0d459e19004c43011681/Lib/test/test_peepholer.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/110917/files/{{ revealButtonHref }}
https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-bcf92ed219340e9e0c52401909828c2e9a821541660073e24d64dd996beaf842
https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-bcf92ed219340e9e0c52401909828c2e9a821541660073e24d64dd996beaf842
Lib/test/test_string.pyhttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-95bb50b3b847c725c7aa68ed49b82f17a9565d88254dc0afb6b1919ec8662d79
View file https://github.com/python/cpython/blob/985595ce593961db016d0d459e19004c43011681/Lib/test/test_string.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/110917/files/{{ revealButtonHref }}
https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-95bb50b3b847c725c7aa68ed49b82f17a9565d88254dc0afb6b1919ec8662d79
https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-95bb50b3b847c725c7aa68ed49b82f17a9565d88254dc0afb6b1919ec8662d79
Lib/test/test_warnings/__init__.pyhttps://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-21be9e4809f5cd7dcd4665eb0054b4bf9d924c2c9ce0a010e85dba405e94d9e9
View file https://github.com/python/cpython/blob/985595ce593961db016d0d459e19004c43011681/Lib/test/test_warnings/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/110917/files/{{ revealButtonHref }}
https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-21be9e4809f5cd7dcd4665eb0054b4bf9d924c2c9ce0a010e85dba405e94d9e9
https://github.com/python/cpython/pull/110917/files/985595ce593961db016d0d459e19004c43011681#diff-21be9e4809f5cd7dcd4665eb0054b4bf9d924c2c9ce0a010e85dba405e94d9e9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.