René's URL Explorer Experiment


Title: gh-110205: Fix asyncio ThreadedChildWatcher._join_threads() by vstinner · Pull Request #110790 · python/cpython · GitHub

Open Graph Title: gh-110205: Fix asyncio ThreadedChildWatcher._join_threads() by vstinner · Pull Request #110790 · python/cpython

X Title: gh-110205: Fix asyncio ThreadedChildWatcher._join_threads() by vstinner · Pull Request #110790 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: ThreadedChildWatcher._join_threads() now clears references to completed threads. test_asyncio.utils.TestCase now calls _join_threads() of the watcher, uses SHORT_TIMEOUT to join a thread, and then ...

X Description: ThreadedChildWatcher._join_threads() now clears references to completed threads. test_asyncio.utils.TestCase now calls _join_threads() of the watcher, uses SHORT_TIMEOUT to join a thread, and then ...

Opengraph URL: https://github.com/python/cpython/pull/110790

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:14c96689-776f-eff1-72dc-fceb8fc117c6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB58A:1ECB:1714E4A:20A8ABD:6A4FECC6
html-safe-nonce4c114e337f9ef41e0d50c707e0e69e0b8b0dd5783228ce4bc9c536cb8d6b118c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNThBOjFFQ0I6MTcxNEU0QToyMEE4QUJEOjZBNEZFQ0M2IiwidmlzaXRvcl9pZCI6IjcyMTg2MDU2MDk4MDkwNzk0OTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccd376dbb655d2bb55f69dc89775b1832875f56813586cfd1247dabcf58fe877f
hovercard-subject-tagpull_request:1555068001
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/110790/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4ababc59c9f3f2c4aeacdcc820ed0ee4004653a14005ca0c1bdb9d297d36e47a/python/cpython/pull/110790
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4ababc59c9f3f2c4aeacdcc820ed0ee4004653a14005ca0c1bdb9d297d36e47a/python/cpython/pull/110790
og:image:altThreadedChildWatcher._join_threads() now clears references to completed threads. test_asyncio.utils.TestCase now calls _join_threads() of the watcher, uses SHORT_TIMEOUT to join a thread, and then ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef7e270be010aa4de2871991025fbb97f3afe2bcb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/110790#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F110790
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F110790
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/110790
Reloadhttps://github.com/python/cpython/pull/110790
Reloadhttps://github.com/python/cpython/pull/110790
Please reload this pagehttps://github.com/python/cpython/pull/110790
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/110790
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:asyncio_clear_watcher_threadshttps://github.com/vstinner/cpython/tree/asyncio_clear_watcher_threads
Conversationhttps://github.com/python/cpython/pull/110790
Commits3 (3)https://github.com/python/cpython/pull/110790/commits
Checkshttps://github.com/python/cpython/pull/110790/checks
Files changedhttps://github.com/python/cpython/pull/110790/files
gh-110205: Fix asyncio ThreadedChildWatcher._join_threads()https://github.com/python/cpython/pull/110790#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:asyncio_clear_watcher_threadshttps://github.com/vstinner/cpython/tree/asyncio_clear_watcher_threads
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 13, 2023https://github.com/python/cpython/pull/110790#issue-1941010152
Please reload this pagehttps://github.com/python/cpython/pull/110790
test_asyncio.test_subprocess leaked dangling threads on PPC64LE Fedora Stable 3.x: #110205https://github.com/python/cpython/issues/110205
Please reload this pagehttps://github.com/python/cpython/pull/110790
https://github.com/vstinner
pythongh-110205https://github.com/python/cpython/issues/110205
: Fix asyncio ThreadedChildWatcher._join_threads()https://github.com/python/cpython/pull/110790/commits/d414ed266bfc747d03ea9044ea0f662e2b388f1c
d414ed2https://github.com/python/cpython/pull/110790/commits/d414ed266bfc747d03ea9044ea0f662e2b388f1c
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Oct 13, 2023https://github.com/python/cpython/pull/110790#event-10638353585
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
gvanrossumhttps://github.com/gvanrossum
kumaraditya303https://github.com/kumaraditya303
willingchttps://github.com/willingc
code ownershttps://github.com/python/cpython/blob/4a53a397c311567f05553bc25a28aebaba4f6f65/.github/CODEOWNERS#L18
October 13, 2023 00:30https://github.com/python/cpython/pull/110790#event-10638353732
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 13, 2023https://github.com/python/cpython/pull/110790#event-10638354224
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 13, 2023 https://github.com/python/cpython/pull/110790#ref-issue-1921581142
test_asyncio.test_subprocess leaked dangling threads on PPC64LE Fedora Stable 3.x: #110205 https://github.com/python/cpython/issues/110205
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Oct 13, 2023https://github.com/python/cpython/pull/110790#event-10638355870
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Oct 13, 2023 https://github.com/python/cpython/pull/110790#pullrequestreview-1675962127
View reviewed changes https://github.com/python/cpython/pull/110790/files/d414ed266bfc747d03ea9044ea0f662e2b388f1c
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/110790#pullrequestreview-1675962127
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/110790
Lib/asyncio/unix_events.pyhttps://github.com/python/cpython/pull/110790/files/d414ed266bfc747d03ea9044ea0f662e2b388f1c#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4
gvanrossumhttps://github.com/gvanrossum
Oct 13, 2023https://github.com/python/cpython/pull/110790#discussion_r1357926343
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/110790
vstinnerhttps://github.com/vstinner
Oct 13, 2023https://github.com/python/cpython/pull/110790#discussion_r1357951627
Please reload this pagehttps://github.com/python/cpython/pull/110790
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/110790
vstinnerhttps://github.com/vstinner
Oct 13, 2023https://github.com/python/cpython/pull/110790#discussion_r1357952423
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/110790
vstinnerhttps://github.com/vstinner
Oct 13, 2023https://github.com/python/cpython/pull/110790#discussion_r1357984372
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/110790
gvanrossumhttps://github.com/gvanrossum
Oct 13, 2023https://github.com/python/cpython/pull/110790#discussion_r1358844293
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/110790
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 13, 2023https://github.com/python/cpython/pull/110790#issuecomment-1761125032
Please reload this pagehttps://github.com/python/cpython/pull/110790
https://github.com/vstinner
Don't create a new listhttps://github.com/python/cpython/pull/110790/commits/f161daafc1d9be2a96c6486f3924dabfb63eda76
f161daahttps://github.com/python/cpython/pull/110790/commits/f161daafc1d9be2a96c6486f3924dabfb63eda76
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Oct 13, 2023https://github.com/python/cpython/pull/110790#issuecomment-1761208575
Please reload this pagehttps://github.com/python/cpython/pull/110790
https://github.com/vstinner
Fix typo: self.threads => self._threadshttps://github.com/python/cpython/pull/110790/commits/dbbad2d163f835e06514a465d33b3d34c0d42c58
dbbad2dhttps://github.com/python/cpython/pull/110790/commits/dbbad2d163f835e06514a465d33b3d34c0d42c58
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 13, 2023https://github.com/python/cpython/pull/110790#issuecomment-1761607673
Please reload this pagehttps://github.com/python/cpython/pull/110790
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 13, 2023https://github.com/python/cpython/pull/110790#event-10647183346
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
October 13, 2023 17:53https://github.com/python/cpython/pull/110790#event-10647183927
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Oct 13, 2023 https://github.com/python/cpython/pull/110790#pullrequestreview-1677371601
View reviewed changes https://github.com/python/cpython/pull/110790/files/dbbad2d163f835e06514a465d33b3d34c0d42c58
Lib/asyncio/unix_events.pyhttps://github.com/python/cpython/pull/110790/files/f161daafc1d9be2a96c6486f3924dabfb63eda76..dbbad2d163f835e06514a465d33b3d34c0d42c58#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4
gvanrossumhttps://github.com/gvanrossum
Oct 13, 2023https://github.com/python/cpython/pull/110790#discussion_r1358843171
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/110790
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Oct 14, 2023 https://github.com/python/cpython/pull/110790#ref-pullrequest-1943566450
gh-110205: Fix asyncio ThreadedChildWatcher._join_threads() #110884 https://github.com/python/cpython/pull/110884
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F110790
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/cpython/pull/110790/files/d414ed266bfc747d03ea9044ea0f662e2b388f1c
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/willingc
willingc https://github.com/willingc
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
Please reload this pagehttps://github.com/python/cpython/pull/110790
https://github.com/vstinner
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.