René's URL Explorer Experiment


Title: [3.8] gh-108310: Fix TestPreHandshakeClose tests in test_ssl by frenzymadness · Pull Request #110718 · python/cpython · GitHub

Open Graph Title: [3.8] gh-108310: Fix TestPreHandshakeClose tests in test_ssl by frenzymadness · Pull Request #110718 · python/cpython

X Title: [3.8] gh-108310: Fix TestPreHandshakeClose tests in test_ssl by frenzymadness · Pull Request #110718 · python/cpython

Description: The new class is part of the fix for CVE-2023-40217: b4bcc06 but it's not in the lists of tests so they're not executed. The new tests also need SHORT_TIMEOUT constant not available in test.support in 3.8. I'm using the original issue here as this change fixes the original testsuite for the CVE in TLS. An alternative for having the constant in test_ssl is to backport this commit from 3.9: 24c6258 But it touches a lot of files and I think that might be too much for 3.8. Cc the authors of the original fix: @ambv and @gpshead Issue: gh-108310

Open Graph Description: The new class is part of the fix for CVE-2023-40217: b4bcc06 but it's not in the lists of tests so they're not executed. The new tests also need SHORT_TIMEOUT constant not available in test...

X Description: The new class is part of the fix for CVE-2023-40217: b4bcc06 but it's not in the lists of tests so they're not executed. The new tests also need SHORT_TIMEOUT constant not available...

Opengraph URL: https://github.com/python/cpython/pull/110718

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:accded1a-a6b7-132f-dec7-5f41dc1d9159
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED04:1672C1:1A22B1A:22206F3:696B31D7
html-safe-noncea9b79b78578f0f921e57ea0e06d39e56811bcd1c964a2d2b2e866a5717077df8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDA0OjE2NzJDMToxQTIyQjFBOjIyMjA2RjM6Njk2QjMxRDciLCJ2aXNpdG9yX2lkIjoiMTcyODg1OTMwMzQ2MDk0MjI5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac95d795490ed993275629e10aa09961510bb9225943c4af5deb74d609cbbcc77d
hovercard-subject-tagpull_request:1552179091
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/110718/files
twitter:imagehttps://avatars.githubusercontent.com/u/5688939?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5688939?s=400&v=4
og:image:altThe new class is part of the fix for CVE-2023-40217: b4bcc06 but it's not in the lists of tests so they're not executed. The new tests also need SHORT_TIMEOUT constant not available in test...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/110718/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F110718%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F110718%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/110718/files
Reloadhttps://github.com/python/cpython/pull/110718/files
Reloadhttps://github.com/python/cpython/pull/110718/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/110718/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/110718/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:3.8https://github.com/python/cpython/tree/3.8
frenzymadness:fix_tls_testshttps://github.com/frenzymadness/cpython/tree/fix_tls_tests
Conversation 0 https://github.com/python/cpython/pull/110718
Commits 2 https://github.com/python/cpython/pull/110718/commits
Checks 0 https://github.com/python/cpython/pull/110718/checks
Files changed https://github.com/python/cpython/pull/110718/files
Please reload this pagehttps://github.com/python/cpython/pull/110718/files
[3.8] gh-108310: Fix TestPreHandshakeClose tests in test_ssl https://github.com/python/cpython/pull/110718/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/110718/files
7fa62f5 gh-108310: Fix TestPreHandshakeClose tests in test_ssl frenzymadness Oct 11, 2023 https://github.com/python/cpython/pull/110718/commits/7fa62f5471b71008cb98ca5abffa5be432dae39b
e82325a Add Blurb ambv Oct 11, 2023 https://github.com/python/cpython/pull/110718/commits/e82325acfbc699f1f0e7cff3f31b74081f2b26c6
Clear filters https://github.com/python/cpython/pull/110718/files
Please reload this pagehttps://github.com/python/cpython/pull/110718/files
Please reload this pagehttps://github.com/python/cpython/pull/110718/files
test_ssl.py https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
2023-10-11-16-02-55.gh-issue-108310.URRe8Y.rst https://github.com/python/cpython/pull/110718/files#diff-81a065a268fe955de00924d70350d7626dbc7ae5d346a1c257a5e8673c37fa07
https://github.com/python/cpython/blob/3.8/.github/CODEOWNERS#L40
Lib/test/test_ssl.pyhttps://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
View file https://github.com/frenzymadness/cpython/blob/e82325acfbc699f1f0e7cff3f31b74081f2b26c6/Lib/test/test_ssl.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/110718/{{ revealButtonHref }}
https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
https://github.com/python/cpython/pull/110718/files#diff-d526ded1c360bed6b222de46f4ca92b834f978ebed992fb3189bf9a94a198578
Misc/NEWS.d/next/Tests/2023-10-11-16-02-55.gh-issue-108310.URRe8Y.rsthttps://github.com/python/cpython/pull/110718/files#diff-81a065a268fe955de00924d70350d7626dbc7ae5d346a1c257a5e8673c37fa07
View file https://github.com/frenzymadness/cpython/blob/e82325acfbc699f1f0e7cff3f31b74081f2b26c6/Misc/NEWS.d/next/Tests/2023-10-11-16-02-55.gh-issue-108310.URRe8Y.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/110718/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.