Title: [3.8] gh-108310: Fix TestPreHandshakeClose tests in test_ssl by frenzymadness · Pull Request #110718 · python/cpython · GitHub
Open Graph Title: [3.8] gh-108310: Fix TestPreHandshakeClose tests in test_ssl by frenzymadness · Pull Request #110718 · python/cpython
X Title: [3.8] gh-108310: Fix TestPreHandshakeClose tests in test_ssl by frenzymadness · Pull Request #110718 · python/cpython
Description: The new class is part of the fix for CVE-2023-40217: b4bcc06 but it's not in the lists of tests so they're not executed. The new tests also need SHORT_TIMEOUT constant not available in test.support in 3.8. I'm using the original issue here as this change fixes the original testsuite for the CVE in TLS. An alternative for having the constant in test_ssl is to backport this commit from 3.9: 24c6258 But it touches a lot of files and I think that might be too much for 3.8. Cc the authors of the original fix: @ambv and @gpshead Issue: gh-108310
Open Graph Description: The new class is part of the fix for CVE-2023-40217: b4bcc06 but it's not in the lists of tests so they're not executed. The new tests also need SHORT_TIMEOUT constant not available in test...
X Description: The new class is part of the fix for CVE-2023-40217: b4bcc06 but it's not in the lists of tests so they're not executed. The new tests also need SHORT_TIMEOUT constant not available...
Opengraph URL: https://github.com/python/cpython/pull/110718
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:7420e954-ad07-a673-2d48-385339991830 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | B830:16B656:1BDE17:251509:696B369E |
| html-safe-nonce | 896db354fb90b513733c6604937e4fae59be21478243179e4c52fd7091454a7a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODMwOjE2QjY1NjoxQkRFMTc6MjUxNTA5OjY5NkIzNjlFIiwidmlzaXRvcl9pZCI6IjU5OTUzNDIyOTA0NTQ1MjU1OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 165c830fa779f7c22df4b4cb5f944269690d7d58ee2cdf71cf0cb24c67f27365 |
| hovercard-subject-tag | pull_request:1552179091 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/110718/checks |
| twitter:image | https://avatars.githubusercontent.com/u/5688939?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5688939?s=400&v=4 |
| og:image:alt | The new class is part of the fix for CVE-2023-40217: b4bcc06 but it's not in the lists of tests so they're not executed. The new tests also need SHORT_TIMEOUT constant not available in test... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width