Title: gh-104909: Make LOAD_ATTR_PROPERTY a viable uop by gvanrossum · Pull Request #110560 · python/cpython · GitHub
Open Graph Title: gh-104909: Make LOAD_ATTR_PROPERTY a viable uop by gvanrossum · Pull Request #110560 · python/cpython
X Title: gh-104909: Make LOAD_ATTR_PROPERTY a viable uop by gvanrossum · Pull Request #110560 · python/cpython
Description: There are severe problems here. LOAD_ATTR_PROPERTY takes a func_version cache entry an an fget cache entry, which need to be cross-checked (fget->func_version == func_version) but a single uop cannot reference two cache entries. The immediate fix (after rearranging the cache entries) is to load fget onto the stack. However, this isn't safe, because it will break when DEOPT_IF() jumps back to the unspecialized opcode (since the stack is different). Moreover, I needed to disable two assertions from the code generator. It's possible there's a better way, but I'd have to think, and it's not worth it unless we solve the other problem. This draft PR just exists to find out what else CI finds. Issue: gh-104909
Open Graph Description: There are severe problems here. LOAD_ATTR_PROPERTY takes a func_version cache entry an an fget cache entry, which need to be cross-checked (fget->func_version == func_version) but a single uop c...
X Description: There are severe problems here. LOAD_ATTR_PROPERTY takes a func_version cache entry an an fget cache entry, which need to be cross-checked (fget->func_version == func_version) but a single u...
Opengraph URL: https://github.com/python/cpython/pull/110560
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b4bf1580-bf72-bb29-9bda-ed7c0bbfc47c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9960:28B0D7:103036C:16C02A2:696A2B5C |
| html-safe-nonce | f5e54eca1aba231f039c6c46d2a2b0bbeff4ba50fb08683742202e5558135cb8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTYwOjI4QjBENzoxMDMwMzZDOjE2QzAyQTI6Njk2QTJCNUMiLCJ2aXNpdG9yX2lkIjoiMTQzOTgyMDQ4MTMyMDA2OTk4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c905f8a7d6dea888ab10d38523dc53bf54242eff9c1246cf512776c5f9535b33 |
| hovercard-subject-tag | pull_request:1547804163 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/110560/files |
| twitter:image | https://avatars.githubusercontent.com/u/2894642?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2894642?s=400&v=4 |
| og:image:alt | There are severe problems here. LOAD_ATTR_PROPERTY takes a func_version cache entry an an fget cache entry, which need to be cross-checked (fget->func_version == func_version) but a single uop c... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | a1022f03e4f0d91ea173e4e5dac892c982e0588c62f1ce56121d755a320a3569 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f472b8e6c7b3fdd5d0354972a3f4c516289bf0be |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width