René's URL Explorer Experiment


Title: bpo-35431: Add a function computing binomial numbers to the math module by KellerFuchs · Pull Request #11018 · python/cpython · GitHub

Open Graph Title: bpo-35431: Add a function computing binomial numbers to the math module by KellerFuchs · Pull Request #11018 · python/cpython

X Title: bpo-35431: Add a function computing binomial numbers to the math module by KellerFuchs · Pull Request #11018 · python/cpython

Description: Add tests specifying the behaviour of math.binomial(k, n): when 0 <= k <= n; when k > n; when k or n are negative or non-integral; when k or n are neither int nor float. Implement math.binomial in C; done by @FR4NKESTI3N Profile/benchmark and optimize if needed. @rhettinger suggested optimizing this, if needed, in a later PR. https://bugs.python.org/issue35431

Open Graph Description: Add tests specifying the behaviour of math.binomial(k, n): when 0 <= k <= n; when k > n; when k or n are negative or non-integral; when k or n are neither int nor float. Implement ...

X Description: Add tests specifying the behaviour of math.binomial(k, n): when 0 &lt;= k &lt;= n; when k &gt; n; when k or n are negative or non-integral; when k or n are neither int nor float. ...

Opengraph URL: https://github.com/python/cpython/pull/11018

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c17f1d3c-005e-fad4-0073-1a00705adb85
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8B2:1A6FEB:24D7E95:324F442:6A543615
html-safe-nonceb04717775759b05e8f255698d20b065c8d6f727949296e0690fa6fb83087f5df
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEIyOjFBNkZFQjoyNEQ3RTk1OjMyNEY0NDI6NkE1NDM2MTUiLCJ2aXNpdG9yX2lkIjoiODM1NTgxNDMxMTU3MTI0MDQ2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccb5a2969d46c5c719ecaa996aaf6be42c45da83376e269a5fa617df9a53b4283
hovercard-subject-tagpull_request:236835338
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/11018/files
twitter:imagehttps://avatars.githubusercontent.com/u/14331571?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/14331571?s=400&v=4
og:image:altAdd tests specifying the behaviour of math.binomial(k, n): when 0 <= k <= n; when k > n; when k or n are negative or non-integral; when k or n are neither int nor float. Implement ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/11018/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11018%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F11018%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/11018/files
Reloadhttps://github.com/python/cpython/pull/11018/files
Reloadhttps://github.com/python/cpython/pull/11018/files
Please reload this pagehttps://github.com/python/cpython/pull/11018/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/11018/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
KellerFuchshttps://github.com/KellerFuchs
python:masterhttps://github.com/python/cpython/tree/master
KellerFuchs:math/binomialhttps://github.com/KellerFuchs/cpython/tree/math/binomial
Conversation 27 https://github.com/python/cpython/pull/11018
Commits 20 https://github.com/python/cpython/pull/11018/commits
Checks 0 https://github.com/python/cpython/pull/11018/checks
Files changed https://github.com/python/cpython/pull/11018/files
Please reload this pagehttps://github.com/python/cpython/pull/11018/files
bpo-35431: Add a function computing binomial numbers to the math module https://github.com/python/cpython/pull/11018/files#top
Show all changes 20 commits https://github.com/python/cpython/pull/11018/files
0651138 Add tests for math.binomial KellerFuchs Dec 7, 2018 https://github.com/python/cpython/pull/11018/commits/0651138bef7cafa6ebcc47828327647b42d83307
5665470 Update the spec for math.binomial to reject float inputs KellerFuchs Dec 7, 2018 https://github.com/python/cpython/pull/11018/commits/56654708947a4645d9553ecd5ca6d6f18a2bf73f
7a1d05b Refactor testBinomial{Value,Type}Errors KellerFuchs Jan 28, 2019 https://github.com/python/cpython/pull/11018/commits/7a1d05bb4e3080808eac0a154a0674a96cd883ec
ff7084b Rename math.binomial to math.combinations KellerFuchs Jan 28, 2019 https://github.com/python/cpython/pull/11018/commits/ff7084bbbd2529ce8381f7320563fd9f36fc5c19
4a1d3bd 📜🤖 Added by blurb_it. blurb-it[bot] Jan 2, 2019 https://github.com/python/cpython/pull/11018/commits/4a1d3bd5da4e09ca269bd54cd6fe85f498cba5e3
bbf79c6 implemented math.comb function FR4NKESTI3N Jan 2, 2019 https://github.com/python/cpython/pull/11018/commits/bbf79c687d5174ceb74884c9723320c3b23f6882
87f71ac Rename math.comb to math.combinations KellerFuchs Jan 28, 2019 https://github.com/python/cpython/pull/11018/commits/87f71acc34892325cf2b4586571a074561ee493e
dba9385 Merge testsuites for math.combinations KellerFuchs Jan 28, 2019 https://github.com/python/cpython/pull/11018/commits/dba93852c452ce610deb19b45afa6b815a6d43c3
eb8860c fixup! 📜🤖 Added by blurb_it. KellerFuchs Jan 28, 2019 https://github.com/python/cpython/pull/11018/commits/eb8860c512698a4ec288049ad8837657c10f804c
5169915 fixup! Rename math.comb to math.combinations KellerFuchs Jan 28, 2019 https://github.com/python/cpython/pull/11018/commits/5169915a1629df7d1a5e4826b066d72ae85e3655
4b5b1d3 lib/tests: math.combinations raises ValueError when k>n KellerFuchs Jan 28, 2019 https://github.com/python/cpython/pull/11018/commits/4b5b1d3080ba96b963479f2efaf0cc23716bd32b
bd731e3 fixup! Add tests for math.binomial KellerFuchs Jan 28, 2019 https://github.com/python/cpython/pull/11018/commits/bd731e3a220b2903690267193e30bc7e8e46a887
ecb234e math.combinations: Improve notation in comments and exceptions KellerFuchs Jan 28, 2019 https://github.com/python/cpython/pull/11018/commits/ecb234e6168c8cb76d672208de24af6037368f0e
a1e6496 fixup! lib/tests: math.combinations raises ValueError when k>n KellerFuchs Feb 1, 2019 https://github.com/python/cpython/pull/11018/commits/a1e6496baf99155b6ff9477741c9a4c3d7ec074f
d1e4964 Rename math.combinations to math.comb KellerFuchs Feb 1, 2019 https://github.com/python/cpython/pull/11018/commits/d1e49643f94fd3be58c958c5ac5356d7cde13c8e
2a5b01e math.comb: Fixup mistake in exception message KellerFuchs Feb 1, 2019 https://github.com/python/cpython/pull/11018/commits/2a5b01ea7244bb2bb5a889f60cce3cf35f89ab49
5b1532c test_math: Rename testCombinations* to testComb* KellerFuchs Feb 1, 2019 https://github.com/python/cpython/pull/11018/commits/5b1532cb7ba03d1193907ae07fbf6fbb3305687e
9c0a3d0 Changed name to comb in docs FR4NKESTI3N Feb 2, 2019 https://github.com/python/cpython/pull/11018/commits/9c0a3d0f5b9081a0d0c359a78733adafad6459c4
9f50476 Update 2019-01-02-19-48-23.bpo-35431.FhG6QA.rst FR4NKESTI3N Feb 2, 2019 https://github.com/python/cpython/pull/11018/commits/9f50476498b0b9c463d0d666e9a3e545cbfaef7c
bf49e8a math.comb: Document the OverflowError behaviour KellerFuchs Feb 3, 2019 https://github.com/python/cpython/pull/11018/commits/bf49e8ae23701efb52487deb5e280bd59affdc77
Clear filters https://github.com/python/cpython/pull/11018/files
Please reload this pagehttps://github.com/python/cpython/pull/11018/files
Please reload this pagehttps://github.com/python/cpython/pull/11018/files
math.rst https://github.com/python/cpython/pull/11018/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
test_math.py https://github.com/python/cpython/pull/11018/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
2019-01-02-19-48-23.bpo-35431.FhG6QA.rst https://github.com/python/cpython/pull/11018/files#diff-f2d14dc3a39651326a8fca32dc65519bbc0b29366b6f0c398cb87661c55e0443
mathmodule.c.h https://github.com/python/cpython/pull/11018/files#diff-be28b04d80a581f81971deb34bb269241521f2aae3517b952fcfeba9f073bbf1
mathmodule.c https://github.com/python/cpython/pull/11018/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
Doc/library/math.rsthttps://github.com/python/cpython/pull/11018/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
View file https://github.com/KellerFuchs/cpython/blob/bf49e8ae23701efb52487deb5e280bd59affdc77/Doc/library/math.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11018/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11018/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
vadmiumhttps://github.com/vadmium
Apr 12, 2019https://github.com/python/cpython/pull/11018/files#r274849236
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11018/files
KellerFuchshttps://github.com/KellerFuchs
Feb 5, 2019https://github.com/python/cpython/pull/11018/files#r254083501
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/11018/files
KellerFuchshttps://github.com/KellerFuchs
Feb 5, 2019https://github.com/python/cpython/pull/11018/files#r254083702
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@FR4NKESTI3Nhttps://github.com/FR4NKESTI3N
Please reload this pagehttps://github.com/python/cpython/pull/11018/files
https://github.com/python/cpython/pull/11018/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
Lib/test/test_math.pyhttps://github.com/python/cpython/pull/11018/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
View file https://github.com/KellerFuchs/cpython/blob/bf49e8ae23701efb52487deb5e280bd59affdc77/Lib/test/test_math.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11018/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11018/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
https://github.com/python/cpython/pull/11018/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
Misc/NEWS.d/next/Library/2019-01-02-19-48-23.bpo-35431.FhG6QA.rsthttps://github.com/python/cpython/pull/11018/files#diff-f2d14dc3a39651326a8fca32dc65519bbc0b29366b6f0c398cb87661c55e0443
View file https://github.com/KellerFuchs/cpython/blob/bf49e8ae23701efb52487deb5e280bd59affdc77/Misc/NEWS.d/next/Library/2019-01-02-19-48-23.bpo-35431.FhG6QA.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11018/{{ revealButtonHref }}
Modules/clinic/mathmodule.c.hhttps://github.com/python/cpython/pull/11018/files#diff-be28b04d80a581f81971deb34bb269241521f2aae3517b952fcfeba9f073bbf1
View file https://github.com/KellerFuchs/cpython/blob/bf49e8ae23701efb52487deb5e280bd59affdc77/Modules/clinic/mathmodule.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/11018/files
Modules/mathmodule.chttps://github.com/python/cpython/pull/11018/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
View file https://github.com/KellerFuchs/cpython/blob/bf49e8ae23701efb52487deb5e280bd59affdc77/Modules/mathmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/11018/{{ revealButtonHref }}
https://github.com/python/cpython/pull/11018/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com/python/cpython/pull/11018/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com/python/cpython/pull/11018/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com/python/cpython/pull/11018/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.