René's URL Explorer Experiment


Title: gh-109782: Ensure `os.path.isdir` has the same signature on all platforms by aminalaee · Pull Request #109790 · python/cpython · GitHub

Open Graph Title: gh-109782: Ensure `os.path.isdir` has the same signature on all platforms by aminalaee · Pull Request #109790 · python/cpython

X Title: gh-109782: Ensure `os.path.isdir` has the same signature on all platforms by aminalaee · Pull Request #109790 · python/cpython

Description: To fix the os.path.isdir signature for Windows to be the same as genericpath version. # in genericpath.py def isdir(s) -> bool: ... # in optimized nt module def isdir(path) -> bool: ... Issue: ...

Open Graph Description: To fix the os.path.isdir signature for Windows to be the same as genericpath version. # in genericpath.py def isdir(s) -> bool: ... # in optimized nt module def isdir(path) -> bool: ... I...

X Description: To fix the os.path.isdir signature for Windows to be the same as genericpath version. # in genericpath.py def isdir(s) -> bool: ... # in optimized nt module def isdir(path) -> bool: ...

Opengraph URL: https://github.com/python/cpython/pull/109790

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:67b3e21b-ea6e-1ada-1cac-91cde089ddec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE292:2D4000:7855AF:A5616B:696A2099
html-safe-nonced32a4d1d1275327283ed648e3b918458eface3fe9c5c5f94839416ff96d947ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjkyOjJENDAwMDo3ODU1QUY6QTU2MTZCOjY5NkEyMDk5IiwidmlzaXRvcl9pZCI6IjIxMzUyNzAxMjg1NzgzMzg5NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac592f8dfffb3a1b3e70fa6a450c0ba9d4bae2552fdf71792600ec92f87bde2776
hovercard-subject-tagpull_request:1527397506
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/109790/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2a0f5ef7e1adeba63eb7d80d7f8ff63313c2f5f0f257c8d5f3d6550a910e7e0d/python/cpython/pull/109790
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2a0f5ef7e1adeba63eb7d80d7f8ff63313c2f5f0f257c8d5f3d6550a910e7e0d/python/cpython/pull/109790
og:image:altTo fix the os.path.isdir signature for Windows to be the same as genericpath version. # in genericpath.py def isdir(s) -> bool: ... # in optimized nt module def isdir(path) -> bool: ... I...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaminalaee
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/109790#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F109790
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F109790
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/109790
Reloadhttps://github.com/python/cpython/pull/109790
Reloadhttps://github.com/python/cpython/pull/109790
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/109790
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/109790
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/109790#issue-comment-box
zoobahttps://github.com/zooba
python:mainhttps://github.com/python/cpython/tree/main
aminalaee:fix-nt-os-path-isdir-signaturehttps://github.com/aminalaee/cpython/tree/fix-nt-os-path-isdir-signature
gh-109782: Ensure os.path.isdir has the same signature on all platforms https://github.com/python/cpython/pull/109790#top
zoobahttps://github.com/zooba
python:mainhttps://github.com/python/cpython/tree/main
aminalaee:fix-nt-os-path-isdir-signaturehttps://github.com/aminalaee/cpython/tree/fix-nt-os-path-isdir-signature
Conversation 8 https://github.com/python/cpython/pull/109790
Commits 3 https://github.com/python/cpython/pull/109790/commits
Checks 0 https://github.com/python/cpython/pull/109790/checks
Files changed https://github.com/python/cpython/pull/109790/files
Please reload this pagehttps://github.com/python/cpython/pull/109790
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/aminalaee
aminalaeehttps://github.com/aminalaee
Sep 23, 2023https://github.com/python/cpython/pull/109790#issue-1909848868
Please reload this pagehttps://github.com/python/cpython/pull/109790
Windows os.path.isdir has different signature #109782https://github.com/python/cpython/issues/109782
Please reload this pagehttps://github.com/python/cpython/pull/109790
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 23, 2023 https://github.com/python/cpython/pull/109790#ref-issue-1909792770
Windows os.path.isdir has different signature #109782 https://github.com/python/cpython/issues/109782
https://github.com/aminalaee
pythongh-109782https://github.com/python/cpython/issues/109782
Update NT os.path.isdir signaturehttps://github.com/python/cpython/pull/109790/commits/13d10dfcb5800fdd676a8ddd47395578b765a2c0
13d10dfhttps://github.com/python/cpython/pull/109790/commits/13d10dfcb5800fdd676a8ddd47395578b765a2c0
https://github.com/aminalaee
aminalaeehttps://github.com/aminalaee
force-pushedhttps://github.com/python/cpython/compare/0628d63dad3eea4852955bc9b3a7aab7aedd1723..13d10dfcb5800fdd676a8ddd47395578b765a2c0
0628d63https://github.com/python/cpython/commit/0628d63dad3eea4852955bc9b3a7aab7aedd1723
13d10dfhttps://github.com/python/cpython/commit/13d10dfcb5800fdd676a8ddd47395578b765a2c0
Compare https://github.com/python/cpython/compare/0628d63dad3eea4852955bc9b3a7aab7aedd1723..13d10dfcb5800fdd676a8ddd47395578b765a2c0
September 23, 2023 17:06https://github.com/python/cpython/pull/109790#event-10453623220
https://github.com/aminalaee
aminalaeehttps://github.com/aminalaee
September 23, 2023 17:46https://github.com/python/cpython/pull/109790#event-10453721360
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 23, 2023https://github.com/python/cpython/pull/109790#event-10453721470
https://github.com/AlexWaygood
Add news and testshttps://github.com/python/cpython/pull/109790/commits/2e995911d9d46af1b3fd31734a0311b645da96d5
2e99591https://github.com/python/cpython/pull/109790/commits/2e995911d9d46af1b3fd31734a0311b645da96d5
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Sep 24, 2023https://github.com/python/cpython/pull/109790#event-10455468780
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Sep 24, 2023 https://github.com/python/cpython/pull/109790#pullrequestreview-1641095448
View reviewed changes https://github.com/python/cpython/pull/109790/files/2e995911d9d46af1b3fd31734a0311b645da96d5
AlexWaygoodhttps://github.com/AlexWaygood
https://github.com/python/cpython/pull/109790#pullrequestreview-1641095448
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/109790
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 24, 2023https://github.com/python/cpython/pull/109790#event-10455605488
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
hauntsaninjahttps://github.com/hauntsaninja
mdboomhttps://github.com/mdboom
September 24, 2023 17:02https://github.com/python/cpython/pull/109790#event-10455605948
https://github.com/zooba
zoobahttps://github.com/zooba
Sep 26, 2023https://github.com/python/cpython/pull/109790#issuecomment-1735107074
Please reload this pagehttps://github.com/python/cpython/pull/109790
https://github.com/aminalaee
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F109790
https://github.com/aminalaee
Remove testhttps://github.com/python/cpython/pull/109790/commits/9cc53cda6c593811fabd9e2f71f439b4068d782f
9cc53cdhttps://github.com/python/cpython/pull/109790/commits/9cc53cda6c593811fabd9e2f71f439b4068d782f
https://github.com/zooba
zoobahttps://github.com/zooba
7df8b16https://github.com/python/cpython/commit/7df8b16d28d2418161cef49814b6aca9fb70788d
Sep 28, 2023https://github.com/python/cpython/pull/109790#event-10500945673
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 28, 2023https://github.com/python/cpython/pull/109790#event-10500946288
https://github.com/zooba
zoobahttps://github.com/zooba
Sep 28, 2023https://github.com/python/cpython/pull/109790#issuecomment-1739507492
Please reload this pagehttps://github.com/python/cpython/pull/109790
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Sep 28, 2023https://github.com/python/cpython/pull/109790#issuecomment-1739520938
Please reload this pagehttps://github.com/python/cpython/pull/109790
https://github.com/aminalaee
aminalaeehttps://github.com/aminalaee
September 28, 2023 15:27https://github.com/python/cpython/pull/109790#event-10501057968
csm10495https://github.com/csm10495
Sep 29, 2023 https://github.com/python/cpython/pull/109790#ref-commit-f7f79fe
https://github.com/aminalaee
https://github.com/csm10495
pythongh-109782https://github.com/python/cpython/issues/109782
: Ensurehttps://github.com/csm10495/cpython/commit/f7f79fe0b8ac72e35afe57bde86461fc68d05b6c
os.path.isdirhttps://github.com/csm10495/cpython/commit/f7f79fe0b8ac72e35afe57bde86461fc68d05b6c
has the same signature on all…https://github.com/csm10495/cpython/commit/f7f79fe0b8ac72e35afe57bde86461fc68d05b6c
f7f79fehttps://github.com/csm10495/cpython/commit/f7f79fe0b8ac72e35afe57bde86461fc68d05b6c
pythonGH-109790https://github.com/python/cpython/pull/109790
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Oct 2, 2023https://github.com/python/cpython/pull/109790#event-10528343912
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Oct 2, 2023https://github.com/python/cpython/pull/109790#issuecomment-1743369711
@aminalaeehttps://github.com/aminalaee
@zoobahttps://github.com/zooba
Please reload this pagehttps://github.com/python/cpython/pull/109790
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Oct 2, 2023https://github.com/python/cpython/pull/109790#issuecomment-1743369856
@aminalaeehttps://github.com/aminalaee
@zoobahttps://github.com/zooba
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/109790
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
zoobahttps://github.com/zooba
Oct 2, 2023https://github.com/python/cpython/pull/109790#event-10528344962
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
zoobahttps://github.com/zooba
Oct 2, 2023https://github.com/python/cpython/pull/109790#event-10528347193
AlexWaygoodhttps://github.com/AlexWaygood
Oct 2, 2023 https://github.com/python/cpython/pull/109790#ref-commit-1ca2a2f
https://github.com/aminalaee
https://github.com/AlexWaygood
pythongh-109782https://github.com/python/cpython/issues/109782
: Ensurehttps://github.com/AlexWaygood/cpython/commit/1ca2a2fa170feaab996dde741642420f33b13c72
os.path.isdirhttps://github.com/AlexWaygood/cpython/commit/1ca2a2fa170feaab996dde741642420f33b13c72
has the same signature on all…https://github.com/AlexWaygood/cpython/commit/1ca2a2fa170feaab996dde741642420f33b13c72
1ca2a2fhttps://github.com/AlexWaygood/cpython/commit/1ca2a2fa170feaab996dde741642420f33b13c72
pythonGH-109790https://github.com/python/cpython/pull/109790
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 2, 2023https://github.com/python/cpython/pull/109790#issuecomment-1743413523
GH-110233https://github.com/python/cpython/pull/110233
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/109790
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Oct 2, 2023https://github.com/python/cpython/pull/109790#event-10528468944
AlexWaygoodhttps://github.com/AlexWaygood
Oct 2, 2023 https://github.com/python/cpython/pull/109790#ref-commit-da75bd6
https://github.com/AlexWaygood
https://github.com/aminalaee
[3.12]https://github.com/python/cpython/commit/da75bd6c31ca8fbbee494a9a4fc320d8b6db0552
gh-109782https://github.com/python/cpython/issues/109782
: Ensurehttps://github.com/python/cpython/commit/da75bd6c31ca8fbbee494a9a4fc320d8b6db0552
os.path.isdirhttps://github.com/python/cpython/commit/da75bd6c31ca8fbbee494a9a4fc320d8b6db0552
has the same signature on al…https://github.com/python/cpython/commit/da75bd6c31ca8fbbee494a9a4fc320d8b6db0552
da75bd6https://github.com/python/cpython/commit/da75bd6c31ca8fbbee494a9a4fc320d8b6db0552
GH-109790https://github.com/python/cpython/pull/109790
#110233https://github.com/python/cpython/pull/110233
gh-109782https://github.com/python/cpython/issues/109782
GH-109790https://github.com/python/cpython/pull/109790
Glyphackhttps://github.com/Glyphack
Sep 2, 2024 https://github.com/python/cpython/pull/109790#ref-commit-5a8bdec
https://github.com/aminalaee
https://github.com/Glyphack
pythongh-109782https://github.com/python/cpython/issues/109782
: Ensurehttps://github.com/Glyphack/cpython/commit/5a8bdecd7886413b932a9ec23176302293725182
os.path.isdirhttps://github.com/Glyphack/cpython/commit/5a8bdecd7886413b932a9ec23176302293725182
has the same signature on all…https://github.com/Glyphack/cpython/commit/5a8bdecd7886413b932a9ec23176302293725182
5a8bdechttps://github.com/Glyphack/cpython/commit/5a8bdecd7886413b932a9ec23176302293725182
pythonGH-109790https://github.com/python/cpython/pull/109790
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F109790
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
https://github.com/python/cpython/pull/109790/files/2e995911d9d46af1b3fd31734a0311b645da96d5
https://github.com/mdboom
mdboom https://github.com/mdboom
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
Please reload this pagehttps://github.com/python/cpython/pull/109790
https://github.com/aminalaee
https://github.com/zooba
https://github.com/AlexWaygood
https://github.com/miss-islington
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.