| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:483e9ff6-e4b0-6eff-8d31-9a9899c2e883 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EC3C:12476C:17622E6:1EA9CDB:6B001680 |
| html-safe-nonce | 75f589bdfe3133f7f0d624291541c5b8c9d09bc2ff8daeac93cef6b529b1c685 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzNDOjEyNDc2QzoxNzYyMkU2OjFFQTlDREI6NkIwMDE2ODAiLCJ2aXNpdG9yX2lkIjoiODM5OTQyODczODEwNTc0Mjk3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1cad7196c61b72b579a0d891b9577faa58243008c9bb528d16c27a41099d1b82 |
| hovercard-subject-tag | pull_request:1522130197 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/109589/files |
| twitter:image | https://avatars.githubusercontent.com/u/20119138?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/20119138?s=400&v=4 |
| og:image:alt | Complete implementation for #106922. Implementing (1) requires substantial changes for an implementation of (2) or (3), so I just did it all in one go.
Some changes compared to the initial issue:
W... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | a2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 70121d4e855ee0bb7b75cf15d061d91f8863c0f8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/109589/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F109589%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F109589%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/109589/files |
| Reload | https://github.com/python/cpython/pull/109589/files |
| Reload | https://github.com/python/cpython/pull/109589/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| williamwen42 | https://github.com/williamwen42 |
| python:main | https://github.com/python/cpython/tree/main |
| williamwen42:multiline-traceback-2 | https://github.com/williamwen42/cpython/tree/multiline-traceback-2 |
|
Conversation
10
| https://github.com/python/cpython/pull/109589 |
|
Commits
14
| https://github.com/python/cpython/pull/109589/commits |
|
Checks
0
| https://github.com/python/cpython/pull/109589/checks |
|
Files changed
| https://github.com/python/cpython/pull/109589/files |
| Please reload this page | https://github.com/python/cpython/pull/109589/files |
|
gh-106922: Support multi-line error locations in traceback
| https://github.com/python/cpython/pull/109589/files#top |
|
Show all changes
14 commits
| https://github.com/python/cpython/pull/109589/files |
|
20da582
update traceback.c
williamwen42 Jul 27, 2023
| https://github.com/python/cpython/pull/109589/commits/20da58269741459dbee6cd3bee77c88e5408b34b |
|
2e63abc
update tests and traceback.py
williamwen42 Jul 29, 2023
| https://github.com/python/cpython/pull/109589/commits/2e63abc96106b7e0eaa43ce60afa1184a6ce551f |
|
db094ed
wip more updates to traceback.c
williamwen42 Aug 3, 2023
| https://github.com/python/cpython/pull/109589/commits/db094ed4c5469e188bb407f445c4f052121b0abe |
|
5d8ceff
wip more updates to traceback.c
williamwen42 Aug 18, 2023
| https://github.com/python/cpython/pull/109589/commits/5d8cefff378427ae200ee11c8ccd0c548eaace66 |
|
f35d975
wip done initial traceback.c implementation
williamwen42 Sep 13, 2023
| https://github.com/python/cpython/pull/109589/commits/f35d975a35ca3b8be6d99d8996b0d37a88ead590 |
|
9d02a5c
initial review
williamwen42 Sep 15, 2023
| https://github.com/python/cpython/pull/109589/commits/9d02a5cbac4c4096bc33cacc6fb334fa5ed6e5f8 |
|
91fcb73
fix issues - get tests passing
williamwen42 Sep 18, 2023
| https://github.com/python/cpython/pull/109589/commits/91fcb73b14ca0a9c5337bf89ff7ec80be9e72802 |
|
d155d35
add function call traceback tests
williamwen42 Sep 18, 2023
| https://github.com/python/cpython/pull/109589/commits/d155d35ed18e6505ac63a9fa1deee4b9987bff1c |
|
7bee8ba
add more tests
williamwen42 Sep 18, 2023
| https://github.com/python/cpython/pull/109589/commits/7bee8ba564eef9dabc378a1277b07897a9aca977 |
|
34a5755
make outputs abbreviated, only output 1 line when location informatio…
williamwen42 Sep 19, 2023
| https://github.com/python/cpython/pull/109589/commits/34a5755ec54415126eb8638065eb001c1f22f692 |
|
2fcbea7
fix other failing tests
williamwen42 Sep 19, 2023
| https://github.com/python/cpython/pull/109589/commits/2fcbea7da7da7a2fb7c0de126eadaa6320ab3b48 |
|
e4b978d
fix smelly symbol
williamwen42 Sep 20, 2023
| https://github.com/python/cpython/pull/109589/commits/e4b978ddc34f793fea18e6145996b4269f7fd69f |
|
26fd2d9
small fixes
williamwen42 Sep 21, 2023
| https://github.com/python/cpython/pull/109589/commits/26fd2d9a0c3f6486eaa231d7c5976d7e745be851 |
|
bd8a837
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 21, 2023
| https://github.com/python/cpython/pull/109589/commits/bd8a837b0838ad76a049d7399505b4bc4dadbc35 |
|
Clear filters
| https://github.com/python/cpython/pull/109589/files |
| Please reload this page | https://github.com/python/cpython/pull/109589/files |
| Please reload this page | https://github.com/python/cpython/pull/109589/files |
|
test_contextlib.py
| https://github.com/python/cpython/pull/109589/files#diff-36de20f5f33e93654722aa17ba15b51aa3f58c573c477d69856069944db7994f |
|
test_doctest.py
| https://github.com/python/cpython/pull/109589/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7 |
|
test_exceptions.py
| https://github.com/python/cpython/pull/109589/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f |
|
test_traceback.py
| https://github.com/python/cpython/pull/109589/files#diff-8a52124ffceebd98f91bf96caa0f341ae109f79e190cd5acc1c56c8968d75252 |
|
traceback.py
| https://github.com/python/cpython/pull/109589/files#diff-96634ca56022c201d0ff677e922810a97e4ad8a55de53258cf0cbc22bd7c9be1 |
|
2023-09-21-22-41-45.gh-issue-106922.qslOVH.rst
| https://github.com/python/cpython/pull/109589/files#diff-13945ba05936ff0a45717f975427c94686cfbb3e6c49e032526ee2f0903c8c3e |
|
traceback.c
| https://github.com/python/cpython/pull/109589/files#diff-8bca5f3e0435e43986da8b0359c72b3c60915101d3c0c84d27009eb8c15918f7 |
| Lib/test/test_contextlib.py | https://github.com/python/cpython/pull/109589/files#diff-36de20f5f33e93654722aa17ba15b51aa3f58c573c477d69856069944db7994f |
|
View file
| https://github.com/williamwen42/cpython/blob/bd8a837b0838ad76a049d7399505b4bc4dadbc35/Lib/test/test_contextlib.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/109589/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/109589/files#diff-36de20f5f33e93654722aa17ba15b51aa3f58c573c477d69856069944db7994f |
|
| https://github.com/python/cpython/pull/109589/files#diff-36de20f5f33e93654722aa17ba15b51aa3f58c573c477d69856069944db7994f |
| Lib/test/test_doctest.py | https://github.com/python/cpython/pull/109589/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7 |
|
View file
| https://github.com/williamwen42/cpython/blob/bd8a837b0838ad76a049d7399505b4bc4dadbc35/Lib/test/test_doctest.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/109589/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/109589/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7 |
|
| https://github.com/python/cpython/pull/109589/files#diff-2752e009dea2759fb0a5a0866446e8bbd3f5ed30c030b26d252d7a1178b413e7 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L247 |
| Lib/test/test_exceptions.py | https://github.com/python/cpython/pull/109589/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f |
|
View file
| https://github.com/williamwen42/cpython/blob/bd8a837b0838ad76a049d7399505b4bc4dadbc35/Lib/test/test_exceptions.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/109589/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/109589/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f |
|
| https://github.com/python/cpython/pull/109589/files#diff-3dbd58a46964dc5908595a1caa552fa3f5e2e46610679634ffc1064fd7cc3c8f |
| Please reload this page | https://github.com/python/cpython/pull/109589/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |