René's URL Explorer Experiment


Title: bpo-35398: Improve DDL statement detection for SQLite by montanalow · Pull Request #10913 · python/cpython · GitHub

Open Graph Title: bpo-35398: Improve DDL statement detection for SQLite by montanalow · Pull Request #10913 · python/cpython

X Title: bpo-35398: Improve DDL statement detection for SQLite by montanalow · Pull Request #10913 · python/cpython

Description: SQLite driver depends on DDL detection to return an accurate row count for a statement. SQL statements that begin with comments currently break DDL detection, which results in incorrect row counts ...

Open Graph Description: SQLite driver depends on DDL detection to return an accurate row count for a statement. SQL statements that begin with comments currently break DDL detection, which results in incorrect row counts ...

X Description: SQLite driver depends on DDL detection to return an accurate row count for a statement. SQL statements that begin with comments currently break DDL detection, which results in incorrect row counts ...

Opengraph URL: https://github.com/python/cpython/pull/10913

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:02e5092f-2813-759e-f0ac-90683a23f54e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE4DE:32EF48:8E15CD:C1B83E:6969E47C
html-safe-nonce1fdfeb6181074fea1ffb118d8c6c65e1a24ad82a80f9d6eb78ad4993762e0c14
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNERFOjMyRUY0ODo4RTE1Q0Q6QzFCODNFOjY5NjlFNDdDIiwidmlzaXRvcl9pZCI6IjY2NjkzMTQ2NzAyODEyMjEyNDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6513c706f73737c6884062b22457b7ec8dbce94af6b9b2fa268919d31b19db06
hovercard-subject-tagpull_request:236037696
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/10913/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9dc2d87260b12f53748dcbbcbcd07d569676711c64d9d54355bdb8e8e457aaf5/python/cpython/pull/10913
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9dc2d87260b12f53748dcbbcbcd07d569676711c64d9d54355bdb8e8e457aaf5/python/cpython/pull/10913
og:image:altSQLite driver depends on DDL detection to return an accurate row count for a statement. SQL statements that begin with comments currently break DDL detection, which results in incorrect row counts ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemontanalow
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/10913#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10913
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10913
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/10913
Reloadhttps://github.com/python/cpython/pull/10913
Reloadhttps://github.com/python/cpython/pull/10913
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/10913
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/10913
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/10913#issue-comment-box
montanalowhttps://github.com/montanalow
python:masterhttps://github.com/python/cpython/tree/master
montanalow:fix-issue-35398https://github.com/montanalow/cpython/tree/fix-issue-35398
bpo-35398: Improve DDL statement detection for SQLite https://github.com/python/cpython/pull/10913#top
montanalowhttps://github.com/montanalow
python:masterhttps://github.com/python/cpython/tree/master
montanalow:fix-issue-35398https://github.com/montanalow/cpython/tree/fix-issue-35398
Conversation 10 https://github.com/python/cpython/pull/10913
Commits 5 https://github.com/python/cpython/pull/10913/commits
Checks 0 https://github.com/python/cpython/pull/10913/checks
Files changed https://github.com/python/cpython/pull/10913/files
Please reload this pagehttps://github.com/python/cpython/pull/10913
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/montanalow
montanalowhttps://github.com/montanalow
Dec 5, 2018https://github.com/python/cpython/pull/10913#issue-387581579
Please reload this pagehttps://github.com/python/cpython/pull/10913
https://bugs.python.org/issue35398https://bugs.python.org/issue35398
Please reload this pagehttps://github.com/python/cpython/pull/10913
improve ddl statement detection against leading commentsshttps://github.com/python/cpython/pull/10913/commits/c517ef2cfcce5f592ba4f52224d7fcfb4fca6a59
c517ef2https://github.com/python/cpython/pull/10913/commits/c517ef2cfcce5f592ba4f52224d7fcfb4fca6a59
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
Dec 5, 2018https://github.com/python/cpython/pull/10913#issuecomment-444348927
PSF contributor agreementhttps://www.python.org/psf/contrib/contrib-form/
bugs.python.orghttps://bugs.python.org/
the steps outlined in the CPython devguidehttps://devguide.python.org/pullrequest/#licensing
check yourselfhttps://check-python-cla.herokuapp.com/
Please reload this pagehttps://github.com/python/cpython/pull/10913
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Dec 5, 2018https://github.com/python/cpython/pull/10913#event-2006082016
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 5, 2018https://github.com/python/cpython/pull/10913#event-2006082035
https://github.com/montanalow
montanalowhttps://github.com/montanalow
Dec 5, 2018https://github.com/python/cpython/pull/10913#issuecomment-444350649
Please reload this pagehttps://github.com/python/cpython/pull/10913
December 4, 2018 20:03https://github.com/python/cpython/pull/10913#commits-pushed-39c742f
convert tabs to spaceshttps://github.com/python/cpython/pull/10913/commits/39c742f10624343be25e80e5461b8b1fccaf16c6
39c742fhttps://github.com/python/cpython/pull/10913/commits/39c742f10624343be25e80e5461b8b1fccaf16c6
one more tabhttps://github.com/python/cpython/pull/10913/commits/57d466f27aaa19c5dd86fd49e961ae07f58e9332
57d466fhttps://github.com/python/cpython/pull/10913/commits/57d466f27aaa19c5dd86fd49e961ae07f58e9332
https://github.com/tirkarthi
tirkarthihttps://github.com/tirkarthi
Dec 5, 2018https://github.com/python/cpython/pull/10913#issuecomment-444352150
NEWS entryhttps://devguide.python.org/committing/#what-s-new-and-news-entries
Please reload this pagehttps://github.com/python/cpython/pull/10913
https://github.com/ghost
ghosthttps://github.com/ghost
Dec 5, 2018https://github.com/python/cpython/pull/10913#issuecomment-444455788
Please reload this pagehttps://github.com/python/cpython/pull/10913
https://github.com/montanalow
Use strcmp instead of unnecessary PyOS_strnicmphttps://github.com/python/cpython/pull/10913/commits/b112167fc9c355533edf3aac758b8dba07a3181f
b112167https://github.com/python/cpython/pull/10913/commits/b112167fc9c355533edf3aac758b8dba07a3181f
https://github.com/ghost
ghosthttps://github.com/ghost
Dec 6, 2018https://github.com/python/cpython/pull/10913#issuecomment-444750929
https://devguide.python.org/committing/#what-s-new-and-news-entrieshttps://devguide.python.org/committing/#what-s-new-and-news-entries
Please reload this pagehttps://github.com/python/cpython/pull/10913
https://github.com/montanalow
use strncmp over strcmphttps://github.com/python/cpython/pull/10913/commits/1e8fd4cb45b7f23cc8c00b7cf09208896d1e1ed9
1e8fd4chttps://github.com/python/cpython/pull/10913/commits/1e8fd4cb45b7f23cc8c00b7cf09208896d1e1ed9
https://github.com/ghost
ghosthttps://github.com/ghost
Dec 6, 2018https://github.com/python/cpython/pull/10913#issuecomment-444759078
Please reload this pagehttps://github.com/python/cpython/pull/10913
https://github.com/montanalow
montanalowhttps://github.com/montanalow
Dec 6, 2018https://github.com/python/cpython/pull/10913#issuecomment-444760179
Please reload this pagehttps://github.com/python/cpython/pull/10913
https://github.com/matrixise
matrixisehttps://github.com/matrixise
Feb 14, 2019https://github.com/python/cpython/pull/10913#issuecomment-463704849
@montanalowhttps://github.com/montanalow
Please reload this pagehttps://github.com/python/cpython/pull/10913
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Mar 29, 2019https://github.com/python/cpython/pull/10913#event-2240466119
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Mar 29, 2019https://github.com/python/cpython/pull/10913#event-2240466166
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
Mar 29, 2019https://github.com/python/cpython/pull/10913#issuecomment-478152063
Please reload this pagehttps://github.com/python/cpython/pull/10913
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
Mar 29, 2019https://github.com/python/cpython/pull/10913#event-2240468184
https://github.com/coleifer
coleiferhttps://github.com/coleifer
May 11, 2019https://github.com/python/cpython/pull/10913#issuecomment-491536760
#13216https://github.com/python/cpython/pull/13216
Please reload this pagehttps://github.com/python/cpython/pull/10913
https://github.com/coleifer
coleiferhttps://github.com/coleifer
May 11, 2019 https://github.com/python/cpython/pull/10913#ref-pullrequest-442047137
bpo-36859: Use sqlite3_stmt_readonly API when possible to determine if statement is DML.K #13216 https://github.com/python/cpython/pull/13216
https://github.com/python/cpython/pull/10913
montanalowhttps://github.com/python/cpython/pull/10913
May 16, 2022 https://github.com/python/cpython/pull/10913#ref-issue-1199002133
SQLite incorrect row count for UPDATE #79579 https://github.com/python/cpython/issues/79579
Jun 6, 2022 https://github.com/python/cpython/pull/10913#ref-pullrequest-1261688329
gh-79579: Update sqlite3.Cursor.rowcount for all data-modifying queries #93532 https://github.com/python/cpython/pull/93532
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10913
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/10913
https://github.com/montanalow
https://github.com/the-knights-who-say-ni
https://github.com/tirkarthi
https://github.com/matrixise
https://github.com/brettcannon
https://github.com/coleifer
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.