René's URL Explorer Experiment


Title: [3.12] gh-63760: Don't declare gethostname() on Solaris (#108817) by vstinner · Pull Request #108824 · python/cpython · GitHub

Open Graph Title: [3.12] gh-63760: Don't declare gethostname() on Solaris (#108817) by vstinner · Pull Request #108824 · python/cpython

X Title: [3.12] gh-63760: Don't declare gethostname() on Solaris (#108817) by vstinner · Pull Request #108824 · python/cpython

Description: Since 2005, Solaris defines gethostname(). socketmodule.c no longer has to define gethostname() for Solaris. Oracle Solaris and OpenSolaris have patches to remove the gethostname() definition in Py...

Open Graph Description: Since 2005, Solaris defines gethostname(). socketmodule.c no longer has to define gethostname() for Solaris. Oracle Solaris and OpenSolaris have patches to remove the gethostname() definition in Py...

X Description: Since 2005, Solaris defines gethostname(). socketmodule.c no longer has to define gethostname() for Solaris. Oracle Solaris and OpenSolaris have patches to remove the gethostname() definition in Py...

Mail addresses
Kulikjak@gmail.com

Opengraph URL: https://github.com/python/cpython/pull/108824

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cdfe2c98-2ad1-eecf-27ed-33217e467163
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92D8:178041:1EFD71C:2A86F4C:696AB31E
html-safe-nonce40381d83c7de3dfa35c5888862982c24927728c76e0c36492d7b9ddabb953caa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkQ4OjE3ODA0MToxRUZENzFDOjJBODZGNEM6Njk2QUIzMUUiLCJ2aXNpdG9yX2lkIjoiODczODkwOTUyODc0OTk0NTYzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd3d4e50deb83beb7cfc0b2e497b7615bb055a96864caa9475bc2658bc549dd6e
hovercard-subject-tagpull_request:1500037859
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/108824/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f17f9544856797d453e13b2fa240478dac79de3860a937e09e895cd42b59e23b/python/cpython/pull/108824
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f17f9544856797d453e13b2fa240478dac79de3860a937e09e895cd42b59e23b/python/cpython/pull/108824
og:image:altSince 2005, Solaris defines gethostname(). socketmodule.c no longer has to define gethostname() for Solaris. Oracle Solaris and OpenSolaris have patches to remove the gethostname() definition in Py...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
None4fa1799b6a53c2d30c950d74230781bef9e7f61138c72c7727e4b83f0743752b
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release41f276818bd204c4a30a0281fb3c576298d9474c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/108824#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108824
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108824
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/108824
Reloadhttps://github.com/python/cpython/pull/108824
Reloadhttps://github.com/python/cpython/pull/108824
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/108824
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/108824
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/108824#issue-comment-box
Yhg1shttps://github.com/Yhg1s
python:3.12https://github.com/python/cpython/tree/3.12
vstinner:socket_solaris_gethostnamehttps://github.com/vstinner/cpython/tree/socket_solaris_gethostname
[3.12] gh-63760: Don't declare gethostname() on Solaris (#108817) https://github.com/python/cpython/pull/108824#top
Yhg1shttps://github.com/Yhg1s
python:3.12https://github.com/python/cpython/tree/3.12
vstinner:socket_solaris_gethostnamehttps://github.com/vstinner/cpython/tree/socket_solaris_gethostname
Conversation 3 https://github.com/python/cpython/pull/108824
Commits 1 https://github.com/python/cpython/pull/108824/commits
Checks 0 https://github.com/python/cpython/pull/108824/checks
Files changed https://github.com/python/cpython/pull/108824/files
Please reload this pagehttps://github.com/python/cpython/pull/108824
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 2, 2023https://github.com/python/cpython/pull/108824#issue-1878788692
Please reload this pagehttps://github.com/python/cpython/pull/108824
https://github.com/oracle/solaris-userland/blob/master/components/python/python37/patches/15-gethostname.patchhttps://github.com/oracle/solaris-userland/blob/master/components/python/python37/patches/15-gethostname.patch
https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/python/python37/patches/15-gethostname.patchhttps://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/python/python37/patches/15-gethostname.patch
https://github.com/omniosorg/omnios-build/blob/master/build/python27/patches/24-gethostname.patchhttps://github.com/omniosorg/omnios-build/blob/master/build/python27/patches/24-gethostname.patch
0e6d582https://github.com/python/cpython/commit/0e6d582b3b73a88e71cae04327b31a1ee203722c
request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined #63760https://github.com/python/cpython/issues/63760
Please reload this pagehttps://github.com/python/cpython/pull/108824
https://github.com/vstinner
https://github.com/kulikjak
pythongh-63760https://github.com/python/cpython/issues/63760
: Don't declare gethostname() on Solaris (https://github.com/python/cpython/pull/108824/commits/a61961cb44de91968a18e2bb2c31a74e609e9b8e
python#108817https://github.com/python/cpython/pull/108817
)https://github.com/python/cpython/pull/108824/commits/a61961cb44de91968a18e2bb2c31a74e609e9b8e
a61961chttps://github.com/python/cpython/pull/108824/commits/a61961cb44de91968a18e2bb2c31a74e609e9b8e
https://github.com/oracle/solaris-userland/blob/master/components/python/python37/patches/15-gethostname.patchhttps://github.com/oracle/solaris-userland/blob/master/components/python/python37/patches/15-gethostname.patch
https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/python/python37/patches/15-gethostname.patchhttps://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/python/python37/patches/15-gethostname.patch
https://github.com/omniosorg/omnios-build/blob/master/build/python27/patches/24-gethostname.patchhttps://github.com/omniosorg/omnios-build/blob/master/build/python27/patches/24-gethostname.patch
0e6d582https://github.com/vstinner/cpython/commit/0e6d582b3b73a88e71cae04327b31a1ee203722c
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Sep 2, 2023https://github.com/python/cpython/pull/108824#event-10264555975
request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined #63760 https://github.com/python/cpython/issues/63760
gh-63760: Don't declare gethostname() on Solaris #108817 https://github.com/python/cpython/pull/108817
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 2, 2023https://github.com/python/cpython/pull/108824#event-10264556274
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 2, 2023https://github.com/python/cpython/pull/108824#issuecomment-1703900802
Please reload this pagehttps://github.com/python/cpython/pull/108824
https://github.com/Yhg1s
Yhg1shttps://github.com/Yhg1s
7269916https://github.com/python/cpython/commit/7269916cd7b89b5e6f20bfe83ebe1038bda56b4b
Sep 2, 2023https://github.com/python/cpython/pull/108824#event-10264891946
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 2, 2023https://github.com/python/cpython/pull/108824#issuecomment-1703948471
@vstinnerhttps://github.com/vstinner
@Yhg1shttps://github.com/Yhg1s
Please reload this pagehttps://github.com/python/cpython/pull/108824
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 2, 2023https://github.com/python/cpython/pull/108824#event-10264892002
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 2, 2023https://github.com/python/cpython/pull/108824#issuecomment-1703948504
GH-108832https://github.com/python/cpython/pull/108832
3.11 branchhttps://github.com/python/cpython/tree/3.11
Please reload this pagehttps://github.com/python/cpython/pull/108824
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Sep 2, 2023https://github.com/python/cpython/pull/108824#event-10264892277
miss-islingtonhttps://github.com/miss-islington
Sep 2, 2023 https://github.com/python/cpython/pull/108824#ref-commit-44fd787
https://github.com/vstinner
https://github.com/kulikjak
https://github.com/miss-islington
[3.12]https://github.com/miss-islington/cpython/commit/44fd7870a2ad3f8360ad54facd496fe77c956719
pythongh-63760https://github.com/python/cpython/issues/63760
: Don't declare gethostname() on Solaris (https://github.com/miss-islington/cpython/commit/44fd7870a2ad3f8360ad54facd496fe77c956719
python…https://github.com/python/cpython/pull/108817
44fd787https://github.com/miss-islington/cpython/commit/44fd7870a2ad3f8360ad54facd496fe77c956719
…GH-108817https://github.com/python/cpython/pull/108817
pythonGH-108824https://github.com/python/cpython/pull/108824
pythongh-63760https://github.com/python/cpython/issues/63760
pythonGH-108817https://github.com/python/cpython/pull/108817
https://github.com/oracle/solaris-userland/blob/master/components/python/python37/patches/15-gethostname.patchhttps://github.com/oracle/solaris-userland/blob/master/components/python/python37/patches/15-gethostname.patch
https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/python/python37/patches/15-gethostname.patchhttps://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/python/python37/patches/15-gethostname.patch
https://github.com/omniosorg/omnios-build/blob/master/build/python27/patches/24-gethostname.patchhttps://github.com/omniosorg/omnios-build/blob/master/build/python27/patches/24-gethostname.patch
7269916https://github.com/miss-islington/cpython/commit/7269916cd7b89b5e6f20bfe83ebe1038bda56b4b
0e6d582https://github.com/miss-islington/cpython/commit/0e6d582b3b73a88e71cae04327b31a1ee203722c
vstinnerhttps://github.com/vstinner
Sep 3, 2023 https://github.com/python/cpython/pull/108824#ref-commit-b30c83e
https://github.com/miss-islington
https://github.com/vstinner
[3.11] [3.12]https://github.com/python/cpython/commit/b30c83eb21e665fac7e5cb240943e6a4a70b3ec7
gh-63760https://github.com/python/cpython/issues/63760
: Don't declare gethostname() on Solaris (https://github.com/python/cpython/commit/b30c83eb21e665fac7e5cb240943e6a4a70b3ec7
GH-10…https://github.com/python/cpython/pull/108817
b30c83ehttps://github.com/python/cpython/commit/b30c83eb21e665fac7e5cb240943e6a4a70b3ec7
…8817https://github.com/python/cpython/pull/108817
GH-108824https://github.com/python/cpython/pull/108824
#108832https://github.com/python/cpython/pull/108832
gh-63760https://github.com/python/cpython/issues/63760
GH-108817https://github.com/python/cpython/pull/108817
GH-108824https://github.com/python/cpython/pull/108824
gh-63760https://github.com/python/cpython/issues/63760
GH-108817https://github.com/python/cpython/pull/108817
https://github.com/oracle/solaris-userland/blob/master/components/python/python37/patches/15-gethostname.patchhttps://github.com/oracle/solaris-userland/blob/master/components/python/python37/patches/15-gethostname.patch
https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/python/python37/patches/15-gethostname.patchhttps://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/python/python37/patches/15-gethostname.patch
https://github.com/omniosorg/omnios-build/blob/master/build/python27/patches/24-gethostname.patchhttps://github.com/omniosorg/omnios-build/blob/master/build/python27/patches/24-gethostname.patch
7269916https://github.com/python/cpython/commit/7269916cd7b89b5e6f20bfe83ebe1038bda56b4b
0e6d582https://github.com/python/cpython/commit/0e6d582b3b73a88e71cae04327b31a1ee203722c
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
September 13, 2023 16:09https://github.com/python/cpython/pull/108824#event-10361705204
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108824
Please reload this pagehttps://github.com/python/cpython/pull/108824
https://github.com/vstinner
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/Yhg1s
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.