René's URL Explorer Experiment


Title: gh-108740: Fix "make regen-all" race condition by vstinner · Pull Request #108741 · python/cpython · GitHub

Open Graph Title: gh-108740: Fix "make regen-all" race condition by vstinner · Pull Request #108741 · python/cpython

X Title: gh-108740: Fix "make regen-all" race condition by vstinner · Pull Request #108741 · python/cpython

Description: Fix a race condition in "make regen-all". The deepfreeze.c source and files generated by Argument Clinic are now generated or updated before generating "global objects". Previously, some identifiers may miss depending on the order in which these files were generated. "make regen-global-objects": Make sure that deepfreeze.c is generated and up to date, and always run "make clinic". "make clinic" no longer runs generate_global_objects.py script anymore. "make regen-deepfreeze" now only updates deepfreeze.c, it doesn't build deepfreeze.o anymore. Issue: gh-108740

Open Graph Description: Fix a race condition in "make regen-all". The deepfreeze.c source and files generated by Argument Clinic are now generated or updated before generating "global objects". Previou...

X Description: Fix a race condition in "make regen-all". The deepfreeze.c source and files generated by Argument Clinic are now generated or updated before generating "global objects&am...

Opengraph URL: https://github.com/python/cpython/pull/108741

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c5850454-447c-61be-a536-9cf2ba94fbc5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id815E:14FC13:1A68A35:231139C:696AF428
html-safe-nonceb9e2e8a94114f44d1318ad9eb1f058f30a5a4e9fe240826d708d71317fc6f8bd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTVFOjE0RkMxMzoxQTY4QTM1OjIzMTEzOUM6Njk2QUY0MjgiLCJ2aXNpdG9yX2lkIjoiNDkwODI3ODg2MDg4MTc4NTg5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2e6d1cae13b3ca45eac75c2b3eeaad54fa9e8bfad7d0837e76bbf7f2f13e1d8c
hovercard-subject-tagpull_request:1497994728
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/108741/files
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:altFix a race condition in "make regen-all". The deepfreeze.c source and files generated by Argument Clinic are now generated or updated before generating "global objects". Previou...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/108741/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108741%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108741%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/108741/files
Reloadhttps://github.com/python/cpython/pull/108741/files
Reloadhttps://github.com/python/cpython/pull/108741/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/108741/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/108741/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:fix_regen_all_race_condhttps://github.com/vstinner/cpython/tree/fix_regen_all_race_cond
Conversation 20 https://github.com/python/cpython/pull/108741
Commits 6 https://github.com/python/cpython/pull/108741/commits
Checks 0 https://github.com/python/cpython/pull/108741/checks
Files changed https://github.com/python/cpython/pull/108741/files
Please reload this pagehttps://github.com/python/cpython/pull/108741/files
gh-108740: Fix "make regen-all" race condition https://github.com/python/cpython/pull/108741/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/108741/files
3afb66f gh-108740: Fix "make regen-all" race condition vstinner Aug 31, 2023 https://github.com/python/cpython/pull/108741/commits/3afb66f665f813bbd59202f917a4f997576b1d7a
6a909dd Update Doc/using/configure.rst vstinner Sep 2, 2023 https://github.com/python/cpython/pull/108741/commits/6a909ddd77c99b40ac588256affefd2baaedbe00
af96ee6 Style erlend-aasland Sep 6, 2023 https://github.com/python/cpython/pull/108741/commits/af96ee6541e9c017e453de9ac99f0479b9498e2d
a760e70 Use DEEPFREEZE_C in target rule as well erlend-aasland Sep 6, 2023 https://github.com/python/cpython/pull/108741/commits/a760e70fefebac28021e75b20d6ca5c698b7ee87
418d72e Revert "Use DEEPFREEZE_C in target rule as well" erlend-aasland Sep 6, 2023 https://github.com/python/cpython/pull/108741/commits/418d72e970774b6676d0fc8691e83297af35b6f9
66e8d70 Use $(DEEPFREEZE_C) vstinner Sep 6, 2023 https://github.com/python/cpython/pull/108741/commits/66e8d7013c39111118ad0e3c8a75202d38e8e8a2
Clear filters https://github.com/python/cpython/pull/108741/files
Please reload this pagehttps://github.com/python/cpython/pull/108741/files
Please reload this pagehttps://github.com/python/cpython/pull/108741/files
configure.rst https://github.com/python/cpython/pull/108741/files#diff-3d679da2b3a01e3744dc65d731bb0a896c07e60f3cfdb19911afab3c146a80ef
Makefile.pre.in https://github.com/python/cpython/pull/108741/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
2023-09-01-01-39-26.gh-issue-108740.JHExAQ.rst https://github.com/python/cpython/pull/108741/files#diff-1ddf99057a8eb35588658c4df76fca1690bb99a9e65261f322622ba44d467cec
freeze_modules.py https://github.com/python/cpython/pull/108741/files#diff-91d43feb1075ce3c911827f9a0118b28508e802fbf91b5a742e5fa478bf3ff96
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L83
Doc/using/configure.rsthttps://github.com/python/cpython/pull/108741/files#diff-3d679da2b3a01e3744dc65d731bb0a896c07e60f3cfdb19911afab3c146a80ef
View file https://github.com/vstinner/cpython/blob/66e8d7013c39111118ad0e3c8a75202d38e8e8a2/Doc/using/configure.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108741/{{ revealButtonHref }}
https://github.com/python/cpython/pull/108741/files#diff-3d679da2b3a01e3744dc65d731bb0a896c07e60f3cfdb19911afab3c146a80ef
https://github.com/python/cpython/pull/108741/files#diff-3d679da2b3a01e3744dc65d731bb0a896c07e60f3cfdb19911afab3c146a80ef
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L84
Makefile.pre.inhttps://github.com/python/cpython/pull/108741/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
View file https://github.com/vstinner/cpython/blob/66e8d7013c39111118ad0e3c8a75202d38e8e8a2/Makefile.pre.in
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108741/{{ revealButtonHref }}
https://github.com/python/cpython/pull/108741/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/108741/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/108741/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/108741/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/108741/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/108741/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/108741/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/108741/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/108741/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/108741/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
https://github.com/python/cpython/pull/108741/files#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767c
Misc/NEWS.d/next/Build/2023-09-01-01-39-26.gh-issue-108740.JHExAQ.rsthttps://github.com/python/cpython/pull/108741/files#diff-1ddf99057a8eb35588658c4df76fca1690bb99a9e65261f322622ba44d467cec
View file https://github.com/vstinner/cpython/blob/66e8d7013c39111118ad0e3c8a75202d38e8e8a2/Misc/NEWS.d/next/Build/2023-09-01-01-39-26.gh-issue-108740.JHExAQ.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108741/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L262
Tools/build/freeze_modules.pyhttps://github.com/python/cpython/pull/108741/files#diff-91d43feb1075ce3c911827f9a0118b28508e802fbf91b5a742e5fa478bf3ff96
View file https://github.com/vstinner/cpython/blob/66e8d7013c39111118ad0e3c8a75202d38e8e8a2/Tools/build/freeze_modules.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108741/{{ revealButtonHref }}
https://github.com/python/cpython/pull/108741/files#diff-91d43feb1075ce3c911827f9a0118b28508e802fbf91b5a742e5fa478bf3ff96
https://github.com/python/cpython/pull/108741/files#diff-91d43feb1075ce3c911827f9a0118b28508e802fbf91b5a742e5fa478bf3ff96
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.