René's URL Explorer Experiment


Title: gh-108696: revert bypassing import cache in test_import helper by carljm · Pull Request #108698 · python/cpython · GitHub

Open Graph Title: gh-108696: revert bypassing import cache in test_import helper by carljm · Pull Request #108698 · python/cpython

X Title: gh-108696: revert bypassing import cache in test_import helper by carljm · Pull Request #108698 · python/cpython

Description: Per suggestion from @FFY00 on #104186, let's revert this change to get the refleak buildbots green again. Verified that with this diff, ./python -m test -R: -v test_import no longer leaks reference...

Open Graph Description: Per suggestion from @FFY00 on #104186, let's revert this change to get the refleak buildbots green again. Verified that with this diff, ./python -m test -R: -v test_import no longer leaks refer...

X Description: Per suggestion from @FFY00 on #104186, let's revert this change to get the refleak buildbots green again. Verified that with this diff, ./python -m test -R: -v test_import no longer leaks r...

Opengraph URL: https://github.com/python/cpython/pull/108698

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:13161751-e9df-9fe7-f6eb-b9687dc34845
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CCE:155BED:26D5B4:365976:696A6F11
html-safe-nonce56c59392d181b7e80d93bc616cfd31c21867c2c92f058aec98a5adf4d3c3bab6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0NFOjE1NUJFRDoyNkQ1QjQ6MzY1OTc2OjY5NkE2RjExIiwidmlzaXRvcl9pZCI6IjUwMjgxMzA3ODY1NjUwNTgzMjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacae4ea72e9e022a41afd259f95a29442a17cbe4717a2998e4ba834d0f9e5ec17f
hovercard-subject-tagpull_request:1496185780
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/108698/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ba7aa1d11fb0512fb2d714c7df6c36d465b60852bbf0a20920aa881c5abee5fa/python/cpython/pull/108698
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ba7aa1d11fb0512fb2d714c7df6c36d465b60852bbf0a20920aa881c5abee5fa/python/cpython/pull/108698
og:image:altPer suggestion from @FFY00 on #104186, let's revert this change to get the refleak buildbots green again. Verified that with this diff, ./python -m test -R: -v test_import no longer leaks refer...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecarljm
hostnamegithub.com
expected-hostnamegithub.com
None6fea32d5b7276b841b7a803796d9715bc6cfb31ed549fdf9de2948ac25d12ba6
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef2d9f6432a5a115ec709295ae70623f33bb80aee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/108698#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108698
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108698
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/108698
Reloadhttps://github.com/python/cpython/pull/108698
Reloadhttps://github.com/python/cpython/pull/108698
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/108698
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/108698
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/108698#issue-comment-box
carljmhttps://github.com/carljm
python:mainhttps://github.com/python/cpython/tree/main
carljm:importleakhttps://github.com/carljm/cpython/tree/importleak
gh-108696: revert bypassing import cache in test_import helper https://github.com/python/cpython/pull/108698#top
carljmhttps://github.com/carljm
python:mainhttps://github.com/python/cpython/tree/main
carljm:importleakhttps://github.com/carljm/cpython/tree/importleak
Conversation 1 https://github.com/python/cpython/pull/108698
Commits 1 https://github.com/python/cpython/pull/108698/commits
Checks 0 https://github.com/python/cpython/pull/108698/checks
Files changed https://github.com/python/cpython/pull/108698/files
Please reload this pagehttps://github.com/python/cpython/pull/108698
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/carljm
carljmhttps://github.com/carljm
Aug 30, 2023https://github.com/python/cpython/pull/108698#issue-1874416667
Please reload this pagehttps://github.com/python/cpython/pull/108698
@FFY00https://github.com/FFY00
#104186https://github.com/python/cpython/pull/104186
test_import leaks references #108696https://github.com/python/cpython/issues/108696
Please reload this pagehttps://github.com/python/cpython/pull/108698
https://github.com/carljm
pythongh-108696https://github.com/python/cpython/issues/108696
: revert bypassing import cache in test_import helperhttps://github.com/python/cpython/pull/108698/commits/d6548de26f33cb275410ecad4e367ffb2c064d0d
d6548dehttps://github.com/python/cpython/pull/108698/commits/d6548de26f33cb275410ecad4e367ffb2c064d0d
https://github.com/carljm
carljmhttps://github.com/carljm
brettcannonhttps://github.com/brettcannon
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
code ownershttps://github.com/python/cpython/blob/f59c66e8c8a6715c585cf2cdf1f99715480b4da1/.github/CODEOWNERS#L71
August 30, 2023 21:48https://github.com/python/cpython/pull/108698#event-10237689035
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 30, 2023 https://github.com/python/cpython/pull/108698#ref-issue-1874339631
test_import leaks references #108696 https://github.com/python/cpython/issues/108696
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 30, 2023https://github.com/python/cpython/pull/108698#event-10237689701
https://github.com/carljm
carljmhttps://github.com/carljm
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Aug 30, 2023https://github.com/python/cpython/pull/108698#event-10237691334
https://github.com/carljm
carljmhttps://github.com/carljm
FFY00https://github.com/FFY00
August 30, 2023 21:49https://github.com/python/cpython/pull/108698#event-10237693024
https://github.com/carljm
carljmhttps://github.com/carljm
Aug 30, 2023 https://github.com/python/cpython/pull/108698#ref-pullrequest-1696866255
GH-103247: bypass the import cache on the _require_loader helper #104186 https://github.com/python/cpython/pull/104186
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
Aug 31, 2023 https://github.com/python/cpython/pull/108698#pullrequestreview-1603660849
View reviewed changes https://github.com/python/cpython/pull/108698/files/d6548de26f33cb275410ecad4e367ffb2c064d0d
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 31, 2023https://github.com/python/cpython/pull/108698#event-10238420204
https://github.com/carljm
carljmhttps://github.com/carljm
157b89ehttps://github.com/python/cpython/commit/157b89e55ed1ec12418a4853a0ba10eabc11ce60
Aug 31, 2023https://github.com/python/cpython/pull/108698#event-10238424306
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Aug 31, 2023https://github.com/python/cpython/pull/108698#event-10238424480
https://github.com/carljm
carljmhttps://github.com/carljm
August 31, 2023 00:15https://github.com/python/cpython/pull/108698#event-10238424680
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 31, 2023https://github.com/python/cpython/pull/108698#issuecomment-1700205283
157b89ehttps://github.com/python/cpython/commit/157b89e55ed1ec12418a4853a0ba10eabc11ce60
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/all/#builders/338/builds/4926https://buildbot.python.org/all/#builders/338/builds/4926
157b89ehttps://github.com/python/cpython/commit/157b89e55ed1ec12418a4853a0ba10eabc11ce60
https://buildbot.python.org/all/#builders/338/builds/4926https://buildbot.python.org/all/#builders/338/builds/4926
Please reload this pagehttps://github.com/python/cpython/pull/108698
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108698
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
https://github.com/python/cpython/pull/108698/files/d6548de26f33cb275410ecad4e367ffb2c064d0d
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/warsaw
warsaw https://github.com/warsaw
https://github.com/FFY00
FFY00 https://github.com/FFY00
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/108698
https://github.com/carljm
https://github.com/bedevere-bot
https://github.com/brettcannon
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.