René's URL Explorer Experiment


Title: [3.10] Fix `inspect.signature` call on mocks (#96335) (gh-96127) by thechrisu · Pull Request #108652 · python/cpython · GitHub

Open Graph Title: [3.10] Fix `inspect.signature` call on mocks (#96335) (gh-96127) by thechrisu · Pull Request #108652 · python/cpython

X Title: [3.10] Fix `inspect.signature` call on mocks (#96335) (gh-96127) by thechrisu · Pull Request #108652 · python/cpython

Description: Backporting this fix to make inspect.signature() work with AsyncMock(). This was previously considered in #101647, but that required more rework. The change looked pretty straightforward, and tests...

Open Graph Description: Backporting this fix to make inspect.signature() work with AsyncMock(). This was previously considered in #101647, but that required more rework. The change looked pretty straightforward, and tests...

X Description: Backporting this fix to make inspect.signature() work with AsyncMock(). This was previously considered in #101647, but that required more rework. The change looked pretty straightforward, and tests...

Opengraph URL: https://github.com/python/cpython/pull/108652

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:19a32ec9-1c36-a9ea-27da-d6896c1188f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE906:8907F:AA244E:F1151F:696A5E82
html-safe-nonce9674acf84f1cd34e8659d921dbc5b46a360fb971b2550f21284399f09dbcc429
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTA2Ojg5MDdGOkFBMjQ0RTpGMTE1MUY6Njk2QTVFODIiLCJ2aXNpdG9yX2lkIjoiNTY2MTM4OTI5NzUyNDY1MDI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7770f763f0692a5be5323305aceb0a6b0058463be4845595fe30e5872a59c69c
hovercard-subject-tagpull_request:1494228393
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/108652/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/422d1c16b445480831cc4676275a6a0b0320146b3e8549f792c9fbd6164c1760/python/cpython/pull/108652
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/422d1c16b445480831cc4676275a6a0b0320146b3e8549f792c9fbd6164c1760/python/cpython/pull/108652
og:image:altBackporting this fix to make inspect.signature() work with AsyncMock(). This was previously considered in #101647, but that required more rework. The change looked pretty straightforward, and tests...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamethechrisu
hostnamegithub.com
expected-hostnamegithub.com
None9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release87cbd411c2982752221b5751d583a515b23bf5fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/108652#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108652
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108652
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/108652
Reloadhttps://github.com/python/cpython/pull/108652
Reloadhttps://github.com/python/cpython/pull/108652
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/108652
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/108652
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/108652#issue-comment-box
thechrisuhttps://github.com/thechrisu
python:3.10https://github.com/python/cpython/tree/3.10
thechrisu:backport-9e7d726-3.10https://github.com/thechrisu/cpython/tree/backport-9e7d726-3.10
[3.10] Fix inspect.signature call on mocks (#96335) (gh-96127) https://github.com/python/cpython/pull/108652#top
thechrisuhttps://github.com/thechrisu
python:3.10https://github.com/python/cpython/tree/3.10
thechrisu:backport-9e7d726-3.10https://github.com/thechrisu/cpython/tree/backport-9e7d726-3.10
Conversation 1 https://github.com/python/cpython/pull/108652
Commits 1 https://github.com/python/cpython/pull/108652/commits
Checks 0 https://github.com/python/cpython/pull/108652/checks
Files changed https://github.com/python/cpython/pull/108652/files
Please reload this pagehttps://github.com/python/cpython/pull/108652
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/thechrisu
thechrisuhttps://github.com/thechrisu
Aug 29, 2023https://github.com/python/cpython/pull/108652#issue-1872188809
Please reload this pagehttps://github.com/python/cpython/pull/108652
#101647https://github.com/python/cpython/pull/101647
https://devguide.python.org/#quick-referencehttps://devguide.python.org/#quick-reference
Calling inspect.signature with an AsyncMock instance raises an exception #96127https://github.com/python/cpython/issues/96127
Please reload this pagehttps://github.com/python/cpython/pull/108652
https://github.com/sobolevn
pythongh-96127https://github.com/python/cpython/issues/96127
: Fixhttps://github.com/python/cpython/pull/108652/commits/ac3aad4213977e94f8f9cc7879d06e7c40a6dae0
inspect.signaturehttps://github.com/python/cpython/pull/108652/commits/ac3aad4213977e94f8f9cc7879d06e7c40a6dae0
call on mocks (https://github.com/python/cpython/pull/108652/commits/ac3aad4213977e94f8f9cc7879d06e7c40a6dae0
python#96335https://github.com/python/cpython/pull/96335
)https://github.com/python/cpython/pull/108652/commits/ac3aad4213977e94f8f9cc7879d06e7c40a6dae0
ac3aad4https://github.com/python/cpython/pull/108652/commits/ac3aad4213977e94f8f9cc7879d06e7c40a6dae0
https://github.com/thechrisu
thechrisuhttps://github.com/thechrisu
cjw296https://github.com/cjw296
code ownerhttps://github.com/python/cpython/blob/fc382d3dd08709a9dc5000a691d3a74f7b4a99ac/.github/CODEOWNERS#L98
August 29, 2023 18:30https://github.com/python/cpython/pull/108652#event-10224529824
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 29, 2023 https://github.com/python/cpython/pull/108652#ref-issue-1344768684
Calling inspect.signature with an AsyncMock instance raises an exception #96127 https://github.com/python/cpython/issues/96127
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 29, 2023https://github.com/python/cpython/pull/108652#event-10224779717
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Aug 29, 2023https://github.com/python/cpython/pull/108652#issuecomment-1697977011
Please reload this pagehttps://github.com/python/cpython/pull/108652
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Aug 29, 2023https://github.com/python/cpython/pull/108652#event-10224799439
https://github.com/thechrisu
thechrisuhttps://github.com/thechrisu
August 29, 2023 19:02https://github.com/python/cpython/pull/108652#event-10224809244
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108652
https://github.com/cjw296
cjw296 https://github.com/cjw296
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/108652
https://github.com/thechrisu
https://github.com/AlexWaygood
https://github.com/bedevere-bot
https://github.com/sobolevn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.