René's URL Explorer Experiment


Title: gh-108494: Argument Clinic: fix support of Limited C API by serhiy-storchaka · Pull Request #108536 · python/cpython · GitHub

Open Graph Title: gh-108494: Argument Clinic: fix support of Limited C API by serhiy-storchaka · Pull Request #108536 · python/cpython

X Title: gh-108494: Argument Clinic: fix support of Limited C API by serhiy-storchaka · Pull Request #108536 · python/cpython

Description: I tried to enable the use of the limited C API in Argument Clinic for all code. With this PR it generates working code, and all tests are passed, except the low-level vectorcall test in test_call and few tests in test_clinic (as expected). _struct.c and winreg.c use converters incompatible with the limited C API. I temporary blacklisted these files. I only tested on Linux, so there may be errors in Windows or macOS specific modules. Issue: gh-108494

Open Graph Description: I tried to enable the use of the limited C API in Argument Clinic for all code. With this PR it generates working code, and all tests are passed, except the low-level vectorcall test in test_call a...

X Description: I tried to enable the use of the limited C API in Argument Clinic for all code. With this PR it generates working code, and all tests are passed, except the low-level vectorcall test in test_call a...

Opengraph URL: https://github.com/python/cpython/pull/108536

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:48c09657-8e3e-1129-32a2-feb20988d8f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD3C8:1B7E6F:22AABC9:2F80977:696ABE38
html-safe-nonce384b3e81309e201cff142a8dd72e9fc07000e8e2377ea23e152f101431175eed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0M4OjFCN0U2RjoyMkFBQkM5OjJGODA5Nzc6Njk2QUJFMzgiLCJ2aXNpdG9yX2lkIjoiMTM5ODI4OTk4MTUxODgyMjk2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdbcc1cd09ed2a4c8a46659b237290a5c2f4a3e640c7480710e132ed97950a8f1
hovercard-subject-tagpull_request:1490926475
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/108536/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altI tried to enable the use of the limited C API in Argument Clinic for all code. With this PR it generates working code, and all tests are passed, except the low-level vectorcall test in test_call a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/108536/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108536%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108536%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/108536/files
Reloadhttps://github.com/python/cpython/pull/108536/files
Reloadhttps://github.com/python/cpython/pull/108536/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/108536/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/108536/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:clinic-limited-capihttps://github.com/serhiy-storchaka/cpython/tree/clinic-limited-capi
Conversation 13 https://github.com/python/cpython/pull/108536
Commits 7 https://github.com/python/cpython/pull/108536/commits
Checks 0 https://github.com/python/cpython/pull/108536/checks
Files changed https://github.com/python/cpython/pull/108536/files
Please reload this pagehttps://github.com/python/cpython/pull/108536/files
gh-108494: Argument Clinic: fix support of Limited C API https://github.com/python/cpython/pull/108536/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/108536/files
1896045 gh-108494: Argument Clinic: fix support of limited C API serhiy-storchaka Aug 27, 2023 https://github.com/python/cpython/pull/108536/commits/1896045217430c3b3c41865f4c460fdf76b003c5
2a535ce Update warnings. serhiy-storchaka Aug 28, 2023 https://github.com/python/cpython/pull/108536/commits/2a535ce054cf9c19c1f2d0e80715c61d9c227883
06b40ab Autodetect unsupported combination of required and optional keyword-o… serhiy-storchaka Aug 28, 2023 https://github.com/python/cpython/pull/108536/commits/06b40ab20db95a7f2e77bae748da60312046d12c
4a77952 Explicitly mark broken converters. serhiy-storchaka Aug 28, 2023 https://github.com/python/cpython/pull/108536/commits/4a7795226f01dae04706c25a7498dc00f51ed279
4274341 Merge branch 'main' into clinic-limited-capi serhiy-storchaka Aug 28, 2023 https://github.com/python/cpython/pull/108536/commits/42743419747d243ef3276011178151cb28895418
19e5ee2 Revert unnecessary changes. serhiy-storchaka Aug 28, 2023 https://github.com/python/cpython/pull/108536/commits/19e5ee268a1d7eeecae037a165a5ae8a0ed5d58c
f20b03c Update Tools/clinic/clinic.py serhiy-storchaka Aug 28, 2023 https://github.com/python/cpython/pull/108536/commits/f20b03c5543952d847d3899e4dea5402198feb45
Clear filters https://github.com/python/cpython/pull/108536/files
Please reload this pagehttps://github.com/python/cpython/pull/108536/files
Please reload this pagehttps://github.com/python/cpython/pull/108536/files
test_call.py https://github.com/python/cpython/pull/108536/files#diff-f27c08f13ff54ee9a69325f9291a3a2510a05b82ff8d813a8ab2e0072af632bb
test_enum.py https://github.com/python/cpython/pull/108536/files#diff-8467f9fbbff81abf26d87a8dbbf0e0c866157971948010e48cc73539251a9e4c
test_pyexpat.py https://github.com/python/cpython/pull/108536/files#diff-bdb65b60742876d0828ee1d7f2c168d36fa02cc202ace32d27c46a7b4a17605d
_localemodule.c https://github.com/python/cpython/pull/108536/files#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0
module.c https://github.com/python/cpython/pull/108536/files#diff-6cfed746161998667a9ea0e65596ab18dc519c5f12476b29759f2fc7de22bd34
_struct.c https://github.com/python/cpython/pull/108536/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
_tracemalloc.c https://github.com/python/cpython/pull/108536/files#diff-e3c46632586859324a8cb7de0a3d6c60fcba118b5a0a262640102530ceca3a2a
_testclinic_limited.c.h https://github.com/python/cpython/pull/108536/files#diff-b259736b5bcab9bc555295d16a89f8f80ee42dd6e0bb39df20b87043c122c690
winreg.c https://github.com/python/cpython/pull/108536/files#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c
clinic.py https://github.com/python/cpython/pull/108536/files#diff-4c6b55ec7d80a3d60f100ce230eb879d9acbe2e558e01d318960e6197d7c47b3
Lib/test/test_call.pyhttps://github.com/python/cpython/pull/108536/files#diff-f27c08f13ff54ee9a69325f9291a3a2510a05b82ff8d813a8ab2e0072af632bb
View file https://github.com/serhiy-storchaka/cpython/blob/f20b03c5543952d847d3899e4dea5402198feb45/Lib/test/test_call.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108536/{{ revealButtonHref }}
https://github.com/python/cpython/pull/108536/files#diff-f27c08f13ff54ee9a69325f9291a3a2510a05b82ff8d813a8ab2e0072af632bb
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 27, 2023https://github.com/python/cpython/pull/108536/files#r1306644037
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/108536/files
https://github.com/python/cpython/pull/108536/files#diff-f27c08f13ff54ee9a69325f9291a3a2510a05b82ff8d813a8ab2e0072af632bb
https://github.com/python/cpython/pull/108536/files#diff-f27c08f13ff54ee9a69325f9291a3a2510a05b82ff8d813a8ab2e0072af632bb
https://github.com/python/cpython/pull/108536/files#diff-f27c08f13ff54ee9a69325f9291a3a2510a05b82ff8d813a8ab2e0072af632bb
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L454
Lib/test/test_enum.pyhttps://github.com/python/cpython/pull/108536/files#diff-8467f9fbbff81abf26d87a8dbbf0e0c866157971948010e48cc73539251a9e4c
View file https://github.com/serhiy-storchaka/cpython/blob/f20b03c5543952d847d3899e4dea5402198feb45/Lib/test/test_enum.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108536/{{ revealButtonHref }}
https://github.com/python/cpython/pull/108536/files#diff-8467f9fbbff81abf26d87a8dbbf0e0c866157971948010e48cc73539251a9e4c
https://github.com/python/cpython/pull/108536/files#diff-8467f9fbbff81abf26d87a8dbbf0e0c866157971948010e48cc73539251a9e4c
Lib/test/test_pyexpat.pyhttps://github.com/python/cpython/pull/108536/files#diff-bdb65b60742876d0828ee1d7f2c168d36fa02cc202ace32d27c46a7b4a17605d
View file https://github.com/serhiy-storchaka/cpython/blob/f20b03c5543952d847d3899e4dea5402198feb45/Lib/test/test_pyexpat.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108536/{{ revealButtonHref }}
https://github.com/python/cpython/pull/108536/files#diff-bdb65b60742876d0828ee1d7f2c168d36fa02cc202ace32d27c46a7b4a17605d
https://github.com/python/cpython/pull/108536/files#diff-bdb65b60742876d0828ee1d7f2c168d36fa02cc202ace32d27c46a7b4a17605d
Modules/_localemodule.chttps://github.com/python/cpython/pull/108536/files#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0
View file https://github.com/serhiy-storchaka/cpython/blob/f20b03c5543952d847d3899e4dea5402198feb45/Modules/_localemodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108536/{{ revealButtonHref }}
https://github.com/python/cpython/pull/108536/files#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0
https://github.com/python/cpython/pull/108536/files#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L580
Modules/_sqlite/module.chttps://github.com/python/cpython/pull/108536/files#diff-6cfed746161998667a9ea0e65596ab18dc519c5f12476b29759f2fc7de22bd34
View file https://github.com/serhiy-storchaka/cpython/blob/f20b03c5543952d847d3899e4dea5402198feb45/Modules/_sqlite/module.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108536/{{ revealButtonHref }}
https://github.com/python/cpython/pull/108536/files#diff-6cfed746161998667a9ea0e65596ab18dc519c5f12476b29759f2fc7de22bd34
Please reload this pagehttps://github.com/python/cpython/pull/108536/files
https://github.com/python/cpython/pull/108536/files#diff-6cfed746161998667a9ea0e65596ab18dc519c5f12476b29759f2fc7de22bd34
Modules/_struct.chttps://github.com/python/cpython/pull/108536/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
View file https://github.com/serhiy-storchaka/cpython/blob/f20b03c5543952d847d3899e4dea5402198feb45/Modules/_struct.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108536/{{ revealButtonHref }}
https://github.com/python/cpython/pull/108536/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
Please reload this pagehttps://github.com/python/cpython/pull/108536/files
https://github.com/python/cpython/pull/108536/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
https://github.com/python/cpython/pull/108536/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
Modules/_tracemalloc.chttps://github.com/python/cpython/pull/108536/files#diff-e3c46632586859324a8cb7de0a3d6c60fcba118b5a0a262640102530ceca3a2a
View file https://github.com/serhiy-storchaka/cpython/blob/f20b03c5543952d847d3899e4dea5402198feb45/Modules/_tracemalloc.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108536/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/108536/files
https://github.com/python/cpython/pull/108536/files#diff-e3c46632586859324a8cb7de0a3d6c60fcba118b5a0a262640102530ceca3a2a
Modules/clinic/_testclinic_limited.c.hhttps://github.com/python/cpython/pull/108536/files#diff-b259736b5bcab9bc555295d16a89f8f80ee42dd6e0bb39df20b87043c122c690
View file https://github.com/serhiy-storchaka/cpython/blob/f20b03c5543952d847d3899e4dea5402198feb45/Modules/clinic/_testclinic_limited.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/108536/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L184
PC/winreg.chttps://github.com/python/cpython/pull/108536/files#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c
View file https://github.com/serhiy-storchaka/cpython/blob/f20b03c5543952d847d3899e4dea5402198feb45/PC/winreg.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108536/{{ revealButtonHref }}
https://github.com/python/cpython/pull/108536/files#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c
https://github.com/python/cpython/pull/108536/files#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c
https://github.com/python/cpython/pull/108536/files#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c
https://github.com/python/cpython/pull/108536/files#diff-ebc17afaffe862b9d14021622fc6b6c230edbb2cad594481648a453cb8436b7c
Please reload this pagehttps://github.com/python/cpython/pull/108536/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.