| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1ce7587a-03b4-2c0c-993d-8db48023141e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A628:196750:9CE89B:D4C163:6969E447 |
| html-safe-nonce | 1c9312d116650fa33503d473b8dae087c0b54320519b3c30b66a3b08c0663e93 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjI4OjE5Njc1MDo5Q0U4OUI6RDRDMTYzOjY5NjlFNDQ3IiwidmlzaXRvcl9pZCI6IjIxNDQ1MDIzNTQwNTQ2MDM4NDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 897d1a192dc4d4a3d0f8efd42db06b269371682d394e67e96211d697f05f6e36 |
| hovercard-subject-tag | pull_request:1488637711 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/108454/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bfd86f50326718ba1ca3bb256f6f9a9fac7df2e10a3eb46cf2548dd31c4e6cd3/python/cpython/pull/108454 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bfd86f50326718ba1ca3bb256f6f9a9fac7df2e10a3eb46cf2548dd31c4e6cd3/python/cpython/pull/108454 |
| og:image:alt | @gvanrossum: This fixes the new pyright complaints you reported in #108112 (comment), and enables the equivalent mypy lint so that this kind of thing is checked in CI in the future.
The maybe_* var... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AlexWaygood |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/108454#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108454 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108454 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/108454 |
| Reload | https://github.com/python/cpython/pull/108454 |
| Reload | https://github.com/python/cpython/pull/108454 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/108454#issue-comment-box |
| AlexWaygood | https://github.com/AlexWaygood |
| python:main | https://github.com/python/cpython/tree/main |
| AlexWaygood:possibly-undefined-cases | https://github.com/AlexWaygood/cpython/tree/possibly-undefined-cases |
|
gh-104504: Cases generator: enable mypy's possibly-undefined error code
| https://github.com/python/cpython/pull/108454#top |
| AlexWaygood | https://github.com/AlexWaygood |
| python:main | https://github.com/python/cpython/tree/main |
| AlexWaygood:possibly-undefined-cases | https://github.com/AlexWaygood/cpython/tree/possibly-undefined-cases |
|
Conversation
14
| https://github.com/python/cpython/pull/108454 |
|
Commits
4
| https://github.com/python/cpython/pull/108454/commits |
|
Checks
0
| https://github.com/python/cpython/pull/108454/checks |
|
Files changed
| https://github.com/python/cpython/pull/108454/files |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Aug 24, 2023 | https://github.com/python/cpython/pull/108454#issue-1865821224 |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| @gvanrossum | https://github.com/gvanrossum |
| #108112 (comment) | https://github.com/python/cpython/pull/108112#discussion_r1303706047 |
| #108112 | https://github.com/python/cpython/pull/108112 |
| Run mypy on cases_generator #104504 | https://github.com/python/cpython/issues/104504 |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
|
| https://github.com/AlexWaygood |
| Cases generator: enable mypy's possibly-undefined error code | https://github.com/python/cpython/pull/108454/commits/bec3fb7037b60c560f9a7d264d0917442e2e717e |
| bec3fb7 | https://github.com/python/cpython/pull/108454/commits/bec3fb7037b60c560f9a7d264d0917442e2e717e |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Aug 24, 2023 | https://github.com/python/cpython/pull/108454#event-10185659849 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| gvanrossum | https://github.com/gvanrossum |
| August 24, 2023 20:15 | https://github.com/python/cpython/pull/108454#event-10185659877 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
Aug 18, 2023
| https://github.com/python/cpython/pull/108454#ref-issue-1709783934 |
|
Run mypy on cases_generator
#104504
| https://github.com/python/cpython/issues/104504 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Aug 24, 2023 | https://github.com/python/cpython/pull/108454#event-10185660710 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Aug 24, 2023
| https://github.com/python/cpython/pull/108454#pullrequestreview-1594413897 |
|
View reviewed changes
| https://github.com/python/cpython/pull/108454/files/bec3fb7037b60c560f9a7d264d0917442e2e717e |
| Tools/cases_generator/generate_cases.py | https://github.com/python/cpython/pull/108454/files/bec3fb7037b60c560f9a7d264d0917442e2e717e#diff-65feee563fa44b472b07751184c6f557699f84b3c2ef79174bfd5d538d748272 |
| gvanrossum | https://github.com/gvanrossum |
| Aug 24, 2023 | https://github.com/python/cpython/pull/108454#discussion_r1304837081 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| AlexWaygood | https://github.com/AlexWaygood |
| Aug 24, 2023 | https://github.com/python/cpython/pull/108454#discussion_r1304840260 |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| AlexWaygood | https://github.com/AlexWaygood |
| Aug 24, 2023 | https://github.com/python/cpython/pull/108454#discussion_r1304845613 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @hauntsaninja | https://github.com/hauntsaninja |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| AlexWaygood | https://github.com/AlexWaygood |
| Aug 24, 2023 | https://github.com/python/cpython/pull/108454#discussion_r1304867985 |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| gvanrossum | https://github.com/gvanrossum |
| Aug 24, 2023 | https://github.com/python/cpython/pull/108454#discussion_r1304879686 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| AlexWaygood | https://github.com/AlexWaygood |
| Aug 24, 2023 | https://github.com/python/cpython/pull/108454#discussion_r1304884724 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| hauntsaninja | https://github.com/hauntsaninja |
| Aug 24, 2023 | https://github.com/python/cpython/pull/108454#discussion_r1304885442 |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| AlexWaygood | https://github.com/AlexWaygood |
| Aug 24, 2023 | https://github.com/python/cpython/pull/108454#discussion_r1304890424 |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| hauntsaninja | https://github.com/hauntsaninja |
| Aug 24, 2023 | https://github.com/python/cpython/pull/108454#discussion_r1304904385 |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| hauntsaninja | https://github.com/hauntsaninja |
| Aug 30, 2023 | https://github.com/python/cpython/pull/108454#discussion_r1309606221 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| python/mypy#15995 | https://github.com/python/mypy/pull/15995 |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
|
| https://github.com/AlexWaygood |
| Better variable name | https://github.com/python/cpython/pull/108454/commits/cda549975b2bf6a552d78be70ed43b463bfa551a |
| cda5499 | https://github.com/python/cpython/pull/108454/commits/cda549975b2bf6a552d78be70ed43b463bfa551a |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Aug 25, 2023
| https://github.com/python/cpython/pull/108454#ref-issue-1866799225 |
|
Two possibly-undefined bugs with match statements
python/mypy#15958
| https://github.com/python/mypy/issues/15958 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Aug 25, 2023 | https://github.com/python/cpython/pull/108454#issuecomment-1693155631 |
| python/mypy#15958 | https://github.com/python/mypy/issues/15958 |
| #108454 (comment) | https://github.com/python/cpython/pull/108454#discussion_r1304867985 |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
|
| https://github.com/AlexWaygood |
| Work around the mypy bugs | https://github.com/python/cpython/pull/108454/commits/163167b8ca68f4715450da986e86e263bc15e13e |
| 163167b | https://github.com/python/cpython/pull/108454/commits/163167b8ca68f4715450da986e86e263bc15e13e |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| gvanrossum | https://github.com/gvanrossum |
| August 25, 2023 10:45 | https://github.com/python/cpython/pull/108454#event-10191682656 |
|
| https://github.com/AlexWaygood |
| Merge branch 'main' into possibly-undefined-cases | https://github.com/python/cpython/pull/108454/commits/d7e36f00ba2e3186a1e044e3f68f0dd0e97bf9d9 |
| d7e36f0 | https://github.com/python/cpython/pull/108454/commits/d7e36f00ba2e3186a1e044e3f68f0dd0e97bf9d9 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Aug 25, 2023
| https://github.com/python/cpython/pull/108454#pullrequestreview-1596159697 |
|
View reviewed changes
| https://github.com/python/cpython/pull/108454/files/d7e36f00ba2e3186a1e044e3f68f0dd0e97bf9d9 |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/cpython/pull/108454#pullrequestreview-1596159697 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Aug 25, 2023 | https://github.com/python/cpython/pull/108454#event-10195264775 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| 5a25daa | https://github.com/python/cpython/commit/5a25daa5124606e3973265c6f6f9757a3c366cdc |
| Aug 25, 2023 | https://github.com/python/cpython/pull/108454#event-10195279233 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Aug 25, 2023 | https://github.com/python/cpython/pull/108454#event-10195279716 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| August 25, 2023 17:08 | https://github.com/python/cpython/pull/108454#event-10195279869 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108454 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/cpython/pull/108454/files/bec3fb7037b60c560f9a7d264d0917442e2e717e |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/python/cpython/pull/108454/files/d7e36f00ba2e3186a1e044e3f68f0dd0e97bf9d9 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/108454 |
|
| https://github.com/AlexWaygood |
|
| https://github.com/gvanrossum |
|
| https://github.com/hauntsaninja |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |