René's URL Explorer Experiment


Title: gh-108111: Flush gzip write buffer before seeking, fixing bad writes by effigies · Pull Request #108341 · python/cpython · GitHub

Open Graph Title: gh-108111: Flush gzip write buffer before seeking, fixing bad writes by effigies · Pull Request #108341 · python/cpython

X Title: gh-108111: Flush gzip write buffer before seeking, fixing bad writes by effigies · Pull Request #108341 · python/cpython

Description: Issue described in detail in #108111. Short story: write(x); seek(len(x)); write(x) results in b''.join([x, bytes(len(x)), x]) being written. This is due to buffered writes not updating the GzipFile.offset() until flushed. It's possible there could be something more efficient, but this seemed like the simplest solution. Issue: gh-108111

Open Graph Description: Issue described in detail in #108111. Short story: write(x); seek(len(x)); write(x) results in b''.join([x, bytes(len(x)), x]) being written. This is due to buffered writes not updating the...

X Description: Issue described in detail in #108111. Short story: write(x); seek(len(x)); write(x) results in b''.join([x, bytes(len(x)), x]) being written. This is due to buffered writes not upda...

Opengraph URL: https://github.com/python/cpython/pull/108341

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4df13b85-76b8-3ad6-45d1-3f928949db87
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD44:B7306:1BE1569:2692707:696AA95E
html-safe-nonce89e063c4fced5fbe4a9663725cbce2016e7aafea80e9c9d76b4b0a74b34a03e7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDQ0OkI3MzA2OjFCRTE1Njk6MjY5MjcwNzo2OTZBQTk1RSIsInZpc2l0b3JfaWQiOiI5MTAyNzc1MDY5MjU4MTk3MzQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7cefce1a09bcd8e1cf504f58c388e96f375eac9a5cea1c13daf9e55a74875d50
hovercard-subject-tagpull_request:1485465064
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/108341/files
twitter:imagehttps://avatars.githubusercontent.com/u/83442?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/83442?s=400&v=4
og:image:altIssue described in detail in #108111. Short story: write(x); seek(len(x)); write(x) results in b''.join([x, bytes(len(x)), x]) being written. This is due to buffered writes not updating the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd9a979046e6382bd084e2bd873bf65f797125ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/108341/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108341%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108341%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/108341/files
Reloadhttps://github.com/python/cpython/pull/108341/files
Reloadhttps://github.com/python/cpython/pull/108341/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/108341/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/108341/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:mainhttps://github.com/python/cpython/tree/main
effigies:fix/gzip-writeseekwritehttps://github.com/effigies/cpython/tree/fix/gzip-writeseekwrite
Conversation 3 https://github.com/python/cpython/pull/108341
Commits 5 https://github.com/python/cpython/pull/108341/commits
Checks 0 https://github.com/python/cpython/pull/108341/checks
Files changed https://github.com/python/cpython/pull/108341/files
Please reload this pagehttps://github.com/python/cpython/pull/108341/files
gh-108111: Flush gzip write buffer before seeking, fixing bad writes https://github.com/python/cpython/pull/108341/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/108341/files
aa32f84 Add test demonstrating GH-108111 effigies Aug 22, 2023 https://github.com/python/cpython/pull/108341/commits/aa32f84095e91d8ffeaf9b3a17ba6e0ef9f80c0b
df0c5bf Flush gzip write buffer before seeking; fixes GH-10811 effigies Aug 22, 2023 https://github.com/python/cpython/pull/108341/commits/df0c5bf6fa5d04ab46ba6f51aba96d58898d3c81
1a1130b Write NEWS blurb effigies Aug 22, 2023 https://github.com/python/cpython/pull/108341/commits/1a1130bf975d0074204620aee22b00689aa95b97
3d39458 Add self to ACKS effigies Aug 22, 2023 https://github.com/python/cpython/pull/108341/commits/3d39458da82c486d790925549fd3efbf70b546f3
c123209 Merge branch 'main' into fix/gzip-writeseekwrite ambv Aug 23, 2023 https://github.com/python/cpython/pull/108341/commits/c12320989ae68d775638496dbfb40e55a71272b2
Clear filters https://github.com/python/cpython/pull/108341/files
Please reload this pagehttps://github.com/python/cpython/pull/108341/files
Please reload this pagehttps://github.com/python/cpython/pull/108341/files
gzip.py https://github.com/python/cpython/pull/108341/files#diff-ad9b54ac8ef847cbb11fb0550f7e8cede55b1d92de15899e0a885a94a124838a
test_gzip.py https://github.com/python/cpython/pull/108341/files#diff-9929cddaa6d51e36fc67f9426bd70f73aa995b01f4ce0a5d9b93c83a3a5c4587
ACKS https://github.com/python/cpython/pull/108341/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
2023-08-22-17-27-12.gh-issue-108111.N7a4u_.rst https://github.com/python/cpython/pull/108341/files#diff-83d60181004a1c8b8d451aa400942b24a700acac30309f73b40ef954ba5471de
Lib/gzip.pyhttps://github.com/python/cpython/pull/108341/files#diff-ad9b54ac8ef847cbb11fb0550f7e8cede55b1d92de15899e0a885a94a124838a
View file https://github.com/effigies/cpython/blob/c12320989ae68d775638496dbfb40e55a71272b2/Lib/gzip.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108341/{{ revealButtonHref }}
https://github.com/python/cpython/pull/108341/files#diff-ad9b54ac8ef847cbb11fb0550f7e8cede55b1d92de15899e0a885a94a124838a
https://github.com/python/cpython/pull/108341/files#diff-ad9b54ac8ef847cbb11fb0550f7e8cede55b1d92de15899e0a885a94a124838a
Lib/test/test_gzip.pyhttps://github.com/python/cpython/pull/108341/files#diff-9929cddaa6d51e36fc67f9426bd70f73aa995b01f4ce0a5d9b93c83a3a5c4587
View file https://github.com/effigies/cpython/blob/c12320989ae68d775638496dbfb40e55a71272b2/Lib/test/test_gzip.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108341/{{ revealButtonHref }}
https://github.com/python/cpython/pull/108341/files#diff-9929cddaa6d51e36fc67f9426bd70f73aa995b01f4ce0a5d9b93c83a3a5c4587
https://github.com/python/cpython/pull/108341/files#diff-9929cddaa6d51e36fc67f9426bd70f73aa995b01f4ce0a5d9b93c83a3a5c4587
Misc/ACKShttps://github.com/python/cpython/pull/108341/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
View file https://github.com/effigies/cpython/blob/c12320989ae68d775638496dbfb40e55a71272b2/Misc/ACKS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108341/{{ revealButtonHref }}
https://github.com/python/cpython/pull/108341/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
https://github.com/python/cpython/pull/108341/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
Misc/NEWS.d/next/Library/2023-08-22-17-27-12.gh-issue-108111.N7a4u_.rsthttps://github.com/python/cpython/pull/108341/files#diff-83d60181004a1c8b8d451aa400942b24a700acac30309f73b40ef954ba5471de
View file https://github.com/effigies/cpython/blob/c12320989ae68d775638496dbfb40e55a71272b2/Misc/NEWS.d/next/Library/2023-08-22-17-27-12.gh-issue-108111.N7a4u_.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/108341/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.