René's URL Explorer Experiment


Title: gh-108111: Flush gzip write buffer before seeking, fixing bad writes by effigies · Pull Request #108341 · python/cpython · GitHub

Open Graph Title: gh-108111: Flush gzip write buffer before seeking, fixing bad writes by effigies · Pull Request #108341 · python/cpython

X Title: gh-108111: Flush gzip write buffer before seeking, fixing bad writes by effigies · Pull Request #108341 · python/cpython

Description: Issue described in detail in #108111. Short story: write(x); seek(len(x)); write(x) results in b''.join([x, bytes(len(x)), x]) being written. This is due to buffered writes not updating the GzipFil...

Open Graph Description: Issue described in detail in #108111. Short story: write(x); seek(len(x)); write(x) results in b''.join([x, bytes(len(x)), x]) being written. This is due to buffered writes not updating the...

X Description: Issue described in detail in #108111. Short story: write(x); seek(len(x)); write(x) results in b''.join([x, bytes(len(x)), x]) being written. This is due to buffered writes not upda...

Opengraph URL: https://github.com/python/cpython/pull/108341

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a3a76fe0-9bb9-f468-5b07-824ef36dfbbd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA51E:2F0D9B:5C247F:81F787:696A254B
html-safe-nonce6a09217dcefd27ebeac7763e92ede7014376068d1933969367f62bcb10c2d7cb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTFFOjJGMEQ5Qjo1QzI0N0Y6ODFGNzg3OjY5NkEyNTRCIiwidmlzaXRvcl9pZCI6Ijc5NjI1NzU1MDY4OTAxNzE3MjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac508d082c122a60ebcd8e11b450c41b896dca4e4b038def8a97330115e4e0bad6
hovercard-subject-tagpull_request:1485465064
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/108341/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6eb0f4787787b4ee91529f7482d01fe8f2ae43e07f46e586c00a7c4681b04fb1/python/cpython/pull/108341
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6eb0f4787787b4ee91529f7482d01fe8f2ae43e07f46e586c00a7c4681b04fb1/python/cpython/pull/108341
og:image:altIssue described in detail in #108111. Short story: write(x); seek(len(x)); write(x) results in b''.join([x, bytes(len(x)), x]) being written. This is due to buffered writes not updating the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeffigies
hostnamegithub.com
expected-hostnamegithub.com
Nonea1022f03e4f0d91ea173e4e5dac892c982e0588c62f1ce56121d755a320a3569
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef472b8e6c7b3fdd5d0354972a3f4c516289bf0be
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/108341#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108341
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108341
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/108341
Reloadhttps://github.com/python/cpython/pull/108341
Reloadhttps://github.com/python/cpython/pull/108341
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/108341
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/108341
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/108341#issue-comment-box
ambvhttps://github.com/ambv
python:mainhttps://github.com/python/cpython/tree/main
effigies:fix/gzip-writeseekwritehttps://github.com/effigies/cpython/tree/fix/gzip-writeseekwrite
gh-108111: Flush gzip write buffer before seeking, fixing bad writes https://github.com/python/cpython/pull/108341#top
ambvhttps://github.com/ambv
python:mainhttps://github.com/python/cpython/tree/main
effigies:fix/gzip-writeseekwritehttps://github.com/effigies/cpython/tree/fix/gzip-writeseekwrite
Conversation 3 https://github.com/python/cpython/pull/108341
Commits 5 https://github.com/python/cpython/pull/108341/commits
Checks 0 https://github.com/python/cpython/pull/108341/checks
Files changed https://github.com/python/cpython/pull/108341/files
Please reload this pagehttps://github.com/python/cpython/pull/108341
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/effigies
effigieshttps://github.com/effigies
Aug 22, 2023https://github.com/python/cpython/pull/108341#issue-1862241630
Please reload this pagehttps://github.com/python/cpython/pull/108341
#108111https://github.com/python/cpython/issues/108111
GzipFile.seek makes invalid write if buffer is not flushed in Python 3.12rc1 #108111https://github.com/python/cpython/issues/108111
Please reload this pagehttps://github.com/python/cpython/pull/108341
effigieshttps://github.com/effigies
August 22, 2023 17:18https://github.com/python/cpython/pull/108341#commits-pushed-aa32f84
https://github.com/effigies
Add test demonstratinghttps://github.com/python/cpython/pull/108341/commits/aa32f84095e91d8ffeaf9b3a17ba6e0ef9f80c0b
pythonGH-108111https://github.com/python/cpython/issues/108111
aa32f84https://github.com/python/cpython/pull/108341/commits/aa32f84095e91d8ffeaf9b3a17ba6e0ef9f80c0b
https://github.com/effigies
Flush gzip write buffer before seeking;https://github.com/python/cpython/pull/108341/commits/df0c5bf6fa5d04ab46ba6f51aba96d58898d3c81
fixeshttps://github.com/python/cpython/pull/108341/commits/df0c5bf6fa5d04ab46ba6f51aba96d58898d3c81
pythonGH-10811https://github.com/python/cpython/pull/10811
df0c5bfhttps://github.com/python/cpython/pull/108341/commits/df0c5bf6fa5d04ab46ba6f51aba96d58898d3c81
https://github.com/effigies
Write NEWS blurbhttps://github.com/python/cpython/pull/108341/commits/1a1130bf975d0074204620aee22b00689aa95b97
1a1130bhttps://github.com/python/cpython/pull/108341/commits/1a1130bf975d0074204620aee22b00689aa95b97
https://github.com/effigies
Add self to ACKShttps://github.com/python/cpython/pull/108341/commits/3d39458da82c486d790925549fd3efbf70b546f3
3d39458https://github.com/python/cpython/pull/108341/commits/3d39458da82c486d790925549fd3efbf70b546f3
https://github.com/ghost
ghosthttps://github.com/ghost
Aug 22, 2023https://github.com/python/cpython/pull/108341#issuecomment-1688964330
Please reload this pagehttps://github.com/python/cpython/pull/108341
https://cpython-clabot.herokuapp.com/signed-contributor-license-agreement?version=96a49432-b8b1-11ec-9bf5-bfe9ad6c72c4
Please reload this pagehttps://github.com/python/cpython/pull/108341
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 22, 2023 https://github.com/python/cpython/pull/108341#ref-issue-1856797852
GzipFile.seek makes invalid write if buffer is not flushed in Python 3.12rc1 #108111 https://github.com/python/cpython/issues/108111
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 22, 2023https://github.com/python/cpython/pull/108341#event-10163376220
https://github.com/ambv
Merge branch 'main' into fix/gzip-writeseekwritehttps://github.com/python/cpython/pull/108341/commits/c12320989ae68d775638496dbfb40e55a71272b2
c123209https://github.com/python/cpython/pull/108341/commits/c12320989ae68d775638496dbfb40e55a71272b2
https://github.com/encukou
encukouhttps://github.com/encukou
August 23, 2023 14:52https://github.com/python/cpython/pull/108341#event-10171233888
https://github.com/encukou
encukouhttps://github.com/encukou
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Aug 23, 2023https://github.com/python/cpython/pull/108341#event-10171349473
https://github.com/encukou
encukouhttps://github.com/encukou
Aug 23, 2023 https://github.com/python/cpython/pull/108341#pullrequestreview-1591833212
View reviewed changes https://github.com/python/cpython/pull/108341/files/c12320989ae68d775638496dbfb40e55a71272b2
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 23, 2023https://github.com/python/cpython/pull/108341#event-10171431341
https://github.com/ambv
ambvhttps://github.com/ambv
2eb60c1https://github.com/python/cpython/commit/2eb60c1934f47671e6b3c9b90b6d9f1912d829a0
Aug 24, 2023https://github.com/python/cpython/pull/108341#event-10178395769
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Aug 24, 2023https://github.com/python/cpython/pull/108341#issuecomment-1691233382
@effigieshttps://github.com/effigies
@ambvhttps://github.com/ambv
Please reload this pagehttps://github.com/python/cpython/pull/108341
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Aug 24, 2023https://github.com/python/cpython/pull/108341#event-10178396261
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 24, 2023https://github.com/python/cpython/pull/108341#issuecomment-1691233656
GH-108402https://github.com/python/cpython/pull/108402
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/108341
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Aug 24, 2023https://github.com/python/cpython/pull/108341#event-10178398325
miss-islingtonhttps://github.com/miss-islington
Aug 24, 2023 https://github.com/python/cpython/pull/108341#ref-commit-807eaac
https://github.com/effigies
https://github.com/ambv
https://github.com/miss-islington
pythongh-108111https://github.com/python/cpython/issues/108111
: Flush gzip write buffer before seeking, fixing bad w…https://github.com/miss-islington/cpython/commit/807eaacbc8f6a62768dec5baad36b52d17993465
807eaachttps://github.com/miss-islington/cpython/commit/807eaacbc8f6a62768dec5baad36b52d17993465
pythonGH-108341https://github.com/python/cpython/pull/108341
2eb60c1https://github.com/miss-islington/cpython/commit/2eb60c1934f47671e6b3c9b90b6d9f1912d829a0
Yhg1shttps://github.com/Yhg1s
Aug 24, 2023 https://github.com/python/cpython/pull/108341#ref-commit-20357ed
https://github.com/miss-islington
https://github.com/effigies
https://github.com/ambv
[3.12]https://github.com/python/cpython/commit/20357ed2a434fc59a9cd33c162594e8f792813b4
gh-108111https://github.com/python/cpython/issues/108111
: Flush gzip write buffer before seeking, fixing bad …https://github.com/python/cpython/commit/20357ed2a434fc59a9cd33c162594e8f792813b4
20357edhttps://github.com/python/cpython/commit/20357ed2a434fc59a9cd33c162594e8f792813b4
GH-108341https://github.com/python/cpython/pull/108341
#108402https://github.com/python/cpython/pull/108402
gh-108111https://github.com/python/cpython/issues/108111
GH-108341https://github.com/python/cpython/pull/108341
2eb60c1https://github.com/python/cpython/commit/2eb60c1934f47671e6b3c9b90b6d9f1912d829a0
https://github.com/effigies
effigieshttps://github.com/effigies
August 24, 2023 16:05https://github.com/python/cpython/pull/108341#event-10183451210
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F108341
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/python/cpython/pull/108341/files/c12320989ae68d775638496dbfb40e55a71272b2
Please reload this pagehttps://github.com/python/cpython/pull/108341
https://github.com/effigies
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/encukou
https://github.com/ambv
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.