René's URL Explorer Experiment


Title: gh-91051: fix segfault when using all 8 type watchers by carljm · Pull Request #107853 · python/cpython · GitHub

Open Graph Title: gh-91051: fix segfault when using all 8 type watchers by carljm · Pull Request #107853 · python/cpython

X Title: gh-91051: fix segfault when using all 8 type watchers by carljm · Pull Request #107853 · python/cpython

Description: The type watcher implementation adds char tp_watched; to the PyTypeObject struct, and then in PyType_Modified it assigns int bits = type->tp_watched; and then treats bits as a bitset, expecting tha...

Open Graph Description: The type watcher implementation adds char tp_watched; to the PyTypeObject struct, and then in PyType_Modified it assigns int bits = type->tp_watched; and then treats bits as a bitset, expecting ...

X Description: The type watcher implementation adds char tp_watched; to the PyTypeObject struct, and then in PyType_Modified it assigns int bits = type->tp_watched; and then treats bits as a bitset, expect...

Opengraph URL: https://github.com/python/cpython/pull/107853

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:eb5abb20-8348-edf8-4926-376fafadbdb4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB776:210DE3:5CE6AF:83D78F:696A4A6B
html-safe-nonceaf56f19728535084ff679c559b5eb010a59127db3a3c1c36bc4812691a1ec355
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzc2OjIxMERFMzo1Q0U2QUY6ODNENzhGOjY5NkE0QTZCIiwidmlzaXRvcl9pZCI6IjM4MTg4ODk4NjU0MzIwMjU3MDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac63261d8b485c181557ea39e751bccc73b9616738d1a8a511332b547051bc1bec
hovercard-subject-tagpull_request:1471122548
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/107853/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e1b8221bda7ecd68ebc611ed6749eec784eef8b92b17f3d5a6755d3212655ae1/python/cpython/pull/107853
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e1b8221bda7ecd68ebc611ed6749eec784eef8b92b17f3d5a6755d3212655ae1/python/cpython/pull/107853
og:image:altThe type watcher implementation adds char tp_watched; to the PyTypeObject struct, and then in PyType_Modified it assigns int bits = type->tp_watched; and then treats bits as a bitset, expecting ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecarljm
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/107853#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F107853
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F107853
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/107853
Reloadhttps://github.com/python/cpython/pull/107853
Reloadhttps://github.com/python/cpython/pull/107853
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/107853
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/107853
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/107853#issue-comment-box
carljmhttps://github.com/carljm
python:mainhttps://github.com/python/cpython/tree/main
carljm:typewatchersignhttps://github.com/carljm/cpython/tree/typewatchersign
gh-91051: fix segfault when using all 8 type watchers https://github.com/python/cpython/pull/107853#top
carljmhttps://github.com/carljm
python:mainhttps://github.com/python/cpython/tree/main
carljm:typewatchersignhttps://github.com/carljm/cpython/tree/typewatchersign
Conversation 6 https://github.com/python/cpython/pull/107853
Commits 2 https://github.com/python/cpython/pull/107853/commits
Checks 0 https://github.com/python/cpython/pull/107853/checks
Files changed https://github.com/python/cpython/pull/107853/files
Please reload this pagehttps://github.com/python/cpython/pull/107853
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/carljm
carljmhttps://github.com/carljm
Aug 11, 2023https://github.com/python/cpython/pull/107853#issue-1846053856
Please reload this pagehttps://github.com/python/cpython/pull/107853
Allow extensions to set a callback to be invoked when a type is modified #91051https://github.com/python/cpython/issues/91051
Please reload this pagehttps://github.com/python/cpython/pull/107853
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 11, 2023 https://github.com/python/cpython/pull/107853#ref-issue-1199076251
Allow extensions to set a callback to be invoked when a type is modified #91051 https://github.com/python/cpython/issues/91051
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 11, 2023https://github.com/python/cpython/pull/107853#event-10065005500
https://github.com/carljm
carljmhttps://github.com/carljm
itamarohttps://github.com/itamaro
markshannonhttps://github.com/markshannon
August 11, 2023 00:39https://github.com/python/cpython/pull/107853#event-10065008857
https://github.com/carljm
carljmhttps://github.com/carljm
Aug 11, 2023https://github.com/python/cpython/pull/107853#issuecomment-1674090836
@Yhg1shttps://github.com/Yhg1s
Please reload this pagehttps://github.com/python/cpython/pull/107853
https://github.com/carljm
carljmhttps://github.com/carljm
release-blocker https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Arelease-blocker
Aug 11, 2023https://github.com/python/cpython/pull/107853#event-10065011450
https://github.com/carljm
pythongh-91051https://github.com/python/cpython/issues/91051
: fix segfault when using all 8 type watchershttps://github.com/python/cpython/pull/107853/commits/e149aed693535d6d3e914ed0e37afc5c96d3d5b5
e149aedhttps://github.com/python/cpython/pull/107853/commits/e149aed693535d6d3e914ed0e37afc5c96d3d5b5
https://github.com/carljm
carljmhttps://github.com/carljm
force-pushedhttps://github.com/python/cpython/compare/7c249fa78fd723d31fdfb5cb603e21e2a6d4cf7c..e149aed693535d6d3e914ed0e37afc5c96d3d5b5
7c249fahttps://github.com/python/cpython/commit/7c249fa78fd723d31fdfb5cb603e21e2a6d4cf7c
e149aedhttps://github.com/python/cpython/commit/e149aed693535d6d3e914ed0e37afc5c96d3d5b5
Compare https://github.com/python/cpython/compare/7c249fa78fd723d31fdfb5cb603e21e2a6d4cf7c..e149aed693535d6d3e914ed0e37afc5c96d3d5b5
August 11, 2023 00:47https://github.com/python/cpython/pull/107853#event-10065032863
https://github.com/itamaro
itamarohttps://github.com/itamaro
Aug 11, 2023 https://github.com/python/cpython/pull/107853#pullrequestreview-1572907432
View reviewed changes https://github.com/python/cpython/pull/107853/files/e149aed693535d6d3e914ed0e37afc5c96d3d5b5
itamarohttps://github.com/itamaro
https://github.com/python/cpython/pull/107853#pullrequestreview-1572907432
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/107853
Lib/test/test_capi/test_watchers.pyhttps://github.com/python/cpython/pull/107853/files/e149aed693535d6d3e914ed0e37afc5c96d3d5b5#diff-f13cecf74c62d3b381dfd239e6e1c1c18e83e809b9c3dcb20237d1a8d27c439c
Please reload this pagehttps://github.com/python/cpython/pull/107853
https://github.com/ambv
ambvhttps://github.com/ambv
Aug 11, 2023https://github.com/python/cpython/pull/107853#issuecomment-1674880034
Please reload this pagehttps://github.com/python/cpython/pull/107853
https://github.com/ambv
ambvhttps://github.com/ambv
Aug 11, 2023https://github.com/python/cpython/pull/107853#event-10070356694
https://github.com/ambv
ambvhttps://github.com/ambv
Aug 11, 2023https://github.com/python/cpython/pull/107853#event-10070357236
https://github.com/carljm
add commenthttps://github.com/python/cpython/pull/107853/commits/8b92d50263baf927291deee02618257365473ef9
8b92d50https://github.com/python/cpython/pull/107853/commits/8b92d50263baf927291deee02618257365473ef9
https://github.com/carljm
carljmhttps://github.com/carljm
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Aug 11, 2023https://github.com/python/cpython/pull/107853#event-10070675614
https://github.com/carljm
carljmhttps://github.com/carljm
66e4eddhttps://github.com/python/cpython/commit/66e4edd7346b1cd65ddff6da890a0d725e325116
Aug 11, 2023https://github.com/python/cpython/pull/107853#event-10072837249
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Aug 11, 2023https://github.com/python/cpython/pull/107853#issuecomment-1675214596
@carljmhttps://github.com/carljm
Please reload this pagehttps://github.com/python/cpython/pull/107853
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 11, 2023https://github.com/python/cpython/pull/107853#event-10072837688
https://github.com/carljm
carljmhttps://github.com/carljm
August 11, 2023 18:42https://github.com/python/cpython/pull/107853#event-10072838361
miss-islingtonhttps://github.com/miss-islington
Aug 11, 2023 https://github.com/python/cpython/pull/107853#ref-commit-4f05fc0
https://github.com/carljm
https://github.com/miss-islington
pythongh-91051https://github.com/python/cpython/issues/91051
: fix segfault when using all 8 type watchers (https://github.com/miss-islington/cpython/commit/4f05fc0f3964e168da21da8a117a3da2f010d7b0
pythonGH…https://github.com/python/cpython/pull/107853
4f05fc0https://github.com/miss-islington/cpython/commit/4f05fc0f3964e168da21da8a117a3da2f010d7b0
…-107853https://github.com/python/cpython/pull/107853
66e4eddhttps://github.com/miss-islington/cpython/commit/66e4edd7346b1cd65ddff6da890a0d725e325116
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 11, 2023https://github.com/python/cpython/pull/107853#issuecomment-1675214746
GH-107876https://github.com/python/cpython/pull/107876
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/107853
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Aug 11, 2023https://github.com/python/cpython/pull/107853#event-10072839160
Yhg1shttps://github.com/Yhg1s
Aug 16, 2023 https://github.com/python/cpython/pull/107853#ref-commit-00bfed7
https://github.com/miss-islington
https://github.com/carljm
[3.12]https://github.com/python/cpython/commit/00bfed7cba3f2d66a1534f9f088ddf68abbf0d3f
gh-91051https://github.com/python/cpython/issues/91051
: fix segfault when using all 8 type watchers (https://github.com/python/cpython/commit/00bfed7cba3f2d66a1534f9f088ddf68abbf0d3f
GH-107853https://github.com/python/cpython/pull/107853
https://github.com/python/cpython/commit/00bfed7cba3f2d66a1534f9f088ddf68abbf0d3f
00bfed7https://github.com/python/cpython/commit/00bfed7cba3f2d66a1534f9f088ddf68abbf0d3f
#107876https://github.com/python/cpython/pull/107876
gh-91051https://github.com/python/cpython/issues/91051
GH-107853https://github.com/python/cpython/pull/107853
66e4eddhttps://github.com/python/cpython/commit/66e4edd7346b1cd65ddff6da890a0d725e325116
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F107853
https://github.com/itamaro
itamaro https://github.com/itamaro
https://github.com/python/cpython/pull/107853/files/e149aed693535d6d3e914ed0e37afc5c96d3d5b5
https://github.com/markshannon
markshannon https://github.com/markshannon
release-blocker https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Arelease-blocker
Release and Deferred blockers 🚫 https://github.com/orgs/python/projects/2
Please reload this pagehttps://github.com/python/cpython/pull/107853
https://github.com/carljm
https://github.com/ambv
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/itamaro
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.