René's URL Explorer Experiment


Title: bpo-30681: Support invalid date format or value in email Date header by timb07 · Pull Request #10783 · python/cpython · GitHub

Open Graph Title: bpo-30681: Support invalid date format or value in email Date header by timb07 · Pull Request #10783 · python/cpython

X Title: bpo-30681: Support invalid date format or value in email Date header by timb07 · Pull Request #10783 · python/cpython

Description: In email.utils.parsedate_to_datetime(), a failure to parse the date, or invalid date components (such as hour outside 0..23) raises an exception. Document this behaviour, and add tests to test_email/test_utils.py to confirm this behaviour. In email.headerregistry.DateHeader.parse(), check when parsedate_to_datetime() raises an exception and add a new defect InvalidDateDefect; preserve the invalid value as the string value of the header, but set the datetime attribute to None. Add tests to test_email/test_headerregistry.py to confirm this behaviour; also added test to test_email/test_inversion.py to confirm emails with such defective date headers round trip successfully. This pull request incorporates feedback gratefully received from @bitdancer, @brettcannon, @Mariatta and @warsaw, and replaces the earlier PR #2254. https://bugs.python.org/issue30681

Open Graph Description: In email.utils.parsedate_to_datetime(), a failure to parse the date, or invalid date components (such as hour outside 0..23) raises an exception. Document this behaviour, and add tests to test_emai...

X Description: In email.utils.parsedate_to_datetime(), a failure to parse the date, or invalid date components (such as hour outside 0..23) raises an exception. Document this behaviour, and add tests to test_emai...

Opengraph URL: https://github.com/python/cpython/pull/10783

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e8bdb238-b831-7f1c-f88b-c0a17c9fe31d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC0A8:37ADE8:2478ACE:302817D:696B1A29
html-safe-nonce7bf719df1f8d8c13e6239195363d6779ca9154c65f76eabdb3a27ee6d56d3941
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEE4OjM3QURFODoyNDc4QUNFOjMwMjgxN0Q6Njk2QjFBMjkiLCJ2aXNpdG9yX2lkIjoiMTE4NTM3Njk1NTAyODY3NTExMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf81c61c47e9f69be24701a5ce9ed8e5811f34ccc52406c17478f385bb313737c
hovercard-subject-tagpull_request:234470014
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/10783/files
twitter:imagehttps://avatars.githubusercontent.com/u/2024221?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2024221?s=400&v=4
og:image:altIn email.utils.parsedate_to_datetime(), a failure to parse the date, or invalid date components (such as hour outside 0..23) raises an exception. Document this behaviour, and add tests to test_emai...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/10783/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10783%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10783%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/10783/files
Reloadhttps://github.com/python/cpython/pull/10783/files
Reloadhttps://github.com/python/cpython/pull/10783/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/10783/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/10783/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
timb07https://github.com/timb07
python:masterhttps://github.com/python/cpython/tree/master
timb07:fix-issue-30681chttps://github.com/timb07/cpython/tree/fix-issue-30681c
Conversation 7 https://github.com/python/cpython/pull/10783
Commits 4 https://github.com/python/cpython/pull/10783/commits
Checks 0 https://github.com/python/cpython/pull/10783/checks
Files changed https://github.com/python/cpython/pull/10783/files
Please reload this pagehttps://github.com/python/cpython/pull/10783/files
bpo-30681: Support invalid date format or value in email Date header https://github.com/python/cpython/pull/10783/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/10783/files
db7496a bpo-30681: Handle invalid date in Date header timb07 Nov 29, 2018 https://github.com/python/cpython/pull/10783/commits/db7496af8af25632590e653b5e0358c098736347
0f5c299 bpo-30681: Add InvalidDateDefect timb07 Nov 29, 2018 https://github.com/python/cpython/pull/10783/commits/0f5c299c148f99c5ef7e3d8b17d0ba91b67a105c
d6087ac bpo-30681: Document failure modes of parsedate_to_datetime and add tests timb07 Nov 28, 2018 https://github.com/python/cpython/pull/10783/commits/d6087ac8a4dd7735bbe4281ecc8dee7d321bea3f
1cef999 bpo-30681: Add Misc/NEWS.d entry timb07 Nov 29, 2018 https://github.com/python/cpython/pull/10783/commits/1cef999357b7acaa6b6a190a96be1af86f4cc9a0
Clear filters https://github.com/python/cpython/pull/10783/files
Please reload this pagehttps://github.com/python/cpython/pull/10783/files
Please reload this pagehttps://github.com/python/cpython/pull/10783/files
email.utils.rst https://github.com/python/cpython/pull/10783/files#diff-15bcbdeeb9e76ef919818d32e64f86beef64e8bfb716d2461cd1ca9f7bdb8c19
errors.py https://github.com/python/cpython/pull/10783/files#diff-6b53981eabbf3b2dac54ddb7efc6c1097124bd8148e2264cc1ac30851b45518e
headerregistry.py https://github.com/python/cpython/pull/10783/files#diff-f85d622b1a28a4b95e7c002fa4d122fa17432857826708d2febd0033a2848d9c
test_headerregistry.py https://github.com/python/cpython/pull/10783/files#diff-dc8bbb38fe110368deddc8c037f2898646059fe5b3299da68159ba5ef4721c2b
test_inversion.py https://github.com/python/cpython/pull/10783/files#diff-500e83ac40e0ce66e4ae0053f90b196815733930e893420ecde94b049d972596
test_utils.py https://github.com/python/cpython/pull/10783/files#diff-888fa6f6fe209ed51b9101ba2170e2242ed017d32b63c3ff28c26bc7191ceecd
2018-11-29-11-14-18.bpo-30681.04zEWG.rst https://github.com/python/cpython/pull/10783/files#diff-3a3e71479991bd58ae1962c3f10a04c82bf7ff7a79cba0a01bc35a4eef4a0e22
Doc/library/email.utils.rsthttps://github.com/python/cpython/pull/10783/files#diff-15bcbdeeb9e76ef919818d32e64f86beef64e8bfb716d2461cd1ca9f7bdb8c19
View file https://github.com/timb07/cpython/blob/1cef999357b7acaa6b6a190a96be1af86f4cc9a0/Doc/library/email.utils.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10783/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10783/files#diff-15bcbdeeb9e76ef919818d32e64f86beef64e8bfb716d2461cd1ca9f7bdb8c19
https://github.com/python/cpython/pull/10783/files#diff-15bcbdeeb9e76ef919818d32e64f86beef64e8bfb716d2461cd1ca9f7bdb8c19
Lib/email/errors.pyhttps://github.com/python/cpython/pull/10783/files#diff-6b53981eabbf3b2dac54ddb7efc6c1097124bd8148e2264cc1ac30851b45518e
View file https://github.com/timb07/cpython/blob/1cef999357b7acaa6b6a190a96be1af86f4cc9a0/Lib/email/errors.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10783/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10783/files#diff-6b53981eabbf3b2dac54ddb7efc6c1097124bd8148e2264cc1ac30851b45518e
maxkinghttps://github.com/maxking
May 27, 2019https://github.com/python/cpython/pull/10783/files#r287895007
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/10783/files
Lib/email/headerregistry.pyhttps://github.com/python/cpython/pull/10783/files#diff-f85d622b1a28a4b95e7c002fa4d122fa17432857826708d2febd0033a2848d9c
View file https://github.com/timb07/cpython/blob/1cef999357b7acaa6b6a190a96be1af86f4cc9a0/Lib/email/headerregistry.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10783/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10783/files#diff-f85d622b1a28a4b95e7c002fa4d122fa17432857826708d2febd0033a2848d9c
https://github.com/python/cpython/pull/10783/files#diff-f85d622b1a28a4b95e7c002fa4d122fa17432857826708d2febd0033a2848d9c
Lib/test/test_email/test_headerregistry.pyhttps://github.com/python/cpython/pull/10783/files#diff-dc8bbb38fe110368deddc8c037f2898646059fe5b3299da68159ba5ef4721c2b
View file https://github.com/timb07/cpython/blob/1cef999357b7acaa6b6a190a96be1af86f4cc9a0/Lib/test/test_email/test_headerregistry.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10783/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10783/files#diff-dc8bbb38fe110368deddc8c037f2898646059fe5b3299da68159ba5ef4721c2b
https://github.com/python/cpython/pull/10783/files#diff-dc8bbb38fe110368deddc8c037f2898646059fe5b3299da68159ba5ef4721c2b
Lib/test/test_email/test_inversion.pyhttps://github.com/python/cpython/pull/10783/files#diff-500e83ac40e0ce66e4ae0053f90b196815733930e893420ecde94b049d972596
View file https://github.com/timb07/cpython/blob/1cef999357b7acaa6b6a190a96be1af86f4cc9a0/Lib/test/test_email/test_inversion.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10783/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10783/files#diff-500e83ac40e0ce66e4ae0053f90b196815733930e893420ecde94b049d972596
https://github.com/python/cpython/pull/10783/files#diff-500e83ac40e0ce66e4ae0053f90b196815733930e893420ecde94b049d972596
Lib/test/test_email/test_utils.pyhttps://github.com/python/cpython/pull/10783/files#diff-888fa6f6fe209ed51b9101ba2170e2242ed017d32b63c3ff28c26bc7191ceecd
View file https://github.com/timb07/cpython/blob/1cef999357b7acaa6b6a190a96be1af86f4cc9a0/Lib/test/test_email/test_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10783/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10783/files#diff-888fa6f6fe209ed51b9101ba2170e2242ed017d32b63c3ff28c26bc7191ceecd
pgansslehttps://github.com/pganssle
Jun 11, 2019https://github.com/python/cpython/pull/10783/files#r292480778
Please reload this pagehttps://github.com/python/cpython/pull/10783/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/10783/files
https://github.com/python/cpython/pull/10783/files#diff-888fa6f6fe209ed51b9101ba2170e2242ed017d32b63c3ff28c26bc7191ceecd
Misc/NEWS.d/next/Library/2018-11-29-11-14-18.bpo-30681.04zEWG.rsthttps://github.com/python/cpython/pull/10783/files#diff-3a3e71479991bd58ae1962c3f10a04c82bf7ff7a79cba0a01bc35a4eef4a0e22
View file https://github.com/timb07/cpython/blob/1cef999357b7acaa6b6a190a96be1af86f4cc9a0/Misc/NEWS.d/next/Library/2018-11-29-11-14-18.bpo-30681.04zEWG.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10783/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.