Title: [3.7] bpo-34022: Stop forcing of hash-based invalidation with SOURCE_DATE_EPOCH (GH-9607) by miss-islington · Pull Request #10775 · python/cpython · GitHub
Open Graph Title: [3.7] bpo-34022: Stop forcing of hash-based invalidation with SOURCE_DATE_EPOCH (GH-9607) by miss-islington · Pull Request #10775 · python/cpython
X Title: [3.7] bpo-34022: Stop forcing of hash-based invalidation with SOURCE_DATE_EPOCH (GH-9607) by miss-islington · Pull Request #10775 · python/cpython
Description: Unconditional forcing of CHECKED_HASH invalidation was introduced in 3.7.0 in bpo-29708. The change is bad, as it unconditionally overrides invalidation_mode, even if it was passed as an explicit argument to py_compile.compile() or compileall. An environment variable should never override an explicit argument to a library function. That change leads to multiple test failures if the SOURCE_DATE_EPOCH environment variable is set. This changes py_compile.compile() to only look at SOURCE_DATE_EPOCH if no explicit invalidation_mode was specified. I also made various relevant tests run with explicit control over the value of SOURCE_DATE_EPOCH. While looking at this, I noticed that zipimport does not work with hash-based .pycs at all, though I left the fixes for subsequent commits. (cherry picked from commit a6b3ec5) Co-authored-by: Elvis Pranskevichus elvis@magic.io https://bugs.python.org/issue34022
Open Graph Description: Unconditional forcing of CHECKED_HASH invalidation was introduced in 3.7.0 in bpo-29708. The change is bad, as it unconditionally overrides invalidation_mode, even if it was passed as an explicit ...
X Description: Unconditional forcing of CHECKED_HASH invalidation was introduced in 3.7.0 in bpo-29708. The change is bad, as it unconditionally overrides invalidation_mode, even if it was passed as an explicit ...
Opengraph URL: https://github.com/python/cpython/pull/10775
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:dccd8c26-1df8-b0bf-bb17-d4c59ef6c384 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BB86:275F42:27BD2A1:35BE3D7:696ADE83 |
| html-safe-nonce | 08563701cda9b670fdb309f5a4510c875e62b1d009fe269b1b6b57100c6ebc40 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjg2OjI3NUY0MjoyN0JEMkExOjM1QkUzRDc6Njk2QURFODMiLCJ2aXNpdG9yX2lkIjoiMTY5NDU3MjM2NDc4ODU4ODE2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f9bd3bef7ab5b8ef59d5050f6f3aa2a3739cf98b10c2603ead54aab9acc4f65b |
| hovercard-subject-tag | pull_request:234360154 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/10775/files |
| twitter:image | https://avatars.githubusercontent.com/u/31488909?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/31488909?s=400&v=4 |
| og:image:alt | Unconditional forcing of CHECKED_HASH invalidation was introduced in 3.7.0 in bpo-29708. The change is bad, as it unconditionally overrides invalidation_mode, even if it was passed as an explicit ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 524a93f2c1f36522a3b4be4c110467ee4172245d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width