Title: [3.7] bpo-34022: Stop forcing of hash-based invalidation with SOURCE_DATE_EPOCH (GH-9607) by miss-islington · Pull Request #10775 · python/cpython · GitHub
Open Graph Title: [3.7] bpo-34022: Stop forcing of hash-based invalidation with SOURCE_DATE_EPOCH (GH-9607) by miss-islington · Pull Request #10775 · python/cpython
X Title: [3.7] bpo-34022: Stop forcing of hash-based invalidation with SOURCE_DATE_EPOCH (GH-9607) by miss-islington · Pull Request #10775 · python/cpython
Description: Unconditional forcing of CHECKED_HASH invalidation was introduced in 3.7.0 in bpo-29708. The change is bad, as it unconditionally overrides invalidation_mode, even if it was passed as an explicit argument to py_compile.compile() or compileall. An environment variable should never override an explicit argument to a library function. That change leads to multiple test failures if the SOURCE_DATE_EPOCH environment variable is set. This changes py_compile.compile() to only look at SOURCE_DATE_EPOCH if no explicit invalidation_mode was specified. I also made various relevant tests run with explicit control over the value of SOURCE_DATE_EPOCH. While looking at this, I noticed that zipimport does not work with hash-based .pycs at all, though I left the fixes for subsequent commits. (cherry picked from commit a6b3ec5) Co-authored-by: Elvis Pranskevichus elvis@magic.io https://bugs.python.org/issue34022
Open Graph Description: Unconditional forcing of CHECKED_HASH invalidation was introduced in 3.7.0 in bpo-29708. The change is bad, as it unconditionally overrides invalidation_mode, even if it was passed as an explicit ...
X Description: Unconditional forcing of CHECKED_HASH invalidation was introduced in 3.7.0 in bpo-29708. The change is bad, as it unconditionally overrides invalidation_mode, even if it was passed as an explicit ...
Opengraph URL: https://github.com/python/cpython/pull/10775
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:cc123fc0-e5af-6814-0e12-e0706ef47598 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 9334:24CD64:2472369:302DB2A:696B1A3F |
| html-safe-nonce | 84e199a47f4747e4617e99925c9d7233fe5848ade15fe50542da2ab8546373c5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzM0OjI0Q0Q2NDoyNDcyMzY5OjMwMkRCMkE6Njk2QjFBM0YiLCJ2aXNpdG9yX2lkIjoiNjkwMjE1MjI2MzU0Mzc1MjMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | cad9d5fcbd5d656543aa5ab0e97617de7f6df18e6d2751c8c6046d004fa58f33 |
| hovercard-subject-tag | pull_request:234360154 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/10775/checks |
| twitter:image | https://avatars.githubusercontent.com/u/31488909?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/31488909?s=400&v=4 |
| og:image:alt | Unconditional forcing of CHECKED_HASH invalidation was introduced in 3.7.0 in bpo-29708. The change is bad, as it unconditionally overrides invalidation_mode, even if it was passed as an explicit ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width