René's URL Explorer Experiment

Title: gh-104683: Argument clinic: remove some unnecessary uses of `self.next()` in the DSLParser by AlexWaygood · Pull Request #107635 · python/cpython · GitHub

Open Graph Title: gh-104683: Argument clinic: remove some unnecessary uses of `self.next()` in the DSLParser by AlexWaygood · Pull Request #107635 · python/cpython

X Title: gh-104683: Argument clinic: remove some unnecessary uses of `self.next()` in the DSLParser by AlexWaygood · Pull Request #107635 · python/cpython

Description: Many state_foo methods on the DSLParser class in clinic.py are called only indirectly via the next() method: cpython/Tools/clinic/clinic.py Lines 4645 to 4652 in 407d7fd def next( self, state: StateKeeper, line: str | None = None ) -> None: self.state = state if line is not None: self.state(line) The reason for this is that the DSLParser parses argument-clinic input a line at a time; but state often persists across lines. (Example: a docstring can span multiple lines; by saving the "state" at the end of one line, the DSLParser is able to resume parsing with the same state when it begins parsing the next line, and therefore knows that it's in the middle of a docstring.) However, there are two state_foo methods on the DSLParser class that are arguably badly named, and shouldn't be called via self.next(), even though they both currently are: state_modulename_name state_parameter_docstring_start Both of these are examples of states that are impossible to span multiple lines. A modulename declaration cannot span multiple lines; nor can the start of a parameter docstring. As such, calling these methods via self.next() is needless indirection, and can be removed. It is provable that both of these states cannot span multiple lines, due to the fact that neither state_modulename_name nor state_parameter_docstring_start ever exit early before setting self.state to something new (by calling self.next). Issue: gh-104683

Open Graph Description: Many state_foo methods on the DSLParser class in clinic.py are called only indirectly via the next() method: cpython/Tools/clinic/clinic.py Lines 4645 to 4652 ...

X Description: Many state_foo methods on the DSLParser class in clinic.py are called only indirectly via the next() method: cpython/Tools/clinic/clinic.py Lines 4645 to 4652 ...

Opengraph URL: https://github.com/python/cpython/pull/107635

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width