René's URL Explorer Experiment


Title: gh-106727: Add `__module__` check for `inspect.getsource(cls)` by gaogaotiantian · Pull Request #106968 · python/cpython · GitHub

Open Graph Title: gh-106727: Add `__module__` check for `inspect.getsource(cls)` by gaogaotiantian · Pull Request #106968 · python/cpython

X Title: gh-106727: Add `__module__` check for `inspect.getsource(cls)` by gaogaotiantian · Pull Request #106968 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: In method heuristics, make sure the method we check against comes from the same file as the class. Fixed the issue from #106815 Issue: inspect.getsource (findsource) not working as expected when ...

X Description: In method heuristics, make sure the method we check against comes from the same file as the class. Fixed the issue from #106815 Issue: inspect.getsource (findsource) not working as expected when ...

Opengraph URL: https://github.com/python/cpython/pull/106968

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8b29c581-6f80-f684-d0ae-9198289efdc7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB59C:9EFA3:4229E8:587E06:6A51932A
html-safe-nonce27d5549b95bf6176362c6b7a91a4aeb56ae8ab44392a680fc8600ad9028c296b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTlDOjlFRkEzOjQyMjlFODo1ODdFMDY6NkE1MTkzMkEiLCJ2aXNpdG9yX2lkIjoiMzIzMTcwNTI1Mjk4OTIyMjgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4c58dfe3e4983c73e2d71238104b1ef9bd4dbc9760494548b73f63047a27f4d8
hovercard-subject-tagpull_request:1444956076
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/106968/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3b419fb0105e7944e227c15c46dbe57653f5fceabbd84148e006015d8d91c574/python/cpython/pull/106968
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3b419fb0105e7944e227c15c46dbe57653f5fceabbd84148e006015d8d91c574/python/cpython/pull/106968
og:image:altIn method heuristics, make sure the method we check against comes from the same file as the class. Fixed the issue from #106815 Issue: inspect.getsource (findsource) not working as expected when ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegaogaotiantian
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/106968#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F106968
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F106968
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/106968
Reloadhttps://github.com/python/cpython/pull/106968
Reloadhttps://github.com/python/cpython/pull/106968
Please reload this pagehttps://github.com/python/cpython/pull/106968
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/106968
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
carljmhttps://github.com/carljm
python:mainhttps://github.com/python/cpython/tree/main
gaogaotiantian:module-check-for-inspecthttps://github.com/gaogaotiantian/cpython/tree/module-check-for-inspect
Conversationhttps://github.com/python/cpython/pull/106968
Commits3 (3)https://github.com/python/cpython/pull/106968/commits
Checkshttps://github.com/python/cpython/pull/106968/checks
Files changedhttps://github.com/python/cpython/pull/106968/files
gh-106727: Add __module__ check for inspect.getsource(cls)https://github.com/python/cpython/pull/106968#top
carljmhttps://github.com/carljm
python:mainhttps://github.com/python/cpython/tree/main
gaogaotiantian:module-check-for-inspecthttps://github.com/gaogaotiantian/cpython/tree/module-check-for-inspect
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
Jul 21, 2023https://github.com/python/cpython/pull/106968#issue-1816330595
Please reload this pagehttps://github.com/python/cpython/pull/106968
#106815https://github.com/python/cpython/pull/106815
inspect.getsource (findsource) not working as expected when duplicate class is used #106727https://github.com/python/cpython/issues/106727
Please reload this pagehttps://github.com/python/cpython/pull/106968
https://github.com/gaogaotiantian
Add __module__ check for inspect.getsourcehttps://github.com/python/cpython/pull/106968/commits/7ff082f25ddd3fb4b7b2eca5131a5267042e69cb
7ff082fhttps://github.com/python/cpython/pull/106968/commits/7ff082f25ddd3fb4b7b2eca5131a5267042e69cb
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jul 21, 2023 https://github.com/python/cpython/pull/106968#ref-issue-1803501087
inspect.getsource (findsource) not working as expected when duplicate class is used #106727 https://github.com/python/cpython/issues/106727
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 21, 2023https://github.com/python/cpython/pull/106968#event-9888590149
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
carljmhttps://github.com/carljm
July 21, 2023 20:10https://github.com/python/cpython/pull/106968#event-9888593158
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jul 21, 2023https://github.com/python/cpython/pull/106968#event-9888594915
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
Jul 21, 2023https://github.com/python/cpython/pull/106968#issuecomment-1646189812
#106815https://github.com/python/cpython/pull/106815
@carljmhttps://github.com/carljm
Please reload this pagehttps://github.com/python/cpython/pull/106968
https://github.com/carljm
carljmhttps://github.com/carljm
Jul 21, 2023 https://github.com/python/cpython/pull/106968#pullrequestreview-1541789618
View reviewed changes https://github.com/python/cpython/pull/106968/files/7ff082f25ddd3fb4b7b2eca5131a5267042e69cb
carljmhttps://github.com/carljm
https://github.com/python/cpython/pull/106968#pullrequestreview-1541789618
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/106968
Lib/inspect.pyhttps://github.com/python/cpython/pull/106968/files/7ff082f25ddd3fb4b7b2eca5131a5267042e69cb#diff-b89cd06e4637abacb73f2500301ff979a67ad7ecbfa7cf151c7243715898d7ea
Please reload this pagehttps://github.com/python/cpython/pull/106968
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 21, 2023https://github.com/python/cpython/pull/106968#event-9888624957
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jul 21, 2023https://github.com/python/cpython/pull/106968#issuecomment-1646192971
Please reload this pagehttps://github.com/python/cpython/pull/106968
https://github.com/carljm
carljmhttps://github.com/carljm
Jul 21, 2023https://github.com/python/cpython/pull/106968#issuecomment-1646194144
#106815https://github.com/python/cpython/pull/106815
@carljmhttps://github.com/carljm
Please reload this pagehttps://github.com/python/cpython/pull/106968
https://github.com/gaogaotiantian
Replaced line breaker with parenthesis, added test casehttps://github.com/python/cpython/pull/106968/commits/13f977515c9e2d8fd7bce21f8ea23d9ab886a708
13f9775https://github.com/python/cpython/pull/106968/commits/13f977515c9e2d8fd7bce21f8ea23d9ab886a708
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
carljmhttps://github.com/carljm
July 22, 2023 18:47https://github.com/python/cpython/pull/106968#event-9891548888
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
Jul 22, 2023https://github.com/python/cpython/pull/106968#issuecomment-1646649397
Please reload this pagehttps://github.com/python/cpython/pull/106968
https://github.com/carljm
carljmhttps://github.com/carljm
Jul 24, 2023 https://github.com/python/cpython/pull/106968#pullrequestreview-1543997821
View reviewed changes https://github.com/python/cpython/pull/106968/files/13f977515c9e2d8fd7bce21f8ea23d9ab886a708
Lib/test/test_inspect.pyhttps://github.com/python/cpython/pull/106968/files/13f977515c9e2d8fd7bce21f8ea23d9ab886a708#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
Please reload this pagehttps://github.com/python/cpython/pull/106968
Lib/test/test_inspect.pyhttps://github.com/python/cpython/pull/106968/files/13f977515c9e2d8fd7bce21f8ea23d9ab886a708#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
Please reload this pagehttps://github.com/python/cpython/pull/106968
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Jul 24, 2023https://github.com/python/cpython/pull/106968#event-9903118942
https://github.com/gaogaotiantian
https://github.com/carljm
Remove backslash in test caseshttps://github.com/python/cpython/pull/106968/commits/eb2ba7a6104c0d5a5b661f8997d77cf9433a8f7d
eb2ba7ahttps://github.com/python/cpython/pull/106968/commits/eb2ba7a6104c0d5a5b661f8997d77cf9433a8f7d
https://github.com/carljm
carljmhttps://github.com/carljm
b383703https://github.com/python/cpython/commit/b38370349139e06f3a44150943ee44e345567d77
Jul 24, 2023https://github.com/python/cpython/pull/106968#event-9904283391
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jul 24, 2023https://github.com/python/cpython/pull/106968#event-9904283791
jtcavehttps://github.com/jtcave
Jul 27, 2023 https://github.com/python/cpython/pull/106968#ref-commit-3801021
https://github.com/gaogaotiantian
https://github.com/jtcave
pythongh-106727https://github.com/python/cpython/issues/106727
: Addhttps://github.com/jtcave/cpython/commit/3801021484b1b4297294a3f68434867ec63f198f
__module__https://github.com/jtcave/cpython/commit/3801021484b1b4297294a3f68434867ec63f198f
check forhttps://github.com/jtcave/cpython/commit/3801021484b1b4297294a3f68434867ec63f198f
inspect.getsource(cls)https://github.com/jtcave/cpython/commit/3801021484b1b4297294a3f68434867ec63f198f
(https://github.com/jtcave/cpython/commit/3801021484b1b4297294a3f68434867ec63f198f
p…https://github.com/python/cpython/pull/106968
3801021https://github.com/jtcave/cpython/commit/3801021484b1b4297294a3f68434867ec63f198f
…ython#106968https://github.com/python/cpython/pull/106968
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
Jul 29, 2023 https://github.com/python/cpython/pull/106968#ref-issue-1827674005
test_inspect fails with --forever argument #107446 https://github.com/python/cpython/issues/107446
https://github.com/Viicos
Viicoshttps://github.com/Viicos
Aug 10, 2023 https://github.com/python/cpython/pull/106968#ref-pullrequest-1797253170
Extract attribute docstrings for FieldInfo.description pydantic/pydantic#6563 https://github.com/pydantic/pydantic/pull/6563
https://github.com/gaogaotiantian
gaogaotiantianhttps://github.com/gaogaotiantian
September 9, 2023 17:47https://github.com/python/cpython/pull/106968#event-10324705932
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F106968
https://github.com/carljm
carljm https://github.com/carljm
https://github.com/python/cpython/pull/106968/files/13f977515c9e2d8fd7bce21f8ea23d9ab886a708
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/106968
https://github.com/gaogaotiantian
https://github.com/bedevere-bot
https://github.com/carljm
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.