René's URL Explorer Experiment


Title: [3.6] bpo-28604: Fix localeconv() for different LC_MONETARY (GH-10606) (GH-10619) by vstinner · Pull Request #10621 · python/cpython · GitHub

Open Graph Title: [3.6] bpo-28604: Fix localeconv() for different LC_MONETARY (GH-10606) (GH-10619) by vstinner · Pull Request #10621 · python/cpython

X Title: [3.6] bpo-28604: Fix localeconv() for different LC_MONETARY (GH-10606) (GH-10619) by vstinner · Pull Request #10621 · python/cpython

Description: locale.localeconv() now sets temporarily the LC_CTYPE locale to the LC_MONETARY locale if the two locales are different and monetary strings are non-ASCII. This temporary change affects other threads. Changes: locale.localeconv() can now set LC_CTYPE to LC_MONETARY to decode monetary fields. Add LocaleInfo.grouping_buffer: copy localeconv() grouping string since it can be replaced anytime if a different thread calls localeconv(). (cherry picked from commit 02e6bf7) (cherry picked from commit 6eff6b8) https://bugs.python.org/issue28604

Open Graph Description: locale.localeconv() now sets temporarily the LC_CTYPE locale to the LC_MONETARY locale if the two locales are different and monetary strings are non-ASCII. This temporary change affects other threa...

X Description: locale.localeconv() now sets temporarily the LC_CTYPE locale to the LC_MONETARY locale if the two locales are different and monetary strings are non-ASCII. This temporary change affects other threa...

Opengraph URL: https://github.com/python/cpython/pull/10621

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:810578a2-0153-b921-94a5-30c113098da1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCEDA:2C7E8A:31813CA:41252FA:69955C32
html-safe-nonced27aabeaa14195ffc2fc1dc370f2be855977b3b0eb6a47a13c962421007ac620
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRURBOjJDN0U4QTozMTgxM0NBOjQxMjUyRkE6Njk5NTVDMzIiLCJ2aXNpdG9yX2lkIjoiNTM1MzY0NzM5NzMxMzc5NzE3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac851f50aa376bf062c1d65fa3f86718ceac484a4977898668e515442a4e88c6ae
hovercard-subject-tagpull_request:232459730
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:altlocale.localeconv() now sets temporarily the LC_CTYPE locale to the LC_MONETARY locale if the two locales are different and monetary strings are non-ASCII. This temporary change affects other threa...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4bd759bc5f83244e2a0de29b937365905c0fefd238b6f077c24a49830375b4df
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecac7d4a5a6053f6655d0c3e8bfe5fd7a55c216fd
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10621%2Fcommits%2Fc2d8ef6350eefc41f1890eee943abceaeb1b535d
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10621%2Fcommits%2Fc2d8ef6350eefc41f1890eee943abceaeb1b535d
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d
Reloadhttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d
Reloadhttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.5k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:3.6https://github.com/python/cpython/tree/3.6
Conversation 0 https://github.com/python/cpython/pull/10621
Commits 1 https://github.com/python/cpython/pull/10621/commits
Checks 0 https://github.com/python/cpython/pull/10621/checks
Files changed https://github.com/python/cpython/pull/10621/files
Please reload this pagehttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d
[3.6] bpo-28604: Fix localeconv() for different LC_MONETARY (GH-10606) (GH-10619) https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#top
Show all changes 1 commit https://github.com/python/cpython/pull/10621/files
c2d8ef6 bpo-28604: Fix localeconv() for different LC_MONETARY (GH-10606) (GH-… vstinner Nov 20, 2018 https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d
Clear filters https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d
Please reload this pagehttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d
Please reload this pagehttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d
locale.rst https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-c0b38974efe1dad485444473d18545928f898fd0bcc8911d84122b6e51eb261b
2018-11-20-13-34-01.bpo-28604.iiih5h.rst https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-3b6535c8d783005664d63df483cc0ab6fbe0536f69467239828928b1e4e3f8cc
_localemodule.c https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0
fileutils.c https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
formatter_unicode.c https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-37eb3a999ae7446eed59e16b9ba4a7196ee73b7f6271f7fbe591efa452ec4c37
bpo-28604https://bugs.python.org/issue?@action=redirect&bpo=28604
GH-10606https://github.com/python/cpython/pull/10606
GH-…https://github.com/python/cpython/pull/10619
…10619https://github.com/python/cpython/pull/10619
02e6bf7https://github.com/python/cpython/commit/02e6bf7f2025cddcbde6432f6b6396198ab313f4
6eff6b8https://github.com/python/cpython/commit/6eff6b8eecd7a8eccad16419269fa18ec820922e
Please reload this pagehttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d
https://github.com/vstinner
vstinnerhttps://github.com/python/cpython/commits?author=vstinner
Doc/library/locale.rsthttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-c0b38974efe1dad485444473d18545928f898fd0bcc8911d84122b6e51eb261b
View file https://github.com/python/cpython/blob/c2d8ef6350eefc41f1890eee943abceaeb1b535d/Doc/library/locale.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10621/commits/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-c0b38974efe1dad485444473d18545928f898fd0bcc8911d84122b6e51eb261b
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-c0b38974efe1dad485444473d18545928f898fd0bcc8911d84122b6e51eb261b
Misc/NEWS.d/next/Library/2018-11-20-13-34-01.bpo-28604.iiih5h.rsthttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-3b6535c8d783005664d63df483cc0ab6fbe0536f69467239828928b1e4e3f8cc
View file https://github.com/python/cpython/blob/c2d8ef6350eefc41f1890eee943abceaeb1b535d/Misc/NEWS.d/next/Library/2018-11-20-13-34-01.bpo-28604.iiih5h.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10621/commits/{{ revealButtonHref }}
Modules/_localemodule.chttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0
View file https://github.com/python/cpython/blob/c2d8ef6350eefc41f1890eee943abceaeb1b535d/Modules/_localemodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10621/commits/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-68d4a50f88ce330d08190024a328c2d0fc25b94a3d864796e590a34849450cc0
Python/fileutils.chttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
View file https://github.com/python/cpython/blob/c2d8ef6350eefc41f1890eee943abceaeb1b535d/Python/fileutils.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10621/commits/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-27e9033ac552bd8208213a2d5a0a294312e3918cd81c4da822ab32c382e392c4
Python/formatter_unicode.chttps://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-37eb3a999ae7446eed59e16b9ba4a7196ee73b7f6271f7fbe591efa452ec4c37
View file https://github.com/python/cpython/blob/c2d8ef6350eefc41f1890eee943abceaeb1b535d/Python/formatter_unicode.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10621/commits/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-37eb3a999ae7446eed59e16b9ba4a7196ee73b7f6271f7fbe591efa452ec4c37
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-37eb3a999ae7446eed59e16b9ba4a7196ee73b7f6271f7fbe591efa452ec4c37
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-37eb3a999ae7446eed59e16b9ba4a7196ee73b7f6271f7fbe591efa452ec4c37
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-37eb3a999ae7446eed59e16b9ba4a7196ee73b7f6271f7fbe591efa452ec4c37
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-37eb3a999ae7446eed59e16b9ba4a7196ee73b7f6271f7fbe591efa452ec4c37
https://github.com/python/cpython/pull/10621/commits/c2d8ef6350eefc41f1890eee943abceaeb1b535d#diff-37eb3a999ae7446eed59e16b9ba4a7196ee73b7f6271f7fbe591efa452ec4c37
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.