René's URL Explorer Experiment


Title: gh-106030: Miscellaneous fixes in Python/suggestions.c by serhiy-storchaka · Pull Request #106031 · python/cpython · GitHub

Open Graph Title: gh-106030: Miscellaneous fixes in Python/suggestions.c by serhiy-storchaka · Pull Request #106031 · python/cpython

X Title: gh-106030: Miscellaneous fixes in Python/suggestions.c by serhiy-storchaka · Pull Request #106031 · python/cpython

Description: PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and should not be used. PyUnicode_CompareWithASCIIString() only works if the second argument is ASCII string. Refleak in get_sugges...

Open Graph Description: PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and should not be used. PyUnicode_CompareWithASCIIString() only works if the second argument is ASCII string. Refleak in get_sugges...

X Description: PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and should not be used. PyUnicode_CompareWithASCIIString() only works if the second argument is ASCII string. Refleak in get_sugges...

Opengraph URL: https://github.com/python/cpython/pull/106031

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dbf3925c-af17-031d-da58-0fd96844e0f2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA5DC:75A99:5322EC:7537BC:696A0DCC
html-safe-nonce4075f8541fecb9d054070dc760d28369a20cd62351bc7bf658878fd5ddc1a1ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNURDOjc1QTk5OjUzMjJFQzo3NTM3QkM6Njk2QTBEQ0MiLCJ2aXNpdG9yX2lkIjoiMzk1MzQ5MTU1OTIxMzMwNTI5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6ff20171770e629d5fb22da11572875d57891da80756c222881c0dd4858d538f
hovercard-subject-tagpull_request:1405198168
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/106031/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/12195e6e72e32c8469a5f037dbc3529967793af11900e8d2fea41cd4626bd7dd/python/cpython/pull/106031
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/12195e6e72e32c8469a5f037dbc3529967793af11900e8d2fea41cd4626bd7dd/python/cpython/pull/106031
og:image:altPyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and should not be used. PyUnicode_CompareWithASCIIString() only works if the second argument is ASCII string. Refleak in get_sugges...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameserhiy-storchaka
hostnamegithub.com
expected-hostnamegithub.com
None699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7266b2d935baa1c6474b16dd9feaa5ca30607261
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/106031#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F106031
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F106031
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/106031
Reloadhttps://github.com/python/cpython/pull/106031
Reloadhttps://github.com/python/cpython/pull/106031
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/106031
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/106031
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/106031#issue-comment-box
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:suggestionshttps://github.com/serhiy-storchaka/cpython/tree/suggestions
gh-106030: Miscellaneous fixes in Python/suggestions.c https://github.com/python/cpython/pull/106031#top
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:suggestionshttps://github.com/serhiy-storchaka/cpython/tree/suggestions
Conversation 4 https://github.com/python/cpython/pull/106031
Commits 1 https://github.com/python/cpython/pull/106031/commits
Checks 0 https://github.com/python/cpython/pull/106031/checks
Files changed https://github.com/python/cpython/pull/106031/files
Please reload this pagehttps://github.com/python/cpython/pull/106031
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 23, 2023https://github.com/python/cpython/pull/106031#issue-1771608744
Please reload this pagehttps://github.com/python/cpython/pull/106031
Miscellaneous fixes in Python/suggestions.c #106030https://github.com/python/cpython/issues/106030
Please reload this pagehttps://github.com/python/cpython/pull/106031
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 23, 2023https://github.com/python/cpython/pull/106031#event-9618761050
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 23, 2023 https://github.com/python/cpython/pull/106031#ref-issue-1771605726
Miscellaneous fixes in Python/suggestions.c #106030 https://github.com/python/cpython/issues/106030
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 23, 2023 https://github.com/python/cpython/pull/106031#ref-pullrequest-1771521214
gh-106025: Fix incorrect usage of PyUnicode_CompareWithASCIIString in suggestions.c #106026 https://github.com/python/cpython/pull/106026
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
pablogsalhttps://github.com/pablogsal
June 23, 2023 15:02https://github.com/python/cpython/pull/106031#event-9618796375
https://github.com/serhiy-storchaka
pythongh-106030https://github.com/python/cpython/issues/106030
: Miscaleous fixes in Python/suggestions.chttps://github.com/python/cpython/pull/106031/commits/c82f8b85179274d7b9cf870871fe50a5657e80ec
c82f8b8https://github.com/python/cpython/pull/106031/commits/c82f8b85179274d7b9cf870871fe50a5657e80ec
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
force-pushedhttps://github.com/python/cpython/compare/3d6655d53ab7cfd06aee962eb859821c8a56d0c2..c82f8b85179274d7b9cf870871fe50a5657e80ec
3d6655dhttps://github.com/python/cpython/commit/3d6655d53ab7cfd06aee962eb859821c8a56d0c2
c82f8b8https://github.com/python/cpython/commit/c82f8b85179274d7b9cf870871fe50a5657e80ec
Compare https://github.com/python/cpython/compare/3d6655d53ab7cfd06aee962eb859821c8a56d0c2..c82f8b85179274d7b9cf870871fe50a5657e80ec
June 23, 2023 15:04https://github.com/python/cpython/pull/106031#event-9618815234
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Jun 23, 2023https://github.com/python/cpython/pull/106031#event-9618934397
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 23, 2023https://github.com/python/cpython/pull/106031#event-9619088371
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Jun 23, 2023 https://github.com/python/cpython/pull/106031#pullrequestreview-1495420291
View reviewed changes https://github.com/python/cpython/pull/106031/files/c82f8b85179274d7b9cf870871fe50a5657e80ec
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 23, 2023https://github.com/python/cpython/pull/106031#event-9619309016
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
c8c162ehttps://github.com/python/cpython/commit/c8c162ef5294cddb7ac75fe93ab918e5661c68ee
Jun 23, 2023https://github.com/python/cpython/pull/106031#event-9619744117
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jun 23, 2023https://github.com/python/cpython/pull/106031#issuecomment-1604549065
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/106031
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jun 23, 2023https://github.com/python/cpython/pull/106031#event-9619744587
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
June 23, 2023 16:53https://github.com/python/cpython/pull/106031#event-9619744731
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jun 23, 2023https://github.com/python/cpython/pull/106031#issuecomment-1604549182
@serhiy-storchakahttps://github.com/serhiy-storchaka
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/106031
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 23, 2023https://github.com/python/cpython/pull/106031#event-9619745505
miss-islingtonhttps://github.com/miss-islington
Jun 23, 2023 https://github.com/python/cpython/pull/106031#ref-commit-1e9fb9d
https://github.com/serhiy-storchaka
https://github.com/miss-islington
pythongh-106030https://github.com/python/cpython/issues/106030
: Miscellaneous fixes in Python/suggestions.c (https://github.com/miss-islington/cpython/commit/1e9fb9d94d84038dedf3aa7e32e2da738de97983
pythonG…https://github.com/python/cpython/pull/106031
1e9fb9dhttps://github.com/miss-islington/cpython/commit/1e9fb9d94d84038dedf3aa7e32e2da738de97983
…H-106031https://github.com/python/cpython/pull/106031
c8c162ehttps://github.com/miss-islington/cpython/commit/c8c162ef5294cddb7ac75fe93ab918e5661c68ee
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 23, 2023https://github.com/python/cpython/pull/106031#issuecomment-1604549301
GH-106036https://github.com/python/cpython/pull/106036
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/106031
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 23, 2023https://github.com/python/cpython/pull/106031#event-9619746313
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 23, 2023 https://github.com/python/cpython/pull/106031#ref-commit-de2160e
https://github.com/serhiy-storchaka
[3.11]https://github.com/serhiy-storchaka/cpython/commit/de2160eff6b029829e206d490472a16b3e90a84f
pythongh-106030https://github.com/python/cpython/issues/106030
: Miscellaneous fixes in Python/suggestions.c (https://github.com/serhiy-storchaka/cpython/commit/de2160eff6b029829e206d490472a16b3e90a84f
p…https://github.com/python/cpython/pull/106031
de2160ehttps://github.com/serhiy-storchaka/cpython/commit/de2160eff6b029829e206d490472a16b3e90a84f
…ythonGH-106031https://github.com/python/cpython/pull/106031
c8c162ehttps://github.com/serhiy-storchaka/cpython/commit/c8c162ef5294cddb7ac75fe93ab918e5661c68ee
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 23, 2023 https://github.com/python/cpython/pull/106031#ref-commit-f8ca034
https://github.com/serhiy-storchaka
[3.11]https://github.com/serhiy-storchaka/cpython/commit/f8ca034a5d445631b6e91a377ae275151ec01158
pythongh-106030https://github.com/python/cpython/issues/106030
: Miscellaneous fixes in Python/suggestions.c (https://github.com/serhiy-storchaka/cpython/commit/f8ca034a5d445631b6e91a377ae275151ec01158
p…https://github.com/python/cpython/pull/106031
f8ca034https://github.com/serhiy-storchaka/cpython/commit/f8ca034a5d445631b6e91a377ae275151ec01158
…ythonGH-106031https://github.com/python/cpython/pull/106031
c8c162ehttps://github.com/serhiy-storchaka/cpython/commit/c8c162ef5294cddb7ac75fe93ab918e5661c68ee
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 23, 2023https://github.com/python/cpython/pull/106031#issuecomment-1604571378
GH-106039https://github.com/python/cpython/pull/106039
3.11 branchhttps://github.com/python/cpython/tree/3.11
Please reload this pagehttps://github.com/python/cpython/pull/106031
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Jun 23, 2023https://github.com/python/cpython/pull/106031#event-9619898887
hauntsaninjahttps://github.com/hauntsaninja
Jun 27, 2023 https://github.com/python/cpython/pull/106031#ref-commit-1bb2bf7
https://github.com/miss-islington
https://github.com/serhiy-storchaka
[3.12]https://github.com/python/cpython/commit/1bb2bf7cd6d8dc8c644e9591282a70f6b3550026
gh-106030https://github.com/python/cpython/issues/106030
: Miscellaneous fixes in Python/suggestions.c (https://github.com/python/cpython/commit/1bb2bf7cd6d8dc8c644e9591282a70f6b3550026
GH-106031https://github.com/python/cpython/pull/106031
1bb2bf7https://github.com/python/cpython/commit/1bb2bf7cd6d8dc8c644e9591282a70f6b3550026
https://github.com/python/cpython/pull/106031
#106036https://github.com/python/cpython/pull/106036
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 25, 2023https://github.com/python/cpython/pull/106031#event-9909509446
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F106031
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
https://github.com/python/cpython/pull/106031/files/c82f8b85179274d7b9cf870871fe50a5657e80ec
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/106031
https://github.com/serhiy-storchaka
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/pablogsal
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.