René's URL Explorer Experiment


Title: gh-105927: PyImport_AddModule() uses _PyWeakref_GET_REF() by vstinner · Pull Request #106001 · python/cpython · GitHub

Open Graph Title: gh-105927: PyImport_AddModule() uses _PyWeakref_GET_REF() by vstinner · Pull Request #106001 · python/cpython

X Title: gh-105927: PyImport_AddModule() uses _PyWeakref_GET_REF() by vstinner · Pull Request #106001 · python/cpython

Description: It now raises an exception if sys.modules doesn't hold a strong reference to the module. Elaborate the comment explaining why a weak reference is used to create a borrowed reference. Issue: C AP...

Open Graph Description: It now raises an exception if sys.modules doesn't hold a strong reference to the module. Elaborate the comment explaining why a weak reference is used to create a borrowed reference. Issue: ...

X Description: It now raises an exception if sys.modules doesn't hold a strong reference to the module. Elaborate the comment explaining why a weak reference is used to create a borrowed reference. Iss...

Opengraph URL: https://github.com/python/cpython/pull/106001

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7e5d74e2-b6ae-b043-7029-b09d1a95426d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD88:CD10D:231801D:2DBE440:696B52CF
html-safe-nonce809f4ac92ae94db00bbd7ff559bf063bfa2747d32feddd678078a882db45e470
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDg4OkNEMTBEOjIzMTgwMUQ6MkRCRTQ0MDo2OTZCNTJDRiIsInZpc2l0b3JfaWQiOiI0MDczNDkwNzU1MDMwMzA3NTM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc046b1bed26851fe41a278290cf74da23dfddcbabe4671923ade16922d11e016
hovercard-subject-tagpull_request:1404220460
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/106001/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2cf8ce0c9c543da5d5fe12c1ba1ddb78c57d4b598e7e944556fad1e910b6aec4/python/cpython/pull/106001
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2cf8ce0c9c543da5d5fe12c1ba1ddb78c57d4b598e7e944556fad1e910b6aec4/python/cpython/pull/106001
og:image:altIt now raises an exception if sys.modules doesn't hold a strong reference to the module. Elaborate the comment explaining why a weak reference is used to create a borrowed reference. Issue: ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/106001#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F106001
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F106001
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/106001
Reloadhttps://github.com/python/cpython/pull/106001
Reloadhttps://github.com/python/cpython/pull/106001
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/106001
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/106001
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/106001#issue-comment-box
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:getref_add_modulehttps://github.com/vstinner/cpython/tree/getref_add_module
gh-105927: PyImport_AddModule() uses _PyWeakref_GET_REF() https://github.com/python/cpython/pull/106001#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:getref_add_modulehttps://github.com/vstinner/cpython/tree/getref_add_module
Conversation 2 https://github.com/python/cpython/pull/106001
Commits 1 https://github.com/python/cpython/pull/106001/commits
Checks 0 https://github.com/python/cpython/pull/106001/checks
Files changed https://github.com/python/cpython/pull/106001/files
Please reload this pagehttps://github.com/python/cpython/pull/106001
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 22, 2023https://github.com/python/cpython/pull/106001#issue-1770465325
Please reload this pagehttps://github.com/python/cpython/pull/106001
C API: Add PyWeakref_GetRef() function #105927https://github.com/python/cpython/issues/105927
Please reload this pagehttps://github.com/python/cpython/pull/106001
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jun 22, 2023https://github.com/python/cpython/pull/106001#event-9611642292
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
brettcannonhttps://github.com/brettcannon
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
code ownershttps://github.com/python/cpython/blob/193a2b2eaab9890f2cb16128c95bb63cb49307f1/.github/CODEOWNERS#L71
June 22, 2023 22:16https://github.com/python/cpython/pull/106001#event-9611642348
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 22, 2023https://github.com/python/cpython/pull/106001#event-9611642814
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 22, 2023 https://github.com/python/cpython/pull/106001#ref-issue-1764293800
C API: Add PyWeakref_GetRef() function #105927 https://github.com/python/cpython/issues/105927
https://github.com/vstinner
pythongh-105927https://github.com/python/cpython/issues/105927
: PyImport_AddModule() uses _PyWeakref_GET_REF()https://github.com/python/cpython/pull/106001/commits/341d2a004ce535e815c76d2a7c46def6a5b22604
341d2a0https://github.com/python/cpython/pull/106001/commits/341d2a004ce535e815c76d2a7c46def6a5b22604
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
force-pushedhttps://github.com/python/cpython/compare/60ebd65af63e6bb15763650c1b160e11828bc63e..341d2a004ce535e815c76d2a7c46def6a5b22604
60ebd65https://github.com/python/cpython/commit/60ebd65af63e6bb15763650c1b160e11828bc63e
341d2a0https://github.com/python/cpython/commit/341d2a004ce535e815c76d2a7c46def6a5b22604
Compare https://github.com/python/cpython/compare/60ebd65af63e6bb15763650c1b160e11828bc63e..341d2a004ce535e815c76d2a7c46def6a5b22604
June 22, 2023 22:17https://github.com/python/cpython/pull/106001#event-9611648259
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
ee52158https://github.com/python/cpython/commit/ee52158f209835d6d4ca27f44218466f266f4afb
Jun 22, 2023https://github.com/python/cpython/pull/106001#event-9611957267
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 22, 2023https://github.com/python/cpython/pull/106001#event-9611957405
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
June 22, 2023 23:23https://github.com/python/cpython/pull/106001#event-9611957509
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 22, 2023 https://github.com/python/cpython/pull/106001#ref-pullrequest-1770346640
gh-105922: PyImport_AddModule() uses Py_DECREF() #105998 https://github.com/python/cpython/pull/105998
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 23, 2023 https://github.com/python/cpython/pull/106001#pullrequestreview-1494508639
View reviewed changes https://github.com/python/cpython/pull/106001/files/341d2a004ce535e815c76d2a7c46def6a5b22604
Python/import.chttps://github.com/python/cpython/pull/106001/files/341d2a004ce535e815c76d2a7c46def6a5b22604#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 23, 2023https://github.com/python/cpython/pull/106001#discussion_r1239395160
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/106001
vstinnerhttps://github.com/vstinner
Jun 23, 2023https://github.com/python/cpython/pull/106001#discussion_r1239515072
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#105998https://github.com/python/cpython/pull/105998
Please reload this pagehttps://github.com/python/cpython/pull/106001
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 10, 2023 https://github.com/python/cpython/pull/106001#ref-issue-1763920302
C API: Add PyImport_AddModuleRef() function #105922 https://github.com/python/cpython/issues/105922
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F106001
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/106001/files/341d2a004ce535e815c76d2a7c46def6a5b22604
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/warsaw
warsaw https://github.com/warsaw
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/106001
https://github.com/vstinner
https://github.com/serhiy-storchaka
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.