René's URL Explorer Experiment


Title: gh-105922: PyImport_AddModule() uses Py_DECREF() by vstinner · Pull Request #105998 · python/cpython · GitHub

Open Graph Title: gh-105922: PyImport_AddModule() uses Py_DECREF() by vstinner · Pull Request #105998 · python/cpython

X Title: gh-105922: PyImport_AddModule() uses Py_DECREF() by vstinner · Pull Request #105998 · python/cpython

Description: Rewrite PyImport_AddModule() to simply call Py_DECREF(), rather than creating a weak reference, to get a borrowed reference to the module. Issue: C API: Add PyImport_AddModuleRef() function #10...

Open Graph Description: Rewrite PyImport_AddModule() to simply call Py_DECREF(), rather than creating a weak reference, to get a borrowed reference to the module. Issue: C API: Add PyImport_AddModuleRef() function #10...

X Description: Rewrite PyImport_AddModule() to simply call Py_DECREF(), rather than creating a weak reference, to get a borrowed reference to the module. Issue: C API: Add PyImport_AddModuleRef() function #10...

Opengraph URL: https://github.com/python/cpython/pull/105998

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:14c4cdc8-5219-9113-4212-adae2df929c5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADEA:311995:2A4B052:374D022:696B6E32
html-safe-nonce5afa668920f678bb6ffc1b6eb47f14677348ad0b9dcbddeffeafa8de5741d9a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREVBOjMxMTk5NToyQTRCMDUyOjM3NEQwMjI6Njk2QjZFMzIiLCJ2aXNpdG9yX2lkIjoiMjA1NzM0NDY4MTUwMTIyNDQ5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0b3a62df571bffd78b5c04e98bad33a985d58b95462736be89e1ed6fd7b78a7c
hovercard-subject-tagpull_request:1404116155
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/105998/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ccdb3121f2e95cd9fefc2028e55d3704009b2483eb6f111385ef70ee5e4684d6/python/cpython/pull/105998
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ccdb3121f2e95cd9fefc2028e55d3704009b2483eb6f111385ef70ee5e4684d6/python/cpython/pull/105998
og:image:altRewrite PyImport_AddModule() to simply call Py_DECREF(), rather than creating a weak reference, to get a borrowed reference to the module. Issue: C API: Add PyImport_AddModuleRef() function #10...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105998#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105998
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105998
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105998
Reloadhttps://github.com/python/cpython/pull/105998
Reloadhttps://github.com/python/cpython/pull/105998
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105998
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105998
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/105998#issue-comment-box
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:add_module_objhttps://github.com/vstinner/cpython/tree/add_module_obj
gh-105922: PyImport_AddModule() uses Py_DECREF() https://github.com/python/cpython/pull/105998#top
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
vstinner:add_module_objhttps://github.com/vstinner/cpython/tree/add_module_obj
Conversation 15 https://github.com/python/cpython/pull/105998
Commits 3 https://github.com/python/cpython/pull/105998/commits
Checks 0 https://github.com/python/cpython/pull/105998/checks
Files changed https://github.com/python/cpython/pull/105998/files
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 22, 2023https://github.com/python/cpython/pull/105998#issue-1770346640
Please reload this pagehttps://github.com/python/cpython/pull/105998
C API: Add PyImport_AddModuleRef() function #105922https://github.com/python/cpython/issues/105922
https://cpython-previews--105998.org.readthedocs.build/https://cpython-previews--105998.org.readthedocs.build/
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jun 22, 2023https://github.com/python/cpython/pull/105998#event-9610931160
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
brettcannonhttps://github.com/brettcannon
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
code ownershttps://github.com/python/cpython/blob/c38da1e3e19a7bf1053c6d52e730e970efeceff6/.github/CODEOWNERS#L71
June 22, 2023 20:26https://github.com/python/cpython/pull/105998#event-9610931230
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 22, 2023https://github.com/python/cpython/pull/105998#event-9610931483
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 22, 2023 https://github.com/python/cpython/pull/105998#ref-issue-1763920302
C API: Add PyImport_AddModuleRef() function #105922 https://github.com/python/cpython/issues/105922
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 22, 2023https://github.com/python/cpython/pull/105998#issuecomment-1603276951
@serhiy-storchakahttps://github.com/serhiy-storchaka
gh-86160https://github.com/python/cpython/issues/86160
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/vstinner
pythongh-105922https://github.com/python/cpython/issues/105922
: PyImport_AddModule() uses Py_DECREF()https://github.com/python/cpython/pull/105998/commits/cef28f1c62a75b6ba867ecc7aa989f51ea0930e9
cef28f1https://github.com/python/cpython/pull/105998/commits/cef28f1c62a75b6ba867ecc7aa989f51ea0930e9
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
force-pushedhttps://github.com/python/cpython/compare/283783c301c6c3445c0b3c442299903181fba062..cef28f1c62a75b6ba867ecc7aa989f51ea0930e9
283783chttps://github.com/python/cpython/commit/283783c301c6c3445c0b3c442299903181fba062
cef28f1https://github.com/python/cpython/commit/cef28f1c62a75b6ba867ecc7aa989f51ea0930e9
Compare https://github.com/python/cpython/compare/283783c301c6c3445c0b3c442299903181fba062..cef28f1c62a75b6ba867ecc7aa989f51ea0930e9
June 22, 2023 20:38https://github.com/python/cpython/pull/105998#event-9611019548
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 22, 2023https://github.com/python/cpython/pull/105998#issuecomment-1603286228
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 22, 2023https://github.com/python/cpython/pull/105998#issuecomment-1603295761
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 22, 2023https://github.com/python/cpython/pull/105998#issuecomment-1603318478
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 22, 2023https://github.com/python/cpython/pull/105998#issuecomment-1603371557
#91095 (comment)https://github.com/python/cpython/issues/91095#issuecomment-1603368373
Please reload this pagehttps://github.com/python/cpython/pull/105998
vstinnerhttps://github.com/vstinner
June 23, 2023 00:22https://github.com/python/cpython/pull/105998#commits-pushed-c2490a4
https://github.com/vstinner
Fix for custom sys.modules typehttps://github.com/python/cpython/pull/105998/commits/c2490a482dee57f154c15bf246c57b96cd29b49c
c2490a4https://github.com/python/cpython/pull/105998/commits/c2490a482dee57f154c15bf246c57b96cd29b49c
https://github.com/vstinner
Add testhttps://github.com/python/cpython/pull/105998/commits/326246876a43427b3a873af7c341a2ed825dc7d6
3262468https://github.com/python/cpython/pull/105998/commits/326246876a43427b3a873af7c341a2ed825dc7d6
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
June 22, 2023 22:38https://github.com/python/cpython/pull/105998#event-9611739917
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 22, 2023https://github.com/python/cpython/pull/105998#event-9611740060
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 22, 2023https://github.com/python/cpython/pull/105998#issuecomment-1603417653
85a5fbbhttps://github.com/python/cpython/commit/85a5fbbdfea617f6cc8fae82c9e8c2b5c424436d
3f5da24https://github.com/python/cpython/commit/3f5da24ea304e674a9abbdcffc4d671e32aa70f1
25ce566https://github.com/python/cpython/commit/25ce566661c1b7446b3ddb4076513a62f93ce08d
3f9eee6https://github.com/python/cpython/commit/3f9eee6eb4b25fe1926eaa5f00e02344b126f54d
[subinterpreters] Eliminate PyInterpreterState.modules. #72597https://github.com/python/cpython/issues/72597
4db8988https://github.com/python/cpython/commit/4db8988420e0a122d617df741381b0c385af032c
b2fc549https://github.com/python/cpython/commit/b2fc5492789623d656953d458f3eeaac03c1ef56
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 22, 2023https://github.com/python/cpython/pull/105998#issuecomment-1603420879
3f9eee6https://github.com/python/cpython/commit/3f9eee6eb4b25fe1926eaa5f00e02344b126f54d
GH-72597https://github.com/python/cpython/issues/72597
GH-72597https://github.com/python/cpython/issues/72597
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 22, 2023https://github.com/python/cpython/pull/105998#issuecomment-1603427283
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 22, 2023https://github.com/python/cpython/pull/105998#issuecomment-1603431952
#106001https://github.com/python/cpython/pull/106001
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 23, 2023 https://github.com/python/cpython/pull/105998#pullrequestreview-1494500936
View reviewed changes https://github.com/python/cpython/pull/105998/files/326246876a43427b3a873af7c341a2ed825dc7d6
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/105998#pullrequestreview-1494500936
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 23, 2023https://github.com/python/cpython/pull/105998#issuecomment-1603772504
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 23, 2023 https://github.com/python/cpython/pull/105998#ref-pullrequest-1770465325
gh-105927: PyImport_AddModule() uses _PyWeakref_GET_REF() #106001 https://github.com/python/cpython/pull/106001
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 23, 2023https://github.com/python/cpython/pull/105998#issuecomment-1603908645
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 23, 2023 https://github.com/python/cpython/pull/105998#ref-issue-1771174774
PEP 726: Support defining __setattr__() and __delattr__() in a module #106016 https://github.com/python/cpython/issues/106016
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 23, 2023https://github.com/python/cpython/pull/105998#issuecomment-1604059309
#106016https://github.com/python/cpython/issues/106016
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
Jun 23, 2023 https://github.com/python/cpython/pull/105998#pullrequestreview-1496185513
View reviewed changes https://github.com/python/cpython/pull/105998/files/326246876a43427b3a873af7c341a2ed825dc7d6
Python/import.chttps://github.com/python/cpython/pull/105998/files/326246876a43427b3a873af7c341a2ed825dc7d6#diff-28cfc3e2868980a79d93d2ebdc8747dcb9231f3dd7f2caef96e74107d1ea3bf3
brettcannonhttps://github.com/brettcannon
Jun 23, 2023https://github.com/python/cpython/pull/105998#discussion_r1240501449
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 26, 2023https://github.com/python/cpython/pull/105998#issuecomment-1607377235
ee52158https://github.com/python/cpython/commit/ee52158f209835d6d4ca27f44218466f266f4afb
#106016https://github.com/python/cpython/issues/106016
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 26, 2023https://github.com/python/cpython/pull/105998#event-9638343330
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
June 26, 2023 12:33https://github.com/python/cpython/pull/105998#event-9638343822
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105998
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
https://github.com/python/cpython/pull/105998/files/326246876a43427b3a873af7c341a2ed825dc7d6
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/105998/files/326246876a43427b3a873af7c341a2ed825dc7d6
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/warsaw
warsaw https://github.com/warsaw
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/105998
https://github.com/vstinner
https://github.com/serhiy-storchaka
https://github.com/brettcannon
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.