René's URL Explorer Experiment


Title: gh-105936: Fix frozen dataclasses with slots' `__setattr__` and `__delattr_` by avboag · Pull Request #105937 · python/cpython · GitHub

Open Graph Title: gh-105936: Fix frozen dataclasses with slots' `__setattr__` and `__delattr_` by avboag · Pull Request #105937 · python/cpython

X Title: gh-105936: Fix frozen dataclasses with slots' `__setattr__` and `__delattr_` by avboag · Pull Request #105937 · python/cpython

Description: The problem was that super was called cls with the original class instead of the one generated by _add_slots. The PR moves _add_slots to before the generation of other methods for the dataclass that enabling the use of right cls everywhere (currently _frozen_get_del_attr was the only place to be affected). Issue: gh-105936

Open Graph Description: The problem was that super was called cls with the original class instead of the one generated by _add_slots. The PR moves _add_slots to before the generation of other methods for the dataclass tha...

X Description: The problem was that super was called cls with the original class instead of the one generated by _add_slots. The PR moves _add_slots to before the generation of other methods for the dataclass tha...

Opengraph URL: https://github.com/python/cpython/pull/105937

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d7a1a06e-6593-7749-1945-48b6a1b9b32d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id83C6:2679E9:37DC103:4A83A54:6B021C2B
html-safe-nonce05ef42982610e75c0d4e17c6e299fb23a33c2e67cd97ba76e1da94813e7787cd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0M2OjI2NzlFOTozN0RDMTAzOjRBODNBNTQ6NkIwMjFDMkIiLCJ2aXNpdG9yX2lkIjoiNDk4NzU4MDY5ODk3NTE0OTA5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd069fe76bc304244d6f89196c375ee6944f73c2bbce66f0a295ae1db9269d46f
hovercard-subject-tagpull_request:1399587399
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/105937/files
twitter:imagehttps://avatars.githubusercontent.com/u/16599111?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16599111?s=400&v=4
og:image:altThe problem was that super was called cls with the original class instead of the one generated by _add_slots. The PR moves _add_slots to before the generation of other methods for the dataclass tha...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105937/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105937%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105937%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105937/files
Reloadhttps://github.com/python/cpython/pull/105937/files
Reloadhttps://github.com/python/cpython/pull/105937/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
avboaghttps://github.com/avboag
python:mainhttps://github.com/python/cpython/tree/main
avboag:fixing_frozen_slots_set_del_attrhttps://github.com/avboag/cpython/tree/fixing_frozen_slots_set_del_attr
Conversation 2 https://github.com/python/cpython/pull/105937
Commits 3 https://github.com/python/cpython/pull/105937/commits
Checks 0 https://github.com/python/cpython/pull/105937/checks
Files changed https://github.com/python/cpython/pull/105937/files
Please reload this pagehttps://github.com/python/cpython/pull/105937/files
gh-105936: Fix frozen dataclasses with slots' __setattr__ and __delattr_ https://github.com/python/cpython/pull/105937/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/105937/files
6641ed3 Fixed bug. avboag Jun 20, 2023 https://github.com/python/cpython/pull/105937/commits/6641ed36cb2ccaf5a9f96a18f1a1e54b56c54ef4
4bf0b7e Typo fix. avboag Jun 20, 2023 https://github.com/python/cpython/pull/105937/commits/4bf0b7e9861bd4166bcfa11b41d0563ee9bb8d71
f74a833 📜🤖 Added by blurb_it. blurb-it[bot] Jun 20, 2023 https://github.com/python/cpython/pull/105937/commits/f74a8336300efd3bd4524bc8491941f5c7e4b3c5
Clear filters https://github.com/python/cpython/pull/105937/files
Please reload this pagehttps://github.com/python/cpython/pull/105937/files
Please reload this pagehttps://github.com/python/cpython/pull/105937/files
dataclasses.py https://github.com/python/cpython/pull/105937/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
test_dataclasses.py https://github.com/python/cpython/pull/105937/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
2023-06-20-10-14-29.gh-issue-105936.7VfFJW.rst https://github.com/python/cpython/pull/105937/files#diff-3571090eaa93aec0f54d291e584e239188d3199821bd1fa4046733af55218c92
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L422
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/105937/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
View file https://github.com/avboag/cpython/blob/f74a8336300efd3bd4524bc8491941f5c7e4b3c5/Lib/dataclasses.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105937/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105937/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/105937/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/105937/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/105937/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/105937/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/105937/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/105937/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/105937/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
Lib/test/test_dataclasses.pyhttps://github.com/python/cpython/pull/105937/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
View file https://github.com/avboag/cpython/blob/f74a8336300efd3bd4524bc8491941f5c7e4b3c5/Lib/test/test_dataclasses.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105937/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105937/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
https://github.com/python/cpython/pull/105937/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
https://github.com/python/cpython/pull/105937/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
https://github.com/python/cpython/pull/105937/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
Misc/NEWS.d/next/Library/2023-06-20-10-14-29.gh-issue-105936.7VfFJW.rsthttps://github.com/python/cpython/pull/105937/files#diff-3571090eaa93aec0f54d291e584e239188d3199821bd1fa4046733af55218c92
View file https://github.com/avboag/cpython/blob/f74a8336300efd3bd4524bc8491941f5c7e4b3c5/Misc/NEWS.d/next/Library/2023-06-20-10-14-29.gh-issue-105936.7VfFJW.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105937/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.