René's URL Explorer Experiment


Title: gh-105936: Fix frozen dataclasses with slots' `__setattr__` and `__delattr_` by avboag · Pull Request #105937 · python/cpython · GitHub

Open Graph Title: gh-105936: Fix frozen dataclasses with slots' `__setattr__` and `__delattr_` by avboag · Pull Request #105937 · python/cpython

X Title: gh-105936: Fix frozen dataclasses with slots' `__setattr__` and `__delattr_` by avboag · Pull Request #105937 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The problem was that super was called cls with the original class instead of the one generated by _add_slots. The PR moves _add_slots to before the generation of other methods for the dataclass tha...

X Description: The problem was that super was called cls with the original class instead of the one generated by _add_slots. The PR moves _add_slots to before the generation of other methods for the dataclass tha...

Opengraph URL: https://github.com/python/cpython/pull/105937

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2b6da829-7a1f-be18-dd61-57252d4186e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED02:20AA01:410C618:52877BE:6B020AC5
html-safe-nonce659c1cf3bc54b2e57192dea33881a5939d51735202d7168cae7ce714a8eecca2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDAyOjIwQUEwMTo0MTBDNjE4OjUyODc3QkU6NkIwMjBBQzUiLCJ2aXNpdG9yX2lkIjoiODU1MTQ3ODU4MTkwODM0MzQ5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd08dda3bf965e65c7907ec29cbd3ee70a20abedcea4ec01430ff2f099c7e9ae0
hovercard-subject-tagpull_request:1399587399
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/105937/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/509283317fce9e9fa18c4eb37fc6afd8389823d9f27781541c087c72144b5662/python/cpython/pull/105937
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/509283317fce9e9fa18c4eb37fc6afd8389823d9f27781541c087c72144b5662/python/cpython/pull/105937
og:image:altThe problem was that super was called cls with the original class instead of the one generated by _add_slots. The PR moves _add_slots to before the generation of other methods for the dataclass tha...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameavboag
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/105937#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105937
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105937
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105937
Reloadhttps://github.com/python/cpython/pull/105937
Reloadhttps://github.com/python/cpython/pull/105937
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
avboaghttps://github.com/avboag
python:mainhttps://github.com/python/cpython/tree/main
avboag:fixing_frozen_slots_set_del_attrhttps://github.com/avboag/cpython/tree/fixing_frozen_slots_set_del_attr
Conversationhttps://github.com/python/cpython/pull/105937
Commits3 (3)https://github.com/python/cpython/pull/105937/commits
Checkshttps://github.com/python/cpython/pull/105937/checks
Files changedhttps://github.com/python/cpython/pull/105937/files
gh-105936: Fix frozen dataclasses with slots' __setattr__ and __delattr_ https://github.com/python/cpython/pull/105937#top
avboaghttps://github.com/avboag
python:mainhttps://github.com/python/cpython/tree/main
avboag:fixing_frozen_slots_set_del_attrhttps://github.com/avboag/cpython/tree/fixing_frozen_slots_set_del_attr
https://github.com/avboag
avboaghttps://github.com/avboag
Jun 20, 2023https://github.com/python/cpython/pull/105937#issue-1765086758
Please reload this pagehttps://github.com/python/cpython/pull/105937
dataclasses: frozen dataclasses with slots' __setattr__ and __delattr__ does not work. #105936https://github.com/python/cpython/issues/105936
Please reload this pagehttps://github.com/python/cpython/pull/105937
avboaghttps://github.com/avboag
June 20, 2023 13:07https://github.com/python/cpython/pull/105937#commits-pushed-6641ed3
https://github.com/avboag
Fixed bug.https://github.com/python/cpython/pull/105937/commits/6641ed36cb2ccaf5a9f96a18f1a1e54b56c54ef4
6641ed3https://github.com/python/cpython/pull/105937/commits/6641ed36cb2ccaf5a9f96a18f1a1e54b56c54ef4
https://github.com/avboag
Typo fix.https://github.com/python/cpython/pull/105937/commits/4bf0b7e9861bd4166bcfa11b41d0563ee9bb8d71
4bf0b7ehttps://github.com/python/cpython/pull/105937/commits/4bf0b7e9861bd4166bcfa11b41d0563ee9bb8d71
https://github.com/avboag
avboaghttps://github.com/avboag
ericvsmithhttps://github.com/ericvsmith
code ownerhttps://github.com/python/cpython/blob/155577de1b6a7f4404b2bf90bcc1a588201550da/.github/CODEOWNERS#L148
June 20, 2023 10:13https://github.com/python/cpython/pull/105937#event-9577736999
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jun 20, 2023https://github.com/python/cpython/pull/105937#event-9577737398
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 20, 2023https://github.com/python/cpython/pull/105937#issuecomment-1598498845
require a NEWS entryhttps://devguide.python.org/committing/#updating-news-and-what-s-new-in-python
blurb_ithttps://blurb-it.herokuapp.com
blurbhttps://pypi.org/project/blurb/
Please reload this pagehttps://github.com/python/cpython/pull/105937
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 20, 2023 https://github.com/python/cpython/pull/105937#ref-issue-1765075985
dataclasses: frozen dataclasses with slots' __setattr__ and __delattr__ does not work. #105936 https://github.com/python/cpython/issues/105936
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/105937/commits/f74a8336300efd3bd4524bc8491941f5c7e4b3c5
f74a833https://github.com/python/cpython/pull/105937/commits/f74a8336300efd3bd4524bc8491941f5c7e4b3c5
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
Jan 5, 2024https://github.com/python/cpython/pull/105937#event-11398231064
https://github.com/Prometheus3375
Prometheus3375https://github.com/Prometheus3375
Jan 22, 2026 https://github.com/python/cpython/pull/105937#ref-pullrequest-3828096997
gh-105936: Properly update closure cells for __setattr__ and __delattr__ in frozen dataclasses with slots #144021 https://github.com/python/cpython/pull/144021
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Apr 13, 2026https://github.com/python/cpython/pull/105937#issuecomment-4233048126
#144021https://github.com/python/cpython/pull/144021
Please reload this pagehttps://github.com/python/cpython/pull/105937
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Apr 13, 2026https://github.com/python/cpython/pull/105937#event-24428057876
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105937
https://github.com/ericvsmith
ericvsmith https://github.com/ericvsmith
Please reload this pagehttps://github.com/python/cpython/pull/105937
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/105937
https://github.com/avboag
https://github.com/bedevere-bot
https://github.com/gpshead
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.