René's URL Explorer Experiment


Title: gh-105331: Fix asyncio.sleep() bug by weijay0804 · Pull Request #105641 · python/cpython · GitHub

Open Graph Title: gh-105331: Fix asyncio.sleep() bug by weijay0804 · Pull Request #105641 · python/cpython

X Title: gh-105331: Fix asyncio.sleep() bug by weijay0804 · Pull Request #105641 · python/cpython

Description: Issue: gh-105331: fix asyncio.sleep(float('nan')) does not raise ValueError

Open Graph Description: Issue: gh-105331: fix asyncio.sleep(float('nan')) does not raise ValueError

X Description: Issue: gh-105331: fix asyncio.sleep(float('nan')) does not raise ValueError

Opengraph URL: https://github.com/python/cpython/pull/105641

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:78e2fc42-bdf2-210f-5a90-ffe05a1b2bb7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id891C:3651F6:13A346D:19A6BB7:696B1A46
html-safe-nonce166ee8c7015fac2cf32ae9a89cb8801c7195d1bf4395bbde3b5094d596124bb8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTFDOjM2NTFGNjoxM0EzNDZEOjE5QTZCQjc6Njk2QjFBNDYiLCJ2aXNpdG9yX2lkIjoiNDM0NDc4NTU1OTczNzgwMTI4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1ab07246c7a82c8629bd9a77dbc907a02d4e6c9de59c188a9337d1d7a826e9f6
hovercard-subject-tagpull_request:1387458076
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/105641/files
twitter:imagehttps://avatars.githubusercontent.com/u/74105438?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/74105438?s=400&v=4
og:image:altIssue: gh-105331: fix asyncio.sleep(float('nan')) does not raise ValueError
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105641/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105641%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105641%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105641/files
Reloadhttps://github.com/python/cpython/pull/105641/files
Reloadhttps://github.com/python/cpython/pull/105641/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105641/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105641/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
weijay0804:fix-issue-105331https://github.com/weijay0804/cpython/tree/fix-issue-105331
Conversation 11 https://github.com/python/cpython/pull/105641
Commits 14 https://github.com/python/cpython/pull/105641/commits
Checks 0 https://github.com/python/cpython/pull/105641/checks
Files changed https://github.com/python/cpython/pull/105641/files
Please reload this pagehttps://github.com/python/cpython/pull/105641/files
gh-105331: Fix asyncio.sleep() bug https://github.com/python/cpython/pull/105641/files#top
Show all changes 14 commits https://github.com/python/cpython/pull/105641/files
f2008da gh-105331: Fix asyncio.sleep() bug weijay0804 Jun 11, 2023 https://github.com/python/cpython/pull/105641/commits/f2008da416ce82618b58ee72b42f405722e62be9
cb1492f 📜🤖 Added by blurb_it. blurb-it[bot] Jun 11, 2023 https://github.com/python/cpython/pull/105641/commits/cb1492fb1271b0484ba0eabcda8b97c23bf2a9e8
ca806d9 run make patchcheck to fix Azure Pipelines PR problem weijay0804 Jun 11, 2023 https://github.com/python/cpython/pull/105641/commits/ca806d984361fe388d47ebaf00ce051b78071c4f
588bbbd gh-105331: move import math to the toplevel weijay0804 Jun 11, 2023 https://github.com/python/cpython/pull/105641/commits/588bbbd8fa0006c060bece8468366d4e44782bf1
1c17886 gh-105331: Improve the content description of the error message weijay0804 Jun 11, 2023 https://github.com/python/cpython/pull/105641/commits/1c178868b8aeab22f18dcf1529bec1d63c8661ae
9bd7ced gh-105331: Improve description to more detailed weijay0804 Jun 11, 2023 https://github.com/python/cpython/pull/105641/commits/9bd7ced8253218635f0451620a3d395ddb7d5f7f
cc03137 gh-105331: Fix the indentation change weijay0804 Jun 12, 2023 https://github.com/python/cpython/pull/105641/commits/cc03137c460f117950600797ac69c6af182adfa1
4a08061 gh-105331: Add test for asyncio.sleep() delay is nan weijay0804 Jun 12, 2023 https://github.com/python/cpython/pull/105641/commits/4a08061f6b557a8a3ca81e9c20a5c4469544faee
11b9d7e gh-105331: Move check delay is nan section after delay <= 0 section weijay0804 Jun 12, 2023 https://github.com/python/cpython/pull/105641/commits/11b9d7e480547af8900f6728ab596135c997c24d
7c3f3eb gh-105331: Add description for versionchanged weijay0804 Jun 12, 2023 https://github.com/python/cpython/pull/105641/commits/7c3f3eb828647d5ad63946ada67c013ae5beeba4
730ee4e Update Misc/NEWS.d/next/Core and Builtins/2023-06-11-09-14-30.gh-issu… weijay0804 Jun 12, 2023 https://github.com/python/cpython/pull/105641/commits/730ee4e2254463ae4edd2f737a052876b189d808
49c55c6 minor tweaks kumaraditya303 Jun 12, 2023 https://github.com/python/cpython/pull/105641/commits/49c55c69a14375e4e90ee44933dad4b2bb220dd9
c1712ad refer to `nan` not `math.nan` kumaraditya303 Jun 12, 2023 https://github.com/python/cpython/pull/105641/commits/c1712ad15d329216b7c9355fee24ad26cfcbfa65
5c840c4 fix news kumaraditya303 Jun 12, 2023 https://github.com/python/cpython/pull/105641/commits/5c840c4e5d2af6bd0027f42565265c25d73f2c13
Clear filters https://github.com/python/cpython/pull/105641/files
Please reload this pagehttps://github.com/python/cpython/pull/105641/files
Please reload this pagehttps://github.com/python/cpython/pull/105641/files
asyncio-task.rst https://github.com/python/cpython/pull/105641/files#diff-5e9a5bb933b1bd1d6092f7e5adb5c06da7a6792e0597f55f911245acacfce7a7
tasks.py https://github.com/python/cpython/pull/105641/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
test_tasks.py https://github.com/python/cpython/pull/105641/files#diff-ef1c83c981ac721906ba3b05e123351be23dcfb59e92d0aeb6f4033db9cdd8c8
2023-06-11-09-14-30.gh-issue-105331.nlZvoW.rst https://github.com/python/cpython/pull/105641/files#diff-fdcd518173666fd428a977c3323b1535fa1af8c2e22dcf7b0ba872ffa9b96e97
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L367
Doc/library/asyncio-task.rsthttps://github.com/python/cpython/pull/105641/files#diff-5e9a5bb933b1bd1d6092f7e5adb5c06da7a6792e0597f55f911245acacfce7a7
View file https://github.com/weijay0804/cpython/blob/5c840c4e5d2af6bd0027f42565265c25d73f2c13/Doc/library/asyncio-task.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105641/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105641/files#diff-5e9a5bb933b1bd1d6092f7e5adb5c06da7a6792e0597f55f911245acacfce7a7
https://github.com/python/cpython/pull/105641/files#diff-5e9a5bb933b1bd1d6092f7e5adb5c06da7a6792e0597f55f911245acacfce7a7
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L369
Lib/asyncio/tasks.pyhttps://github.com/python/cpython/pull/105641/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
View file https://github.com/weijay0804/cpython/blob/5c840c4e5d2af6bd0027f42565265c25d73f2c13/Lib/asyncio/tasks.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105641/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105641/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
https://github.com/python/cpython/pull/105641/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
https://github.com/python/cpython/pull/105641/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
https://github.com/python/cpython/pull/105641/files#diff-429f4ed1e0f89ea2c92e2a8e8548ea8ae1a3d528979554fbfa4c38329e951529
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L370
Lib/test/test_asyncio/test_tasks.pyhttps://github.com/python/cpython/pull/105641/files#diff-ef1c83c981ac721906ba3b05e123351be23dcfb59e92d0aeb6f4033db9cdd8c8
View file https://github.com/weijay0804/cpython/blob/5c840c4e5d2af6bd0027f42565265c25d73f2c13/Lib/test/test_asyncio/test_tasks.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105641/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105641/files#diff-ef1c83c981ac721906ba3b05e123351be23dcfb59e92d0aeb6f4033db9cdd8c8
https://github.com/python/cpython/pull/105641/files#diff-ef1c83c981ac721906ba3b05e123351be23dcfb59e92d0aeb6f4033db9cdd8c8
Misc/NEWS.d/next/Core and Builtins/2023-06-11-09-14-30.gh-issue-105331.nlZvoW.rsthttps://github.com/python/cpython/pull/105641/files#diff-fdcd518173666fd428a977c3323b1535fa1af8c2e22dcf7b0ba872ffa9b96e97
View file https://github.com/weijay0804/cpython/blob/5c840c4e5d2af6bd0027f42565265c25d73f2c13/Misc/NEWS.d/next/Core%20and%20Builtins/2023-06-11-09-14-30.gh-issue-105331.nlZvoW.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105641/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.