René's URL Explorer Experiment


Title: gh-105766: Add Locking Around Custom Allocators by ericsnowcurrently · Pull Request #105619 · python/cpython · GitHub

Open Graph Title: gh-105766: Add Locking Around Custom Allocators by ericsnowcurrently · Pull Request #105619 · python/cpython

X Title: gh-105766: Add Locking Around Custom Allocators by ericsnowcurrently · Pull Request #105619 · python/cpython

Description: The "mem" and "object" allocators are documented as dependent on the GIL. However, after per-interpreter GIL landed we weren't enforcing that. This fixes that by using wrapping all allocations/fr...

Open Graph Description: The "mem" and "object" allocators are documented as dependent on the GIL. However, after per-interpreter GIL landed we weren't enforcing that. This fixes that by using wra...

X Description: The "mem" and "object" allocators are documented as dependent on the GIL. However, after per-interpreter GIL landed we weren't enforcing that. This fix...

Opengraph URL: https://github.com/python/cpython/pull/105619

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:acf4a5b8-8b76-ed86-0cd4-06ef1d838b53
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id864A:29B8E2:275D3EE:356CE71:696AE04A
html-safe-nonced45edf16435b6d909ef34f393cc2b8c7727201af8fb38ce1be7e0396f58e8182
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjRBOjI5QjhFMjoyNzVEM0VFOjM1NkNFNzE6Njk2QUUwNEEiLCJ2aXNpdG9yX2lkIjoiNjQxMjMxOTU2NDA0ODgxODI1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0389476146b7caf362b01aa249d4f7778e9297e1a11eddf0dc8f9579e62bc1aa
hovercard-subject-tagpull_request:1386896156
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/105619/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f9c64064f53904ab15ea12f19ae7332594ed5fd48d3a45a19979754b6917b2bb/python/cpython/pull/105619
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f9c64064f53904ab15ea12f19ae7332594ed5fd48d3a45a19979754b6917b2bb/python/cpython/pull/105619
og:image:altThe "mem" and "object" allocators are documented as dependent on the GIL. However, after per-interpreter GIL landed we weren't enforcing that. This fixes that by using wra...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3d84d50b3c75fa36755c3cf392edbc09e626f979
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105619#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105619
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105619
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105619
Reloadhttps://github.com/python/cpython/pull/105619
Reloadhttps://github.com/python/cpython/pull/105619
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105619
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105619
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/105619#issue-comment-box
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:lock-around-custom-allocatorshttps://github.com/ericsnowcurrently/cpython/tree/lock-around-custom-allocators
gh-105766: Add Locking Around Custom Allocators https://github.com/python/cpython/pull/105619#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:lock-around-custom-allocatorshttps://github.com/ericsnowcurrently/cpython/tree/lock-around-custom-allocators
Conversation 15 https://github.com/python/cpython/pull/105619
Commits 8 https://github.com/python/cpython/pull/105619/commits
Checks 0 https://github.com/python/cpython/pull/105619/checks
Files changed https://github.com/python/cpython/pull/105619/files
Please reload this pagehttps://github.com/python/cpython/pull/105619
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 10, 2023https://github.com/python/cpython/pull/105619#issue-1750673664
Please reload this pagehttps://github.com/python/cpython/pull/105619
"mem" and "object" Allocators are No Longer Protected by the GIL #105766https://github.com/python/cpython/issues/105766
Please reload this pagehttps://github.com/python/cpython/pull/105619
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
June 8, 2023 14:16https://github.com/python/cpython/pull/105619#commits-pushed-fcbeb6d
https://github.com/ericsnowcurrently
Add wrapper allocators with locking when needed.https://github.com/python/cpython/pull/105619/commits/fcbeb6daa91e64d583bb132e8ee4beed583e0e7e
fcbeb6dhttps://github.com/python/cpython/pull/105619/commits/fcbeb6daa91e64d583bb132e8ee4beed583e0e7e
https://github.com/ericsnowcurrently
Fix set_allocator_unlocked.https://github.com/python/cpython/pull/105619/commits/fbe26ebccf37a7f4175cbd253a9b64941de86105
fbe26ebhttps://github.com/python/cpython/pull/105619/commits/fbe26ebccf37a7f4175cbd253a9b64941de86105
https://github.com/ericsnowcurrently
Implement should_lock().https://github.com/python/cpython/pull/105619/commits/71916298ec746f53c8790f64d0f9e8c86ceb3679
7191629https://github.com/python/cpython/pull/105619/commits/71916298ec746f53c8790f64d0f9e8c86ceb3679
https://github.com/ericsnowcurrently
Implement acquire_custom_allocator_lock() and release_custom_allocato…https://github.com/python/cpython/pull/105619/commits/dd609899265a349b778c2b8c060022e7f5ff44b5
dd60989https://github.com/python/cpython/pull/105619/commits/dd609899265a349b778c2b8c060022e7f5ff44b5
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
markshannonhttps://github.com/markshannon
vstinnerhttps://github.com/vstinner
June 10, 2023 00:32https://github.com/python/cpython/pull/105619#event-9489150409
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 10, 2023 https://github.com/python/cpython/pull/105619#ref-issue-1495359092
Improve Interpreter Isolation #100227 https://github.com/python/cpython/issues/100227
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 10, 2023https://github.com/python/cpython/pull/105619#event-9489387113
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 12, 2023https://github.com/python/cpython/pull/105619#issuecomment-1587566809
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/105619
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jun 12, 2023https://github.com/python/cpython/pull/105619#issuecomment-1587598398
Please reload this pagehttps://github.com/python/cpython/pull/105619
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 12, 2023https://github.com/python/cpython/pull/105619#issuecomment-1587607561
Please reload this pagehttps://github.com/python/cpython/pull/105619
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
June 12, 2023 15:50https://github.com/python/cpython/pull/105619#event-9504488853
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 12, 2023https://github.com/python/cpython/pull/105619#event-9504489379
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jun 12, 2023https://github.com/python/cpython/pull/105619#issuecomment-1587613401
Please reload this pagehttps://github.com/python/cpython/pull/105619
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 12, 2023https://github.com/python/cpython/pull/105619#issuecomment-1587665738
Please reload this pagehttps://github.com/python/cpython/pull/105619
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 12, 2023https://github.com/python/cpython/pull/105619#issuecomment-1587700259
Please reload this pagehttps://github.com/python/cpython/pull/105619
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 14, 2023 https://github.com/python/cpython/pull/105619#ref-issue-1755875424
"mem" and "object" Allocators are No Longer Protected by the GIL #105766 https://github.com/python/cpython/issues/105766
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 14, 2023https://github.com/python/cpython/pull/105619#event-9522414484
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Jul 27, 2023 https://github.com/python/cpython/pull/105619#pullrequestreview-1548773134
View reviewed changes https://github.com/python/cpython/pull/105619/files/dd609899265a349b778c2b8c060022e7f5ff44b5
gpsheadhttps://github.com/gpshead
https://github.com/python/cpython/pull/105619#pullrequestreview-1548773134
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/105619
Python/pylifecycle.chttps://github.com/python/cpython/pull/105619/files/dd609899265a349b778c2b8c060022e7f5ff44b5#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
gpsheadhttps://github.com/gpshead
Jul 26, 2023https://github.com/python/cpython/pull/105619#discussion_r1275584846
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/105619
Python/pylifecycle.chttps://github.com/python/cpython/pull/105619/files/dd609899265a349b778c2b8c060022e7f5ff44b5#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
gpsheadhttps://github.com/gpshead
Jul 26, 2023https://github.com/python/cpython/pull/105619#discussion_r1275585695
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/105619
Include/internal/pycore_pymem.hhttps://github.com/python/cpython/pull/105619/files/dd609899265a349b778c2b8c060022e7f5ff44b5#diff-f43c977e1d9084d42f494114fd29faf9312b850ffefcebb64396214024f19377
gpsheadhttps://github.com/gpshead
Jul 26, 2023https://github.com/python/cpython/pull/105619#discussion_r1275586307
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/105619
Objects/obmalloc.chttps://github.com/python/cpython/pull/105619/files/dd609899265a349b778c2b8c060022e7f5ff44b5#diff-399a22135f328b4e42b0722ef216587945eedf2d8c103a584a3dca5b30650329
gpsheadhttps://github.com/gpshead
Jul 27, 2023https://github.com/python/cpython/pull/105619#discussion_r1275591822
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/105619
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jul 27, 2023https://github.com/python/cpython/pull/105619#discussion_r1276810466
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/105619
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 27, 2023https://github.com/python/cpython/pull/105619#event-9929863729
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jul 27, 2023https://github.com/python/cpython/pull/105619#issuecomment-1652706034
Please reload this pagehttps://github.com/python/cpython/pull/105619
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Jul 27, 2023https://github.com/python/cpython/pull/105619#event-9929863794
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Jul 27, 2023https://github.com/python/cpython/pull/105619#issuecomment-1652711362
https://discuss.python.org/t/what-to-do-about-custom-allocators-and-the-gil/30327https://discuss.python.org/t/what-to-do-about-custom-allocators-and-the-gil/30327
Please reload this pagehttps://github.com/python/cpython/pull/105619
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
July 27, 2023 14:21https://github.com/python/cpython/pull/105619#commits-pushed-0f2a242
https://github.com/ericsnowcurrently
Merge branch 'main' into lock-around-custom-allocatorshttps://github.com/python/cpython/pull/105619/commits/0f2a24229b51476e61bff3cc2d4f28d4eab38ccc
0f2a242https://github.com/python/cpython/pull/105619/commits/0f2a24229b51476e61bff3cc2d4f28d4eab38ccc
https://github.com/ericsnowcurrently
Check for overflow/underflow.https://github.com/python/cpython/pull/105619/commits/321d1c2efa0f09f98e8837d3d97f459e5c2bb23d
321d1c2https://github.com/python/cpython/pull/105619/commits/321d1c2efa0f09f98e8837d3d97f459e5c2bb23d
https://github.com/ericsnowcurrently
Use an unsigned int.https://github.com/python/cpython/pull/105619/commits/52c01ea5f04c7e0efc852cb8df9da929a1074bfe
52c01eahttps://github.com/python/cpython/pull/105619/commits/52c01ea5f04c7e0efc852cb8df9da929a1074bfe
https://github.com/ericsnowcurrently
Only modify num_gils if the interpreter has its own GIL.https://github.com/python/cpython/pull/105619/commits/a2135973fd0bab33c73c546cf87785892956300f
a213597https://github.com/python/cpython/pull/105619/commits/a2135973fd0bab33c73c546cf87785892956300f
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jul 28, 2023https://github.com/python/cpython/pull/105619#issuecomment-1656117643
Please reload this pagehttps://github.com/python/cpython/pull/105619
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jul 28, 2023https://github.com/python/cpython/pull/105619#event-9950856970
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105619
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/105619/files/dd609899265a349b778c2b8c060022e7f5ff44b5
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/markshannon
markshannon https://github.com/markshannon
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/105619
https://github.com/ericsnowcurrently
https://github.com/markshannon
https://github.com/bedevere-bot
https://github.com/gpshead
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.