René's URL Explorer Experiment


Title: gh-105375: Improve error handling in the sys extension module by erlend-aasland · Pull Request #105611 · python/cpython · GitHub

Open Graph Title: gh-105375: Improve error handling in the sys extension module by erlend-aasland · Pull Request #105611 · python/cpython

X Title: gh-105375: Improve error handling in the sys extension module by erlend-aasland · Pull Request #105611 · python/cpython

Description: Bail on first error to prevent exceptions from possibly being overwritten. Issue: Incorrect error handling for APIs that can raise exceptions #105375

Open Graph Description: Bail on first error to prevent exceptions from possibly being overwritten. Issue: Incorrect error handling for APIs that can raise exceptions #105375

X Description: Bail on first error to prevent exceptions from possibly being overwritten. Issue: Incorrect error handling for APIs that can raise exceptions #105375

Opengraph URL: https://github.com/python/cpython/pull/105611

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0d22ec70-2ba9-89ed-b475-c4d389e1dcf8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C76:1672C1:11D107B:173E3F9:696B12C9
html-safe-noncee3d82448e9395f2bce805bf4274e3dc08a56cbb1e64290bffaf9137d495c951b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Qzc2OjE2NzJDMToxMUQxMDdCOjE3M0UzRjk6Njk2QjEyQzkiLCJ2aXNpdG9yX2lkIjoiMjE1MjkxMDQ1NjkxMTIzNzgzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac26062bfdd0256831962a5af6cbc0deedec084b794f7d89a6183bf0171c9599f8
hovercard-subject-tagpull_request:1386766336
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/105611/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e6bd60a2fca211ef16036a876d1c577132050a4eabda25dc8481196fac03ef07/python/cpython/pull/105611
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e6bd60a2fca211ef16036a876d1c577132050a4eabda25dc8481196fac03ef07/python/cpython/pull/105611
og:image:altBail on first error to prevent exceptions from possibly being overwritten. Issue: Incorrect error handling for APIs that can raise exceptions #105375
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105611#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105611
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105611
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105611
Reloadhttps://github.com/python/cpython/pull/105611
Reloadhttps://github.com/python/cpython/pull/105611
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105611
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105611
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/105611#issue-comment-box
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:improve-sysmodule-error-handlinghttps://github.com/erlend-aasland/cpython/tree/improve-sysmodule-error-handling
gh-105375: Improve error handling in the sys extension module https://github.com/python/cpython/pull/105611#top
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:improve-sysmodule-error-handlinghttps://github.com/erlend-aasland/cpython/tree/improve-sysmodule-error-handling
Conversation 11 https://github.com/python/cpython/pull/105611
Commits 2 https://github.com/python/cpython/pull/105611/commits
Checks 0 https://github.com/python/cpython/pull/105611/checks
Files changed https://github.com/python/cpython/pull/105611/files
Please reload this pagehttps://github.com/python/cpython/pull/105611
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 9, 2023https://github.com/python/cpython/pull/105611#issue-1750530108
Please reload this pagehttps://github.com/python/cpython/pull/105611
Incorrect error handling for APIs that can raise exceptions #105375https://github.com/python/cpython/issues/105375
Please reload this pagehttps://github.com/python/cpython/pull/105611
https://github.com/erlend-aasland
pythongh-105375https://github.com/python/cpython/issues/105375
: Improve error handling in the sys extension modulehttps://github.com/python/cpython/pull/105611/commits/02cac21a5eae31dee44361932458537ebf28a52a
02cac21https://github.com/python/cpython/pull/105611/commits/02cac21a5eae31dee44361932458537ebf28a52a
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 9, 2023https://github.com/python/cpython/pull/105611#event-9488411074
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 9, 2023https://github.com/python/cpython/pull/105611#event-9488411322
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 9, 2023 https://github.com/python/cpython/pull/105611#ref-issue-1743883856
Incorrect error handling for APIs that can raise exceptions #105375 https://github.com/python/cpython/issues/105375
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
🔨 test-with-refleak-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-refleak-buildbots%22
Jun 11, 2023https://github.com/python/cpython/pull/105611#event-9493609332
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 11, 2023https://github.com/python/cpython/pull/105611#issuecomment-1586110520
@erlend-aaslandhttps://github.com/erlend-aasland
02cac21https://github.com/python/cpython/commit/02cac21a5eae31dee44361932458537ebf28a52a
Please reload this pagehttps://github.com/python/cpython/pull/105611
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-refleak-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-refleak-buildbots%22
Jun 11, 2023https://github.com/python/cpython/pull/105611#event-9493609434
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
sobolevnhttps://github.com/sobolevn
June 11, 2023 10:41https://github.com/python/cpython/pull/105611#event-9493610042
https://github.com/erlend-aasland
Merge branch 'main' into improve-sysmodule-error-handlinghttps://github.com/python/cpython/pull/105611/commits/56280c55b083a1419dab6b62ac96f76a07a39aa5
56280c5https://github.com/python/cpython/pull/105611/commits/56280c55b083a1419dab6b62ac96f76a07a39aa5
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
June 11, 2023 19:38https://github.com/python/cpython/pull/105611#event-9495322077
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
June 11, 2023 19:38https://github.com/python/cpython/pull/105611#event-9495322882
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
June 11, 2023 19:39https://github.com/python/cpython/pull/105611#event-9495324627
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
41cddc2https://github.com/python/cpython/commit/41cddc2e93a285b81fa30ac542b088bd9d0112e9
Jun 11, 2023https://github.com/python/cpython/pull/105611#event-9495401684
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jun 11, 2023https://github.com/python/cpython/pull/105611#issuecomment-1586321410
@erlend-aaslandhttps://github.com/erlend-aasland
Please reload this pagehttps://github.com/python/cpython/pull/105611
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 11, 2023https://github.com/python/cpython/pull/105611#event-9495401982
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jun 11, 2023https://github.com/python/cpython/pull/105611#issuecomment-1586321422
@erlend-aaslandhttps://github.com/erlend-aasland
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/105611
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
erlend-aaslandhttps://github.com/erlend-aasland
Jun 11, 2023https://github.com/python/cpython/pull/105611#event-9495402437
miss-islingtonhttps://github.com/miss-islington
Jun 11, 2023 https://github.com/python/cpython/pull/105611#ref-commit-753d979
https://github.com/erlend-aasland
https://github.com/miss-islington
pythongh-105375https://github.com/python/cpython/issues/105375
: Improve error handling in the sys extension module (https://github.com/miss-islington/cpython/commit/753d979a533a0ef381da55d1cc0aac95a33ba317
p…https://github.com/python/cpython/pull/105611
753d979https://github.com/miss-islington/cpython/commit/753d979a533a0ef381da55d1cc0aac95a33ba317
…ythonGH-105611https://github.com/python/cpython/pull/105611
41cddc2https://github.com/miss-islington/cpython/commit/41cddc2e93a285b81fa30ac542b088bd9d0112e9
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 11, 2023https://github.com/python/cpython/pull/105611#issuecomment-1586321475
GH-105665https://github.com/python/cpython/pull/105665
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/105611
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 11, 2023https://github.com/python/cpython/pull/105611#event-9495403127
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
June 11, 2023 20:05https://github.com/python/cpython/pull/105611#event-9495410874
erlend-aaslandhttps://github.com/erlend-aasland
Jun 11, 2023 https://github.com/python/cpython/pull/105611#ref-commit-3d5eb67
https://github.com/erlend-aasland
[3.11]https://github.com/erlend-aasland/cpython/commit/3d5eb673cdafc7f98462af631ebb217d0b8f669d
pythongh-105375https://github.com/python/cpython/issues/105375
: Improve error handling in the sys extension m…https://github.com/erlend-aasland/cpython/commit/3d5eb673cdafc7f98462af631ebb217d0b8f669d
3d5eb67https://github.com/erlend-aasland/cpython/commit/3d5eb673cdafc7f98462af631ebb217d0b8f669d
python#105611https://github.com/python/cpython/pull/105611
41cddc2https://github.com/erlend-aasland/cpython/commit/41cddc2e93a285b81fa30ac542b088bd9d0112e9
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 11, 2023https://github.com/python/cpython/pull/105611#issuecomment-1586323824
GH-105666https://github.com/python/cpython/pull/105666
3.11 branchhttps://github.com/python/cpython/tree/3.11
Please reload this pagehttps://github.com/python/cpython/pull/105611
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Jun 11, 2023https://github.com/python/cpython/pull/105611#event-9495427927
erlend-aaslandhttps://github.com/erlend-aasland
Jun 11, 2023 https://github.com/python/cpython/pull/105611#ref-commit-f98d475
https://github.com/erlend-aasland
[3.11]https://github.com/python/cpython/commit/f98d475ee311268b28a9fc598a4efd22696d1208
gh-105375https://github.com/python/cpython/issues/105375
: Improve error handling in the sys extension module (https://github.com/python/cpython/commit/f98d475ee311268b28a9fc598a4efd22696d1208
#…https://github.com/python/cpython/pull/105611
f98d475https://github.com/python/cpython/commit/f98d475ee311268b28a9fc598a4efd22696d1208
…105611https://github.com/python/cpython/pull/105611
#105666https://github.com/python/cpython/pull/105666
41cddc2https://github.com/python/cpython/commit/41cddc2e93a285b81fa30ac542b088bd9d0112e9
erlend-aaslandhttps://github.com/erlend-aasland
Jun 11, 2023 https://github.com/python/cpython/pull/105611#ref-commit-a1034b5
https://github.com/miss-islington
https://github.com/erlend-aasland
[3.12]https://github.com/python/cpython/commit/a1034b5fd3af59d813452742153e60b40b39ff4a
gh-105375https://github.com/python/cpython/issues/105375
: Improve error handling in the sys extension module (https://github.com/python/cpython/commit/a1034b5fd3af59d813452742153e60b40b39ff4a
G…https://github.com/python/cpython/pull/105611
a1034b5https://github.com/python/cpython/commit/a1034b5fd3af59d813452742153e60b40b39ff4a
…H-105611https://github.com/python/cpython/pull/105611
#105665https://github.com/python/cpython/pull/105665
41cddc2https://github.com/python/cpython/commit/41cddc2e93a285b81fa30ac542b088bd9d0112e9
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jun 12, 2023 https://github.com/python/cpython/pull/105611#pullrequestreview-1474284538
View reviewed changes https://github.com/python/cpython/pull/105611/files/56280c55b083a1419dab6b62ac96f76a07a39aa5
Python/sysmodule.chttps://github.com/python/cpython/pull/105611/files/56280c55b083a1419dab6b62ac96f76a07a39aa5#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
Please reload this pagehttps://github.com/python/cpython/pull/105611
Python/sysmodule.chttps://github.com/python/cpython/pull/105611/files/56280c55b083a1419dab6b62ac96f76a07a39aa5#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
Please reload this pagehttps://github.com/python/cpython/pull/105611
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Jun 12, 2023 https://github.com/python/cpython/pull/105611#ref-pullrequest-1752189853
gh-105673: Fix uninitialized warning in sysmodule.c #105674 https://github.com/python/cpython/pull/105674
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105611
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/105611/files/56280c55b083a1419dab6b62ac96f76a07a39aa5
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/erlend-aasland
erlend-aasland https://github.com/erlend-aasland
Please reload this pagehttps://github.com/python/cpython/pull/105611
https://github.com/erlend-aasland
https://github.com/bedevere-bot
https://github.com/miss-islington
https://github.com/serhiy-storchaka
https://github.com/sobolevn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.