René's URL Explorer Experiment


Title: gh-105375: Harden error handling in `_testcapi/heaptype.c` by erlend-aasland · Pull Request #105608 · python/cpython · GitHub

Open Graph Title: gh-105375: Harden error handling in `_testcapi/heaptype.c` by erlend-aasland · Pull Request #105608 · python/cpython

X Title: gh-105375: Harden error handling in `_testcapi/heaptype.c` by erlend-aasland · Pull Request #105608 · python/cpython

Description: Bail on first error in heapctypesubclasswithfinalizer_finalize() Issue: Incorrect error handling for APIs that can raise exceptions #105375

Open Graph Description: Bail on first error in heapctypesubclasswithfinalizer_finalize() Issue: Incorrect error handling for APIs that can raise exceptions #105375

X Description: Bail on first error in heapctypesubclasswithfinalizer_finalize() Issue: Incorrect error handling for APIs that can raise exceptions #105375

Opengraph URL: https://github.com/python/cpython/pull/105608

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f5fc6c0e-4280-191e-e842-d94ba10f77b6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id93F8:8D142:242C04B:2F82E57:696B1232
html-safe-nonce611b6d432c72bb41bf46ee0d75984980c18cd5e2f77b3177722b3bba08a5802c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0Y4OjhEMTQyOjI0MkMwNEI6MkY4MkU1Nzo2OTZCMTIzMiIsInZpc2l0b3JfaWQiOiI2MDkwMjA5OTE0NjM1NjIwOTE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac31a363b4b9198029ebca1be643b5925922bd3e0d673807c3080be95d7a5cef57
hovercard-subject-tagpull_request:1386744695
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/105608/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d16c4eba55ed4851e31434460b626b259ad35e99779c59a2a0b8b7f1178986fa/python/cpython/pull/105608
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d16c4eba55ed4851e31434460b626b259ad35e99779c59a2a0b8b7f1178986fa/python/cpython/pull/105608
og:image:altBail on first error in heapctypesubclasswithfinalizer_finalize() Issue: Incorrect error handling for APIs that can raise exceptions #105375
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105608#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105608
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105608
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105608
Reloadhttps://github.com/python/cpython/pull/105608
Reloadhttps://github.com/python/cpython/pull/105608
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105608
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105608
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/105608#issue-comment-box
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:improve-testcapi-error-handlinghttps://github.com/erlend-aasland/cpython/tree/improve-testcapi-error-handling
gh-105375: Harden error handling in _testcapi/heaptype.c https://github.com/python/cpython/pull/105608#top
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:improve-testcapi-error-handlinghttps://github.com/erlend-aasland/cpython/tree/improve-testcapi-error-handling
Conversation 3 https://github.com/python/cpython/pull/105608
Commits 1 https://github.com/python/cpython/pull/105608/commits
Checks 0 https://github.com/python/cpython/pull/105608/checks
Files changed https://github.com/python/cpython/pull/105608/files
Please reload this pagehttps://github.com/python/cpython/pull/105608
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 9, 2023https://github.com/python/cpython/pull/105608#issue-1750506250
Please reload this pagehttps://github.com/python/cpython/pull/105608
Incorrect error handling for APIs that can raise exceptions #105375https://github.com/python/cpython/issues/105375
Please reload this pagehttps://github.com/python/cpython/pull/105608
https://github.com/erlend-aasland
pythongh-105375https://github.com/python/cpython/issues/105375
: Fix error handling in testcapi heaptype testhttps://github.com/python/cpython/pull/105608/commits/f134dab9a5f5ec5a697bae8fa2bc7113aa65f4d0
f134dabhttps://github.com/python/cpython/pull/105608/commits/f134dab9a5f5ec5a697bae8fa2bc7113aa65f4d0
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 9, 2023https://github.com/python/cpython/pull/105608#event-9488269226
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 9, 2023https://github.com/python/cpython/pull/105608#event-9488269346
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 9, 2023 https://github.com/python/cpython/pull/105608#ref-issue-1743883856
Incorrect error handling for APIs that can raise exceptions #105375 https://github.com/python/cpython/issues/105375
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 9, 2023https://github.com/python/cpython/pull/105608#issuecomment-1585143284
Please reload this pagehttps://github.com/python/cpython/pull/105608
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 9, 2023https://github.com/python/cpython/pull/105608#event-9488291571
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
June 9, 2023 21:26https://github.com/python/cpython/pull/105608#event-9488292924
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
d636d7dhttps://github.com/python/cpython/commit/d636d7dfe714e7168b342c7ea5f9f9d3b3569ed0
Jun 9, 2023https://github.com/python/cpython/pull/105608#event-9488450164
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jun 9, 2023https://github.com/python/cpython/pull/105608#issuecomment-1585166888
@erlend-aaslandhttps://github.com/erlend-aasland
Please reload this pagehttps://github.com/python/cpython/pull/105608
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 9, 2023https://github.com/python/cpython/pull/105608#event-9488450360
miss-islingtonhttps://github.com/miss-islington
Jun 9, 2023 https://github.com/python/cpython/pull/105608#ref-commit-3b776e8
https://github.com/erlend-aasland
https://github.com/miss-islington
pythongh-105375https://github.com/python/cpython/issues/105375
: Harden error handling inhttps://github.com/miss-islington/cpython/commit/3b776e86eefb7453d992c6886c53215d4ca54319
_testcapi/heaptype.chttps://github.com/miss-islington/cpython/commit/3b776e86eefb7453d992c6886c53215d4ca54319
(https://github.com/miss-islington/cpython/commit/3b776e86eefb7453d992c6886c53215d4ca54319
pyt…https://github.com/python/cpython/pull/105608
3b776e8https://github.com/miss-islington/cpython/commit/3b776e86eefb7453d992c6886c53215d4ca54319
…honGH-105608https://github.com/python/cpython/pull/105608
d636d7dhttps://github.com/miss-islington/cpython/commit/d636d7dfe714e7168b342c7ea5f9f9d3b3569ed0
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 9, 2023https://github.com/python/cpython/pull/105608#issuecomment-1585167008
GH-105615https://github.com/python/cpython/pull/105615
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/105608
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 9, 2023https://github.com/python/cpython/pull/105608#event-9488451164
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
June 9, 2023 21:54https://github.com/python/cpython/pull/105608#event-9488452269
erlend-aaslandhttps://github.com/erlend-aasland
Jun 9, 2023 https://github.com/python/cpython/pull/105608#ref-commit-4fbbf69
https://github.com/miss-islington
https://github.com/erlend-aasland
[3.12]https://github.com/python/cpython/commit/4fbbf699c0d72f6db62484c88a05c826c3703eb5
gh-105375https://github.com/python/cpython/issues/105375
: Harden error handling inhttps://github.com/python/cpython/commit/4fbbf699c0d72f6db62484c88a05c826c3703eb5
_testcapi/heaptype.chttps://github.com/python/cpython/commit/4fbbf699c0d72f6db62484c88a05c826c3703eb5
(https://github.com/python/cpython/commit/4fbbf699c0d72f6db62484c88a05c826c3703eb5
GH…https://github.com/python/cpython/pull/105608
4fbbf69https://github.com/python/cpython/commit/4fbbf699c0d72f6db62484c88a05c826c3703eb5
…-105608https://github.com/python/cpython/pull/105608
#105615https://github.com/python/cpython/pull/105615
d636d7dhttps://github.com/python/cpython/commit/d636d7dfe714e7168b342c7ea5f9f9d3b3569ed0
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 11, 2023https://github.com/python/cpython/pull/105608#event-9495299147
Incorrect error handling for APIs that can raise exceptions #105375 https://github.com/python/cpython/issues/105375
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105608
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Incorrect error handling for APIs that can raise exceptions https://github.com/python/cpython/issues/105375
Please reload this pagehttps://github.com/python/cpython/pull/105608
https://github.com/erlend-aasland
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.