René's URL Explorer Experiment


Title: gh-105375: Improve _decimal error handling by erlend-aasland · Pull Request #105605 · python/cpython · GitHub

Open Graph Title: gh-105375: Improve _decimal error handling by erlend-aasland · Pull Request #105605 · python/cpython

X Title: gh-105375: Improve _decimal error handling by erlend-aasland · Pull Request #105605 · python/cpython

Description: Fix a bug where an exception could end up being overwritten. Issue: Incorrect error handling for APIs that can raise exceptions #105375

Open Graph Description: Fix a bug where an exception could end up being overwritten. Issue: Incorrect error handling for APIs that can raise exceptions #105375

X Description: Fix a bug where an exception could end up being overwritten. Issue: Incorrect error handling for APIs that can raise exceptions #105375

Opengraph URL: https://github.com/python/cpython/pull/105605

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5fe08386-60fa-9b9d-1539-7117d0807cab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9132:1B7E6F:239B703:30BF305:696AC131
html-safe-nonce421b04887abb185a8df1a2f1512c10c25b396faf2df42437763fc5ef53f9d563
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTMyOjFCN0U2RjoyMzlCNzAzOjMwQkYzMDU6Njk2QUMxMzEiLCJ2aXNpdG9yX2lkIjoiODMzMDg4ODcyNjU1MTY0MjQxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac31efc6d17521f31ed68d0f5d03eae773e70d7e1bc73cec4ec9d63c500fb8590f
hovercard-subject-tagpull_request:1386721801
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/105605/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a0ebf454eed3c0e783053c20d6d6b950f5180f697f5c07a0432e5946c2e8a57d/python/cpython/pull/105605
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a0ebf454eed3c0e783053c20d6d6b950f5180f697f5c07a0432e5946c2e8a57d/python/cpython/pull/105605
og:image:altFix a bug where an exception could end up being overwritten. Issue: Incorrect error handling for APIs that can raise exceptions #105375
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None986b6a1d774985095564e64d6963d11f094da3d0e2bfda2ab1a27d63662eb033
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release89ad2112b9c4e11df6a0c13c8c1f8eedd36b0977
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105605#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105605
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105605
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105605
Reloadhttps://github.com/python/cpython/pull/105605
Reloadhttps://github.com/python/cpython/pull/105605
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105605
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105605
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/105605#issue-comment-box
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:improve-decimal-error-handlinghttps://github.com/erlend-aasland/cpython/tree/improve-decimal-error-handling
gh-105375: Improve _decimal error handling https://github.com/python/cpython/pull/105605#top
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:improve-decimal-error-handlinghttps://github.com/erlend-aasland/cpython/tree/improve-decimal-error-handling
Conversation 3 https://github.com/python/cpython/pull/105605
Commits 2 https://github.com/python/cpython/pull/105605/commits
Checks 0 https://github.com/python/cpython/pull/105605/checks
Files changed https://github.com/python/cpython/pull/105605/files
Please reload this pagehttps://github.com/python/cpython/pull/105605
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 9, 2023https://github.com/python/cpython/pull/105605#issue-1750480986
Please reload this pagehttps://github.com/python/cpython/pull/105605
Incorrect error handling for APIs that can raise exceptions #105375https://github.com/python/cpython/issues/105375
Please reload this pagehttps://github.com/python/cpython/pull/105605
https://github.com/erlend-aasland
pythongh-105375https://github.com/python/cpython/issues/105375
: Improve _decimal error handlinghttps://github.com/python/cpython/pull/105605/commits/6daf015c749ed9825ed0665b6fc8890d824f452a
6daf015https://github.com/python/cpython/pull/105605/commits/6daf015c749ed9825ed0665b6fc8890d824f452a
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
rhettingerhttps://github.com/rhettinger
code ownerhttps://github.com/python/cpython/blob/b047fa5e56ba725362c64ca3d6fccbdcf51d0cab/.github/CODEOWNERS#L146
June 9, 2023 20:54https://github.com/python/cpython/pull/105605#event-9488109382
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 9, 2023https://github.com/python/cpython/pull/105605#event-9488109411
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
sobolevnhttps://github.com/sobolevn
June 9, 2023 20:54https://github.com/python/cpython/pull/105605#event-9488109591
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 9, 2023https://github.com/python/cpython/pull/105605#event-9488109687
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 9, 2023 https://github.com/python/cpython/pull/105605#ref-issue-1743883856
Incorrect error handling for APIs that can raise exceptions #105375 https://github.com/python/cpython/issues/105375
erlend-aaslandhttps://github.com/erlend-aasland
Jun 9, 2023 https://github.com/python/cpython/pull/105605#ref-commit-d6cf426
https://github.com/erlend-aasland
pythongh-105605https://github.com/python/cpython/pull/105605
: Harden pyexpat initialisationhttps://github.com/erlend-aasland/cpython/commit/d6cf4261e655eefbc31213ca577c3a9cc9043735
d6cf426https://github.com/erlend-aasland/cpython/commit/d6cf4261e655eefbc31213ca577c3a9cc9043735
https://github.com/erlend-aasland
Merge branch 'main' into improve-decimal-error-handlinghttps://github.com/python/cpython/pull/105605/commits/aed383820850d2003e2bd345d55501776a7da80e
aed3838https://github.com/python/cpython/pull/105605/commits/aed383820850d2003e2bd345d55501776a7da80e
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Jun 10, 2023 https://github.com/python/cpython/pull/105605#pullrequestreview-1473324634
View reviewed changes https://github.com/python/cpython/pull/105605/files/aed383820850d2003e2bd345d55501776a7da80e
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
June 10, 2023 21:01https://github.com/python/cpython/pull/105605#event-9491681903
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
c932f72https://github.com/python/cpython/commit/c932f7284977ebf813313157c52d716ba225a7ac
Jun 11, 2023https://github.com/python/cpython/pull/105605#event-9493496458
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jun 11, 2023https://github.com/python/cpython/pull/105605#issuecomment-1586099383
@erlend-aaslandhttps://github.com/erlend-aasland
Please reload this pagehttps://github.com/python/cpython/pull/105605
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 11, 2023https://github.com/python/cpython/pull/105605#event-9493496681
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
June 11, 2023 10:06https://github.com/python/cpython/pull/105605#event-9493496935
miss-islingtonhttps://github.com/miss-islington
Jun 11, 2023 https://github.com/python/cpython/pull/105605#ref-commit-68b82ba
https://github.com/erlend-aasland
https://github.com/miss-islington
pythongh-105375https://github.com/python/cpython/issues/105375
: Improve _decimal error handling (https://github.com/miss-islington/cpython/commit/68b82ba369d3f09c8acd6a54f204af838ec510bc
pythonGH-105605https://github.com/python/cpython/pull/105605
)https://github.com/miss-islington/cpython/commit/68b82ba369d3f09c8acd6a54f204af838ec510bc
68b82bahttps://github.com/miss-islington/cpython/commit/68b82ba369d3f09c8acd6a54f204af838ec510bc
c932f72https://github.com/miss-islington/cpython/commit/c932f7284977ebf813313157c52d716ba225a7ac
miss-islingtonhttps://github.com/miss-islington
Jun 11, 2023 https://github.com/python/cpython/pull/105605#ref-commit-e25225f
https://github.com/erlend-aasland
https://github.com/miss-islington
pythongh-105375https://github.com/python/cpython/issues/105375
: Improve _decimal error handling (https://github.com/miss-islington/cpython/commit/e25225f2d3a21c3c259d3621815b1473da4b5944
pythonGH-105605https://github.com/python/cpython/pull/105605
)https://github.com/miss-islington/cpython/commit/e25225f2d3a21c3c259d3621815b1473da4b5944
e25225fhttps://github.com/miss-islington/cpython/commit/e25225f2d3a21c3c259d3621815b1473da4b5944
c932f72https://github.com/miss-islington/cpython/commit/c932f7284977ebf813313157c52d716ba225a7ac
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 11, 2023https://github.com/python/cpython/pull/105605#issuecomment-1586099457
GH-105647https://github.com/python/cpython/pull/105647
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/105605
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 11, 2023https://github.com/python/cpython/pull/105605#event-9493497168
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 11, 2023https://github.com/python/cpython/pull/105605#issuecomment-1586099467
GH-105648https://github.com/python/cpython/pull/105648
3.11 branchhttps://github.com/python/cpython/tree/3.11
Please reload this pagehttps://github.com/python/cpython/pull/105605
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Jun 11, 2023https://github.com/python/cpython/pull/105605#event-9493497252
erlend-aaslandhttps://github.com/erlend-aasland
Jun 11, 2023 https://github.com/python/cpython/pull/105605#ref-commit-b4b5565
https://github.com/miss-islington
https://github.com/erlend-aasland
[3.12]https://github.com/python/cpython/commit/b4b5565e4779d81c943bffe22ffe0972fa398702
gh-105375https://github.com/python/cpython/issues/105375
: Improve _decimal error handling (https://github.com/python/cpython/commit/b4b5565e4779d81c943bffe22ffe0972fa398702
GH-105605https://github.com/python/cpython/pull/105605
) (https://github.com/python/cpython/commit/b4b5565e4779d81c943bffe22ffe0972fa398702
#105647https://github.com/python/cpython/pull/105647
)https://github.com/python/cpython/commit/b4b5565e4779d81c943bffe22ffe0972fa398702
b4b5565https://github.com/python/cpython/commit/b4b5565e4779d81c943bffe22ffe0972fa398702
c932f72https://github.com/python/cpython/commit/c932f7284977ebf813313157c52d716ba225a7ac
erlend-aaslandhttps://github.com/erlend-aasland
Jun 11, 2023 https://github.com/python/cpython/pull/105605#ref-commit-cb26faf
https://github.com/miss-islington
https://github.com/erlend-aasland
[3.11]https://github.com/python/cpython/commit/cb26fafdcc2814c7ac5c080d330970c7971fff3e
gh-105375https://github.com/python/cpython/issues/105375
: Improve _decimal error handling (https://github.com/python/cpython/commit/cb26fafdcc2814c7ac5c080d330970c7971fff3e
GH-105605https://github.com/python/cpython/pull/105605
) (https://github.com/python/cpython/commit/cb26fafdcc2814c7ac5c080d330970c7971fff3e
#105648https://github.com/python/cpython/pull/105648
)https://github.com/python/cpython/commit/cb26fafdcc2814c7ac5c080d330970c7971fff3e
cb26fafhttps://github.com/python/cpython/commit/cb26fafdcc2814c7ac5c080d330970c7971fff3e
c932f72https://github.com/python/cpython/commit/c932f7284977ebf813313157c52d716ba225a7ac
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 11, 2023https://github.com/python/cpython/pull/105605#event-9495299126
Incorrect error handling for APIs that can raise exceptions #105375 https://github.com/python/cpython/issues/105375
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105605
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/python/cpython/pull/105605/files/aed383820850d2003e2bd345d55501776a7da80e
Incorrect error handling for APIs that can raise exceptions https://github.com/python/cpython/issues/105375
Please reload this pagehttps://github.com/python/cpython/pull/105605
https://github.com/erlend-aasland
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/sobolevn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.