René's URL Explorer Experiment


Title: gh-105375: Improve error handling in _ctypes by erlend-aasland · Pull Request #105593 · python/cpython · GitHub

Open Graph Title: gh-105375: Improve error handling in _ctypes by erlend-aasland · Pull Request #105593 · python/cpython

X Title: gh-105375: Improve error handling in _ctypes by erlend-aasland · Pull Request #105593 · python/cpython

Description: Prevent repeated PyLong_FromVoidPtr() from possibly overwriting the current exception. Issue: Incorrect error handling for APIs that can raise exceptions #105375

Open Graph Description: Prevent repeated PyLong_FromVoidPtr() from possibly overwriting the current exception. Issue: Incorrect error handling for APIs that can raise exceptions #105375

X Description: Prevent repeated PyLong_FromVoidPtr() from possibly overwriting the current exception. Issue: Incorrect error handling for APIs that can raise exceptions #105375

Opengraph URL: https://github.com/python/cpython/pull/105593

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f7ed471c-f8c2-b2b7-15cd-e21e3f9e3092
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC112:320F8E:1E3AADE:293593D:696AC067
html-safe-nonce7d10fba506f93247bf32f788a88146413f89729effcc2e3f672899aedf039c49
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTEyOjMyMEY4RToxRTNBQURFOjI5MzU5M0Q6Njk2QUMwNjciLCJ2aXNpdG9yX2lkIjoiMzMwMzM3OTA5NzEwNTM4MzUyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac21d9ccc94137b25a20c6351ab29b183a15cb0803b94b5618e25bc9060727019e
hovercard-subject-tagpull_request:1386660337
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/105593/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dd8da3694a59355392a94b4ee83d7a5a466ef343c2e45dce59e5aac9df334842/python/cpython/pull/105593
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dd8da3694a59355392a94b4ee83d7a5a466ef343c2e45dce59e5aac9df334842/python/cpython/pull/105593
og:image:altPrevent repeated PyLong_FromVoidPtr() from possibly overwriting the current exception. Issue: Incorrect error handling for APIs that can raise exceptions #105375
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105593#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105593
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105593
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105593
Reloadhttps://github.com/python/cpython/pull/105593
Reloadhttps://github.com/python/cpython/pull/105593
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105593
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105593
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/105593#issue-comment-box
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:improve-ctypes-error-handlinghttps://github.com/erlend-aasland/cpython/tree/improve-ctypes-error-handling
gh-105375: Improve error handling in _ctypes https://github.com/python/cpython/pull/105593#top
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:improve-ctypes-error-handlinghttps://github.com/erlend-aasland/cpython/tree/improve-ctypes-error-handling
Conversation 8 https://github.com/python/cpython/pull/105593
Commits 5 https://github.com/python/cpython/pull/105593/commits
Checks 0 https://github.com/python/cpython/pull/105593/checks
Files changed https://github.com/python/cpython/pull/105593/files
Please reload this pagehttps://github.com/python/cpython/pull/105593
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 9, 2023https://github.com/python/cpython/pull/105593#issue-1750412028
Please reload this pagehttps://github.com/python/cpython/pull/105593
Incorrect error handling for APIs that can raise exceptions #105375https://github.com/python/cpython/issues/105375
Please reload this pagehttps://github.com/python/cpython/pull/105593
https://github.com/erlend-aasland
pythongh-105375https://github.com/python/cpython/issues/105375
: Improve error handling in _ctypeshttps://github.com/python/cpython/pull/105593/commits/8c28ddb1561655229c9c5a7e30b92b4da963855a
8c28ddbhttps://github.com/python/cpython/pull/105593/commits/8c28ddb1561655229c9c5a7e30b92b4da963855a
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 9, 2023https://github.com/python/cpython/pull/105593#event-9487662304
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 9, 2023https://github.com/python/cpython/pull/105593#event-9487662463
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 9, 2023 https://github.com/python/cpython/pull/105593#ref-issue-1743883856
Incorrect error handling for APIs that can raise exceptions #105375 https://github.com/python/cpython/issues/105375
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
sobolevnhttps://github.com/sobolevn
June 9, 2023 20:46https://github.com/python/cpython/pull/105593#event-9488063513
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Jun 10, 2023 https://github.com/python/cpython/pull/105593#pullrequestreview-1473330015
View reviewed changes https://github.com/python/cpython/pull/105593/files/8c28ddb1561655229c9c5a7e30b92b4da963855a
Modules/_ctypes/callbacks.chttps://github.com/python/cpython/pull/105593/files/8c28ddb1561655229c9c5a7e30b92b4da963855a#diff-706e65ee28911740bf638707e19578b8182e57c6a8a9a4a91105d825f95a139d
Please reload this pagehttps://github.com/python/cpython/pull/105593
erlend-aaslandhttps://github.com/erlend-aasland
June 11, 2023 12:24https://github.com/python/cpython/pull/105593#commits-pushed-696b70e
https://github.com/erlend-aasland
Pull in mainhttps://github.com/python/cpython/pull/105593/commits/696b70e3a958c18c49adb5dc57f3489759a283f3
696b70ehttps://github.com/python/cpython/pull/105593/commits/696b70e3a958c18c49adb5dc57f3489759a283f3
https://github.com/erlend-aasland
Address review: also decref funchttps://github.com/python/cpython/pull/105593/commits/00461fa7a8ae1c1b1679155209815b1ca420a95a
00461fahttps://github.com/python/cpython/pull/105593/commits/00461fa7a8ae1c1b1679155209815b1ca420a95a
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
🔨 test-with-refleak-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-refleak-buildbots%22
Jun 11, 2023https://github.com/python/cpython/pull/105593#event-9493572217
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 11, 2023https://github.com/python/cpython/pull/105593#issuecomment-1586107564
@erlend-aaslandhttps://github.com/erlend-aasland
00461fahttps://github.com/python/cpython/commit/00461fa7a8ae1c1b1679155209815b1ca420a95a
Please reload this pagehttps://github.com/python/cpython/pull/105593
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-refleak-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-refleak-buildbots%22
Jun 11, 2023https://github.com/python/cpython/pull/105593#event-9493572315
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Jun 11, 2023 https://github.com/python/cpython/pull/105593#pullrequestreview-1473671451
View reviewed changes https://github.com/python/cpython/pull/105593/files/00461fa7a8ae1c1b1679155209815b1ca420a95a
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 11, 2023https://github.com/python/cpython/pull/105593#issuecomment-1586303486
Please reload this pagehttps://github.com/python/cpython/pull/105593
erlend-aaslandhttps://github.com/erlend-aasland
June 11, 2023 21:19https://github.com/python/cpython/pull/105593#commits-pushed-c4c24f4
https://github.com/erlend-aasland
Pull in mainhttps://github.com/python/cpython/pull/105593/commits/c4c24f45b496cfbeb160dfdc32273a0ddfa38bc2
c4c24f4https://github.com/python/cpython/pull/105593/commits/c4c24f45b496cfbeb160dfdc32273a0ddfa38bc2
https://github.com/erlend-aasland
Slightly reduce diff in GH viewhttps://github.com/python/cpython/pull/105593/commits/26fd23d47026f0f0bea2c69765c4092ea90eea6c
26fd23dhttps://github.com/python/cpython/pull/105593/commits/26fd23d47026f0f0bea2c69765c4092ea90eea6c
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
June 11, 2023 19:21https://github.com/python/cpython/pull/105593#event-9495261752
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
e8998e4https://github.com/python/cpython/commit/e8998e46a7ce8ad336e0941a6da6e50cb88d1e47
Jun 11, 2023https://github.com/python/cpython/pull/105593#event-9495349152
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jun 11, 2023https://github.com/python/cpython/pull/105593#issuecomment-1586316582
@erlend-aaslandhttps://github.com/erlend-aasland
Please reload this pagehttps://github.com/python/cpython/pull/105593
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 11, 2023https://github.com/python/cpython/pull/105593#event-9495349363
miss-islingtonhttps://github.com/miss-islington
Jun 11, 2023 https://github.com/python/cpython/pull/105593#ref-commit-40e5cac
https://github.com/erlend-aasland
https://github.com/miss-islington
pythongh-105375https://github.com/python/cpython/issues/105375
: Improve error handling in _ctypes (https://github.com/miss-islington/cpython/commit/40e5cac7c5204a9f5667776f5b187bfae5e5cc1c
pythonGH-105593https://github.com/python/cpython/pull/105593
)https://github.com/miss-islington/cpython/commit/40e5cac7c5204a9f5667776f5b187bfae5e5cc1c
40e5cachttps://github.com/miss-islington/cpython/commit/40e5cac7c5204a9f5667776f5b187bfae5e5cc1c
e8998e4https://github.com/miss-islington/cpython/commit/e8998e46a7ce8ad336e0941a6da6e50cb88d1e47
miss-islingtonhttps://github.com/miss-islington
Jun 11, 2023 https://github.com/python/cpython/pull/105593#ref-commit-f9a3d83
https://github.com/erlend-aasland
https://github.com/miss-islington
pythongh-105375https://github.com/python/cpython/issues/105375
: Improve error handling in _ctypes (https://github.com/miss-islington/cpython/commit/f9a3d83e2f6aca5d6a973475fbf1f748c8ce88a9
pythonGH-105593https://github.com/python/cpython/pull/105593
)https://github.com/miss-islington/cpython/commit/f9a3d83e2f6aca5d6a973475fbf1f748c8ce88a9
f9a3d83https://github.com/miss-islington/cpython/commit/f9a3d83e2f6aca5d6a973475fbf1f748c8ce88a9
e8998e4https://github.com/miss-islington/cpython/commit/e8998e46a7ce8ad336e0941a6da6e50cb88d1e47
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 11, 2023https://github.com/python/cpython/pull/105593#issuecomment-1586316618
GH-105663https://github.com/python/cpython/pull/105663
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/105593
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 11, 2023https://github.com/python/cpython/pull/105593#event-9495350281
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 11, 2023https://github.com/python/cpython/pull/105593#issuecomment-1586316630
GH-105664https://github.com/python/cpython/pull/105664
3.11 branchhttps://github.com/python/cpython/tree/3.11
Please reload this pagehttps://github.com/python/cpython/pull/105593
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Jun 11, 2023https://github.com/python/cpython/pull/105593#event-9495350458
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
June 11, 2023 19:55https://github.com/python/cpython/pull/105593#event-9495376936
erlend-aaslandhttps://github.com/erlend-aasland
Jun 11, 2023 https://github.com/python/cpython/pull/105593#ref-commit-82ac2be
https://github.com/miss-islington
https://github.com/erlend-aasland
[3.12]https://github.com/python/cpython/commit/82ac2be6b386b7d106a36262f1aa960f638bde8d
gh-105375https://github.com/python/cpython/issues/105375
: Improve error handling in _ctypes (https://github.com/python/cpython/commit/82ac2be6b386b7d106a36262f1aa960f638bde8d
GH-105593https://github.com/python/cpython/pull/105593
) (https://github.com/python/cpython/commit/82ac2be6b386b7d106a36262f1aa960f638bde8d
#105663https://github.com/python/cpython/pull/105663
82ac2behttps://github.com/python/cpython/commit/82ac2be6b386b7d106a36262f1aa960f638bde8d
https://github.com/python/cpython/pull/105663
e8998e4https://github.com/python/cpython/commit/e8998e46a7ce8ad336e0941a6da6e50cb88d1e47
erlend-aaslandhttps://github.com/erlend-aasland
Jun 11, 2023 https://github.com/python/cpython/pull/105593#ref-commit-a034493
https://github.com/miss-islington
https://github.com/erlend-aasland
[3.11]https://github.com/python/cpython/commit/a03449374ebd5bffe54d3e09d36b54bc605551d8
gh-105375https://github.com/python/cpython/issues/105375
: Improve error handling in _ctypes (https://github.com/python/cpython/commit/a03449374ebd5bffe54d3e09d36b54bc605551d8
GH-105593https://github.com/python/cpython/pull/105593
) (https://github.com/python/cpython/commit/a03449374ebd5bffe54d3e09d36b54bc605551d8
#105664https://github.com/python/cpython/pull/105664
a034493https://github.com/python/cpython/commit/a03449374ebd5bffe54d3e09d36b54bc605551d8
https://github.com/python/cpython/pull/105664
e8998e4https://github.com/python/cpython/commit/e8998e46a7ce8ad336e0941a6da6e50cb88d1e47
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105593
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/python/cpython/pull/105593/files/00461fa7a8ae1c1b1679155209815b1ca420a95a
Please reload this pagehttps://github.com/python/cpython/pull/105593
https://github.com/erlend-aasland
https://github.com/bedevere-bot
https://github.com/miss-islington
https://github.com/sobolevn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.