René's URL Explorer Experiment


Title: GH-105588: Add missing error checks to some `obj2ast_*` converters by brandtbucher · Pull Request #105589 · python/cpython · GitHub

Open Graph Title: GH-105588: Add missing error checks to some `obj2ast_*` converters by brandtbucher · Pull Request #105589 · python/cpython

X Title: GH-105588: Add missing error checks to some `obj2ast_*` converters by brandtbucher · Pull Request #105589 · python/cpython

Description: Issue: Some object-to-AST conversions are missing error checks #105588

Open Graph Description: Issue: Some object-to-AST conversions are missing error checks #105588

X Description: Issue: Some object-to-AST conversions are missing error checks #105588

Opengraph URL: https://github.com/python/cpython/pull/105589

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1aa631b2-09c2-0e2e-afde-5412daff8fc5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C5A:FE603:21B313:2B7830:696ADA9E
html-safe-nonce642f10e03d770d6317b7b2197caa868123e446a30ef35b3cb22977fded69891b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzVBOkZFNjAzOjIxQjMxMzoyQjc4MzA6Njk2QURBOUUiLCJ2aXNpdG9yX2lkIjoiOTA1MTgyNjQ5MjE1NTgxMjUxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3bdfe2c8bf2c409c26532f35d7109c2a12692655a0f7e61fc451da471059e42f
hovercard-subject-tagpull_request:1386623016
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/105589/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/103282b902491fac602bc87fca2e1700079d7a3e051ff9e2b4e70472093ad450/python/cpython/pull/105589
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/103282b902491fac602bc87fca2e1700079d7a3e051ff9e2b4e70472093ad450/python/cpython/pull/105589
og:image:altIssue: Some object-to-AST conversions are missing error checks #105588
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrandtbucher
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release524a93f2c1f36522a3b4be4c110467ee4172245d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105589#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105589
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105589
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105589
Reloadhttps://github.com/python/cpython/pull/105589
Reloadhttps://github.com/python/cpython/pull/105589
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105589
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105589
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/105589#issue-comment-box
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:ast-error-handlinghttps://github.com/brandtbucher/cpython/tree/ast-error-handling
GH-105588: Add missing error checks to some obj2ast_* converters https://github.com/python/cpython/pull/105589#top
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:ast-error-handlinghttps://github.com/brandtbucher/cpython/tree/ast-error-handling
Conversation 4 https://github.com/python/cpython/pull/105589
Commits 4 https://github.com/python/cpython/pull/105589/commits
Checks 0 https://github.com/python/cpython/pull/105589/checks
Files changed https://github.com/python/cpython/pull/105589/files
Please reload this pagehttps://github.com/python/cpython/pull/105589
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jun 9, 2023https://github.com/python/cpython/pull/105589#issue-1750370670
Please reload this pagehttps://github.com/python/cpython/pull/105589
Some object-to-AST conversions are missing error checks #105588https://github.com/python/cpython/issues/105588
Please reload this pagehttps://github.com/python/cpython/pull/105589
brandtbucherhttps://github.com/brandtbucher
June 9, 2023 11:00https://github.com/python/cpython/pull/105589#commits-pushed-0546055
https://github.com/brandtbucher
Add failing regression testshttps://github.com/python/cpython/pull/105589/commits/0546055b055d05b037e219ebf7099d104b3a0ec9
0546055https://github.com/python/cpython/pull/105589/commits/0546055b055d05b037e219ebf7099d104b3a0ec9
https://github.com/brandtbucher
fixuphttps://github.com/python/cpython/pull/105589/commits/937af55e75533685b0a2e88a85976ad5cf1fd0c6
937af55https://github.com/python/cpython/pull/105589/commits/937af55e75533685b0a2e88a85976ad5cf1fd0c6
https://github.com/brandtbucher
Add error checks after "product" node constructionhttps://github.com/python/cpython/pull/105589/commits/45e92feacee2d1a8567ed7b5434134e219f4f105
45e92fehttps://github.com/python/cpython/pull/105589/commits/45e92feacee2d1a8567ed7b5434134e219f4f105
https://github.com/brandtbucher
blurb addhttps://github.com/python/cpython/pull/105589/commits/f8036bd31ca3fc240229df9d2b1b481fb35f7b68
f8036bdhttps://github.com/python/cpython/pull/105589/commits/f8036bd31ca3fc240229df9d2b1b481fb35f7b68
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
interpreter-core https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Ainterpreter-core
type-crash https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-crash
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 9, 2023https://github.com/python/cpython/pull/105589#event-9487409223
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jun 9, 2023https://github.com/python/cpython/pull/105589#event-9487409279
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
isidenticalhttps://github.com/isidentical
code ownerhttps://github.com/python/cpython/blob/89aac6f6b7b3af046ec137121c90732289e79efc/.github/CODEOWNERS#L106
June 9, 2023 19:04https://github.com/python/cpython/pull/105589#event-9487409502
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 9, 2023https://github.com/python/cpython/pull/105589#event-9487409818
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 9, 2023 https://github.com/python/cpython/pull/105589#ref-issue-1750366008
Some object-to-AST conversions are missing error checks #105588 https://github.com/python/cpython/issues/105588
https://github.com/furkanonder
furkanonderhttps://github.com/furkanonder
Jun 10, 2023https://github.com/python/cpython/pull/105589#issuecomment-1585586625
@isidenticalhttps://github.com/isidentical
Please reload this pagehttps://github.com/python/cpython/pull/105589
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
a4056c8https://github.com/python/cpython/commit/a4056c8f9c2d9970d39e3cb6bffb255cd4b8a42c
Jun 15, 2023https://github.com/python/cpython/pull/105589#event-9545493490
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jun 15, 2023https://github.com/python/cpython/pull/105589#issuecomment-1593813678
@brandtbucherhttps://github.com/brandtbucher
Please reload this pagehttps://github.com/python/cpython/pull/105589
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 15, 2023https://github.com/python/cpython/pull/105589#event-9545493699
miss-islingtonhttps://github.com/miss-islington
Jun 15, 2023 https://github.com/python/cpython/pull/105589#ref-commit-f8c3966
https://github.com/brandtbucher
https://github.com/miss-islington
pythonGH-105588https://github.com/python/cpython/issues/105588
: Add missing error checks to some obj2ast_* converters (https://github.com/miss-islington/cpython/commit/f8c396612af96bf0b07866b9d0d95f5c350e715a
f8c3966https://github.com/miss-islington/cpython/commit/f8c396612af96bf0b07866b9d0d95f5c350e715a
pythonGH-105589https://github.com/python/cpython/pull/105589
a4056c8https://github.com/miss-islington/cpython/commit/a4056c8f9c2d9970d39e3cb6bffb255cd4b8a42c
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 15, 2023https://github.com/python/cpython/pull/105589#issuecomment-1593813784
GH-105838https://github.com/python/cpython/pull/105838
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/105589
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 15, 2023https://github.com/python/cpython/pull/105589#event-9545494455
miss-islingtonhttps://github.com/miss-islington
Jun 15, 2023 https://github.com/python/cpython/pull/105589#ref-commit-3680071
https://github.com/brandtbucher
https://github.com/miss-islington
pythonGH-105588https://github.com/python/cpython/issues/105588
: Add missing error checks to some obj2ast_* converters (https://github.com/miss-islington/cpython/commit/3680071b9381dd9c18ec1d4f5cff5fc3dbe03a07
3680071https://github.com/miss-islington/cpython/commit/3680071b9381dd9c18ec1d4f5cff5fc3dbe03a07
pythonGH-105589https://github.com/python/cpython/pull/105589
a4056c8https://github.com/miss-islington/cpython/commit/a4056c8f9c2d9970d39e3cb6bffb255cd4b8a42c
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 15, 2023https://github.com/python/cpython/pull/105589#issuecomment-1593813811
GH-105839https://github.com/python/cpython/pull/105839
3.11 branchhttps://github.com/python/cpython/tree/3.11
Please reload this pagehttps://github.com/python/cpython/pull/105589
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Jun 15, 2023https://github.com/python/cpython/pull/105589#event-9545494640
brandtbucherhttps://github.com/brandtbucher
Jun 15, 2023 https://github.com/python/cpython/pull/105589#ref-commit-0add516
https://github.com/miss-islington
https://github.com/brandtbucher
[3.12]https://github.com/python/cpython/commit/0add51672d8c8db4b18838dd592991a6cd9b55ca
GH-105588https://github.com/python/cpython/issues/105588
: Add missing error checks to some obj2ast_* converte…https://github.com/python/cpython/commit/0add51672d8c8db4b18838dd592991a6cd9b55ca
0add516https://github.com/python/cpython/commit/0add51672d8c8db4b18838dd592991a6cd9b55ca
GH-105838https://github.com/python/cpython/pull/105838
GH-105588https://github.com/python/cpython/issues/105588
GH-105589https://github.com/python/cpython/pull/105589
a4056c8https://github.com/python/cpython/commit/a4056c8f9c2d9970d39e3cb6bffb255cd4b8a42c
brandtbucherhttps://github.com/brandtbucher
Jun 15, 2023 https://github.com/python/cpython/pull/105589#ref-commit-c0c4186
https://github.com/miss-islington
https://github.com/brandtbucher
[3.11]https://github.com/python/cpython/commit/c0c41868587cea93f69e02311406555a99902183
GH-105588https://github.com/python/cpython/issues/105588
: Add missing error checks to some obj2ast_* converte…https://github.com/python/cpython/commit/c0c41868587cea93f69e02311406555a99902183
c0c4186https://github.com/python/cpython/commit/c0c41868587cea93f69e02311406555a99902183
GH-105839https://github.com/python/cpython/pull/105839
GH-105588https://github.com/python/cpython/issues/105588
GH-105589https://github.com/python/cpython/pull/105589
a4056c8https://github.com/python/cpython/commit/a4056c8f9c2d9970d39e3cb6bffb255cd4b8a42c
carljmhttps://github.com/carljm
Jun 16, 2023 https://github.com/python/cpython/pull/105589#ref-commit-b096651
https://github.com/carljm
Merge branch 'main' into modulelocalshttps://github.com/carljm/cpython/commit/b096651a7e4d3ab9cea35801c81e02cc0e87f7e9
b096651https://github.com/carljm/cpython/commit/b096651a7e4d3ab9cea35801c81e02cc0e87f7e9
pythongh-104799https://github.com/python/cpython/issues/104799
python#105846https://github.com/python/cpython/pull/105846
pythongh-105834https://github.com/python/cpython/issues/105834
python#105835https://github.com/python/cpython/pull/105835
python#105823https://github.com/python/cpython/pull/105823
pythongh-105844https://github.com/python/cpython/issues/105844
python#105851https://github.com/python/cpython/pull/105851
python#104969https://github.com/python/cpython/pull/104969
pythongh-105433https://github.com/python/cpython/issues/105433
python#105443https://github.com/python/cpython/pull/105443
python#93189https://github.com/python/cpython/pull/93189
pythonGH-103124https://github.com/python/cpython/issues/103124
pythonGH-103125https://github.com/python/cpython/pull/103125
pythonGH-105588https://github.com/python/cpython/issues/105588
pythonGH-105589https://github.com/python/cpython/pull/105589
gvanrossumhttps://github.com/gvanrossum
Jun 18, 2023 https://github.com/python/cpython/pull/105589#ref-commit-524490c
https://github.com/brandtbucher
https://github.com/gvanrossum
pythonGH-105588https://github.com/python/cpython/issues/105588
: Add missing error checks to some obj2ast_* converters (https://github.com/gvanrossum/cpython/commit/524490cff4ac371001653fe410ef6a3794fcaded
524490chttps://github.com/gvanrossum/cpython/commit/524490cff4ac371001653fe410ef6a3794fcaded
pythonGH-105589https://github.com/python/cpython/pull/105589
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105589
https://github.com/isidentical
isidentical https://github.com/isidentical
https://github.com/brandtbucher
brandtbucher https://github.com/brandtbucher
interpreter-core https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Ainterpreter-core
type-crash https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-crash
Please reload this pagehttps://github.com/python/cpython/pull/105589
https://github.com/brandtbucher
https://github.com/furkanonder
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.