René's URL Explorer Experiment


Title: gh-105280: Ensure `isinstance([], collections.abc.Mapping)` always evaluates to `False` by AlexWaygood · Pull Request #105281 · python/cpython · GitHub

Open Graph Title: gh-105280: Ensure `isinstance([], collections.abc.Mapping)` always evaluates to `False` by AlexWaygood · Pull Request #105281 · python/cpython

X Title: gh-105280: Ensure `isinstance([], collections.abc.Mapping)` always evaluates to `False` by AlexWaygood · Pull Request #105281 · python/cpython

Description: Issue: typing.Protocol implementation means that isinstance([], collections.abc.Mapping) can sometimes evaluate to True #105280

Open Graph Description: Issue: typing.Protocol implementation means that isinstance([], collections.abc.Mapping) can sometimes evaluate to True #105280

X Description: Issue: typing.Protocol implementation means that isinstance([], collections.abc.Mapping) can sometimes evaluate to True #105280

Opengraph URL: https://github.com/python/cpython/pull/105281

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e2da5276-36f7-52e8-12e8-13c61b169ecc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4CE:87E17:C37F3F:1083A3F:696AC03A
html-safe-noncedb113726cc20cef768673b8e033439240f3dc673ef9376e990c2fa2643f7be1f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENENFOjg3RTE3OkMzN0YzRjoxMDgzQTNGOjY5NkFDMDNBIiwidmlzaXRvcl9pZCI6IjM3NDM0MzI3NDAzNTQ4MzQ0OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace73d2bb1405410f3710a2bc76adb833b222382064a6dabce54c2ac2127e1e06b
hovercard-subject-tagpull_request:1377700944
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/105281/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/72ecbfcf43319f5aa6ae4413423af46a723ab84c434ae5d3729f3de100c4b7d6/python/cpython/pull/105281
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/72ecbfcf43319f5aa6ae4413423af46a723ab84c434ae5d3729f3de100c4b7d6/python/cpython/pull/105281
og:image:altIssue: typing.Protocol implementation means that isinstance([], collections.abc.Mapping) can sometimes evaluate to True #105280
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexWaygood
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105281#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105281
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105281
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105281
Reloadhttps://github.com/python/cpython/pull/105281
Reloadhttps://github.com/python/cpython/pull/105281
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105281
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105281
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/105281#issue-comment-box
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:fix-gc-protocol-bughttps://github.com/AlexWaygood/cpython/tree/fix-gc-protocol-bug
gh-105280: Ensure isinstance([], collections.abc.Mapping) always evaluates to False https://github.com/python/cpython/pull/105281#top
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:fix-gc-protocol-bughttps://github.com/AlexWaygood/cpython/tree/fix-gc-protocol-bug
Conversation 6 https://github.com/python/cpython/pull/105281
Commits 5 https://github.com/python/cpython/pull/105281/commits
Checks 0 https://github.com/python/cpython/pull/105281/checks
Files changed https://github.com/python/cpython/pull/105281/files
Please reload this pagehttps://github.com/python/cpython/pull/105281
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Jun 4, 2023https://github.com/python/cpython/pull/105281#issue-1740315033
Please reload this pagehttps://github.com/python/cpython/pull/105281
typing.Protocol implementation means that isinstance([], collections.abc.Mapping) can sometimes evaluate to True #105280https://github.com/python/cpython/issues/105280
Please reload this pagehttps://github.com/python/cpython/pull/105281
https://github.com/AlexWaygood
Ensure isinstance([], collections.abc.Mapping) always evaluates to …https://github.com/python/cpython/pull/105281/commits/c17b8edd713ce90e16cbc896373b118009e50ce1
c17b8edhttps://github.com/python/cpython/pull/105281/commits/c17b8edd713ce90e16cbc896373b118009e50ce1
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 4, 2023https://github.com/python/cpython/pull/105281#event-9424594665
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Fidget-Spinnerhttps://github.com/Fidget-Spinner
JelleZijlstrahttps://github.com/JelleZijlstra
gvanrossumhttps://github.com/gvanrossum
code ownershttps://github.com/python/cpython/blob/ce558e69d4087dd3653207de78345fbb8a2c7835/.github/CODEOWNERS#L146
June 4, 2023 11:19https://github.com/python/cpython/pull/105281#event-9424594677
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 4, 2023https://github.com/python/cpython/pull/105281#event-9424594738
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 4, 2023 https://github.com/python/cpython/pull/105281#ref-issue-1740308836
typing.Protocol implementation means that isinstance([], collections.abc.Mapping) can sometimes evaluate to True #105280 https://github.com/python/cpython/issues/105280
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Jun 4, 2023https://github.com/python/cpython/pull/105281#issuecomment-1575527952
Please reload this pagehttps://github.com/python/cpython/pull/105281
gh-105237: Allow calling issubclass(X, typing.Protocol) again #105239 https://github.com/python/cpython/pull/105239
Backport recent fixes to Protocol from 3.12 python/typing_extensions#218 https://github.com/python/typing_extensions/pull/218
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Jun 5, 2023 https://github.com/python/cpython/pull/105281#pullrequestreview-1462520211
View reviewed changes https://github.com/python/cpython/pull/105281/files/c17b8edd713ce90e16cbc896373b118009e50ce1
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/105281/files/c17b8edd713ce90e16cbc896373b118009e50ce1#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/105281
https://github.com/AlexWaygood
Add the cleanup before changing the statehttps://github.com/python/cpython/pull/105281/commits/612c551870906e0f2a391950e4e7eb33fa0f4601
612c551https://github.com/python/cpython/pull/105281/commits/612c551870906e0f2a391950e4e7eb33fa0f4601
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Jun 5, 2023 https://github.com/python/cpython/pull/105281#pullrequestreview-1462534692
View reviewed changes https://github.com/python/cpython/pull/105281/files/612c551870906e0f2a391950e4e7eb33fa0f4601
Lib/typing.pyhttps://github.com/python/cpython/pull/105281/files/612c551870906e0f2a391950e4e7eb33fa0f4601#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
Please reload this pagehttps://github.com/python/cpython/pull/105281
https://github.com/AlexWaygood
don't needlessly break compatibility with typing_extensionshttps://github.com/python/cpython/pull/105281/commits/99ec54cc60b62e0f16eb2751bde1e40021eab43b
99ec54chttps://github.com/python/cpython/pull/105281/commits/99ec54cc60b62e0f16eb2751bde1e40021eab43b
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Jun 5, 2023 https://github.com/python/cpython/pull/105281#pullrequestreview-1462537587
View reviewed changes https://github.com/python/cpython/pull/105281/files/99ec54cc60b62e0f16eb2751bde1e40021eab43b
Lib/typing.pyhttps://github.com/python/cpython/pull/105281/files/99ec54cc60b62e0f16eb2751bde1e40021eab43b#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
Please reload this pagehttps://github.com/python/cpython/pull/105281
https://github.com/AlexWaygood
nithttps://github.com/python/cpython/pull/105281/commits/55368cd8124af622a02f37a51c9baeabc54cde3e
55368cdhttps://github.com/python/cpython/pull/105281/commits/55368cd8124af622a02f37a51c9baeabc54cde3e
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Jun 5, 2023 https://github.com/python/cpython/pull/105281#pullrequestreview-1462565154
View reviewed changes https://github.com/python/cpython/pull/105281/files/55368cd8124af622a02f37a51c9baeabc54cde3e
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 5, 2023https://github.com/python/cpython/pull/105281#event-9433513919
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
June 5, 2023 13:35https://github.com/python/cpython/pull/105281#event-9433534242
https://github.com/AlexWaygood
Merge branch 'main' into fix-gc-protocol-bughttps://github.com/python/cpython/pull/105281/commits/d498ff32601c955513556a47f7974569de2f3999
d498ff3https://github.com/python/cpython/pull/105281/commits/d498ff32601c955513556a47f7974569de2f3999
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
08756dbhttps://github.com/python/cpython/commit/08756dbba647440803d2ba4545ba0ab2f0cdfe1c
Jun 5, 2023https://github.com/python/cpython/pull/105281#event-9434043611
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jun 5, 2023https://github.com/python/cpython/pull/105281#issuecomment-1576884254
@AlexWaygoodhttps://github.com/AlexWaygood
Please reload this pagehttps://github.com/python/cpython/pull/105281
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jun 5, 2023https://github.com/python/cpython/pull/105281#event-9434044325
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
June 5, 2023 14:11https://github.com/python/cpython/pull/105281#event-9434046830
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 5, 2023https://github.com/python/cpython/pull/105281#issuecomment-1576884632
GH-105318https://github.com/python/cpython/pull/105318
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/105281
miss-islingtonhttps://github.com/miss-islington
Jun 5, 2023 https://github.com/python/cpython/pull/105281#ref-commit-c004e38
https://github.com/AlexWaygood
https://github.com/miss-islington
pythongh-105280https://github.com/python/cpython/issues/105280
: Ensurehttps://github.com/miss-islington/cpython/commit/c004e382a0689d8dd2c77a69d567460aa47d7e0e
isinstance([], collections.abc.Mapping)https://github.com/miss-islington/cpython/commit/c004e382a0689d8dd2c77a69d567460aa47d7e0e
alw…https://github.com/miss-islington/cpython/commit/c004e382a0689d8dd2c77a69d567460aa47d7e0e
c004e38https://github.com/miss-islington/cpython/commit/c004e382a0689d8dd2c77a69d567460aa47d7e0e
pythonGH-105281https://github.com/python/cpython/pull/105281
08756dbhttps://github.com/miss-islington/cpython/commit/08756dbba647440803d2ba4545ba0ab2f0cdfe1c
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
Jun 5, 2023https://github.com/python/cpython/pull/105281#event-9434047531
AlexWaygoodhttps://github.com/AlexWaygood
Jun 5, 2023 https://github.com/python/cpython/pull/105281#ref-commit-2031238
https://github.com/miss-islington
https://github.com/AlexWaygood
[3.12]https://github.com/python/cpython/commit/2031238eb64150053117e214ca40dc774b95b933
gh-105280https://github.com/python/cpython/issues/105280
: Ensurehttps://github.com/python/cpython/commit/2031238eb64150053117e214ca40dc774b95b933
isinstance([], collections.abc.Mapping)https://github.com/python/cpython/commit/2031238eb64150053117e214ca40dc774b95b933
al…https://github.com/python/cpython/commit/2031238eb64150053117e214ca40dc774b95b933
2031238https://github.com/python/cpython/commit/2031238eb64150053117e214ca40dc774b95b933
GH-105281https://github.com/python/cpython/pull/105281
#105318https://github.com/python/cpython/pull/105318
gh-105280https://github.com/python/cpython/issues/105280
GH-105281https://github.com/python/cpython/pull/105281
08756dbhttps://github.com/python/cpython/commit/08756dbba647440803d2ba4545ba0ab2f0cdfe1c
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 6, 2023 https://github.com/python/cpython/pull/105281#ref-pullrequest-1743530961
3.12 backport gh 105236 #105358 https://github.com/python/cpython/pull/105358
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105281
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/cpython/pull/105281/files/55368cd8124af622a02f37a51c9baeabc54cde3e
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/105281
https://github.com/AlexWaygood
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/JelleZijlstra
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.