René's URL Explorer Experiment


Title: gh-98963: Restore the ability to have a dict-less property. by gpshead · Pull Request #105262 · python/cpython · GitHub

Open Graph Title: gh-98963: Restore the ability to have a dict-less property. by gpshead · Pull Request #105262 · python/cpython

X Title: gh-98963: Restore the ability to have a dict-less property. by gpshead · Pull Request #105262 · python/cpython

Description: Ignore doc string assignment failures in property as has been the behavior of all past Python releases. Preserves the one situation in which the AttributeError has always been raised for this property subclass situation: If the docstring would be applied from a getter function it raises rather than remaining silent. (see the existing test and code comments) This undoes a behavior regression present in 3.12beta1 that was causing existing widely used library code (Google protobuf) to fail. Issue: gh-98963

Open Graph Description: Ignore doc string assignment failures in property as has been the behavior of all past Python releases. Preserves the one situation in which the AttributeError has always been raised for this prope...

X Description: Ignore doc string assignment failures in property as has been the behavior of all past Python releases. Preserves the one situation in which the AttributeError has always been raised for this prope...

Opengraph URL: https://github.com/python/cpython/pull/105262

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ebfcfa6e-bd5f-0c95-7cca-24e405b63a04
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDED6:2E599F:64EC98:8A0573:6969DD37
html-safe-nonce63cd3a8728b633079ad54a2ed3d488f0bd7e5328299ad1276a56246be3da600a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUQ2OjJFNTk5Rjo2NEVDOTg6OEEwNTczOjY5NjlERDM3IiwidmlzaXRvcl9pZCI6Ijc3NTE2MDY4MjA2ODQ4MTU2NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd9d5f93b7f45a82455662f8557cb5f0c47461d93610af88c1e36fea44bd5af13
hovercard-subject-tagpull_request:1376496063
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/105262/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:altIgnore doc string assignment failures in property as has been the behavior of all past Python releases. Preserves the one situation in which the AttributeError has always been raised for this prope...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105262/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105262%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105262%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105262/files
Reloadhttps://github.com/python/cpython/pull/105262/files
Reloadhttps://github.com/python/cpython/pull/105262/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105262/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105262/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
gpshead:property-nodict-docstr-errorhttps://github.com/gpshead/cpython/tree/property-nodict-docstr-error
Conversation 12 https://github.com/python/cpython/pull/105262
Commits 7 https://github.com/python/cpython/pull/105262/commits
Checks 0 https://github.com/python/cpython/pull/105262/checks
Files changed https://github.com/python/cpython/pull/105262/files
Please reload this pagehttps://github.com/python/cpython/pull/105262/files
gh-98963: Restore the ability to have a dict-less property. https://github.com/python/cpython/pull/105262/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/105262/files
93276d2 gh-98963: Restore the ability to have a dict-less property. gpshead Jun 3, 2023 https://github.com/python/cpython/pull/105262/commits/93276d2be56837bc197d0700027a65bfcc85d89c
c6cdc7f Fix ASAN issue, to many DECREFs :P gpshead Jun 4, 2023 https://github.com/python/cpython/pull/105262/commits/c6cdc7f87bf6258c36a0ff0c9f91a89a5d428da7
3ceab53 s/tabs/spaces/ (ugh editor configs) gpshead Jun 4, 2023 https://github.com/python/cpython/pull/105262/commits/3ceab53965fd4daf422d489b29ad9d6b7425baef
95727f5 Restore all historical behaviors. gpshead Jun 4, 2023 https://github.com/python/cpython/pull/105262/commits/95727f576902ad4f6f373ac182a4cc9e96d96592
996e70b Reword comments and NEWS. gpshead Jun 4, 2023 https://github.com/python/cpython/pull/105262/commits/996e70b78d9d1aac14faa0672ed94a673d53ba85
517bd0d restore the singular decref. (correctness) gpshead Jun 4, 2023 https://github.com/python/cpython/pull/105262/commits/517bd0dec879c86f4914f6e5778cc53cae778a60
0307832 DECREF before return, not always. gpshead Jun 5, 2023 https://github.com/python/cpython/pull/105262/commits/0307832ee0cd470c9d0092f7df027348381d02be
Clear filters https://github.com/python/cpython/pull/105262/files
Please reload this pagehttps://github.com/python/cpython/pull/105262/files
Please reload this pagehttps://github.com/python/cpython/pull/105262/files
test_property.py https://github.com/python/cpython/pull/105262/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3
2023-06-02-17-39-19.gh-issue-98963.J4wJgk.rst https://github.com/python/cpython/pull/105262/files#diff-271d7d70938d21d6989618502159c311f5389db819f4589b6cdbfb0b10b0bad4
descrobject.c https://github.com/python/cpython/pull/105262/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264
Lib/test/test_property.pyhttps://github.com/python/cpython/pull/105262/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3
View file https://github.com/gpshead/cpython/blob/0307832ee0cd470c9d0092f7df027348381d02be/Lib/test/test_property.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105262/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105262/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3
https://github.com/python/cpython/pull/105262/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3
Misc/NEWS.d/next/Core and Builtins/2023-06-02-17-39-19.gh-issue-98963.J4wJgk.rsthttps://github.com/python/cpython/pull/105262/files#diff-271d7d70938d21d6989618502159c311f5389db819f4589b6cdbfb0b10b0bad4
View file https://github.com/gpshead/cpython/blob/0307832ee0cd470c9d0092f7df027348381d02be/Misc/NEWS.d/next/Core%20and%20Builtins/2023-06-02-17-39-19.gh-issue-98963.J4wJgk.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105262/{{ revealButtonHref }}
Objects/descrobject.chttps://github.com/python/cpython/pull/105262/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264
View file https://github.com/gpshead/cpython/blob/0307832ee0cd470c9d0092f7df027348381d02be/Objects/descrobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105262/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105262/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264
https://github.com/python/cpython/pull/105262/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264
https://github.com/python/cpython/pull/105262/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264
https://github.com/python/cpython/pull/105262/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264
https://github.com/python/cpython/pull/105262/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.