René's URL Explorer Experiment


Title: gh-105237: Allow calling `issubclass(X, typing.Protocol)` again by AlexWaygood · Pull Request #105239 · python/cpython · GitHub

Open Graph Title: gh-105237: Allow calling `issubclass(X, typing.Protocol)` again by AlexWaygood · Pull Request #105239 · python/cpython

X Title: gh-105237: Allow calling `issubclass(X, typing.Protocol)` again by AlexWaygood · Pull Request #105239 · python/cpython

Description: Issue: gh-105237

Open Graph Description: Issue: gh-105237

X Description: Issue: gh-105237

Opengraph URL: https://github.com/python/cpython/pull/105239

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:897b437a-99eb-26a5-afb9-8c4c508c0526
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id89AC:304CD9:478A5D:6458E9:696A0C5E
html-safe-nonce7a751229280219d46f97081cca716b9d43d34285fd3cd55f3dd2bb3e979bbfb7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUFDOjMwNENEOTo0NzhBNUQ6NjQ1OEU5OjY5NkEwQzVFIiwidmlzaXRvcl9pZCI6Ijg1MzI0NTQ0Mjc5NzA4OTkwMzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac379f0f5983a848c1756b4241f749216d24515d2299f15f326f1dc65b015dd77b
hovercard-subject-tagpull_request:1375786979
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/105239/files
twitter:imagehttps://avatars.githubusercontent.com/u/66076021?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/66076021?s=400&v=4
og:image:altIssue: gh-105237
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7266b2d935baa1c6474b16dd9feaa5ca30607261
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105239/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105239%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105239%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105239/files
Reloadhttps://github.com/python/cpython/pull/105239/files
Reloadhttps://github.com/python/cpython/pull/105239/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105239/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105239/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:protocol-subclass-regressionhttps://github.com/AlexWaygood/cpython/tree/protocol-subclass-regression
Conversation 16 https://github.com/python/cpython/pull/105239
Commits 6 https://github.com/python/cpython/pull/105239/commits
Checks 0 https://github.com/python/cpython/pull/105239/checks
Files changed https://github.com/python/cpython/pull/105239/files
Please reload this pagehttps://github.com/python/cpython/pull/105239/files
gh-105237: Allow calling issubclass(X, typing.Protocol) again https://github.com/python/cpython/pull/105239/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/105239/files
a6b11b0 Allow calling `issubclass(X, Protocol)` AlexWaygood Jun 2, 2023 https://github.com/python/cpython/pull/105239/commits/a6b11b06f99a403573bec1bb6f131024d814bdd6
36b2ac9 Add back some implementation details so we don't unnecessarily break … AlexWaygood Jun 2, 2023 https://github.com/python/cpython/pull/105239/commits/36b2ac937effd3c5c7b531754908e66c0d9226a4
db51c8d Revert unnecessary changes to tests AlexWaygood Jun 2, 2023 https://github.com/python/cpython/pull/105239/commits/db51c8d6a5f72011cdc286932fcd8d1f97371387
776bf2b Fix longstanding bug and add many tests AlexWaygood Jun 2, 2023 https://github.com/python/cpython/pull/105239/commits/776bf2bdbed6c01cc48bdb34446a41cac78bacae
ffb7f1c Small micro-optimisation AlexWaygood Jun 2, 2023 https://github.com/python/cpython/pull/105239/commits/ffb7f1ccddcb0dafb9221c615e17add7ba746243
b85a320 Cleaner solution AlexWaygood Jun 2, 2023 https://github.com/python/cpython/pull/105239/commits/b85a3205c4b22942c9cb4ce0f8619d7b04d2ffe0
Clear filters https://github.com/python/cpython/pull/105239/files
Please reload this pagehttps://github.com/python/cpython/pull/105239/files
Please reload this pagehttps://github.com/python/cpython/pull/105239/files
test_typing.py https://github.com/python/cpython/pull/105239/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
typing.py https://github.com/python/cpython/pull/105239/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
2023-06-02-14-57-11.gh-issue-105239.SAmuuj.rst https://github.com/python/cpython/pull/105239/files#diff-7b1a7eba77874f16e3dd04923110c94df796b64d411d06d692c894703b7ab314
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L599
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/105239/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
View file https://github.com/AlexWaygood/cpython/blob/b85a3205c4b22942c9cb4ce0f8619d7b04d2ffe0/Lib/test/test_typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105239/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105239/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/105239/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L601
Lib/typing.pyhttps://github.com/python/cpython/pull/105239/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
View file https://github.com/AlexWaygood/cpython/blob/b85a3205c4b22942c9cb4ce0f8619d7b04d2ffe0/Lib/typing.py
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/cpython/pull/105239/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105239/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105239/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/105239/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/105239/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
Misc/NEWS.d/next/Library/2023-06-02-14-57-11.gh-issue-105239.SAmuuj.rsthttps://github.com/python/cpython/pull/105239/files#diff-7b1a7eba77874f16e3dd04923110c94df796b64d411d06d692c894703b7ab314
View file https://github.com/AlexWaygood/cpython/blob/b85a3205c4b22942c9cb4ce0f8619d7b04d2ffe0/Misc/NEWS.d/next/Library/2023-06-02-14-57-11.gh-issue-105239.SAmuuj.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105239/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.