René's URL Explorer Experiment


Title: [3.12] gh-104614: Make Sure ob_type is Always Set Correctly by PyType_Ready() (gh-105122) by miss-islington · Pull Request #105211 · python/cpython · GitHub

Open Graph Title: [3.12] gh-104614: Make Sure ob_type is Always Set Correctly by PyType_Ready() (gh-105122) by miss-islington · Pull Request #105211 · python/cpython

X Title: [3.12] gh-104614: Make Sure ob_type is Always Set Correctly by PyType_Ready() (gh-105122) by miss-islington · Pull Request #105211 · python/cpython

Description: When I added the relevant condition to type_ready_set_bases() in gh-103912, I had missed that the function also sets tp_base and ob_type (if necessary). That led to problems for third-party static...

Open Graph Description: When I added the relevant condition to type_ready_set_bases() in gh-103912, I had missed that the function also sets tp_base and ob_type (if necessary). That led to problems for third-party static...

X Description: When I added the relevant condition to type_ready_set_bases() in gh-103912, I had missed that the function also sets tp_base and ob_type (if necessary). That led to problems for third-party static...

Mail addresses
ericsnowcurrently@gmail.com

Opengraph URL: https://github.com/python/cpython/pull/105211

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fb7a3244-0926-eb44-f1ba-b2b2046ed2bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF4A:1BFC98:3E098:52AD8:696A14AA
html-safe-noncec38383305757a47cd6c931d195b4c0d04584e6da38de6c3eb3babbea4f3c00ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjRBOjFCRkM5ODozRTA5ODo1MkFEODo2OTZBMTRBQSIsInZpc2l0b3JfaWQiOiIxNTUyMTM0Mjc5ODM3Mzg5OTk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac942a4e62b4edc4a602179e2d1cff98816aa7e624d0b85f711214fb8e99153bc7
hovercard-subject-tagpull_request:1374875078
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/105211/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/95372a559c142f328db59a2823be742c0936771776ca4411a829bd050830a039/python/cpython/pull/105211
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/95372a559c142f328db59a2823be742c0936771776ca4411a829bd050830a039/python/cpython/pull/105211
og:image:altWhen I added the relevant condition to type_ready_set_bases() in gh-103912, I had missed that the function also sets tp_base and ob_type (if necessary). That led to problems for third-party static...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None34a52bd10bd674f68e5c1b6b74413b79bf2ca20c551055ace3f7cdd112803923
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee8bd37502700f365b18a4d39acf7cb7947e11b1a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105211#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105211
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105211
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105211
Reloadhttps://github.com/python/cpython/pull/105211
Reloadhttps://github.com/python/cpython/pull/105211
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105211
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105211
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/105211#issue-comment-box
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:3.12https://github.com/python/cpython/tree/3.12
miss-islington:backport-1469393-3.12https://github.com/miss-islington/cpython/tree/backport-1469393-3.12
[3.12] gh-104614: Make Sure ob_type is Always Set Correctly by PyType_Ready() (gh-105122) https://github.com/python/cpython/pull/105211#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:3.12https://github.com/python/cpython/tree/3.12
miss-islington:backport-1469393-3.12https://github.com/miss-islington/cpython/tree/backport-1469393-3.12
Conversation 0 https://github.com/python/cpython/pull/105211
Commits 1 https://github.com/python/cpython/pull/105211/commits
Checks 0 https://github.com/python/cpython/pull/105211/checks
Files changed https://github.com/python/cpython/pull/105211/files
Please reload this pagehttps://github.com/python/cpython/pull/105211
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jun 1, 2023https://github.com/python/cpython/pull/105211#issue-1737191527
Please reload this pagehttps://github.com/python/cpython/pull/105211
gh-103912https://github.com/python/cpython/pull/103912
1469393https://github.com/python/cpython/commit/146939306adcff706ebddb047f7470d148125cdf
Type object's ob_type does not get set when tp_bases is set before PyType_Ready #104614https://github.com/python/cpython/issues/104614
Please reload this pagehttps://github.com/python/cpython/pull/105211
https://github.com/ericsnowcurrently
https://github.com/miss-islington
pythongh-104614https://github.com/python/cpython/issues/104614
: Make Sure ob_type is Always Set Correctly by PyType_…https://github.com/python/cpython/pull/105211/commits/d374433e7553511994064b05948460e6906b1458
d374433https://github.com/python/cpython/pull/105211/commits/d374433e7553511994064b05948460e6906b1458
pythongh-105122https://github.com/python/cpython/pull/105122
pythongh-103912https://github.com/python/cpython/pull/103912
1469393https://github.com/miss-islington/cpython/commit/146939306adcff706ebddb047f7470d148125cdf
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/c38ceb032d59d6c8f2006ab9a347d7e207f9f84e/.github/CODEOWNERS#L26
June 1, 2023 22:35https://github.com/python/cpython/pull/105211#event-9408550107
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jun 1, 2023https://github.com/python/cpython/pull/105211#event-9408550276
Type object's ob_type does not get set when tp_bases is set before PyType_Ready #104614 https://github.com/python/cpython/issues/104614
gh-104614: Make Sure ob_type is Always Set Correctly by PyType_Ready() #105122 https://github.com/python/cpython/pull/105122
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jun 1, 2023https://github.com/python/cpython/pull/105211#event-9408550842
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
June 1, 2023 22:36https://github.com/python/cpython/pull/105211#event-9408554066
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
markshannonhttps://github.com/markshannon
June 1, 2023 22:36https://github.com/python/cpython/pull/105211#event-9408554461
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
d57ee81https://github.com/python/cpython/commit/d57ee813ebd496a3fd8118d7dc057d54c4af847e
Jun 1, 2023https://github.com/python/cpython/pull/105211#event-9408701471
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jun 1, 2023https://github.com/python/cpython/pull/105211#event-9408701718
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
June 1, 2023 23:06https://github.com/python/cpython/pull/105211#event-9408702302
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 6, 2023 https://github.com/python/cpython/pull/105211#ref-pullrequest-1743530961
3.12 backport gh 105236 #105358 https://github.com/python/cpython/pull/105358
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105211
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/105211
https://github.com/miss-islington
https://github.com/ericsnowcurrently
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.