René's URL Explorer Experiment


Title: [3.12] gh-105144: Runtime-checkable protocols: move all 'sanity checks' to `_ProtocolMeta.__subclasscheck__` (GH-105152) by miss-islington · Pull Request #105160 · python/cpython · GitHub

Open Graph Title: [3.12] gh-105144: Runtime-checkable protocols: move all 'sanity checks' to `_ProtocolMeta.__subclasscheck__` (GH-105152) by miss-islington · Pull Request #105160 · python/cpython

X Title: [3.12] gh-105144: Runtime-checkable protocols: move all 'sanity checks' to `_ProtocolMeta.__subclasscheck__` (GH-105152) by miss-islington · Pull Request #105160 · python/cpython

Description: (cherry picked from commit c05c31d) Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com Issue: Strange interaction between typing.Protocol and unrelated isinstance() checks #105144

Open Graph Description: (cherry picked from commit c05c31d) Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com Issue: Strange interaction between typing.Protocol and unrelated isinstance() checks #105144

X Description: (cherry picked from commit c05c31d) Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com Issue: Strange interaction between typing.Protocol and unrelated isinstance() checks #105144

Mail addresses
Alex.Waygood@Gmail.com

Opengraph URL: https://github.com/python/cpython/pull/105160

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e65accb5-fc5e-2e97-2045-3c3f4fbda59a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB2F0:1E9341:57A9EB:767EFB:6969D535
html-safe-nonce668787853392f75cb0f221eb173968660c72f05841790166c6b8a9f73c9aee45
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkYwOjFFOTM0MTo1N0E5RUI6NzY3RUZCOjY5NjlENTM1IiwidmlzaXRvcl9pZCI6IjY2MTI5MTA3MjQ1MDM2ODg1MDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace9e187c94e994756e6522539d64f91c3e5a63434b7b0ebcf5ccf1331dcf9e447
hovercard-subject-tagpull_request:1372580762
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/105160/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a3acefd7d760e17f8fa49674d397357dfe21d910da0e680a098ba4ce617cc4bb/python/cpython/pull/105160
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a3acefd7d760e17f8fa49674d397357dfe21d910da0e680a098ba4ce617cc4bb/python/cpython/pull/105160
og:image:alt(cherry picked from commit c05c31d) Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com Issue: Strange interaction between typing.Protocol and unrelated isinstance() checks #105144
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105160#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105160
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105160
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105160
Reloadhttps://github.com/python/cpython/pull/105160
Reloadhttps://github.com/python/cpython/pull/105160
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105160
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105160
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/105160#issue-comment-box
JelleZijlstrahttps://github.com/JelleZijlstra
python:3.12https://github.com/python/cpython/tree/3.12
miss-islington:backport-c05c31d-3.12https://github.com/miss-islington/cpython/tree/backport-c05c31d-3.12
[3.12] gh-105144: Runtime-checkable protocols: move all 'sanity checks' to _ProtocolMeta.__subclasscheck__ (GH-105152) https://github.com/python/cpython/pull/105160#top
JelleZijlstrahttps://github.com/JelleZijlstra
python:3.12https://github.com/python/cpython/tree/3.12
miss-islington:backport-c05c31d-3.12https://github.com/miss-islington/cpython/tree/backport-c05c31d-3.12
Conversation 0 https://github.com/python/cpython/pull/105160
Commits 1 https://github.com/python/cpython/pull/105160/commits
Checks 0 https://github.com/python/cpython/pull/105160/checks
Files changed https://github.com/python/cpython/pull/105160/files
Please reload this pagehttps://github.com/python/cpython/pull/105160
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
May 31, 2023https://github.com/python/cpython/pull/105160#issue-1734637509
Please reload this pagehttps://github.com/python/cpython/pull/105160
c05c31dhttps://github.com/python/cpython/commit/c05c31db8c9dfd708b9857bb57f8e5f3ce40266d
Strange interaction between typing.Protocol and unrelated isinstance() checks #105144https://github.com/python/cpython/issues/105144
Please reload this pagehttps://github.com/python/cpython/pull/105160
https://github.com/AlexWaygood
https://github.com/miss-islington
pythongh-105144https://github.com/python/cpython/issues/105144
: Runtime-checkable protocols: move all 'sanity checks…https://github.com/python/cpython/pull/105160/commits/d0759955faacee078970af70f6b7b8bdee67d895
d075995https://github.com/python/cpython/pull/105160/commits/d0759955faacee078970af70f6b7b8bdee67d895
pythonGH-105152https://github.com/python/cpython/pull/105152
c05c31dhttps://github.com/miss-islington/cpython/commit/c05c31db8c9dfd708b9857bb57f8e5f3ce40266d
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
AlexWaygoodhttps://github.com/AlexWaygood
Fidget-Spinnerhttps://github.com/Fidget-Spinner
JelleZijlstrahttps://github.com/JelleZijlstra
gvanrossumhttps://github.com/gvanrossum
code ownershttps://github.com/python/cpython/blob/4f477c796cbd6db14fa102fecd5afc38a3604850/.github/CODEOWNERS#L144
May 31, 2023 17:02https://github.com/python/cpython/pull/105160#event-9393159168
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 31, 2023https://github.com/python/cpython/pull/105160#event-9393159664
Strange interaction between typing.Protocol and unrelated isinstance() checks #105144 https://github.com/python/cpython/issues/105144
gh-105144: Runtime-checkable protocols: move all 'sanity checks' to _ProtocolMeta.__subclasscheck__ #105152 https://github.com/python/cpython/pull/105152
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
May 31, 2023https://github.com/python/cpython/pull/105160#event-9393160470
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 31, 2023 https://github.com/python/cpython/pull/105160#pullrequestreview-1453739688
View reviewed changes https://github.com/python/cpython/pull/105160/files/d0759955faacee078970af70f6b7b8bdee67d895
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 31, 2023https://github.com/python/cpython/pull/105160#event-9393164382
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 31, 2023https://github.com/python/cpython/pull/105160#event-9393164690
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 31, 2023 17:03https://github.com/python/cpython/pull/105160#event-9393165962
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
076f3cdhttps://github.com/python/cpython/commit/076f3cda140a45b08c2c9518bc19624aae50d3a3
May 31, 2023https://github.com/python/cpython/pull/105160#event-9393452263
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 31, 2023https://github.com/python/cpython/pull/105160#event-9393452914
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
May 31, 2023 17:35https://github.com/python/cpython/pull/105160#event-9393453653
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 6, 2023 https://github.com/python/cpython/pull/105160#ref-pullrequest-1743530961
3.12 backport gh 105236 #105358 https://github.com/python/cpython/pull/105358
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105160
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/cpython/pull/105160/files/d0759955faacee078970af70f6b7b8bdee67d895
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/105160
https://github.com/miss-islington
https://github.com/JelleZijlstra
https://github.com/bedevere-bot
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.