René's URL Explorer Experiment


Title: gh-105020: Share tp_bases and tp_mro Between Interpreters For All Static Builtin Types by ericsnowcurrently · Pull Request #105115 · python/cpython · GitHub

Open Graph Title: gh-105020: Share tp_bases and tp_mro Between Interpreters For All Static Builtin Types by ericsnowcurrently · Pull Request #105115 · python/cpython

X Title: gh-105020: Share tp_bases and tp_mro Between Interpreters For All Static Builtin Types by ericsnowcurrently · Pull Request #105115 · python/cpython

Description: In gh-103912 we added tp_bases and tp_mro to each PyInterpreterState.types.builtins entry. However, doing so ignored the fact that both PyTypeObject fields are public API, and not documented as internal (as opposed to tp_subclasses). We address that here by reverting back to shared objects, making them immortal in the process. Issue: gh-105020

Open Graph Description: In gh-103912 we added tp_bases and tp_mro to each PyInterpreterState.types.builtins entry. However, doing so ignored the fact that both PyTypeObject fields are public API, and not documented as in...

X Description: In gh-103912 we added tp_bases and tp_mro to each PyInterpreterState.types.builtins entry. However, doing so ignored the fact that both PyTypeObject fields are public API, and not documented as in...

Opengraph URL: https://github.com/python/cpython/pull/105115

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4ad56fc5-8eda-b18a-84c2-c106ee7062af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EAC:31622E:DC4735:137593B:696A6650
html-safe-nonce57b66489e8efd74d75193c66837bee7801590462d07d3f2d509d41545f13bc07
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUFDOjMxNjIyRTpEQzQ3MzU6MTM3NTkzQjo2OTZBNjY1MCIsInZpc2l0b3JfaWQiOiI4MzIwMzM0MzUxMjI3ODQwMDgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac564bb928e13a4eaba218f3d023161a6d2d90d281447d524c231504c6b0558ae3
hovercard-subject-tagpull_request:1371096363
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/105115/files
twitter:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
og:image:altIn gh-103912 we added tp_bases and tp_mro to each PyInterpreterState.types.builtins entry. However, doing so ignored the fact that both PyTypeObject fields are public API, and not documented as in...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6fea32d5b7276b841b7a803796d9715bc6cfb31ed549fdf9de2948ac25d12ba6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef2d9f6432a5a115ec709295ae70623f33bb80aee
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105115/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105115%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105115%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105115/files
Reloadhttps://github.com/python/cpython/pull/105115/files
Reloadhttps://github.com/python/cpython/pull/105115/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105115/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105115/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:fix-tp-baseshttps://github.com/ericsnowcurrently/cpython/tree/fix-tp-bases
Conversation 11 https://github.com/python/cpython/pull/105115
Commits 8 https://github.com/python/cpython/pull/105115/commits
Checks 0 https://github.com/python/cpython/pull/105115/checks
Files changed https://github.com/python/cpython/pull/105115/files
Please reload this pagehttps://github.com/python/cpython/pull/105115/files
gh-105020: Share tp_bases and tp_mro Between Interpreters For All Static Builtin Types https://github.com/python/cpython/pull/105115/files#top
Show all changes 8 commits https://github.com/python/cpython/pull/105115/files
7c3e588 Make tp_bases immortal for static builtin types. ericsnowcurrently May 30, 2023 https://github.com/python/cpython/pull/105115/commits/7c3e5881e8177dff321a790022dff4e1c7064e7d
ff411b2 Add _Py_ClearImmortal(). ericsnowcurrently May 30, 2023 https://github.com/python/cpython/pull/105115/commits/ff411b235033d927f98a8596dab990b4d875fd29
354ff5f Drop PyInterpreterState.types.builtins[i].tp_bases. ericsnowcurrently May 30, 2023 https://github.com/python/cpython/pull/105115/commits/354ff5f6d9de6f01a5d79ec0e4db3f323a162059
5be53f4 Make sure tp_bases is a tuple. ericsnowcurrently May 30, 2023 https://github.com/python/cpython/pull/105115/commits/5be53f472e9550bd5876e216aae20474b1b8b185
bf1578e Make tp_mro immortal for static builtin types. ericsnowcurrently May 30, 2023 https://github.com/python/cpython/pull/105115/commits/bf1578e6c2a3105690e65fc07912b3143432fb07
f4a5da1 Update a TODO comment. ericsnowcurrently May 30, 2023 https://github.com/python/cpython/pull/105115/commits/f4a5da1c3725c449a6223922a92e8d17bc8a8425
e054bbe Add a test to avoid more regressions. ericsnowcurrently May 30, 2023 https://github.com/python/cpython/pull/105115/commits/e054bbe9b0472047a6c02403d51fe01c97169ca4
78c7d0e Add a NEWS entry. ericsnowcurrently May 30, 2023 https://github.com/python/cpython/pull/105115/commits/78c7d0ec4fcb732efb7cf7dc5aac08d7c6a8be7e
Clear filters https://github.com/python/cpython/pull/105115/files
Please reload this pagehttps://github.com/python/cpython/pull/105115/files
Please reload this pagehttps://github.com/python/cpython/pull/105115/files
pycore_object.h https://github.com/python/cpython/pull/105115/files#diff-2a12f738a77b362d74a65949b58c37f2affcd15ba8b1c979b63bd00223b8a456
pycore_typeobject.h https://github.com/python/cpython/pull/105115/files#diff-9df981eafa9c743230f2e1513191ba147f0fba63d0c51fb7968c1e7093d9e877
test_misc.py https://github.com/python/cpython/pull/105115/files#diff-4178d53cac5b09685584df43c65b66797dd4ca4df491b2081565d95ba90aaa36
2023-05-30-17-45-32.gh-issue-105115.iRho1K.rst https://github.com/python/cpython/pull/105115/files#diff-359237355a5b86c32b0ace59b79d95552d50f2db4f613a54384adc6cf3b37b1d
_testcapimodule.c https://github.com/python/cpython/pull/105115/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
typeobject.c https://github.com/python/cpython/pull/105115/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Include/internal/pycore_object.hhttps://github.com/python/cpython/pull/105115/files#diff-2a12f738a77b362d74a65949b58c37f2affcd15ba8b1c979b63bd00223b8a456
View file https://github.com/ericsnowcurrently/cpython/blob/78c7d0ec4fcb732efb7cf7dc5aac08d7c6a8be7e/Include/internal/pycore_object.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105115/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105115/files#diff-2a12f738a77b362d74a65949b58c37f2affcd15ba8b1c979b63bd00223b8a456
https://github.com/python/cpython/pull/105115/files#diff-2a12f738a77b362d74a65949b58c37f2affcd15ba8b1c979b63bd00223b8a456
Include/internal/pycore_typeobject.hhttps://github.com/python/cpython/pull/105115/files#diff-9df981eafa9c743230f2e1513191ba147f0fba63d0c51fb7968c1e7093d9e877
View file https://github.com/ericsnowcurrently/cpython/blob/78c7d0ec4fcb732efb7cf7dc5aac08d7c6a8be7e/Include/internal/pycore_typeobject.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105115/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105115/files#diff-9df981eafa9c743230f2e1513191ba147f0fba63d0c51fb7968c1e7093d9e877
https://github.com/python/cpython/pull/105115/files#diff-9df981eafa9c743230f2e1513191ba147f0fba63d0c51fb7968c1e7093d9e877
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L349
Lib/test/test_capi/test_misc.pyhttps://github.com/python/cpython/pull/105115/files#diff-4178d53cac5b09685584df43c65b66797dd4ca4df491b2081565d95ba90aaa36
View file https://github.com/ericsnowcurrently/cpython/blob/78c7d0ec4fcb732efb7cf7dc5aac08d7c6a8be7e/Lib/test/test_capi/test_misc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105115/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105115/files#diff-4178d53cac5b09685584df43c65b66797dd4ca4df491b2081565d95ba90aaa36
https://github.com/python/cpython/pull/105115/files#diff-4178d53cac5b09685584df43c65b66797dd4ca4df491b2081565d95ba90aaa36
Misc/NEWS.d/next/C API/2023-05-30-17-45-32.gh-issue-105115.iRho1K.rsthttps://github.com/python/cpython/pull/105115/files#diff-359237355a5b86c32b0ace59b79d95552d50f2db4f613a54384adc6cf3b37b1d
View file https://github.com/ericsnowcurrently/cpython/blob/78c7d0ec4fcb732efb7cf7dc5aac08d7c6a8be7e/Misc/NEWS.d/next/C%20API/2023-05-30-17-45-32.gh-issue-105115.iRho1K.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105115/{{ revealButtonHref }}
Modules/_testcapimodule.chttps://github.com/python/cpython/pull/105115/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
View file https://github.com/ericsnowcurrently/cpython/blob/78c7d0ec4fcb732efb7cf7dc5aac08d7c6a8be7e/Modules/_testcapimodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105115/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105115/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/105115/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/105115/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/105115/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L216
Objects/typeobject.chttps://github.com/python/cpython/pull/105115/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
View file https://github.com/ericsnowcurrently/cpython/blob/78c7d0ec4fcb732efb7cf7dc5aac08d7c6a8be7e/Objects/typeobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105115/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105115/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/105115/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/105115/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/105115/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/105115/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/105115/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/105115/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/105115/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/105115/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.