René's URL Explorer Experiment


Title: gh-104341: Call _PyEval_ReleaseLock() with NULL When Finalizing the Current Thread by ericsnowcurrently · Pull Request #105109 · python/cpython · GitHub

Open Graph Title: gh-104341: Call _PyEval_ReleaseLock() with NULL When Finalizing the Current Thread by ericsnowcurrently · Pull Request #105109 · python/cpython

X Title: gh-104341: Call _PyEval_ReleaseLock() with NULL When Finalizing the Current Thread by ericsnowcurrently · Pull Request #105109 · python/cpython

Description: This avoids the problematic race in drop_gil() by skipping the FORCE_SWITCHING code there for finalizing threads. This is a much simpler approach to solving the race than in other PRs I've posted. I'd still like to pursue some of those other ideas but that can be done separately for 3.13+. (The idea for this approach came out of discussions with @markshannon.) Issue: gh-104341

Open Graph Description: This avoids the problematic race in drop_gil() by skipping the FORCE_SWITCHING code there for finalizing threads. This is a much simpler approach to solving the race than in other PRs I've post...

X Description: This avoids the problematic race in drop_gil() by skipping the FORCE_SWITCHING code there for finalizing threads. This is a much simpler approach to solving the race than in other PRs I've ...

Opengraph URL: https://github.com/python/cpython/pull/105109

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7c4c3da5-d7bd-c143-bd87-2a15e0712002
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC65C:10FD0C:A2F3E2:D9CF74:69697F75
html-safe-nonce672aec360bd6c1848c80cc7ab1652764365d57ea61abe1678cfa883ded1f1ce4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjVDOjEwRkQwQzpBMkYzRTI6RDlDRjc0OjY5Njk3Rjc1IiwidmlzaXRvcl9pZCI6IjQwNDc4NDE1NDEwNTA5NTc2ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac943e9d8167e51c0d5532cedf250a4ed0149cdf9f19af03e3c35c71599a262f75
hovercard-subject-tagpull_request:1370819238
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/105109/files
twitter:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
og:image:altThis avoids the problematic race in drop_gil() by skipping the FORCE_SWITCHING code there for finalizing threads. This is a much simpler approach to solving the race than in other PRs I've post...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef33e4b94c8824ab2b434d82a94139432fb5ebee9df4b75304140ad22508c4a77
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release48f380098b30acbb700b04f1724481ca10d574fc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105109/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105109%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105109%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105109/files
Reloadhttps://github.com/python/cpython/pull/105109/files
Reloadhttps://github.com/python/cpython/pull/105109/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105109/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105109/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:fix-threading-module-shutdown-3.12https://github.com/ericsnowcurrently/cpython/tree/fix-threading-module-shutdown-3.12
Conversation 15 https://github.com/python/cpython/pull/105109
Commits 7 https://github.com/python/cpython/pull/105109/commits
Checks 0 https://github.com/python/cpython/pull/105109/checks
Files changed https://github.com/python/cpython/pull/105109/files
Please reload this pagehttps://github.com/python/cpython/pull/105109/files
gh-104341: Call _PyEval_ReleaseLock() with NULL When Finalizing the Current Thread https://github.com/python/cpython/pull/105109/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/105109/files
5206f3d Call _PyEval_ReleaseLock() with NULL when finalizing the current thread. ericsnowcurrently May 30, 2023 https://github.com/python/cpython/pull/105109/commits/5206f3de699e869a5fe796c58bb855595637c48b
db6d7ac Temporarily adjust tstate->_status.cleared during interpreter_clear(). ericsnowcurrently May 30, 2023 https://github.com/python/cpython/pull/105109/commits/db6d7ac54435dae0b56bbdefcc8f81a9ebd028dc
a374f48 Disable the broken asserts. ericsnowcurrently May 30, 2023 https://github.com/python/cpython/pull/105109/commits/a374f48ea809f5c279cdd3e154dbf9307417c202
432db0c Add a note about the race in drop_gil(). ericsnowcurrently May 31, 2023 https://github.com/python/cpython/pull/105109/commits/432db0c478ee446308de27cbd547b8d5fc2b81ee
1280e0d Fix a typo. ericsnowcurrently May 31, 2023 https://github.com/python/cpython/pull/105109/commits/1280e0dede5e05a4e04ad59a3d10acd86ee82e67
cc1f2fe Clarify a comment. ericsnowcurrently May 31, 2023 https://github.com/python/cpython/pull/105109/commits/cc1f2fe86a9e22b636fb249b12f8fcde2f8e2016
b64b299 minor comment typo fix. gpshead Jun 1, 2023 https://github.com/python/cpython/pull/105109/commits/b64b299cfbaa5c445848c9bd611a3338fc3c8be8
Clear filters https://github.com/python/cpython/pull/105109/files
Please reload this pagehttps://github.com/python/cpython/pull/105109/files
Please reload this pagehttps://github.com/python/cpython/pull/105109/files
pycore_ceval.h https://github.com/python/cpython/pull/105109/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
ceval_gil.c https://github.com/python/cpython/pull/105109/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
pylifecycle.c https://github.com/python/cpython/pull/105109/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
pystate.c https://github.com/python/cpython/pull/105109/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
Include/internal/pycore_ceval.hhttps://github.com/python/cpython/pull/105109/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
View file https://github.com/ericsnowcurrently/cpython/blob/b64b299cfbaa5c445848c9bd611a3338fc3c8be8/Include/internal/pycore_ceval.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105109/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105109/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
https://github.com/python/cpython/pull/105109/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L309
Python/ceval_gil.chttps://github.com/python/cpython/pull/105109/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
View file https://github.com/ericsnowcurrently/cpython/blob/b64b299cfbaa5c445848c9bd611a3338fc3c8be8/Python/ceval_gil.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105109/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105109/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/105109/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
Please reload this pagehttps://github.com/python/cpython/pull/105109/files
https://github.com/python/cpython/pull/105109/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/105109/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/105109/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/105109/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 30, 2023https://github.com/python/cpython/pull/105109/files#r1210583854
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/105109/files
https://github.com/python/cpython/pull/105109/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L310
Python/pylifecycle.chttps://github.com/python/cpython/pull/105109/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
View file https://github.com/ericsnowcurrently/cpython/blob/b64b299cfbaa5c445848c9bd611a3338fc3c8be8/Python/pylifecycle.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105109/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105109/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/pull/105109/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L311
Python/pystate.chttps://github.com/python/cpython/pull/105109/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
View file https://github.com/ericsnowcurrently/cpython/blob/b64b299cfbaa5c445848c9bd611a3338fc3c8be8/Python/pystate.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105109/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105109/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/105109/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/105109/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/105109/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/105109/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/105109/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/105109/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/105109/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/105109/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/105109/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/105109/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.